Remove legacy preview tool and refactor Preview Generator V2 toward class-based structure - PR_26126_034-preview-generator-v2-cleanup-and-class-review

Author: DavidQ

docs/design/tools/TOOLS_REENGINEERING_INDEX.md

@@ -26,7 +26,6 @@ This index lists the remaining rebuild anchors, schema baseline, and support fol
 | `schemas` | `tools/schemas` | schema folder | reference-only | none | schema baseline only; no schema changes in this PR |
 | `codex` | `tools/codex` | support folder | reference-only | none | reference only; no normal rebuild doc |
 | `dev` | `tools/dev` | support folder | reference-only | none | reference only; no normal rebuild doc |
-| `preview` | `tools/preview` | support folder | reference-only | none | reference only; no normal rebuild doc |
 | `shared` | `tools/shared` | support folder | reference-only | none | reference only; no normal rebuild doc |
 | `templates` | `tools/templates` | support folder | reference-only | none | reference only; no normal rebuild doc |
 

docs/dev/codex_commands.md

@@ -1,51 +1,48 @@
-# Codex Commands - PR_26126_033-preview-generator-v2-paths-stretch-layout
+# Codex Commands - PR_26126_034-preview-generator-v2-cleanup-and-class-review
 
 ```bash
-codex run "Create PR_26126_033-preview-generator-v2-paths-stretch-layout. Fix Preview Generator V2 layout only. Preserve existing generation behavior. In the left column, make the \"Paths or IDs\" accordion section stretch to fill all remaining vertical space down to the bottom of the panel above \"Last Generated Image\". Implement using flex layout: left panel column must be a flex container with column direction; set the Paths or IDs section to flex-grow:1 and its textarea to height:100% (or flex:1) so it expands fully. Do not use inline styles. Keep Last Generated Image fixed height below it. Do not modify samples. Do not add schema. Produce review artifacts."
+codex run "Create PR_26126_034-preview-generator-v2-cleanup-and-class-review. Fix Preview Generator V2 cleanup and structure. Remove legacy tools/preview/* completely. Keep tools/preview-generator-v2 as the active tool. Refactor Preview Generator V2 JavaScript away from one large script body. Use classes for major responsibilities: PreviewGeneratorV2App, PreviewGeneratorV2Ui, PreviewGeneratorV2Capture, PreviewGeneratorV2RepoAccess, PreviewGeneratorV2Logger. Preserve current working behavior exactly. Do not rewrite generation logic. Do not add schema. Do not modify samples. Produce review artifacts and include notes explaining class responsibilities."
 ```
 
 ## Validation Commands
 
 ```powershell
+node --check tools/preview-generator-v2/previewGeneratorV2.js
 @'
 const fs = require('fs');
 const html = fs.readFileSync('tools/preview-generator-v2/index.html', 'utf8');
-const required = [
-  '.preview-generator-v2__center-panel .preview-generator-v2__paths-section',
-  'flex: 1 1 auto;',
-  '.preview-generator-v2__paths-section .accordion-v2__content',
-  'height: 100%;',
-  '.preview-generator-v2__center-panel .preview-generator-v2__last-generated-section',
-  'flex: 0 0 auto;',
-  'preview-generator-v2__paths-section is-open'
-];
-for (const token of required) {
-  if (!html.includes(token)) throw new Error(`Missing layout token: ${token}`);
-}
-if (/<[^>]+style=/.test(html)) throw new Error('Inline style attribute found');
-console.log('paths stretch layout tokens ok');
-'@ | node -
-@'
-const fs = require('fs');
-const html = fs.readFileSync('tools/preview-generator-v2/index.html', 'utf8');
-const scripts = [...html.matchAll(/<script(?![^>]*\bsrc=)[^>]*>([\s\S]*?)<\/script>/gi)].map((match) => match[1]);
-scripts.forEach((script, index) => {
+const inlineScripts = [...html.matchAll(/<script(?![^>]*\bsrc=)[^>]*>([\s\S]*?)<\/script>/gi)].map((match) => match[1]);
+inlineScripts.forEach((script, index) => {
   new Function(script);
   console.log(`inline script ${index + 1} syntax ok`);
 });
 '@ | node -
-git diff --check -- tools/preview-generator-v2/index.html docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/codex_review.diff docs/dev/reports/codex_changed_files.txt
+@'
+const fs = require('fs');
+const js = fs.readFileSync('tools/preview-generator-v2/previewGeneratorV2.js', 'utf8');
+for (const name of ['PreviewGeneratorV2App','PreviewGeneratorV2Ui','PreviewGeneratorV2Capture','PreviewGeneratorV2RepoAccess','PreviewGeneratorV2Logger']) {
+  if (!js.includes(`class ${name}`)) throw new Error(`Missing class ${name}`);
+}
+if (!js.includes('new PreviewGeneratorV2App().init();')) throw new Error('App init missing');
+console.log('required classes present');
+'@ | node -
+if (Test-Path tools/preview) { throw 'tools/preview still exists' } else { 'tools/preview removed' }
+$legacyMatches = rg -n "preview_svg_generator|tools/preview" tools src docs/design --glob '!docs/dev/reports/*'
+if ($LASTEXITCODE -eq 0) { $legacyMatches; throw 'Active legacy preview reference found' }
+if ($LASTEXITCODE -eq 1) { 'no active legacy preview references' }
+if ($LASTEXITCODE -gt 1) { exit $LASTEXITCODE }
+git diff --check -- tools/preview-generator-v2/index.html tools/preview-generator-v2/previewGeneratorV2.js docs/design/tools/TOOLS_REENGINEERING_INDEX.md docs/dev/codex_commands.md docs/dev/commit_comment.txt docs/dev/reports/preview_generator_v2_class_responsibilities.md docs/dev/reports/codex_review.diff docs/dev/reports/codex_changed_files.txt
 npm run test:workspace-v2
 ```
 
 ## Playwright
 
-No new Playwright test was added. This PR changes Preview Generator V2 layout CSS/section classing only, with existing `accordionV2` behavior unchanged. `npm run test:workspace-v2` is attempted as the standard command if available.
+No new Playwright test was added. This PR restructures Preview Generator V2 JavaScript and removes the legacy preview folder while preserving the existing Preview Generator V2 UI and behavior. `npm run test:workspace-v2` is attempted as the standard command if available.
 
 ## Test Notes
 
 `npm run test:workspace-v2` is not defined in the current `package.json`.
 
 ## Manual Test
 
-Open Preview Generator V2 and confirm the `Paths or IDs` accordion stretches through the available column height above `Last Generated Image`. Confirm the `Paths or IDs` textarea grows with the section, `Last Generated Image` stays fixed below it, and generation behavior is unchanged.
+Open Preview Generator V2 from the tool registry. Confirm the tool loads, the repo picker/generate gating/log clear/stop controls still behave as before, and the Last Generated Image and Paths accordion layout from the previous PRs remains intact.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Stretch Preview Generator V2 Paths accordion above fixed Last Generated Image - PR_26126_033-preview-generator-v2-paths-stretch-layout
+Remove legacy preview tool and class-structure Preview Generator V2 runtime - PR_26126_034-preview-generator-v2-cleanup-and-class-review

docs/dev/reports/codex_changed_files.txt

@@ -1,70 +1,39 @@
 # Full git status --short
-MM docs/dev/codex_commands.md
-MM docs/dev/commit_comment.txt
-M  docs/dev/reports/codex_changed_files.txt
-MM docs/dev/reports/codex_review.diff
-M  samples/phase-02/0201/assets/images/preview.svg
-M  samples/phase-02/0202/assets/images/preview.svg
-M  samples/phase-02/0203/assets/images/preview.svg
-M  samples/phase-02/0204/assets/images/preview.svg
-M  samples/phase-02/0205/assets/images/preview.svg
-M  samples/phase-02/0207/assets/images/preview.svg
-M  samples/phase-02/0208/assets/images/preview.svg
-M  samples/phase-02/0209/assets/images/preview.svg
- M samples/phase-02/0210/assets/images/preview.svg
-M  samples/phase-02/0211/assets/images/preview.svg
-M  samples/phase-02/0212/assets/images/preview.svg
-M  samples/phase-02/0213/assets/images/preview.svg
-M  samples/phase-02/0214/assets/images/preview.svg
-M  samples/phase-02/0215/assets/images/preview.svg
-M  samples/phase-02/0216/assets/images/preview.svg
-M  samples/phase-02/0217/assets/images/preview.svg
-M  samples/phase-02/0219/assets/images/preview.svg
-M  samples/phase-02/0222/assets/images/preview.svg
-M  samples/phase-02/0224/assets/images/preview.svg
- M samples/phase-02/0225/assets/images/preview.svg
- M samples/phase-02/0226/assets/images/preview.svg
- M samples/phase-02/0227/assets/images/preview.svg
- M samples/phase-12/1212/assets/images/preview.svg
- M samples/phase-12/1213/assets/images/preview.svg
- M samples/phase-12/1214/assets/images/preview.svg
- M samples/phase-12/1215/assets/images/preview.svg
- M samples/phase-12/1216/assets/images/preview.svg
- M samples/phase-12/1217/assets/images/preview.svg
- M samples/phase-12/1218/assets/images/preview.svg
- M samples/phase-12/1219/assets/images/preview.svg
- M samples/phase-12/1220/assets/images/preview.svg
-MM tools/preview-generator-v2/index.html
+ M docs/design/tools/TOOLS_REENGINEERING_INDEX.md
+ M docs/dev/codex_commands.md
+ M docs/dev/commit_comment.txt
+ M docs/dev/reports/codex_review.diff
+ M tools/preview-generator-v2/index.html
+ D tools/preview.zip
+ D tools/preview/preview_svg_generator.html
+?? docs/dev/reports/preview_generator_v2_class_responsibilities.md
+?? tools/preview-generator-v2/previewGeneratorV2.js
 
 # PR scoped git diff --cached --stat
- docs/dev/codex_commands.md            | 44 +++++++++++++++++++++---------
- docs/dev/commit_comment.txt           |  2 +-
- tools/preview-generator-v2/index.html | 51 ++++++++++++++++++++---------------
- 3 files changed, 62 insertions(+), 35 deletions(-)
 
 # PR scoped git diff --stat
- docs/dev/codex_commands.md            |  34 +++---
- docs/dev/commit_comment.txt           |   2 +-
- docs/dev/reports/codex_review.diff    | 215 +++++++++++++++++++++++++---------
- tools/preview-generator-v2/index.html |  17 ++-
- 4 files changed, 191 insertions(+), 77 deletions(-)
+ docs/design/tools/TOOLS_REENGINEERING_INDEX.md |    1 -
+ docs/dev/codex_commands.md                     |   47 +-
+ docs/dev/commit_comment.txt                    |    2 +-
+ tools/preview-generator-v2/index.html          | 1238 +-----------------------
+ tools/preview.zip                              |  Bin 19111 -> 0 bytes
+ tools/preview/preview_svg_generator.html       | 1042 --------------------
+ 6 files changed, 24 insertions(+), 2306 deletions(-)
+
+# New file diff stat: tools/preview-generator-v2/previewGeneratorV2.js
+ .../preview-generator-v2/previewGeneratorV2.js     | 1317 ++++++++++++++++++++
+ 1 file changed, 1317 insertions(+)
+
+# New file diff stat: docs/dev/reports/preview_generator_v2_class_responsibilities.md
+ .../reports/preview_generator_v2_class_responsibilities.md    | 11 +++++++++++
+ 1 file changed, 11 insertions(+)
 
 # Full git diff --stat
- docs/dev/codex_commands.md                      |  34 ++--
- docs/dev/commit_comment.txt                     |   2 +-
- docs/dev/reports/codex_review.diff              | 215 +++++++++++++++++-------
- samples/phase-02/0210/assets/images/preview.svg |   6 +-
- samples/phase-02/0225/assets/images/preview.svg |  24 +--
- samples/phase-02/0226/assets/images/preview.svg |  21 +--
- samples/phase-02/0227/assets/images/preview.svg |  21 +--
- samples/phase-12/1212/assets/images/preview.svg |  17 +-
- samples/phase-12/1213/assets/images/preview.svg |  17 +-
- samples/phase-12/1214/assets/images/preview.svg |  17 +-
- samples/phase-12/1215/assets/images/preview.svg |  40 +++--
- samples/phase-12/1216/assets/images/preview.svg |  40 +++--
- samples/phase-12/1217/assets/images/preview.svg |  40 +++--
- samples/phase-12/1218/assets/images/preview.svg |  17 +-
- samples/phase-12/1219/assets/images/preview.svg |  17 +-
- samples/phase-12/1220/assets/images/preview.svg |  17 +-
- tools/preview-generator-v2/index.html           |  17 +-
- 17 files changed, 299 insertions(+), 263 deletions(-)
+ docs/design/tools/TOOLS_REENGINEERING_INDEX.md |    1 -
+ docs/dev/codex_commands.md                     |   47 +-
+ docs/dev/commit_comment.txt                    |    2 +-
+ docs/dev/reports/codex_review.diff             | 3958 ++++++++++++++++++++++--
+ tools/preview-generator-v2/index.html          | 1238 +-------
+ tools/preview.zip                              |  Bin 19111 -> 0 bytes
+ tools/preview/preview_svg_generator.html       | 1042 -------
+ 7 files changed, 3728 insertions(+), 2560 deletions(-)