relocate 1319 server runtime files to tests directory — BUILD_PR_LEVEL_12_12_SAMPLE_1319_SERVER_TEST_RELOCATION

DavidQ · DavidQ · commit 56e0d47d312c · 2026-04-15T11:52:18.000-04:00
diff --git a/docs/dev/CODEX_COMMANDS.md b/docs/dev/CODEX_COMMANDS.md
@@ -1,10 +1,9 @@
 MODEL: GPT-5.4
 REASONING: high
 COMMAND:
-Normalize samples shared directory.
-Merge samples/_shared into samples/shared.
-Update all references.
-Remove _shared.
+Move all .mjs runtime files for sample 1319 from server/ to tests/.
+Update all references accordingly.
 Do not change logic.
-Validate all samples still load.
-Update roadmap markers only.
+Ensure server still runs and dashboard works.
+Validate sample 1319 connectivity.
+Update roadmap markers only if execution passes.
diff --git a/docs/dev/COMMIT_COMMENT.txt b/docs/dev/COMMIT_COMMENT.txt
@@ -1 +1 @@
-normalize samples shared directory structure — BUILD_PR_LEVEL_12_11_SAMPLE_SHARED_DIRECTORY_NORMALIZATION
+relocate 1319 server runtime files to tests directory — BUILD_PR_LEVEL_12_12_SAMPLE_1319_SERVER_TEST_RELOCATION
diff --git a/docs/dev/reports/BUILD_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION_validation.txt b/docs/dev/reports/BUILD_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION_validation.txt
@@ -7,15 +7,15 @@ Scope confirmation:
 
 Files changed for this BUILD:
 - samples/index.html
-- samples/_shared/sampleDetailPageEnhancement.js
+- samples/shared/sampleDetailPageEnhancement.js
 - samples/metadata/samples.index.metadata.json
 - docs/dev/reports/BUILD_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION_validation.txt
 
 Validation executed:
 1) node scripts/generate-samples-index.mjs --check
    - Result: OK phases=15 samples=197 metadata=197 mode=check
 
-2) node --check samples/_shared/sampleDetailPageEnhancement.js
+2) node --check samples/shared/sampleDetailPageEnhancement.js
    - Result: pass (no syntax errors)
 
 3) samples/index.html inline script parse + visual CSS presence checks
diff --git a/docs/dev/reports/BUILD_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY_validation.txt b/docs/dev/reports/BUILD_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY_validation.txt
@@ -38,4 +38,4 @@ Validation executed:
    - Result: pass
    - No `console.log` / `console.warn` / `console.error` statements found in:
      - samples/index.html
-     - samples/_shared/sampleDetailPageEnhancement.js
+     - samples/shared/sampleDetailPageEnhancement.js
diff --git a/docs/dev/reports/BUILD_PR_SAMPLES_PRESENTATION_PREVIEW_AND_METADATA_NORMALIZATION_validation.txt b/docs/dev/reports/BUILD_PR_SAMPLES_PRESENTATION_PREVIEW_AND_METADATA_NORMALIZATION_validation.txt
@@ -8,7 +8,7 @@ Scope confirmation:
 Files changed for this BUILD:
 - scripts/normalize-samples-presentation.mjs
 - scripts/generate-samples-index.mjs
-- samples/_shared/sampleDetailPageEnhancement.js
+- samples/shared/sampleDetailPageEnhancement.js
 - samples/metadata/samples.index.metadata.json
 - samples/index.html
 - samples/phaseXX/XXYY/assets/preview.svg (generated for all canonical samples; count=197)
@@ -30,7 +30,7 @@ Validation executed:
 5) Syntax validation
    - node --check scripts/normalize-samples-presentation.mjs => pass
    - node --check scripts/generate-samples-index.mjs => pass
-   - node --check samples/_shared/sampleDetailPageEnhancement.js => pass
+   - node --check samples/shared/sampleDetailPageEnhancement.js => pass
 
 6) Metadata + preview + label normalization checks (all canonical samples)
    - Preview file presence and wiring: pass (197/197)
@@ -41,7 +41,7 @@ Validation executed:
 7) Console-clean guard checks for tested UI files
    - No console.log / console.warn / console.error in:
      - samples/index.html
-     - samples/_shared/sampleDetailPageEnhancement.js
+     - samples/shared/sampleDetailPageEnhancement.js
 
 Representative checks:
 - Sample 0101: H1="Sample 0101 - Basic Loop" | index label="Sample 0101 - Basic Loop"
diff --git a/docs/dev/reports/dependency_cleanup_map.txt b/docs/dev/reports/dependency_cleanup_map.txt
@@ -1,21 +1,21 @@
 PR_06_06_SAMPLE_ENGINE_DEPENDENCY_CLEANUP - dependency cleanup map
 
 Approved shared/public target introduced:
-- /samples/_shared/sampleBaseLayout.css
+- /samples/shared/sampleBaseLayout.css
   - central sample shared boundary for base layout stylesheet dependency
 
 Source -> approved target mapping:
 1) samples/phase-13/1316/index.html
    - /src/engine/ui/baseLayout.css
-   -> /samples/_shared/sampleBaseLayout.css
+   -> /samples/shared/sampleBaseLayout.css
 
 2) samples/phase-13/1317/index.html
    - /src/engine/ui/baseLayout.css
-   -> /samples/_shared/sampleBaseLayout.css
+   -> /samples/shared/sampleBaseLayout.css
 
 3) samples/phase-13/1318/index.html
    - /src/engine/ui/baseLayout.css
-   -> /samples/_shared/sampleBaseLayout.css
+   -> /samples/shared/sampleBaseLayout.css
 
 Resolved direct violations:
 - 3 direct sample -> non-public engine stylesheet dependencies removed.
diff --git a/docs/dev/reports/file_tree_snapshot.txt b/docs/dev/reports/file_tree_snapshot.txt
@@ -4,15 +4,15 @@ Command: PR_01_03_POST_MOVE_VALIDATION
 
 Snapshot Roots
 samples/
-  samples/_shared/
-    samples/_shared/debugConfigUtils.js
-    samples/_shared/lateSampleBootstrap.js
-    samples/_shared/networkDebugUtils.js
-    samples/_shared/numberUtils.js
-    samples/_shared/platformerHelpers.js
-    samples/_shared/runtimePreviewCapture.html
-    samples/_shared/sampleDetailPageEnhancement.js
-    samples/_shared/snapshotCloneUtils.js
+  samples/shared/
+    samples/shared/debugConfigUtils.js
+    samples/shared/lateSampleBootstrap.js
+    samples/shared/networkDebugUtils.js
+    samples/shared/numberUtils.js
+    samples/shared/platformerHelpers.js
+    samples/shared/runtimePreviewCapture.html
+    samples/shared/sampleDetailPageEnhancement.js
+    samples/shared/snapshotCloneUtils.js
   samples/index.html
   samples/metadata/
     samples/metadata/samples.curriculum.validation.json
diff --git a/docs/dev/reports/number_usage_scan.txt b/docs/dev/reports/number_usage_scan.txt
@@ -22,4 +22,4 @@ Consumers Updated In Scope
 - src/engine/debug/inspectors/viewModels/eventStreamInspectorViewModel.js
 - src/engine/debug/inspectors/viewModels/stateDiffInspectorViewModel.js
 - src/engine/debug/inspectors/viewModels/timelineInspectorViewModel.js
-- samples/_shared/numberUtils.js
+- samples/shared/numberUtils.js
diff --git a/docs/dev/reports/validation_checklist.txt b/docs/dev/reports/validation_checklist.txt
@@ -1,3 +1,3 @@
-- duplicate shared directories removed
-- imports normalized
-- no regressions expected
+- runtime files moved to tests/
+- references updated
+- no logic changes
diff --git a/docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md b/docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md
@@ -672,4 +672,4 @@
 [ ] Any doc that is only move/rename/etc. should be deleted (verify content is in the correct doc before deleting).
 [ ] Consolidate PRs for easier one-stop review, so one capability does not require reading many docs (for example, bezel/background); focus on what the capability does.
 [ ] Remove imports to export (should not be import x, export x)
-[ ] other than templates (games/samples/tools), remove the .keep file, if the folder is empty, delete
+[ ] Other than templates (games/samples/tools), remove the .keep file, if the folder is empty, delete
diff --git a/docs/pr/BUILD_PR_LEVEL_12_10_REAL_NETWORK_SAMPLE_AND_DASHBOARD.md b/docs/pr/BUILD_PR_LEVEL_12_10_REAL_NETWORK_SAMPLE_AND_DASHBOARD.md
@@ -27,8 +27,8 @@ This BUILD fixes that properly by requiring:
 - `samples/phase-13/1319/game/RealNetworkLaunchScene.js`
 
 ### Real Server + Dashboard
-- `samples/phase-13/1319/server/realNetworkServer.mjs`
-- `samples/phase-13/1319/server/realNetworkDashboard.mjs`
+- `samples/phase-13/1319/tests/realNetworkServer.mjs`
+- `samples/phase-13/1319/tests/realNetworkDashboard.mjs`
 - `samples/phase-13/1319/server/README.md`
 - `samples/phase-13/1319/server/docker-compose.yml`
 
diff --git a/docs/pr/BUILD_PR_LEVEL_12_12_SAMPLE_1319_SERVER_TEST_RELOCATION.md b/docs/pr/BUILD_PR_LEVEL_12_12_SAMPLE_1319_SERVER_TEST_RELOCATION.md
@@ -0,0 +1,56 @@
+# BUILD_PR_LEVEL_12_12_SAMPLE_1319_SERVER_TEST_RELOCATION
+
+## Purpose
+Relocate 1319 server `.mjs` runtime files from `server/` to `tests/` to align with repo testing/runtime conventions.
+
+## One PR Purpose Only
+File relocation + path correction only.
+
+## Problem
+Current structure places executable `.mjs` under:
+- samples/phase-13/1319/server/
+
+This conflicts with repo pattern where executable/test runtimes belong under:
+- tests/
+
+## Required Changes
+
+### Move Files
+From:
+- samples/phase-13/1319/server/*.mjs
+
+To:
+- samples/phase-13/1319/tests/*.mjs
+
+### Update References
+- Update ALL references to new paths
+- Update README instructions
+- Update any launch scripts
+
+### Keep Structure Clean
+- server/ may retain configs (docker, docs)
+- executable runtime goes to tests/
+
+## Rules
+- No logic changes
+- No behavior changes
+- Path updates only
+
+## Validation
+
+### Path Validation
+- no remaining references to old server/*.mjs paths
+
+### Runtime Validation
+- server starts from new tests/ path
+- sample 1319 still connects correctly
+- dashboard still functional
+
+### Regression
+- no breakage to sample launcher
+- no breakage to other samples
+
+## Acceptance Criteria
+- .mjs files relocated
+- all references updated
+- runtime still works
diff --git a/samples/metadata/samples.shared.boundaries.report.json b/samples/metadata/samples.shared.boundaries.report.json
@@ -551,7 +551,7 @@
   "sharedExtractionCandidates": {
     "fromSamplesShared": [
       {
-        "modulePath": "_shared/lateSampleBootstrap.js",
+        "modulePath": "shared/lateSampleBootstrap.js",
         "importerCount": 24,
         "sampleCount": 24,
         "importerExamples": [
@@ -567,7 +567,7 @@
         "candidateStatus": "candidate-for-src-shared-promotion"
       },
       {
-        "modulePath": "_shared/platformerHelpers.js",
+        "modulePath": "shared/platformerHelpers.js",
         "importerCount": 12,
         "sampleCount": 12,
         "importerExamples": [
@@ -583,11 +583,11 @@
         "candidateStatus": "candidate-for-src-shared-promotion"
       },
       {
-        "modulePath": "_shared/numberUtils.js",
+        "modulePath": "shared/numberUtils.js",
         "importerCount": 13,
         "sampleCount": 5,
         "importerExamples": [
-          "_shared/sampleDetailPageEnhancement.js",
+          "shared/sampleDetailPageEnhancement.js",
           "phase-12/1208/ToolFormattedTilesParallaxScene.js",
           "phase-13/1303/AsteroidsWorldSystemsScene.js",
           "phase-13/1316/game/FakeLoopbackNetworkModel.js",
@@ -599,7 +599,7 @@
         "candidateStatus": "candidate-for-src-shared-promotion"
       },
       {
-        "modulePath": "_shared/debugConfigUtils.js",
+        "modulePath": "shared/debugConfigUtils.js",
         "importerCount": 4,
         "sampleCount": 4,
         "importerExamples": [
@@ -611,7 +611,7 @@
         "candidateStatus": "candidate-for-src-shared-promotion"
       },
       {
-        "modulePath": "_shared/networkDebugUtils.js",
+        "modulePath": "shared/networkDebugUtils.js",
         "importerCount": 3,
         "sampleCount": 3,
         "importerExamples": [
@@ -622,14 +622,14 @@
         "candidateStatus": "candidate-for-src-shared-promotion"
       },
       {
-        "modulePath": "_shared/snapshotCloneUtils.js",
+        "modulePath": "shared/snapshotCloneUtils.js",
         "importerCount": 2,
         "sampleCount": 1,
         "importerExamples": [
           "phase-13/1318/game/ReconciliationLayerAdapter.js",
           "phase-13/1318/game/StateTimelineBuffer.js"
         ],
-        "candidateStatus": "keep-samples-_shared"
+        "candidateStatus": "keep-samples-shared"
       }
     ],
     "fromCrossSampleImports": [
@@ -644,7 +644,7 @@
           "phase-03/0305/TileMetadataScene.js",
           "phase-03/0306/NESStyleZonesParallaxScene.js"
         ],
-        "candidateStatus": "candidate-to-move-into-samples-_shared"
+        "candidateStatus": "candidate-to-move-into-samples-shared"
       },
       {
         "modulePath": "phase-13/1316/game/FakeLoopbackNetworkModel.js",
diff --git a/samples/phase-13/1319/server/README.md b/samples/phase-13/1319/server/README.md
@@ -7,7 +7,7 @@ Run a real WebSocket authoritative server for sample 1319 and expose a live dash
 From repo root:
 
 ```bash
-node samples/phase-13/1319/server/realNetworkServer.mjs
+node samples/phase-13/1319/tests/realNetworkServer.mjs
 ```
 
 ## Serve Sample Launcher
diff --git a/samples/phase-13/1319/server/docker-compose.yml b/samples/phase-13/1319/server/docker-compose.yml
@@ -8,7 +8,7 @@ services:
     command: >
       sh -lc "cd /app
       && npm install --omit=dev --silent
-      && node samples/phase-13/1319/server/realNetworkServer.mjs"
+      && node samples/phase-13/1319/tests/realNetworkServer.mjs"
     environment:
       NETWORK_SAMPLE_1319_HOST: "0.0.0.0"
       NETWORK_SAMPLE_1319_PORT: "4320"
diff --git a/samples/phase-13/1319/tests/realNetworkDashboard.mjs b/samples/phase-13/1319/tests/realNetworkDashboard.mjs
diff --git a/samples/phase-13/1319/tests/realNetworkServer.mjs b/samples/phase-13/1319/tests/realNetworkServer.mjs

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-normalize samples shared directory structure — BUILD_PR_LEVEL_12_11_SAMPLE_SHARED_DIRECTORY_NORMALIZATION`
	`1`	`+relocate 1319 server runtime files to tests directory — BUILD_PR_LEVEL_12_12_SAMPLE_1319_SERVER_TEST_RELOCATION`