Skip to content

Commit 540549f

Browse files
author
DavidQ
committed
Rename Object Geometry to Shape Geometry and add point style controls - PR_26133_075-shape-geometry-rounding-and-terminology-normalization
1 parent c39414d commit 540549f

9 files changed

Lines changed: 461 additions & 182 deletions

File tree

docs/dev/reports/playwright_v8_coverage_report.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Playwright V8 Coverage Report
22

3-
PR: PR_26133_074-geometry-defaults-angle-snap-undo-and-stroke-cap-fixes
3+
PR: PR_26133_075-shape-geometry-rounding-and-terminology-normalization
44

55
Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the latest npm run test:workspace-v2 run.
66

@@ -21,13 +21,11 @@ Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the late
2121

2222
## Changed Runtime JS Files Covered
2323

24-
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 110/110; executed functions 5/6
25-
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 452/452; executed functions 56/59
26-
- (96%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6645/6645; executed functions 673/704
24+
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 109/109; executed functions 5/6
25+
- (96%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6825/6825; executed functions 688/719
2726

2827
## Changed JS Files Considered
2928

3029
- (83%) tools/object-vector-studio-v2/js/bootstrap.js - changed runtime JS file with browser V8 coverage
31-
- (95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - changed runtime JS file with browser V8 coverage
3230
- (96%) tools/object-vector-studio-v2/js/ToolStarterApp.js - changed runtime JS file with browser V8 coverage
3331
- (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - Playwright test file, not collected as browser runtime coverage

docs/dev/reports/playwright_workspace_v2_results.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
# Playwright Workspace V2 Results
22

3-
PR: PR_26133_074-geometry-defaults-angle-snap-undo-and-stroke-cap-fixes
3+
PR: PR_26133_075-shape-geometry-rounding-and-terminology-normalization
44

55
## Validation
66

77
- PASS: npm run test:workspace-v2
88
- Result: 54 passed
9-
- Runtime: 5.1m
9+
- Runtime: 5.3m
1010
- Browser project: playwright
1111
- Workers: 1
1212

1313
## Targeted Checks Covered
1414

15-
- Angle Snap help states that it applies to Object Transform Rotate and rounds the applied rotation delta to 15 degree increments.
16-
- Object Vector Studio V2 schema geometry definitions no longer carry pre-positioned defaults for click/move/click shape creation.
17-
- Stroke ending control is present in Palette and renders line/polyline/polygon/arc stroke caps and joins as round or square.
18-
- Object Preview pivot marker is smaller and labeled as the Origin/Pivot marker for rotation and scale.
19-
- Undo after a preview drag reverts the completed drag in one step rather than stepping through mousemove positions.
20-
- Polygon/Polyline Enter completion, Copy icon mapping, and Object Geometry group marker color remain covered by the workspace suite.
15+
- Object Vector Studio V2 UI and tests use Shape Geometry terminology instead of Object Geometry.
16+
- Palette no longer exposes the old End stroke control; stroke width remains in Palette.
17+
- Shape Geometry renders Point Style for closed cornered shapes and Start/End Point Style for open-ended shapes.
18+
- Closed shape point style changes update rendered joins, and open-ended line styles render separate start/end point cap markers.
19+
- Group summary remains below the point-style controls in Shape Geometry.
20+
- Existing polygon/polyline creation, Enter completion, and runtime error coverage remain green.
2121

2222
## Console/Runtime Errors
2323

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

Lines changed: 139 additions & 96 deletions
Large diffs are not rendered by default.

tools/object-vector-studio-v2/index.html

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,6 @@ <h2 class="tools-platform-frame__eyebrow">First-Class Tools Surface V2</h2>
185185
<span>Width</span>
186186
<input id="objectVectorStudioV2StrokeWidth" type="number" min="0.1" step="0.1" value="2">
187187
</label>
188-
<label class="object-vector-studio-v2__inline-field object-vector-studio-v2__stroke-cap-field" for="objectVectorStudioV2StrokeLinecap">
189-
<span>End</span>
190-
<select id="objectVectorStudioV2StrokeLinecap" title="Stroke endings and joins for lines, polylines, polygons, and arcs">
191-
<option value="round">Round</option>
192-
<option value="square">Square</option>
193-
</select>
194-
</label>
195188
</div>
196189
<div class="object-vector-studio-v2__palette-opacity-row">
197190
<span class="object-vector-studio-v2__palette-opacity-heading">Opacity</span>
@@ -284,15 +277,15 @@ <h2 class="tools-platform-frame__eyebrow">First-Class Tools Surface V2</h2>
284277
</section>
285278

286279
<section class="accordion-v2 tool-starter__accordion tool-starter__accordion--compact is-open" data-accordion-v2-open="true">
287-
<button class="accordion-v2__header" type="button" aria-expanded="true" aria-controls="objectVectorStudioV2ObjectDetailsContent">
280+
<button class="accordion-v2__header" type="button" aria-expanded="true" aria-controls="objectVectorStudioV2ShapeGeometryContent">
288281
<span class="object-vector-studio-v2__geometry-header-title">
289-
<span class="object-vector-studio-v2__geometry-header-line">Object Geometry <span id="objectVectorStudioV2ObjectGeometrySummary" class="object-vector-studio-v2__header-count"></span></span>
290-
<span id="objectVectorStudioV2ObjectGeometryName" class="object-vector-studio-v2__geometry-header-name"></span>
282+
<span class="object-vector-studio-v2__geometry-header-line">Shape Geometry <span id="objectVectorStudioV2ShapeGeometrySummary" class="object-vector-studio-v2__header-count"></span></span>
283+
<span id="objectVectorStudioV2ShapeGeometryName" class="object-vector-studio-v2__geometry-header-name"></span>
291284
</span>
292285
<span class="accordion-v2__icon" aria-hidden="true">+</span>
293286
</button>
294-
<div id="objectVectorStudioV2ObjectDetailsContent" class="accordion-v2__content object-vector-studio-v2__scroll-content">
295-
<div id="objectVectorStudioV2ObjectDetails" class="object-vector-studio-v2__details">No object selected.</div>
287+
<div id="objectVectorStudioV2ShapeGeometryContent" class="accordion-v2__content object-vector-studio-v2__scroll-content">
288+
<div id="objectVectorStudioV2ShapeGeometryDetails" class="object-vector-studio-v2__details">No object selected.</div>
296289
</div>
297290
</section>
298291

0 commit comments

Comments
 (0)