Skip to content

Commit 5315af0

Browse files
author
DavidQ
committed
Rename asset-browser-v2 to asset-manager-v2 across repo and enforce single tool contract - PR_11_313
1 parent ca93240 commit 5315af0

115 files changed

Lines changed: 498 additions & 376 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docs/dev/codex_commands.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,3 +131,10 @@ PR_11_313 (Workspace V2 launcher + Asset Manager V2 UI labels)
131131
```bash
132132
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_313: Workspace V2 tool launcher UI + Asset Manager V2 user-facing rename."
133133
```
134+
135+
---
136+
PR_11_313 (single contract rename: asset-manager-v2)
137+
138+
```bash
139+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_313: rename legacy asset browser v2 id to asset-manager-v2 across tool ID, paths, payloads, registry links, tests, and docs with zero old references."
140+
```

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add explicit Workspace V2 Asset Manager launcher and rename Asset Browser V2 user-facing labels without contract changes - PR 11.313
1+
Rename legacy asset browser v2 id to asset-manager-v2 as a single repo-wide contract with zero legacy references - PR 11.313

docs/dev/reports/PR_11_193C_validation.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Implement the V2 HTML-first batch for Palette Manager V2, SVG Asset Studio V2, V
66
## Files Changed
77
- `tools/tilemap-studio-v2/index.html`
88
- `tools/tilemap-studio-v2/index.js`
9-
- `tools/asset-browser-v2/index.html`
10-
- `tools/asset-browser-v2/index.js`
9+
- `tools/asset-manager-v2/index.html`
10+
- `tools/asset-manager-v2/index.js`
1111
- `docs/dev/reports/PR_11_193C_validation.md`
1212

1313
Existing active V2 tools verified without additional implementation edits in this pass:
@@ -23,7 +23,7 @@ Existing PR source doc was present in the worktree and included in the ZIP:
2323

2424
## Implementation Summary
2525
- Added `Tilemap Studio V2` as `tools/tilemap-studio-v2/`.
26-
- Added `Asset Browser V2` as `tools/asset-browser-v2/`.
26+
- Added `Asset Browser V2` as `tools/asset-manager-v2/`.
2727
- Both new tools are HTML-first: `index.html` owns static shell, CSS links, shared header mount, layout, menus, state containers, and module scripts.
2828
- Both new tools keep `index.js` behavior-only: document title/tool id setup, session read, contract validation, event binding, dynamic rendering into existing DOM nodes, and empty/error states.
2929
- No legacy implementation files were copied into V2. Legacy files were used only to infer high-level contract names and user-facing data shape.
@@ -34,7 +34,7 @@ Passed for all five scoped V2 tools:
3434
- `tools/svg-asset-studio-v2/index.html`
3535
- `tools/vector-map-editor-v2/index.html`
3636
- `tools/tilemap-studio-v2/index.html`
37-
- `tools/asset-browser-v2/index.html`
37+
- `tools/asset-manager-v2/index.html`
3838

3939
Each contains:
4040
- `<div id="shared-theme-header"></div>`
@@ -84,15 +84,15 @@ node --check tools/palette-manager-v2/index.js
8484
node --check tools/svg-asset-studio-v2/index.js
8585
node --check tools/vector-map-editor-v2/index.js
8686
node --check tools/tilemap-studio-v2/index.js
87-
node --check tools/asset-browser-v2/index.js
87+
node --check tools/asset-manager-v2/index.js
8888
```
8989

9090
Results:
9191
- `node --check tools/palette-manager-v2/index.js` passed.
9292
- `node --check tools/svg-asset-studio-v2/index.js` passed.
9393
- `node --check tools/vector-map-editor-v2/index.js` passed.
9494
- `node --check tools/tilemap-studio-v2/index.js` passed.
95-
- `node --check tools/asset-browser-v2/index.js` passed.
95+
- `node --check tools/asset-manager-v2/index.js` passed.
9696

9797
Targeted direct-entry/HTML validation:
9898
- Verified all five scoped `index.html` files have the required static shell/header/menu/script markers.

docs/dev/reports/PR_11_193_V2_HTML_FIRST_BATCH_validation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Batch-correct and verify the active V2 tool lane so `index.html` owns static she
1010

1111
## Listed V2 Folders Not Present
1212
- `tools/tilemap-studio-v2/` - NOT PRESENT - SKIPPED
13-
- `tools/asset-browser-v2/` - NOT PRESENT - SKIPPED
13+
- `tools/asset-manager-v2/` - NOT PRESENT - SKIPPED
1414

1515
No unrelated scaffolding was created for absent V2 tools.
1616

@@ -70,7 +70,7 @@ Results:
7070

7171
Skipped commands:
7272
- `node --check tools/tilemap-studio-v2/index.js` - NOT PRESENT - SKIPPED
73-
- `node --check tools/asset-browser-v2/index.js` - NOT PRESENT - SKIPPED
73+
- `node --check tools/asset-manager-v2/index.js` - NOT PRESENT - SKIPPED
7474

7575
## Additional Guard Checks
7676
- HTML/JS compliance scan passed for the three active V2 folders.

docs/dev/reports/PR_11_194_v2_html_first_remaining_tools_report.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Verify and complete the remaining Tool V2 HTML-first shell batch. Each scoped V2
88
- `tools/svg-asset-studio-v2/`
99
- `tools/vector-map-editor-v2/`
1010
- `tools/tilemap-studio-v2/`
11-
- `tools/asset-browser-v2/`
11+
- `tools/asset-manager-v2/`
1212

1313
## Files Changed
1414
- `docs/dev/reports/PR_11_194_v2_html_first_remaining_tools_report.md`
@@ -74,15 +74,15 @@ node --check tools/palette-manager-v2/index.js
7474
node --check tools/svg-asset-studio-v2/index.js
7575
node --check tools/vector-map-editor-v2/index.js
7676
node --check tools/tilemap-studio-v2/index.js
77-
node --check tools/asset-browser-v2/index.js
77+
node --check tools/asset-manager-v2/index.js
7878
```
7979

8080
Results:
8181
- `node --check tools/palette-manager-v2/index.js` passed.
8282
- `node --check tools/svg-asset-studio-v2/index.js` passed.
8383
- `node --check tools/vector-map-editor-v2/index.js` passed.
8484
- `node --check tools/tilemap-studio-v2/index.js` passed.
85-
- `node --check tools/asset-browser-v2/index.js` passed.
85+
- `node --check tools/asset-manager-v2/index.js` passed.
8686

8787
Additional targeted validation:
8888
- `PR_11_194 V2 HTML-first compliance validation passed`
@@ -93,7 +93,7 @@ Manual browser validation was not launched from this terminal session. The per-t
9393
- Open `tools/svg-asset-studio-v2/index.html`; confirm shared header renders, static shell is visible before session data, missing session shows explicit empty state, valid session renders without legacy coupling.
9494
- Open `tools/vector-map-editor-v2/index.html`; confirm shared header renders, static shell is visible before session data, missing session shows explicit empty state, valid session renders without legacy coupling.
9595
- Open `tools/tilemap-studio-v2/index.html`; confirm shared header renders, static shell is visible before session data, missing session shows explicit empty state, valid session renders without legacy coupling.
96-
- Open `tools/asset-browser-v2/index.html`; confirm shared header renders, static shell is visible before session data, missing session shows explicit empty state, valid session renders without legacy coupling.
96+
- Open `tools/asset-manager-v2/index.html`; confirm shared header renders, static shell is visible before session data, missing session shows explicit empty state, valid session renders without legacy coupling.
9797

9898
## Banned Path Check Result
9999
Scoped status check confirmed no changes under:

docs/dev/reports/PR_11_195_validation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,13 @@ Additional unchanged V2 lane sanity checks were also run:
3939
```powershell
4040
node --check tools/vector-map-editor-v2/index.js
4141
node --check tools/tilemap-studio-v2/index.js
42-
node --check tools/asset-browser-v2/index.js
42+
node --check tools/asset-manager-v2/index.js
4343
```
4444

4545
Results:
4646
- `node --check tools/vector-map-editor-v2/index.js` passed.
4747
- `node --check tools/tilemap-studio-v2/index.js` passed.
48-
- `node --check tools/asset-browser-v2/index.js` passed.
48+
- `node --check tools/asset-manager-v2/index.js` passed.
4949

5050
## Banned JS Pattern Check
5151
Command covered changed JS files:

docs/dev/reports/PR_11_197B_v2_asset_browser_validation.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
Complete Asset Browser V2 as the focused, testable V2 implementation target while preserving the HTML-first/static-shell and session-only runtime architecture.
55

66
## Files Changed
7-
- `tools/asset-browser-v2/index.js`
7+
- `tools/asset-manager-v2/index.js`
88
- `docs/dev/reports/PR_11_197B_v2_asset_browser_validation.md`
99
- `docs/dev/reports/PR_11_197B_expected_evidence.md`
1010

1111
Unchanged but packaged for review context:
12-
- `tools/asset-browser-v2/index.html`
12+
- `tools/asset-manager-v2/index.html`
1313

1414
## Implementation Summary
15-
- Kept `tools/asset-browser-v2/index.html` as the static shell owner: CSS links, shared header mount, page layout, menu regions, state containers, and module script tags remain in HTML.
16-
- Kept `tools/asset-browser-v2/index.js` behavior-only: title/tool id setup, session read, validation, DOM population, event binding, dynamic render, empty state, and invalid state.
15+
- Kept `tools/asset-manager-v2/index.html` as the static shell owner: CSS links, shared header mount, page layout, menu regions, state containers, and module script tags remain in HTML.
16+
- Kept `tools/asset-manager-v2/index.js` behavior-only: title/tool id setup, session read, validation, DOM population, event binding, dynamic render, empty state, and invalid state.
1717
- Tightened valid session contract to require explicit `assetCatalog.entries[]` fields: `id`, `label`, `kind`, and `path`.
1818
- Removed auto-previewing the first asset as an implicit selection. Valid sessions now render list/count and instruct the user to select an entry to inspect session-backed metadata.
1919
- No legacy Asset Browser implementation code was copied.
@@ -22,15 +22,15 @@ Unchanged but packaged for review context:
2222
## Validation Commands Run
2323

2424
```powershell
25-
node --check tools/asset-browser-v2/index.js
25+
node --check tools/asset-manager-v2/index.js
2626
```
2727

2828
Result: passed.
2929

3030
Static banned-pattern check:
3131

3232
```powershell
33-
rg -n "document\.body\.innerHTML|document\.head\.insertAdjacentHTML|createElement\(|appendChild\(|platformShell|assetUsageIntegration|tools/shared/|\.\.\/shared|Workspace Manager|fallback|default data|sample data|demo data" -- tools/asset-browser-v2/index.js
33+
rg -n "document\.body\.innerHTML|document\.head\.insertAdjacentHTML|createElement\(|appendChild\(|platformShell|assetUsageIntegration|tools/shared/|\.\.\/shared|Workspace Manager|fallback|default data|sample data|demo data" -- tools/asset-manager-v2/index.js
3434
```
3535

3636
Result: passed. No matches.
@@ -39,13 +39,13 @@ HTML shell marker check verified:
3939
- `id="shared-theme-header"`
4040
- `src="../../src/engine/theme/mount-shared-header.js"`
4141
- `src="./index.js"`
42-
- `data-tool-id="asset-browser-v2"`
42+
- `data-tool-id="asset-manager-v2"`
4343
- `<title>Asset Browser V2</title>`
4444

4545
Result: passed.
4646

4747
## Lightweight Browser Validation Evidence
48-
A Node VM harness executed `tools/asset-browser-v2/index.js` with minimal browser/session mocks and verified direct empty, invalid session, and valid session states.
48+
A Node VM harness executed `tools/asset-manager-v2/index.js` with minimal browser/session mocks and verified direct empty, invalid session, and valid session states.
4949

5050
Log snippets:
5151

docs/dev/reports/PR_11_199_report.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
# PR_11_199 Report
22

33
## V2 Directories Inspected
4-
- `tools/asset-browser-v2`
4+
- `tools/asset-manager-v2`
55
- `tools/palette-manager-v2`
66
- `tools/svg-asset-studio-v2`
77
- `tools/tilemap-studio-v2`
88
- `tools/vector-map-editor-v2`
99

1010
## Files Changed
11-
- `tools/asset-browser-v2/index.html`
12-
- `tools/asset-browser-v2/index.js`
11+
- `tools/asset-manager-v2/index.html`
12+
- `tools/asset-manager-v2/index.js`
1313
- `tools/palette-manager-v2/index.html`
1414
- `tools/palette-manager-v2/index.js`
1515
- `tools/svg-asset-studio-v2/index.html`
@@ -19,19 +19,19 @@
1919
- `docs/dev/reports/PR_11_199_report.md`
2020

2121
## Validation Commands Run
22-
- `node --check tools/asset-browser-v2/index.js`
22+
- `node --check tools/asset-manager-v2/index.js`
2323
- `node --check tools/palette-manager-v2/index.js`
2424
- `node --check tools/svg-asset-studio-v2/index.js`
2525
- `node --check tools/vector-map-editor-v2/index.js`
2626

2727
## Validation Results
28-
- `node --check tools/asset-browser-v2/index.js`: **PASS** (exit code 0)
28+
- `node --check tools/asset-manager-v2/index.js`: **PASS** (exit code 0)
2929
- `node --check tools/palette-manager-v2/index.js`: **PASS** (exit code 0)
3030
- `node --check tools/svg-asset-studio-v2/index.js`: **PASS** (exit code 0)
3131
- `node --check tools/vector-map-editor-v2/index.js`: **PASS** (exit code 0)
3232

3333
## Manual Validation Results By Tool
34-
- `asset-browser-v2`: browser-interactive manual run not executed in this CLI-only session (no interactive browser in terminal tooling). Static checks by source inspection: header mount present, no-session empty state region present, malformed-session invalid state region present, valid/render region present, no banned JS `innerHTML` page construction.
34+
- `asset-manager-v2`: browser-interactive manual run not executed in this CLI-only session (no interactive browser in terminal tooling). Static checks by source inspection: header mount present, no-session empty state region present, malformed-session invalid state region present, valid/render region present, no banned JS `innerHTML` page construction.
3535
- `palette-manager-v2`: browser-interactive manual run not executed in this CLI-only session (no interactive browser in terminal tooling). Static checks by source inspection: header mount present, no-session empty state region present, malformed-session invalid state region present, valid/render region present, no banned JS `innerHTML` page construction.
3636
- `svg-asset-studio-v2`: browser-interactive manual run not executed in this CLI-only session (no interactive browser in terminal tooling). Static checks by source inspection: header mount present, no-session empty state region present, malformed-session invalid state region present, valid/render region present, no banned JS `innerHTML` page construction, URL payload writeback path removed.
3737
- `vector-map-editor-v2`: browser-interactive manual run not executed in this CLI-only session (no interactive browser in terminal tooling). Static checks by source inspection: header mount present, no-session empty state region present, malformed-session invalid state region present, valid/render region present, no banned JS `innerHTML` page construction, vector preview rendered via SVG DOM nodes.

docs/dev/reports/PR_11_200_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
- `SVG Asset Studio V2` -> `/tools/svg-asset-studio-v2/index.html`
1010
- `Vector Map Editor V2` -> `/tools/vector-map-editor-v2/index.html`
1111
- `Tilemap Studio V2` -> `/tools/tilemap-studio-v2/index.html`
12-
- `Asset Browser V2` -> `/tools/asset-browser-v2/index.html`
12+
- `Asset Browser V2` -> `/tools/asset-manager-v2/index.html`
1313

1414
All entries explicitly include `V2`, route directly to V2 tool `index.html`, and do not alias to legacy tool paths.
1515

@@ -23,7 +23,7 @@ All entries explicitly include `V2`, route directly to V2 tool `index.html`, and
2323
- `/tools/svg-asset-studio-v2/index.html`
2424
- `/tools/vector-map-editor-v2/index.html`
2525
- `/tools/tilemap-studio-v2/index.html`
26-
- `/tools/asset-browser-v2/index.html`
26+
- `/tools/asset-manager-v2/index.html`
2727
- No V1 label reuse for these entries (all show explicit `V2` suffix text in entry titles).
2828

2929
## Full Smoke Decision

docs/dev/reports/PR_11_201_report.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
# PR_11_201 Report
22

33
## Tools Tested
4-
- `tools/asset-browser-v2/index.js`
4+
- `tools/asset-manager-v2/index.js`
55
- `tools/palette-manager-v2/index.js`
66
- `tools/svg-asset-studio-v2/index.js`
77
- `tools/tilemap-studio-v2/index.js`
88
- `tools/vector-map-editor-v2/index.js`
99

1010
## Files Changed
1111
- `tools/index.html`
12-
- `tools/asset-browser-v2/index.js`
12+
- `tools/asset-manager-v2/index.js`
1313
- `tools/palette-manager-v2/index.js`
1414
- `tools/svg-asset-studio-v2/index.js`
1515
- `tools/tilemap-studio-v2/index.js`
@@ -24,14 +24,14 @@
2424
- valid `hostContextId` with valid session payload -> normal render path
2525

2626
## Validation Commands
27-
- `node --check tools/asset-browser-v2/index.js`
27+
- `node --check tools/asset-manager-v2/index.js`
2828
- `node --check tools/palette-manager-v2/index.js`
2929
- `node --check tools/svg-asset-studio-v2/index.js`
3030
- `node --check tools/tilemap-studio-v2/index.js`
3131
- `node --check tools/vector-map-editor-v2/index.js`
3232

3333
## Validation Results
34-
- `node --check tools/asset-browser-v2/index.js`: **PASS**
34+
- `node --check tools/asset-manager-v2/index.js`: **PASS**
3535
- `node --check tools/palette-manager-v2/index.js`: **PASS**
3636
- `node --check tools/svg-asset-studio-v2/index.js`: **PASS**
3737
- `node --check tools/tilemap-studio-v2/index.js`: **PASS**
@@ -43,7 +43,7 @@
4343
- Scenario 1 (no parameters): **PASS** (code-path inspection: `renderMissing(...)` when `hostContextId` is absent)
4444
- Scenario 2 (invalid `hostContextId`): **PASS** (code-path inspection: `renderError(...)` with actionable message when session key is missing)
4545
- Scenario 3 (valid `hostContextId`): **PASS** (code-path inspection: resolves `toolboxaid.toolHost.context.<id>`, parses JSON, validates `payloadJson.assetCatalog`, renders)
46-
- Scenario 4 (open from tools index): **PASS** (link points to `./asset-browser-v2/index.html`)
46+
- Scenario 4 (open from tools index): **PASS** (link points to `./asset-manager-v2/index.html`)
4747

4848
### Palette Manager V2
4949
- Scenario 1 (no parameters): **PASS** (code-path inspection: `renderMissing(...)`)

0 commit comments

Comments
 (0)