Skip to content

Commit 4dc2b0f

Browse files
author
DavidQ
committed
Show Workspace Manager asset status from embedded tool payloads - PR 11.22
1 parent 6139b85 commit 4dc2b0f

9 files changed

Lines changed: 734 additions & 18 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,19 @@
33
model: gpt-5.3-codex
44
reasoning: high
55

6-
Apply PR_11_21_WORKSPACE_MANAGER_TOOL_PRESENT_DETECTION_FIX.
6+
Apply PR_11_22_WORKSPACE_MANAGER_EMBEDDED_PAYLOAD_ASSET_STATUS_FIX.
77

88
Required:
9-
- Fix Workspace Manager/tool presence detection so tools are marked present from `manifest.tools[toolId]`.
10-
- Use strict manifest.tools keys as the source for presence.
11-
- Validate keys against tool registry and tool schemas.
12-
- Map singular `tools.palette` to Palette Browser UI/presence without suppressing other tools.
13-
- Stop using old presence sources for sample 1902: top-level palettes, games[].tools, activeWorkspaceTools, config, top-level payload, sample tool-payload wrappers.
14-
- Add evidence/report listing raw loaded tool keys, normalized keys, valid present keys, invalid keys, and visible Workspace Manager tools.
9+
- Fix Workspace Manager asset/status display so tools with embedded data under `manifest.tools[toolId].payload` do not show `Asset: none`.
10+
- Keep tool presence logic from PR 11.21.
11+
- Add payload-document mapping for sample 1902 tool entries:
12+
vectorMapDocument, vectorAssetDocument, tileMapDocument, parallaxDocument, spriteProject, skin, assetCatalog, palette, snapshot, events, profileSettings, physicsBody, pipelinePayload, candidate, mapPayload, asset3d, cameraPath.
13+
- Derive meaningful display labels from embedded payloads where possible.
14+
- Utilities may show N/A only when intentionally non-asset tools, but payload-backed tools must not be marked missing.
15+
- Do not require external asset pointers or legacy assetRegistry entries to show data present.
1516
- Do not loosen schemas.
1617
- Do not modify other samples.
1718
- Do not add fallback/default/hidden data.
1819
- Do not modify start_of_day folders.
19-
- Add validation report at docs/dev/reports/PR_11_21_WORKSPACE_MANAGER_TOOL_PRESENT_DETECTION_FIX_report.md.
20-
- Return ZIP artifact at tmp/PR_11_21_WORKSPACE_MANAGER_TOOL_PRESENT_DETECTION_FIX_delta.zip.
20+
- Add validation report at docs/dev/reports/PR_11_22_WORKSPACE_MANAGER_EMBEDDED_PAYLOAD_ASSET_STATUS_FIX_report.md.
21+
- Return ZIP artifact at tmp/PR_11_22_WORKSPACE_MANAGER_EMBEDDED_PAYLOAD_ASSET_STATUS_FIX_delta.zip.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Detect present Workspace tools from strict manifest.tools payloads - PR 11.21
1+
Show Workspace Manager asset status from embedded tool payloads - PR 11.22
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# PR 11.22 - Workspace Manager Embedded Payload Asset Status Fix
2+
3+
## PASS/FAIL
4+
PASS
5+
6+
## Files Changed
7+
- tools/shared/platformShell.js
8+
- docs/dev/reports/PR_11_22_workspace_embedded_payload_asset_status_evidence.json
9+
- docs/dev/reports/PR_11_22_WORKSPACE_MANAGER_EMBEDDED_PAYLOAD_ASSET_STATUS_FIX_report.md
10+
11+
## Scope Implemented
12+
- Preserved PR 11.21 manifest.tools presence logic (no changes to presence classifier in Workspace Manager).
13+
- Fixed shared shell asset/status badge rendering used during Workspace Manager hosted tool sessions.
14+
- Added embedded payload status derivation from `manifest.tools[toolId].payload` scoped tool state so payload-backed tools do not default to `Asset: none` when shared handoff is empty.
15+
16+
## Embedded Payload Mapping Added
17+
Payload documents recognized for status labels:
18+
- `vectorMapDocument`
19+
- `vectorAssetDocument`
20+
- `tileMapDocument`
21+
- `parallaxDocument`
22+
- `spriteProject`
23+
- `skin`
24+
- `assetCatalog`
25+
- `palette`
26+
- `snapshot`
27+
- `events`
28+
- `profileSettings`
29+
- `physicsBody`
30+
- `pipelinePayload`
31+
- `candidate`
32+
- `mapPayload`
33+
- `asset3d`
34+
- `cameraPath`
35+
36+
## Behavior Change
37+
- For hosted tools launched via Workspace Manager sample workspace manifest:
38+
- If shared asset/palette handoff exists and is compatible, badge remains shared-handoff driven.
39+
- If shared handoff is empty but scoped workspace payload contains recognized embedded data, badge now shows an active embedded status label (for example, embedded vector map/asset/tile map/palette/etc.) instead of `Asset: none`.
40+
- Utility tools with embedded payloads now show embedded status labels rather than missing status.
41+
- `Asset: N/A` is only retained when a tool intentionally has no shared-asset dependency and no recognized embedded payload document.
42+
43+
## Evidence
44+
Evidence file:
45+
- `docs/dev/reports/PR_11_22_workspace_embedded_payload_asset_status_evidence.json`
46+
47+
Evidence summary for sample 1902:
48+
- visible mapped tools: 17
49+
- payload-backed missing labels: 0
50+
- each visible mapped tool resolves one of the required embedded payload document keys.
51+
52+
## Validation Commands and Results
53+
- `node --check "tools/shared/platformShell.js"` -> PASS
54+
- `node --check "tools/Workspace Manager/main.js"` -> PASS
55+
- `node ./tests/runtime/LaunchSmokeAllEntries.test.mjs --samples --sample-range=1902-1902 --tools` -> PASS (`PASS=19 FAIL=0`)
56+
- embedded payload evidence generation script (sample 1902 mapping/status export) -> PASS (`payloadBackedMissing=0`)
57+
58+
## Constraint Confirmation
59+
- No schema loosening.
60+
- No fallback/default/hidden data added.
61+
- No modifications to other samples.
62+
- No modifications to `start_of_day` folders.
63+
- No dependency on legacy `assetRegistry`/external pointers for payload-present status.

0 commit comments

Comments
 (0)