Skip to content

Commit 4c36183

Browse files
author
DavidQ
committed
Align sample 1713 overlay stack to Final Reference Runtime.
Enforce bottom-right placement and remove Tab key usage.
1 parent e46744e commit 4c36183

5 files changed

Lines changed: 52 additions & 36 deletions

File tree

docs/dev/CODEX_COMMANDS.md

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,9 @@
1-
MODEL: GPT-5.4
2-
REASONING: high
3-
1+
MODEL: GPT-5.3-codex
2+
REASONING: medium
43
COMMAND:
5-
Implement BUILD_PR_LEVEL_17_52_DEBUG_OVERLAY_CYCLE_KEY_AND_SAMPLE_STACK_MAP as a small, testable PR.
6-
7-
Requirements:
8-
- Remove Tab as the overlay-cycle key in the touched phase-17 samples.
9-
- Introduce one consistent non-browser-reserved replacement key across the touched samples.
10-
- Keep all touched debug panels bottom-right anchored.
11-
- Enforce the exact sample-specific cycle maps:
12-
- 1708, 1710: UI Layer -> Mission Feed -> existing title ending in ADY -> Mini-Game Runtime
13-
- 1709, 1711: Movement Runtime -> Movement Lab HUD
14-
- 1712: UI Layer -> Mission Feed -> existing title ending in ADY -> Telemetry Overlay
15-
- 1713: UI Layer -> Mission Feed -> existing title ending in ADY -> Final Reference Runtime
16-
- Keep the ADY-ending title as-is unless already incorrect for another reason.
17-
- Update/add runtime tests so they verify the replacement key, reject Tab behavior, verify panel presence/order, and confirm bottom-right placement.
18-
19-
Constraints:
20-
- Smallest scoped valid change only.
21-
- Do not modify start_of_day folders.
22-
- Do not do repo-wide scanning.
23-
- Keep implementation one-pass executable.
24-
25-
Package the resulting repo-structured ZIP to:
26-
<project folder>/tmp/BUILD_PR_LEVEL_17_52_DEBUG_OVERLAY_CYCLE_KEY_AND_SAMPLE_STACK_MAP.zip
4+
Implement overlay stack mapping for sample 1713 using existing overlay system.
5+
- Enforce bottom-right anchor
6+
- Remove any Tab bindings
7+
- Ensure cycle key matches prior PR (17_52)
8+
- Validate ordering and rendering
9+
Package output ZIP to <project folder>/tmp/

docs/dev/COMMIT_COMMENT.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1-
BUILD_PR_LEVEL_17_52: replace Tab-based debug overlay cycling in touched phase-17 samples and lock bottom-right sample-specific overlay stack maps for 1708-1713 with runtime coverage
1+
Align sample 1713 overlay stack to Final Reference Runtime.
2+
Enforce bottom-right placement and remove Tab key usage.
Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
1-
[ ] Runtime tests pass.
2-
[ ] Tab no longer advances overlay cycling in touched phase-17 samples.
3-
[ ] Replacement key advances overlay cycling in touched phase-17 samples.
4-
[ ] Sample 1708 panel cycle set matches: UI Layer, Mission Feed, *ADY, Mini-Game Runtime.
5-
[ ] Sample 1710 panel cycle set matches: UI Layer, Mission Feed, *ADY, Mini-Game Runtime.
6-
[ ] Sample 1709 panel cycle set matches: Movement Runtime, Movement Lab HUD.
7-
[ ] Sample 1711 panel cycle set matches: Movement Runtime, Movement Lab HUD.
8-
[ ] Sample 1712 panel cycle set matches: UI Layer, Mission Feed, *ADY, Telemetry Overlay.
9-
[ ] Sample 1713 panel cycle set matches: UI Layer, Mission Feed, *ADY, Final Reference Runtime.
10-
[ ] Touched overlay titles render in the bottom-right stack region.
1+
[ ] Sample 1713 loads
2+
[ ] Bottom-right overlay placement correct
3+
[ ] Cycle key works (non-Tab)
4+
[ ] Stack order matches spec

docs/pr/BUILD_PR.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# BUILD_PR_LEVEL_17_53_DEBUG_OVERLAY_SAMPLE_1713_FINAL_REFERENCE_ALIGNMENT
2+
3+
## Purpose
4+
Align Sample 1713 overlay stack to Final Reference Runtime and validate bottom-right positioning + cycle behavior (non-Tab key).
5+
6+
## Scope
7+
- Sample 1713 overlay stack:
8+
- UI Layer
9+
- Mission Feed
10+
- <...ADY>
11+
- Final Reference Runtime
12+
- Bottom-right anchor enforcement
13+
- Cycle key (non-Tab) verification
14+
15+
## Test Steps
16+
1. Load sample 1713
17+
2. Verify overlays render bottom-right
18+
3. Press cycle key → confirm correct order
19+
4. Confirm no Tab usage
20+
21+
## Expected
22+
- Correct stack order
23+
- No overlay overlap issues
24+
- Stable cycling behavior

tests/runtime/Phase17DebugOverlayBottomRightPosition.test.mjs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import DoomRaycastSpritesScene from '../../samples/phase-17/1701/RaycastDemoScen
1313
import TextureMaterialDemoScene from '../../samples/phase-17/1704/TextureMaterialDemoScene.js';
1414
import RealGameplayMiniGameScene from '../../samples/phase-17/1708/RealGameplayMiniGameScene.js';
1515
import GameplayMetricsTelemetryScene from '../../samples/phase-17/1712/GameplayMetricsTelemetryScene.js';
16+
import FinalReferenceGameScene from '../../samples/phase-17/1713/FinalReferenceGameScene.js';
1617

1718
function createCameraStub() {
1819
const state = {
@@ -156,10 +157,23 @@ function assertSample1712TelemetryPlacement() {
156157
assertBottomRightFromTitle(telemetryTitle, 228, 244, 722, 286, 'Sample 1712 telemetry overlay');
157158
}
158159

160+
function assertSample1713FinalRuntimePlacement() {
161+
const scene = new FinalReferenceGameScene();
162+
scene.setCamera3D(createCameraStub());
163+
pressCycleKey(scene);
164+
pressCycleKey(scene);
165+
pressCycleKey(scene);
166+
const renderer = createRendererProbe();
167+
scene.render(renderer);
168+
const runtimeTitle = findExactText(renderer, 'Final Reference Runtime');
169+
assertBottomRightFromTitle(runtimeTitle, 228, 248, 722, 282, 'Sample 1713 final runtime overlay');
170+
}
171+
159172
export function run() {
160173
assertSharedStackMath();
161174
assertSample1701RuntimePanelPlacement();
162175
assertSample1704StackedPanelPlacement();
163176
assertSample1708CyclePlacement();
164177
assertSample1712TelemetryPlacement();
178+
assertSample1713FinalRuntimePlacement();
165179
}

0 commit comments

Comments
 (0)