Load Active Game dropdown from recursively discovered schema-valid game manifests - PR_26128_006-active-game-manifest-discovery

Author: DavidQ

docs/dev/reports/active_game_manifest_discovery.md

@@ -0,0 +1,32 @@
+# PR_26128_006 Active Game Manifest Discovery
+
+## Changes
+- Workspace Manager V2 now starts with an empty, disabled Active Game dropdown until a repo folder is selected.
+- Repo Destination selection clears the active workspace immediately before loading the newly selected repo.
+- Workspace Manager V2 recursively scans the selected repo `games/` tree for `game.manifest.json` files.
+- Discovered manifests are validated through the existing Workspace Manager V2 manifest/schema validation path before being added to Active Game.
+- Active Game is populated only with schema-valid discovered manifests and remains unselected after discovery.
+- Invalid manifests are skipped with visible status log entries that include the manifest path and validation reason.
+- Missing direct child game manifests under `games/` are logged as `SKIP`, not `FAIL`.
+- Repo load failure leaves Active Game empty and disabled.
+
+## Guardrails
+- No `game.manifest.json` files were modified.
+- No sample JSON was modified.
+- No schema contracts were modified.
+- No cross-tool communication was added.
+- No repo write behavior was added or changed.
+- No session/toolState persistence behavior was added for repo discovery; discovered repo/game state remains in-memory.
+
+## Validation
+- `npm run test:workspace-v2` -> PASS, 11 tests.
+- Verified Active Game dropdown is empty and disabled before repo selection.
+- Verified dropdown clears when repo selection changes.
+- Verified dropdown remains disabled on repo load failure.
+- Verified only schema-valid discovered `game.manifest.json` entries appear.
+- Verified invalid manifests are skipped and logged with exact path/reason.
+- Verified missing manifests are logged as `SKIP`, not `FAIL`.
+- Verified no default game is auto-selected after discovery.
+
+## Skipped
+- Full samples smoke test was skipped by request. This PR is scoped to Workspace Manager V2 manifest discovery and dropdown state; `npm run test:workspace-v2` plus targeted Playwright coverage exercises the affected UI, discovery, validation, and launch handoff behavior.

docs/dev/reports/playwright_active_game_manifest_discovery.md

@@ -0,0 +1,21 @@
+# Playwright Active Game Manifest Discovery
+
+## Command
+- `npm run test:workspace-v2`
+
+## Result
+- PASS
+- 11 tests passed.
+
+## Coverage Notes
+- Added Playwright coverage for repo-backed Active Game discovery.
+- The mocked repo picker returns three schema-valid Workspace Manager V2 `game.manifest.json` files, one invalid manifest, and one missing-manifest game folder.
+- Assertions verify:
+  - Active Game is empty and disabled before repo selection.
+  - Repo selection populates only `Asteroids`, `Gravity Well`, and `Pong`.
+  - Active Game remains on the placeholder after discovery.
+  - Invalid manifest log includes `games/InvalidWorkspace/game.manifest.json` and the schema validation reason.
+  - Missing manifest log includes `games/MissingManifest/game.manifest.json` and is logged as `SKIP`.
+  - Switching to a repo missing `games/` clears and disables Active Game.
+  - Re-selecting a valid repo repopulates the dropdown without auto-selecting a game.
+  - Existing Workspace Manager V2 launch flows still work after discovery.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -5,6 +5,7 @@ import { workspaceV2CoverageReporter as coverageReporter } from "../../helpers/w
 
 async function openWorkspaceManagerV2(page, query = "") {
   const server = await startRepoServer();
+  await installMockRepoPicker(page);
   await coverageReporter.start(page);
   await page.goto(`${server.baseUrl}/tools/workspace-manager-v2/index.html${query}`, { waitUntil: "networkidle" });
   return server;
@@ -28,6 +29,111 @@ function manifestRepoPath(server) {
   return server.repoRoot.replaceAll("\\", "/");
 }
 
+async function installMockRepoPicker(page) {
+  await page.addInitScript(() => {
+    const defaultManifestPaths = [
+      "/games/Asteroids/game.manifest.json",
+      "/games/GravityWell/game.manifest.json",
+      "/games/Pong/game.manifest.json"
+    ];
+
+    function makeFileHandle(name, text) {
+      return {
+        kind: "file",
+        name,
+        async getFile() {
+          return new File([text], name, { type: "application/json" });
+        }
+      };
+    }
+
+    function makeDirectoryHandle(name, children = {}) {
+      return {
+        kind: "directory",
+        name,
+        async getDirectoryHandle(childName) {
+          const child = children[childName];
+          if (child?.kind === "directory") {
+            return child;
+          }
+          throw new DOMException(`${childName} was not found.`, "NotFoundError");
+        },
+        async getFileHandle(childName) {
+          const child = children[childName];
+          if (child?.kind === "file") {
+            return child;
+          }
+          throw new DOMException(`${childName} was not found.`, "NotFoundError");
+        },
+        async *entries() {
+          for (const entry of Object.entries(children)) {
+            yield entry;
+          }
+        }
+      };
+    }
+
+    async function fetchManifestText(path) {
+      const response = await fetch(path, { cache: "no-store" });
+      if (!response.ok) {
+        throw new Error(`${path} returned ${response.status}`);
+      }
+      return await response.text();
+    }
+
+    async function makeMockRepoHandle(config = {}) {
+      const repoName = config.repoName || "HTML-JavaScript-Gaming";
+      if (config.missingGames) {
+        return makeDirectoryHandle(repoName, {});
+      }
+      const games = {
+        MissingManifest: makeDirectoryHandle("MissingManifest", {}),
+        InvalidWorkspace: makeDirectoryHandle("InvalidWorkspace", {
+          "game.manifest.json": makeFileHandle("game.manifest.json", JSON.stringify({
+            schema: "html-js-gaming.project",
+            version: 1,
+            tools: {}
+          }))
+        })
+      };
+      for (const manifestPath of (config.manifestPaths || defaultManifestPaths)) {
+        const parts = manifestPath.replace(/^\/+/, "").split("/");
+        const gameFolder = parts[1];
+        games[gameFolder] = makeDirectoryHandle(gameFolder, {
+          "game.manifest.json": makeFileHandle("game.manifest.json", await fetchManifestText(manifestPath))
+        });
+      }
+      return makeDirectoryHandle(repoName, {
+        games: makeDirectoryHandle("games", games)
+      });
+    }
+
+    window.__workspaceManagerV2MockRepoConfig = {};
+    window.showDirectoryPicker = async () => {
+      if (window.__workspaceManagerV2MockRepoConfig?.failPicker) {
+        throw new DOMException("Mock picker canceled.", "AbortError");
+      }
+      return await makeMockRepoHandle(window.__workspaceManagerV2MockRepoConfig || {});
+    };
+  });
+}
+
+async function selectMockRepo(page, { repoName = "HTML-JavaScript-Gaming" } = {}) {
+  await page.evaluate((nextRepoName) => {
+    window.__workspaceManagerV2MockRepoConfig = { repoName: nextRepoName };
+  }, repoName);
+  await page.locator("#pickRepoBtn").click();
+  await expect(page.locator("#repoSelectedValue")).toHaveText(repoName);
+  await expect(page.locator("#activeGameSelect")).toBeEnabled();
+  await expect(page.locator("#activeGameSelect")).toHaveValue("");
+  await expect(page.locator("#activeGameSelect option")).toHaveText([
+    "Select a game",
+    "Asteroids",
+    "Gravity Well",
+    "Pong"
+  ]);
+}
+
 test.describe("Workspace Manager V2 bootstrap", () => {
   test.afterAll(async () => {
     await coverageReporter.writeReport();
@@ -157,6 +263,48 @@ test.describe("Workspace Manager V2 bootstrap", () => {
     }
   });
 
+  test("discovers Active Game options from selected repo manifests", async ({ page }) => {
+    const server = await openWorkspaceManagerV2(page);
+    const pageErrors = [];
+
+    page.on("pageerror", (error) => {
+      pageErrors.push(error.message);
+    });
+
+    try {
+      await expect(page.locator("#activeGameSelect")).toBeDisabled();
+      await expect(page.locator("#activeGameSelect option")).toHaveCount(0);
+      await expect(page.locator("#activeGameSummary")).toHaveText("Pick a repo folder to discover schema-valid game manifests.");
+
+      await selectMockRepo(page);
+      await expect(page.locator("#activeGameSummary")).toHaveText("Discovered 3 schema-valid game manifests from HTML-JavaScript-Gaming.");
+      await expect(page.locator("#statusLog")).toHaveValue(/INFO SKIP games\/InvalidWorkspace\/game\.manifest\.json: Generated Workspace Manager V2 manifest failed schema validation: root\.documentKind is required/);
+      await expect(page.locator("#statusLog")).toHaveValue(/INFO SKIP games\/MissingManifest\/game\.manifest\.json: game\.manifest\.json not found/);
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Discovered 3 schema-valid game manifests\./);
+
+      await page.evaluate(() => {
+        window.__workspaceManagerV2MockRepoConfig = {
+          missingGames: true,
+          repoName: "BrokenRepo"
+        };
+      });
+      await page.locator("#pickRepoBtn").click();
+      await expect(page.locator("#repoSelectedValue")).toHaveText("not selected");
+      await expect(page.locator("#activeGameSelect")).toBeDisabled();
+      await expect(page.locator("#activeGameSelect option")).toHaveCount(0);
+      await expect(page.locator("#activeGameSummary")).toHaveText(/Selected repo is missing games\//);
+      await expect(page.locator("#statusLog")).toHaveValue(/FAIL Repo load failed: Selected repo is missing games\//);
+
+      await selectMockRepo(page, { repoName: "SecondRepo" });
+      await expect(page.locator("#activeGameSummary")).toHaveText("Discovered 3 schema-valid game manifests from SecondRepo.");
+      await expect(page.locator("#workspaceContextOutput")).toHaveValue("{}");
+      expect(pageErrors).toEqual([]);
+    } finally {
+      await coverageReporter.stop(page);
+      await server.close();
+    }
+  });
+
   test("exports manifests and launches tools from fixed Workspace Manager V2 tiles", async ({ page }) => {
     const server = await openWorkspaceManagerV2(page);
     const pageErrors = [];
@@ -176,6 +324,12 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#workspaceContextContent")).toHaveCount(0);
       await expect(page.locator("#workspaceJsonContent #workspaceContextOutput")).toBeVisible();
       await expect(page.locator("#copyWorkspaceJsonButton")).toHaveText("copy");
+      await expect(page.locator("#repoDestinationContent")).toBeVisible();
+      await expect(page.locator(".workspace-manager-v2__panel--left > .accordion-v2").first().locator(".accordion-v2__header > span:first-child")).toHaveText("Repo Destination");
+      await expect(page.locator("#pickRepoBtn")).toHaveText("Pick Repo Folder");
+      await expect(page.locator("#repoSelectedValue")).toHaveText("not selected");
+      await expect(page.locator("#activeGameSelect")).toBeDisabled();
+      await expect(page.locator("#activeGameSelect option")).toHaveCount(0);
       const centerControlLabels = await page.locator(".workspace-manager-v2__panel--center > .accordion-v2 > .accordion-v2__header > span:first-child")
         .evaluateAll((labels) => labels.map((label) => label.textContent.trim()));
       expect(centerControlLabels).toEqual(["Tools", "Workspace JSON"]);
@@ -206,6 +360,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       expect(await page.locator("#workspaceToolTiles [data-workspace-tool-id]").evaluateAll((tiles) => (
         tiles.every((tile) => Array.from(tile.querySelectorAll(".workspace-manager-v2__tool-tile-action"), (action) => action.textContent.trim()).join("|") === "How To Use|Read Me")
       ))).toBe(true);
+      await selectMockRepo(page);
       const compactCenterLayout = await page.evaluate(() => {
         const getRect = (selector) => {
           const element = document.querySelector(selector);
@@ -223,12 +378,6 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       });
       expect(compactCenterLayout.toolsExtraHeight).toBeLessThanOrEqual(90);
       expect(compactCenterLayout.jsonTop).toBeGreaterThan(compactCenterLayout.toolsBottom);
-      await expect(page.locator("#activeGameSelect option")).toHaveText([
-        "Select a game",
-        "Asteroids",
-        "Gravity Well",
-        "Pong"
-      ]);
 
       await page.locator("#activeGameSelect").selectOption("Asteroids");
       await expect(page.locator("#activeGameSummary")).toContainText("games/Asteroids/");
@@ -678,6 +827,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         Pong: { ok: true }
       });
 
+      await selectMockRepo(page);
       await page.locator("#activeGameSelect").selectOption("GravityWell");
       await expect(page.locator("#activeGameSummary")).toContainText("games/GravityWell/");
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"gameRoot": "games\/GravityWell\/"/);
@@ -712,6 +862,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await page.locator("#returnToWorkspaceButton").click();
       await expect(page).toHaveURL(/workspace-manager-v2\/index\.html\?hostContextId=workspace-manager-v2-/);
 
+      await selectMockRepo(page);
       await page.locator("#activeGameSelect").selectOption("Pong");
       await expect(page.locator("#activeGameSummary")).toContainText("games/Pong/");
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"gameRoot": "games\/Pong\/"/);
@@ -762,6 +913,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
     });
 
     try {
+      await selectMockRepo(page);
       await page.locator("#activeGameSelect").selectOption("Asteroids");
       await expect(page.locator("#exportManifestButton")).toBeEnabled();
       await page.evaluate(() => {
@@ -793,10 +945,12 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         status: 200
       });
     });
+    await installMockRepoPicker(page);
     await coverageReporter.start(page);
     await page.goto(`${server.baseUrl}/tools/workspace-manager-v2/index.html`, { waitUntil: "networkidle" });
 
     try {
+      await selectMockRepo(page);
       await page.locator("#activeGameSelect").selectOption("Asteroids");
       await expect(page.locator("#activeAssetRegistrySummary")).toHaveCount(0);
       await expect(page.locator("#workspaceContextOutput")).toHaveValue(/"assets": \{\}/);

tools/workspace-manager-v2/index.html

@@ -73,7 +73,7 @@ <h2 class="tools-platform-frame__eyebrow">Games-only launch context</h2>
               <span>Game</span>
               <select id="activeGameSelect"></select>
             </label>
-            <p id="activeGameSummary" class="workspace-manager-v2__hint">Select a game workspace.</p>
+            <p id="activeGameSummary" class="workspace-manager-v2__hint">Pick a repo folder to discover schema-valid game manifests.</p>
           </div>
         </section>
       </aside>

tools/workspace-manager-v2/js/WorkspaceManagerV2App.js

@@ -21,6 +21,7 @@ export class WorkspaceManagerV2App {
     this.activeGame = null;
     this.activeHostContextId = null;
     this.activeWorkspaceMode = this.contextService.isUatMode() ? "uat" : "";
+    this.activeRepoHandle = null;
   }
 
   start() {
@@ -62,22 +63,61 @@ export class WorkspaceManagerV2App {
     });
     this.summary.clear();
     this.menu.setExportEnabled(false);
+    this.gameSelector.clear();
     this.toolTiles.renderEmpty();
-    this.statusLog.ok("Workspace Manager V2 ready. Select, import, or seed a game workspace to create a schema-valid manifest.");
+    this.statusLog.ok("Workspace Manager V2 ready. Pick a repo folder to discover schema-valid game manifests.");
     void this.restoreWorkspaceFromSession();
   }
 
+  clearActiveWorkspace(summaryText = "Pick a repo folder to discover schema-valid game manifests.") {
+    this.activeContext = null;
+    this.activeGame = null;
+    this.activeHostContextId = null;
+    this.activeWorkspaceMode = this.contextService.isUatMode() ? "uat" : "";
+    this.contextService.clearDiscoveredGames();
+    this.gameSelector.clear();
+    this.gameSelector.setSummary(summaryText);
+    this.menu.setExportEnabled(false);
+    this.toolTiles.renderEmpty();
+    this.summary.clear();
+  }
+
   async pickRepoDestination() {
+    this.activeRepoHandle = null;
+    this.repoDestination.setRepoDestinationDisplayName("not selected");
+    this.clearActiveWorkspace("Loading repo game manifests.");
     if (typeof window.showDirectoryPicker !== "function") {
-      this.statusLog.info("Repo folder picker is unavailable in this browser.");
+      this.gameSelector.setSummary("Repo folder picker is unavailable in this browser.");
+      this.statusLog.fail("Repo load failed: Repo folder picker is unavailable in this browser.");
       return;
     }
     try {
-      const selectedRepoHandle = await window.showDirectoryPicker();
+      const selectedRepoHandle = await window.showDirectoryPicker({ mode: "read" });
       const displayName = selectedRepoHandle?.name || "selected";
+      const discovery = await this.contextService.discoverGameManifests(selectedRepoHandle);
+      if (!discovery.ok) {
+        this.gameSelector.setSummary(discovery.message);
+        this.statusLog.fail(`Repo load failed: ${discovery.message}`);
+        return;
+      }
+      discovery.skips.forEach((skip) => {
+        this.statusLog.info(`SKIP ${skip.path}: ${skip.reason}`);
+      });
+      this.activeRepoHandle = selectedRepoHandle;
       this.repoDestination.setRepoDestinationDisplayName(displayName);
-      this.statusLog.ok(`Repo destination selected: ${displayName}.`);
+      this.contextService.setDiscoveredGames(discovery.games);
+      this.gameSelector.setGames(discovery.games);
+      if (discovery.games.length) {
+        this.gameSelector.setSummary(`Discovered ${discovery.games.length} schema-valid game manifest${discovery.games.length === 1 ? "" : "s"} from ${displayName}.`);
+        this.statusLog.ok(`Repo destination selected: ${displayName}.`);
+        this.statusLog.ok(`Discovered ${discovery.games.length} schema-valid game manifest${discovery.games.length === 1 ? "" : "s"}.`);
+      } else {
+        this.gameSelector.clear();
+        this.gameSelector.setSummary(`No schema-valid game manifests were found in ${displayName}.`);
+        this.statusLog.fail(`Repo load failed: No schema-valid game.manifest.json files were found in ${displayName}.`);
+      }
     } catch (error) {
+      this.gameSelector.setSummary("Pick a repo folder to discover schema-valid game manifests.");
       this.statusLog.info(`Repo folder selection canceled or failed: ${error.message}`);
     }
   }