Fix Object Preview default zoom normalization and update zoom range constants - PR_26133_007-object-preview-zoom-default-and-range-fix

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,4 +1,4 @@
-# PR_26133_006 Playwright V8 Coverage Report
+# PR_26133_007 Playwright V8 Coverage Report
 
 Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed by the final `npm run test:workspace-v2` run.
 
@@ -7,7 +7,7 @@ Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed
 - Coverage is advisory only; no thresholds are enforced.
 - Workspace Manager V2 entry point: 91%.
 - Object Vector Studio V2 runtime coverage entries from the generated report:
-  - `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 91%, executed lines 3313/3313, executed functions 349/384.
+  - `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 91%, executed lines 3313/3313, executed functions 348/384.
   - `tools/object-vector-studio-v2/js/bootstrap.js`: 80%, executed lines 99/99, executed functions 4/5.
 - The generated report lists `tools/object-vector-studio-v2/js/ToolStarterApp.js` as a changed JS file with browser V8 coverage.
 
@@ -16,4 +16,4 @@ Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed
 - Main command: `npm run test:workspace-v2`.
 - Result: 46 passed.
 - Focused Object Vector Studio V2 layout and preview-coordinate scenarios also passed.
-- Manual Object Preview probe confirmed normalized zoom display, unchanged visual scale, and no console/runtime errors.
+- Manual Object Preview probe confirmed default zoom display, 1% control steps, min/max range, unchanged visual scale, and no console/runtime errors.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,28 +1,28 @@
-# PR_26133_006 Workspace V2 Results
+# PR_26133_007 Workspace V2 Results
 
 ## Command Results
 
 - `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`: passed.
 - `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`: passed.
 - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --grep "Object Vector Studio V2 (layout shell|preview coordinates)"`: 2 passed.
-- `npm run test:workspace-v2`: 46 passed.
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --grep "blocks Workspace Manager V2 Save when the toolState file fails schema validation"`: 1 passed after the test setup waited for the Asset Manager V2 session before corrupting it.
+- Final `npm run test:workspace-v2`: 46 passed.
 - `git diff --check`: passed with the existing LF-to-CRLF working-copy warning for `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`.
 
 ## Targeted Object Preview Verification
 
 - Standalone Playwright manual probe reported `consoleErrors: []` and `pageErrors: []`.
-- Object Preview visuals remained unchanged: grid step `10`, viewBox `-640 -440 1280 880` at internal 25%, and Asteroids ship drawn points `0,-180`, `140,160`, `0,80`, `-140,160`.
-- Internal zoom `0.1` displayed as `Zoom 100%`.
-- Internal zoom `0.095` displayed as `Zoom 95%`.
-- Zoom buttons continued changing the internal zoom/viewBox the same way: one zoom out from reset displayed `Zoom 900%`, one zoom in back to reset displayed `Zoom 1000%`, and internal 25% displayed `Zoom 250%`.
-- Pointer and origin coordinate normalization from PR_26133_005 remains intact.
+- Startup/default Object Preview display is `Origin: 0, 0 | Canvas 0,0 centered | Zoom 100%`.
+- Zoom controls increment/decrement by 1%: zoom in displays `Zoom 101%`, then zoom out returns to `Zoom 100%`.
+- Zoom range clamps to the updated constants: max displays `Zoom 200%` with viewBox `-80 -55 160 110`; min displays `Zoom 1%` with viewBox `-16000 -11000 32000 22000`.
+- Visual scale remains unchanged at default: viewBox `-160 -110 320 220`, grid step `10`, and Asteroids ship drawn points `0,-180`, `140,160`, `0,80`, `-140,160`.
+- Pointer/origin coordinate normalization from PR_26133_005 remains intact.
 
 ## Contract Checks
 
-- Visual rendering was not changed.
+- `const MAX_ZOOM = 2;`, `const MIN_ZOOM = 0.01;`, and `const ZOOM_STEP = 0.01;` are applied.
 - Canvas size was not changed.
 - Grid size was not changed.
 - Object drawing scale was not changed.
-- Pointer/origin coordinate normalization was not changed.
+- Coordinate normalization logic was not changed.
 - No unrelated tool/runtime files were changed.
-- No fallback behavior was added.

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -1838,32 +1838,35 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#statusLog")).toHaveValue(/OK Shape\/Tools mode selected from keyboard: select\./);
 
       await page.locator("#objectVectorStudioV2ZoomInButton").click();
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 1100%");
-      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-145.455 -100 290.909 200");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 101%");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-158.416 -108.911 316.832 217.822");
       await page.locator("#objectVectorStudioV2PanRightButton").click();
-      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-125.455 -100 290.909 200");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas 0,0 centered | Zoom 1100%");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-138.416 -108.911 316.832 217.822");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas 0,0 centered | Zoom 101%");
       await page.locator("#objectVectorStudioV2ResetViewButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-160 -110 320 220");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 1000%");
-      await expect(page.locator("#statusLog")).toHaveValue(/OK Viewport reset to 1000% at origin 0,0\./);
-      await page.evaluate(() => {
-        window.__objectVectorStudioV2App.viewport.zoom = 0.1;
-        window.__objectVectorStudioV2App.updateViewport();
-      });
       await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 100%");
+      await expect(page.locator("#statusLog")).toHaveValue(/OK Viewport reset to 100% at origin 0,0\./);
       await page.evaluate(() => {
-        window.__objectVectorStudioV2App.viewport.zoom = 0.095;
+        window.__objectVectorStudioV2App.viewport.zoom = 0.95;
         window.__objectVectorStudioV2App.updateViewport();
       });
       await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 95%");
+      await page.evaluate(() => {
+        window.__objectVectorStudioV2App.zoomViewport(2.5);
+      });
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 200%");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-80 -55 160 110");
+      await page.evaluate(() => {
+        window.__objectVectorStudioV2App.zoomViewport(0);
+      });
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 1%");
+      await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-16000 -11000 32000 22000");
       await page.locator("#objectVectorStudioV2ResetViewButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-160 -110 320 220");
       await page.locator("#objectVectorStudioV2RenderSurface").hover();
-      for (let index = 0; index < 40; index += 1) {
-        await page.mouse.wheel(0, -240);
-      }
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 4000%");
+      await page.mouse.wheel(0, -240);
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 101%");
       await expect(page.locator("#objectVectorStudioV2RenderSurface [data-grid-rendered='true']")).toHaveCount(1);
       await expect(page.locator("#objectVectorStudioV2RenderSurface [data-center-origin='0,0']")).toHaveCount(1);
       const zoomedGridState = await page.locator("#objectVectorStudioV2RenderSurface").evaluate((surface) => ({
@@ -1873,11 +1876,13 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       }));
       expect(zoomedGridState.backgroundImage).toBe("none");
       expect(zoomedGridState.gridLineCount).toBeGreaterThan(0);
-      expect(zoomedGridState.viewBox).toBe("-40 -27.5 80 55");
-      for (let index = 0; index < 60; index += 1) {
-        await page.mouse.wheel(0, 240);
-      }
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 250%");
+      expect(zoomedGridState.viewBox).toBe("-158.416 -108.911 316.832 217.822");
+      await page.mouse.wheel(0, 240);
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 100%");
+      await page.evaluate(() => {
+        window.__objectVectorStudioV2App.zoomViewport(0.25);
+      });
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 25%");
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-640 -440 1280 880");
       await page.locator("#objectVectorStudioV2ResetViewButton").click();
 
@@ -2136,10 +2141,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       });
       await expect(page.locator("#statusLog")).toHaveValue(/OK Render mode svg-work-surface: rendered Asteroids Ship Grid Check with 1 visible shapes; capture mode none\./);
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-160 -110 320 220");
-      for (let index = 0; index < 8; index += 1) {
-        await page.locator("#objectVectorStudioV2ZoomOutButton").click();
-      }
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 250%");
+      await page.evaluate(() => {
+        window.__objectVectorStudioV2App.zoomViewport(0.25);
+      });
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toContainText("Zoom 25%");
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-640 -440 1280 880");
 
       const readPreviewScale = async () => page.locator("#objectVectorStudioV2RenderSurface").evaluate((surface) => {
@@ -2219,10 +2224,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
 
       await page.locator("#objectVectorStudioV2PanRightButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-620 -440 1280 880");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas 0,0 centered | Zoom 250%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 2, 0 | Canvas 0,0 centered | Zoom 25%");
       await page.locator("#objectVectorStudioV2PanLeftButton").click();
       await expect(page.locator("#objectVectorStudioV2RenderSurface")).toHaveAttribute("viewBox", "-640 -440 1280 880");
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 250%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Origin: 0, 0 | Canvas 0,0 centered | Zoom 25%");
       const examplePointerScreen = await page.locator("#objectVectorStudioV2RenderSurface").evaluate((surface) => {
         const point = surface.createSVGPoint();
         point.x = -140;
@@ -2235,7 +2240,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
         clientX: examplePointerScreen.x,
         clientY: examplePointerScreen.y
       });
-      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Pointer -14, -16 | Canvas origin 0,0 centered | Zoom 250%");
+      await expect(page.locator("#objectVectorStudioV2CoordinateDisplay")).toHaveText("Pointer -14, -16 | Canvas origin 0,0 centered | Zoom 25%");
       await page.setViewportSize({ width: 1040, height: 720 });
       const resizedPreviewScale = await readPreviewScale();
       expect(resizedPreviewScale.aspectRatioStable).toBe(true);
@@ -7032,6 +7037,7 @@ test.describe("Workspace Manager V2 bootstrap", () => {
     try {
       await selectMockRepo(page);
       await page.locator("#activeGameSelect").selectOption("Asteroids");
+      await expect.poll(() => page.evaluate(() => sessionStorage.getItem("workspace.tools.asset-manager-v2"))).not.toBeNull();
       await page.evaluate(() => {
         const app = window.__workspaceManagerV2App;
         const session = JSON.parse(window.sessionStorage.getItem("workspace.tools.asset-manager-v2"));

tools/object-vector-studio-v2/js/ToolStarterApp.js

@@ -12,9 +12,9 @@ const SVG_NS = "http://www.w3.org/2000/svg";
 const DEFAULT_VIEWPORT = Object.freeze({ height: 220, width: 320, x: 0, y: 0, zoom: 1 });
 const GRID_STEP = 10;
 const OBJECT_PREVIEW_DRAWING_SCALE = GRID_STEP;
-const MAX_ZOOM = 1;
-const MIN_ZOOM = 0.25;
-const ZOOM_STEP = 0.1;
+const MAX_ZOOM = 2;
+const MIN_ZOOM = 0.01;
+const ZOOM_STEP = 0.01;
 
 const OBJECT_STATE_IDS = Object.freeze(["idle", "thrust", "damaged", "destroyed", "active", "inactive"]);
 
@@ -1884,7 +1884,7 @@ export class ToolStarterApp {
   }
 
   formatZoomPercentage() {
-    return Math.round(this.viewport.zoom * 100 * GRID_STEP);
+    return Math.round(this.viewport.zoom * 100);
   }
 
   zoomViewportByStep(step) {