You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implement `BUILD_PR_LEVEL_18_1_ENGINE_USAGE_ENFORCEMENT_AUDIT_SLICE` exactly as specified in `docs/pr/BUILD_PR_LEVEL_18_1_ENGINE_USAGE_ENFORCEMENT_AUDIT_SLICE.md`.
9
+
10
+
Requirements:
11
+
- keep scope bounded to the overlay runtime hardening slice
12
+
- do not scan or edit unrelated repo areas
13
+
- migrate only clearly duplicated local logic to already-existing stable `src/engine` or `src/shared` surfaces
14
+
- update or add only the smallest necessary tests
15
+
- update roadmap status markers only for directly completed work
- Audited `samples/phase-17/shared/overlayGameplayRuntime.js` for local helper duplication against existing `src/shared` surfaces.
5
+
- Migrated duplicated finite-number normalization usage from local helper `normalizePointerNumber` to shared `asFiniteNumber` from `src/shared/number/index.js`.
6
+
- Removed the local duplicate helper and updated all in-slice pointer/gesture/layout call sites to use the shared helper.
7
+
- Added enforcement coverage in `tests/runtime/Phase19OverlayExpansionFramework.test.mjs` to validate the overlay runtime slice imports shared number normalization and no longer defines the local duplicate helper.
8
+
- Updated Level 18 Track A roadmap markers only for directly advanced bounded-slice progress.
9
+
10
+
No new features were added and no unrelated runtime/game/tool areas were modified.
Create the first executable Level 18 hardening slice by auditing a bounded runtime surface for engine-usage compliance, removing local reimplementation only where clearly duplicated inside the targeted slice, and adding validation-backed enforcement for that same slice.
5
+
6
+
## Why This PR
7
+
Level 18 is deferred execution for engine finalization and hardening. The roadmap explicitly requires additive-only, validation-backed changes with no blind refactors and no structural churn without move-map PRs. This PR starts that lane with the smallest scoped valid change: one bounded audit slice with enforcement and tests, rather than a repo-wide sweep.
8
+
9
+
## Scope
10
+
Bound this PR to the overlay/runtime hardening lane that was active at the end of Level 17 / Level 22 work.
11
+
12
+
Included scope:
13
+
- audit the Phase 17 / Phase 19 shared overlay runtime surfaces and any directly-coupled helper files they use
14
+
- identify any local reimplementation of behavior that already exists in `src/engine/` or `src/shared/`
15
+
- migrate only clearly duplicated logic inside this bounded slice to the correct engine/shared surface
16
+
- add or update validation that proves the bounded slice now relies on engine/shared surfaces instead of local copies
17
+
- update roadmap status markers only for items directly advanced by this PR
18
+
19
+
Excluded scope:
20
+
- no repo-wide sample/game scan
21
+
- no folder moves
22
+
- no start_of_day changes
23
+
- no CSS normalization
24
+
- no docs bucket cleanup outside this PR's own docs
25
+
- no broad naming cleanup
26
+
- no new features
27
+
- no gameplay behavior changes unless required to remove duplicated local logic in the audited slice
- any directly imported overlay-runtime helper modules used by that file
33
+
- any matching test files already covering the overlay runtime slice
34
+
- roadmap status file(s) only for status marker updates tied to this PR
35
+
36
+
Allowed engine/shared targets only if the audited slice already duplicates their logic:
37
+
-`src/engine/**`
38
+
-`src/shared/**`
39
+
40
+
Do not touch unrelated games, tools, or samples.
41
+
42
+
## Execution Steps
43
+
1. Inspect the bounded overlay runtime slice and list local helper logic that appears duplicated.
44
+
2. Compare each duplicate only against existing `src/engine/` and `src/shared/` public or stable helper surfaces.
45
+
3. Migrate only exact-match or near-exact-match duplicate logic where the destination is already stable and appropriate.
46
+
4. Replace local usage with the engine/shared import.
47
+
5. Remove only the local duplicated helper code made unnecessary by the migration.
48
+
6. Add or update targeted tests proving the audited slice still passes and uses the shared/engine surface.
49
+
7. Update the roadmap status markers for the directly-advanced Level 18 items.
50
+
8. Package the complete repo-structured ZIP to `<project folder>/tmp/BUILD_PR_LEVEL_18_1_ENGINE_USAGE_ENFORCEMENT_AUDIT_SLICE.zip`.
51
+
52
+
## Required Deliverables
53
+
- bounded audit + remediation implementation for the overlay runtime slice
54
+
- validation updates for that slice
55
+
- roadmap status updates only
56
+
- repo-structured ZIP artifact
57
+
58
+
## Validation Requirements
59
+
Must run and record results for the smallest relevant set first, then the broader overlay suite if unchanged dependencies require it.
60
+
61
+
Minimum required validation:
62
+
- targeted overlay runtime tests that cover the edited files
63
+
- any existing Phase 17 / Phase 19 / overlay integration tests that exercise the edited slice
64
+
65
+
If the bounded changes touch shared helpers used outside the slice, also run the smallest additional dependent test set needed to prove no regression.
66
+
67
+
## Acceptance Criteria
68
+
- the audited overlay runtime slice no longer contains clearly duplicated logic when an existing stable engine/shared surface already covers it
69
+
- no unrelated files are changed
70
+
- no new feature behavior is introduced
71
+
- all targeted validation passes
72
+
- roadmap status markers reflect only the work actually completed
73
+
- ZIP is produced at the required `<project folder>/tmp/` location
74
+
75
+
## Roadmap Status Update Rules
76
+
Update only status markers that are directly advanced by this PR. Preserve wording.
77
+
78
+
Expected likely marker progression if implementation succeeds:
79
+
-`18. Engine Finalization & Hardening (Deferred Execution)` remains active but may move from fully planned toward partial progress
80
+
-`Track A — Engine Usage Enforcement`
81
+
-`[.] verify all samples/ use engine systems (bounded slice only; if roadmap wording must remain unchanged, update only if execution meaningfully advances the item)`
82
+
-`[.] migrate any local logic into engine/shared where appropriate` if the bounded slice migration is completed
83
+
84
+
Do not mark broader Track A complete from this PR.
85
+
86
+
## Guardrails
87
+
- additive only
88
+
- smallest scoped valid change
89
+
- one PR purpose only
90
+
- no repo-wide scanning unless required by direct imports in the bounded slice
91
+
- no structural churn
92
+
- no move-map work in this PR
93
+
- no implementation in this doc bundle beyond instructions for Codex
0 commit comments