Skip to content

Commit 397ff7a

Browse files
author
DavidQ
committed
Improve Object Vector Studio shape tile actions and polygon geometry point editing - PR_26133_012-object-shape-tile-and-polygon-geometry-editing
1 parent 9b28f6e commit 397ff7a

7 files changed

Lines changed: 198 additions & 91 deletions

File tree

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# PR_26133_011 Playwright V8 Coverage Report
1+
# PR_26133_012 Playwright V8 Coverage Report
22

33
Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed by the final `npm run test:workspace-v2` run.
44

@@ -7,13 +7,13 @@ Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed
77
- Coverage is advisory only; no thresholds are enforced.
88
- Workspace Manager V2 entry point: 91%.
99
- Object Vector Studio V2 runtime coverage entries from the generated report:
10-
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 92%, executed lines 3619/3619, executed functions 383/417.
10+
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 92%, executed lines 3672/3672, executed functions 389/423.
1111
- `tools/object-vector-studio-v2/js/bootstrap.js`: 80%, executed lines 100/100, executed functions 4/5.
1212
- The generated report lists `tests/playwright/tools/WorkspaceManagerV2.spec.mjs` as changed JS not collected by browser runtime coverage.
1313

1414
## Validation Context
1515

1616
- Main command: `npm run test:workspace-v2`.
1717
- Result: 47 passed.
18-
- Focused Object Vector Studio V2 layout and mouse-editing scenarios passed.
19-
- Coverage includes the runtime paths for transform validation, geometry application, preview pointer editing, shape tile delete, and object ID preview updates.
18+
- Focused Object Vector Studio V2 layout, preview coordinate, and mouse-editing scenarios passed.
19+
- Coverage includes the runtime paths for Objects header counts, shape tile visibility/delete actions, palette swatch sync, polygon point-list geometry editing, and invalid point rejection.

docs/dev/reports/playwright_workspace_v2_results.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,21 @@
1-
# PR_26133_011 Workspace V2 Results
1+
# PR_26133_012 Workspace V2 Results
22

33
## Command Results
44

55
- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`: passed.
66
- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`: passed.
7-
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --grep "Object Vector Studio V2 (layout shell|preview shapes with mouse actions)"`: 2 passed.
7+
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --grep "Object Vector Studio V2 (layout shell|preview coordinates|preview shapes with mouse actions)"`: 3 passed.
88
- `npm run test:workspace-v2`: 47 passed.
99
- `git diff --check`: passed with LF-to-CRLF working-copy warnings for touched files.
1010

1111
## Targeted Object Vector Studio V2 Verification
1212

13-
- Confirmed Object Transform textboxes render inline beside labels for Move X, Move Y, Rotate, Scale, Origin X, Origin Y, and Resize.
14-
- Confirmed invalid transform input is marked with `aria-invalid`, writes an actionable failure, and leaves the selected shape transform unchanged.
15-
- Confirmed Apply Geometry commits schema-valid selected-shape geometry changes.
16-
- Confirmed selected-shape summary renders below Apply Geometry.
17-
- Confirmed Object Preview mouse editing works for selected-shape drag/drop, rectangle handle resize, and line endpoint movement.
18-
- Confirmed shape tile delete X removes only the targeted tile shape.
19-
- Confirmed Object Name edits immediately update Object Preview Object ID before Rename is clicked.
13+
- Confirmed the Objects accordion header shows the object/shape count text.
14+
- Confirmed shape tile visibility and delete icon buttons are adjacent on the right, with `Toggle shape visibility` immediately beside `Delete this shape`.
15+
- Confirmed selecting a shape highlights the matching palette swatch.
16+
- Confirmed Polygon Geometry renders as an editable point list with one `x,y` entry per polygon point.
17+
- Confirmed Apply Geometry commits valid polygon point-list edits to the selected polygon.
18+
- Confirmed invalid polygon point rows are marked with `aria-invalid`, report an actionable failure, preserve the invalid text for correction, and do not partially apply geometry.
2019
- Confirmed Object Preview coordinate/grid/zoom expectations from prior PRs remain covered by the workspace-v2 suite.
2120
- Confirmed targeted Object Vector Studio tests reported no console/page errors.
2221

0 commit comments

Comments
 (0)