Remove Asteroids shared tool fallback geometry and load object vectors from manifest - PR_26133_029-remove-asteroids-shared-tool-fallbacks

Author: DavidQ

docs/dev/reports/asteroids_shared_tool_fallback_removal_report.md

@@ -0,0 +1,38 @@
+# Asteroids Shared Tool Fallback Removal Report
+
+Task: PR_26133_029-remove-asteroids-shared-tool-fallbacks
+Date: 2026-05-14
+
+## Removed Fallbacks
+
+- Removed `tools/shared/asteroidsPlatformDemo.js`.
+- Removed shared-tool usage of the hardcoded Asteroids SVG constants:
+  - `ASTEROIDS_SHIP_SVG`
+  - `ASTEROIDS_LARGE_SVG`
+  - `ASTEROIDS_MEDIUM_SVG`
+  - `ASTEROIDS_SMALL_SVG`
+- Removed the Asteroids `BASE_VECTOR_MAP` runtime collision fallback from `games/Asteroids/entities/Asteroid.js`.
+- Removed Asteroids-specific object IDs and geometry fixtures from `tools/shared/vectorAssetSystem.js`.
+
+## Remaining Manifest Load Path
+
+- Canonical Asteroids geometry remains in `games/Asteroids/game.manifest.json`.
+- Runtime/editor geometry source:
+  - `game.workspace.tools["object-vector-studio-v2"].objects`
+  - object IDs such as `object.asteroids.ship` and `object.asteroids.asteroid.small`
+- Asteroid collision profiles are now derived from the validated Object Vector payload passed into `AsteroidsGameScene`.
+- Preview SVG generation is covered by `ObjectVectorRuntimeAssetService.createSvgString(...)`, which generates SVG from manifest object geometry at runtime.
+
+## Object ID vs Shape ID
+
+- `object.*` IDs remain the runtime/gameplay identity SSoT.
+- Shape IDs such as `ship-hull` and `small-asteroid-ridge` remain local editable IDs inside their owning object.
+- Shape IDs are used only for local editing and frame override references; they are not promoted to runtime object identity.
+
+## Validation
+
+- PASS - `npm run test:workspace-v2` completed with 49 passing tests.
+- PASS - Manifest Object Vector payload validated through `ObjectVectorRuntimeAssetService`.
+- PASS - Focused Asteroids transform and collision probes use geometry derived from `game.manifest.json`.
+- PASS - Targeted scans found no hardcoded Asteroids SVG constants in `tools/shared`.
+- PASS - Targeted scans found no `BASE_VECTOR_MAP` fallback in active Asteroids runtime code.

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,7 +1,7 @@
-# PR_26133_028 Playwright V8 Coverage Report
+# PR_26133_029 Playwright V8 Coverage Report
 
-Task: PR_26133_028-remove-vector-map-editor-runtime-dependency
-Date: 2026-05-13
+Task: PR_26133_029-remove-asteroids-shared-tool-fallbacks
+Date: 2026-05-14
 
 ## Result
 
@@ -14,27 +14,27 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 
 ## Exercised Tool Entry Points
 
-- Workspace Manager V2: 91%, 10 runtime JS files exercised.
-- Asset Manager V2: 74%, 13 runtime JS files exercised.
-- Preview Generator V2: 82%, 19 runtime JS files exercised.
-- Palette Manager V2: 62%, 12 runtime JS files exercised.
-- Tool Template V2: not exercised by this Playwright run.
-- Workspace Manager: not exercised by this Playwright run.
+- Workspace Manager V2: exercised by all 49 tests.
+- Object Vector Studio V2: exercised through shell, editing, dirty-state, geometry, and Asteroids runtime-loading flows.
+- Asset Manager V2 and Preview Generator V2: exercised by Workspace Manager V2 cross-tool tests.
+- Tool Template V2 and legacy Workspace Manager: not targeted by this Playwright run.
 
 ## Changed Runtime JS Coverage
 
-- `tools/shared/asteroidsPlatformDemo.js`: not collected by Playwright V8 coverage; covered by focused node probe.
-- `tools/shared/vectorAssetSystem.js`: not collected by Playwright V8 coverage; covered by focused node probe.
-- Object Vector Studio V2 runtime/editor modules from the prior object-ID path remain covered by the Workspace V2 run.
+- `games/Asteroids/game/asteroidObjectGeometry.js`: covered by focused node probes; used by Asteroids scene/world construction.
+- `games/Asteroids/entities/Asteroid.js`: covered by focused Asteroids vector-transform and collision probes.
+- `games/Asteroids/game/AsteroidsWorld.js`: covered by focused collision timing probes.
+- `games/Asteroids/game/AsteroidsGameScene.js` and `games/Asteroids/index.js`: covered by focused validation boot probe and Workspace V2 Asteroids runtime test.
+- `tools/shared/vectorAssetSystem.js`: covered by focused node probe.
+- `tools/shared/asteroidsPlatformDemo.js`: removed.
 
 ## PR-Specific Coverage/Validation Relevance
 
-The workspace-v2 run exercises the Object Vector Studio V2 editor and Asteroids runtime paths affected by this PR:
+The Workspace V2 run plus focused probes verify the paths affected by this PR:
 
-- Asteroids workspace hydration without `vector-map-editor`.
-- Object Vector Studio V2 loading/editing of Asteroids objects through `object-vector-studio-v2.objects`.
-- Asteroids runtime Object Vector rendering through `object.asteroids.*` IDs.
-- Workspace save summaries without vector-map-editor tool state.
-- Asteroids manifest schema validation after vector-map removal.
+- Object Vector Studio V2 remains the editor/source payload for Asteroids geometry.
+- Asteroids runtime uses manifest-backed `object.asteroids.*` object IDs.
+- Shared tools no longer carry Asteroids-specific SVG fallback constants or the Asteroids platform demo module.
+- Shape IDs remain local editable shape IDs inside each object and are not used as runtime object identity.
 
 Generated source report: `docs/dev/reports/playwright_v8_coverage_report.txt`.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,37 +1,36 @@
-# PR_26133_028 Workspace V2 Validation
+# PR_26133_029 Workspace V2 Validation
 
-Task: PR_26133_028-remove-vector-map-editor-runtime-dependency
-Date: 2026-05-13
+Task: PR_26133_029-remove-asteroids-shared-tool-fallbacks
+Date: 2026-05-14
 
 ## Result
 
 PASS - `npm run test:workspace-v2`
 
 - 49 Playwright tests passed.
-- Focused Asteroids/Object Vector workspace checks passed before the full run.
-- Asteroids manifest schema validation passed after removing the Asteroids `vector-map-editor` payload.
+- Object Vector Studio V2 still loads and edits the Asteroids object payload through `tools.object-vector-studio-v2.objects`.
+- Asteroids runtime coverage in Workspace Manager V2 still renders Object Vector assets through `object.asteroids.*` object IDs.
 - No sample JSON files were changed.
 
 ## Targeted Verification
 
-- PASS - Asteroids Workspace Manager V2 context no longer includes `vector-map-editor`.
-- PASS - Object Vector Studio V2 still loads the 6 Asteroids objects from `object-vector-studio-v2.objects`.
-- PASS - Asteroids runtime renders ship, asteroid, and UFO Object Vector objects through `object.asteroids.*` IDs.
-- PASS - Asteroids manifest contains no `vector.asteroids.*` runtime/editor payload.
-- PASS - `tools/shared/asteroidsPlatformDemo.js` and `tools/shared/vectorAssetSystem.js` no longer reference Asteroids `vector-map-editor` data.
-- PASS - Save summaries no longer include `vector-map-editor vectors=5`.
-- PASS - No runtime console/page errors were reported by the targeted Playwright coverage.
+- PASS - `tools/shared/asteroidsPlatformDemo.js` was removed.
+- PASS - `tools/shared` contains no hardcoded Asteroids SVG constants or Asteroids object-vector fallback data.
+- PASS - `games/Asteroids/entities/Asteroid.js` no longer defines `BASE_VECTOR_MAP`.
+- PASS - Asteroid collision geometry is derived from the manifest Object Vector payload.
+- PASS - Object Vector runtime payload validation loads 6 Asteroids objects from `games/Asteroids/game.manifest.json`.
+- PASS - Small, medium, and large asteroid geometry profiles resolve from object IDs while shape IDs remain local shape identifiers.
+- PASS - No `vector.asteroids.*` references remain in the active Asteroids runtime/shared-tool validation targets.
 
 ## Commands
 
-- PASS - `node --check tools/shared/asteroidsPlatformDemo.js`
+- PASS - `node --check games/Asteroids/game/asteroidObjectGeometry.js`
+- PASS - `node --check games/Asteroids/entities/Asteroid.js`
+- PASS - `node --check games/Asteroids/game/AsteroidsWorld.js`
+- PASS - `node --check games/Asteroids/game/AsteroidsGameScene.js`
+- PASS - `node --check games/Asteroids/index.js`
 - PASS - `node --check tools/shared/vectorAssetSystem.js`
-- PASS - `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
 - PASS - `node --check tests/games/AsteroidsPlatformDemo.test.mjs`
-- PASS - `node --check tests/games/AsteroidsAssetReferenceAdoption.test.mjs`
-- PASS - `node --check tests/tools/VectorAssetSystem.test.mjs`
-- PASS - `node --check tests/tools/AssetUsageIntegration.test.mjs`
-- PASS - Asteroids manifest schema and runtime object ID probe with `WorkspaceManagerV2ContextService` and `ObjectVectorRuntimeAssetService`.
-- PASS - Focused node test probes for Asteroids platform demo, Asteroids asset reference adoption, VectorAssetSystem, and AssetUsageIntegration.
-- PASS - `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "header lifecycle|loads Object Vector Studio V2 runtime assets|saves empty Text to Speech|syncs Workspace Manager V2 dirty lifecycle|warns instead of injecting"`
+- PASS - focused node probes for Asteroids manifest Object Vector runtime, asteroid vector transforms, collision timing, Asteroids validation boot, and VectorAssetSystem.
+- PASS - targeted `rg` scans for removed Asteroids SVG constants, `BASE_VECTOR_MAP`, `vector.asteroids.*`, and shared Asteroids fallback usage.
 - PASS - `npm run test:workspace-v2`

games/Asteroids/entities/Asteroid.js

@@ -7,40 +7,10 @@ Asteroid.js
 import { TAU, randomRange, wrap } from '../utils/math.js';
 import { transformPoints } from '../../../src/engine/rendering/index.js';
 
-const BASE_VECTOR_MAP = [
-  { x: 10, y: 40 },
-  { x: 50, y: 20 },
-  { x: 45, y: 5 },
-  { x: 25, y: -10 },
-  { x: 50, y: -35 },
-  { x: 30, y: -45 },
-  { x: 10, y: -38 },
-  { x: -20, y: -45 },
-  { x: -43, y: -18 },
-  { x: -43, y: 20 },
-  { x: -25, y: 20 },
-  { x: -25, y: 40 },
-];
-
-function centerVectorMap(points) {
-  const xs = points.map(({ x }) => x);
-  const ys = points.map(({ y }) => y);
-  const centerX = (Math.min(...xs) + Math.max(...xs)) / 2;
-  const centerY = (Math.min(...ys) + Math.max(...ys)) / 2;
-  return points.map(({ x, y }) => ({ x: x - centerX, y: y - centerY }));
-}
-
-function maxRadius(points) {
-  return Math.max(...points.map(({ x, y }) => Math.sqrt(x * x + y * y)));
-}
-
-const CENTERED_VECTOR_MAP = centerVectorMap(BASE_VECTOR_MAP);
-const BASE_RADIUS = maxRadius(CENTERED_VECTOR_MAP);
-
 const SIZE_PROFILES = {
-  SML: { id: 1, targetRadius: 14 },
-  MED: { id: 2, targetRadius: 22 },
-  LRG: { id: 3, targetRadius: 34 },
+  SML: { id: 1 },
+  MED: { id: 2 },
+  LRG: { id: 3 },
 };
 
 const SIZE_BY_ID = {
@@ -49,19 +19,32 @@ const SIZE_BY_ID = {
   3: SIZE_PROFILES.LRG,
 };
 
+function resolveGeometryProfile(geometryProfiles, sizeId) {
+  if (geometryProfiles instanceof Map) {
+    return geometryProfiles.get(sizeId) || geometryProfiles.get(String(sizeId)) || null;
+  }
+  if (geometryProfiles && typeof geometryProfiles === 'object') {
+    return geometryProfiles[sizeId] || geometryProfiles[String(sizeId)] || null;
+  }
+  return null;
+}
+
 export default class Asteroid {
-  constructor(x, y, size = 3, rng = Math.random) {
+  constructor(x, y, size = 3, rng = Math.random, geometryProfiles = null) {
     const profile = SIZE_BY_ID[size] || SIZE_PROFILES.LRG;
+    const geometryProfile = resolveGeometryProfile(geometryProfiles, profile.id);
     this.x = x;
     this.y = y;
     this.vx = randomRange(-70, 70, rng);
     this.vy = randomRange(-70, 70, rng);
     this.angle = randomRange(0, TAU, rng);
     this.spin = randomRange(-1.4, 1.4, rng);
     this.size = profile.id;
-    this.sizeLabel = Object.entries(SIZE_PROFILES).find(([, value]) => value.id === profile.id)?.[0] || 'LRG';
-    this.scale = profile.targetRadius / BASE_RADIUS;
-    this.radius = profile.targetRadius;
+    this.sizeLabel = geometryProfile?.label || Object.entries(SIZE_PROFILES).find(([, value]) => value.id === profile.id)?.[0] || 'LRG';
+    this.objectId = geometryProfile?.objectId || '';
+    this.collisionPoints = Array.isArray(geometryProfile?.points) ? geometryProfile.points : [];
+    this.scale = 1;
+    this.radius = geometryProfile?.radius || 0;
   }
 
   update(dtSeconds, bounds) {
@@ -71,7 +54,10 @@ export default class Asteroid {
   }
 
   getPoints() {
-    return transformPoints(CENTERED_VECTOR_MAP, {
+    if (!this.collisionPoints.length) {
+      return [];
+    }
+    return transformPoints(this.collisionPoints, {
       x: this.x,
       y: this.y,
       rotation: this.angle,

games/Asteroids/game/AsteroidsGameScene.js

@@ -13,6 +13,10 @@ import ShipDebrisSystem from '../systems/ShipDebrisSystem.js';
 import AsteroidsAttractAdapter from './AsteroidsAttractAdapter.js';
 import AsteroidsHighScoreService from '../systems/AsteroidsHighScoreService.js';
 import AsteroidsInitialsEntry from '../systems/AsteroidsInitialsEntry.js';
+import {
+  ASTEROID_OBJECT_VECTOR_OBJECT_IDS,
+  createAsteroidGeometryProfilesFromObjectVectorAssets
+} from './asteroidObjectGeometry.js';
 import {
   ASTEROIDS_GAME_OVER_AUTO_EXIT_SECONDS, ASTEROIDS_GAME_OVER_RETURN_MODE
 } from "../rules/flowRules.js";
@@ -25,11 +29,6 @@ const SCORE_TWO_X = 824;
 const LIFE_SPACING = 22;
 const PAUSE_OVERLAY_COLOR = 'rgba(2, 6, 23, 0.58)';
 const INITIALS_OVERLAY_COLOR = 'rgba(1, 6, 19, 0.62)';
-const ASTEROID_OBJECT_VECTOR_OBJECT_IDS = Object.freeze({
-  1: "object.asteroids.asteroid.small",
-  2: "object.asteroids.asteroid.medium",
-  3: "object.asteroids.asteroid.large",
-});
 const UFO_OBJECT_VECTOR_OBJECT_IDS = Object.freeze({
   large: "object.asteroids.ufo.large",
   small: "object.asteroids.ufo.small",
@@ -115,6 +114,8 @@ export default class AsteroidsGameScene extends Scene {
     this.devConsoleIntegration = options.devConsoleIntegration || null;
     this.objectVectorAssets = options.objectVectorAssets || null;
     this.objectVectorRuntime = options.objectVectorRuntime || null;
+    this.asteroidGeometryProfiles = options.asteroidGeometryProfiles
+      || createAsteroidGeometryProfilesFromObjectVectorAssets(this.objectVectorAssets);
     this.objectVectorPlaybackMs = 0;
     this.objectVectorRenderCounts = {
       asteroids: 0,
@@ -126,7 +127,9 @@ export default class AsteroidsGameScene extends Scene {
       debugMode: 'prod',
       debugEnabled: Boolean(this.devConsoleIntegration),
     };
-    this.world = new AsteroidsWorld({ width: 960, height: 720 });
+    this.world = new AsteroidsWorld({ width: 960, height: 720 }, {
+      asteroidGeometryProfiles: this.asteroidGeometryProfiles
+    });
     this.highScoreService = new AsteroidsHighScoreService();
     this.highScoreRows = this.highScoreService.loadTable();
     const initialTopScore = this.highScoreService.getTopScore(this.highScoreRows);

games/Asteroids/game/AsteroidsWorld.js

@@ -136,11 +136,12 @@ function getRectOverlapDepth(x, y, radius, rect) {
 }
 
 export default class AsteroidsWorld {
-  constructor(bounds, { rng = Math.random } = {}) {
+  constructor(bounds, { rng = Math.random, asteroidGeometryProfiles = null } = {}) {
     if (!hasLoggedWorldConstruction) {
       hasLoggedWorldConstruction = true;
       logWorldBootStage('constructed', bounds);
     }
+    this.asteroidGeometryProfiles = asteroidGeometryProfiles;
     this.rng = typeof rng === 'function' ? rng : Math.random;
     this.bounds = sanitizeBounds(bounds);
     this.starfield = Array.from({ length: 70 }, () => ({
@@ -153,7 +154,7 @@ export default class AsteroidsWorld {
   }
 
   createAsteroidEntity(x, y, size = 3) {
-    return new Asteroid(x, y, size, this.rng);
+    return new Asteroid(x, y, size, this.rng, this.asteroidGeometryProfiles);
   }
 
   createUfoEntity(type = 'large', level = 1) {