Skip to content

Commit 34acc1d

Browse files
author
DavidQ
committed
Audit tool UI readiness DoD and identify missed fields or controls - PR 10.6N.
Stabilize tool UI readiness failures for accordion state, asset browser, tilemap, vector asset, and vector map loading - PR 10.6O.
1 parent 35884d6 commit 34acc1d

15 files changed

Lines changed: 1698 additions & 144 deletions

‎docs/dev/codex_commands.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
# Codex Commands
1+
# Codex Commands — BUILD_PR_LEVEL_10_6O_TOOL_UAT_FAILURE_STABILIZATION
22

33
## Model
4-
GPT-5.4
4+
GPT-5.3-codex
55

66
## Reasoning
7-
medium
7+
high
88

99
## Command
10-
```text
11-
Review docs/pr/BUILD_PR_LEVEL_10_6M_TOOL_UI_READINESS_DOD.md against the current games/sample tools. Do not implement runtime code. Create docs/dev/reports/level_10_6m_tool_ui_readiness_dod_gap_review.md listing any missed required fields, controls, and tool-specific readiness checks. Keep the PR docs-first. If an execution-backed roadmap item exists, update only the status marker. Produce the final ZIP at tmp/BUILD_PR_LEVEL_10_6M_TOOL_UI_READINESS_DOD.zip.
10+
```powershell
11+
codex --model gpt-5.3-codex --reasoning high "Execute BUILD_PR_LEVEL_10_6O_TOOL_UAT_FAILURE_STABILIZATION exactly as described in docs/pr/BUILD_PR_LEVEL_10_6O_TOOL_UAT_FAILURE_STABILIZATION.md. Fix only the listed UAT failures. Before coding, inspect the owning files for accordion state, asset-browser/import-hub approved assets, tilemap studio load/control binding, vector asset studio palette/paint/stroke binding for samples 1215/1216/1217, and vector map editor failing samples while preserving 1212/1213/1214. Add diagnostics proving expected vs actual input and UI-control readiness. Do not introduce fallback/demo data or hardcoded paths. Run npm run test:launch-smoke:games and npm run test:sample-standalone:data-flow. Write docs/dev/reports/level_10_6o_tool_uat_failure_stabilization_report.md. Package changed files into tmp/BUILD_PR_LEVEL_10_6O_TOOL_UAT_FAILURE_STABILIZATION.zip."
1212
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add tool UI readiness definition of done and Codex gap review - PR 10.6M
1+
Stabilize tool UI readiness failures for accordion state, asset browser, tilemap, vector asset, and vector map loading - PR 10.6O

‎docs/dev/reports/launch_smoke_report.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Launch Smoke Report
22

3-
Generated: 2026-04-27T19:02:18.016Z
3+
Generated: 2026-04-27T19:59:35.044Z
44

55
Filters: games=true, samples=false, tools=false, sampleRange=all
66

‎docs/dev/reports/level_10_6n_tool_ui_dod_audit_report.md‎

Lines changed: 584 additions & 0 deletions
Large diffs are not rendered by default.

‎docs/dev/reports/level_10_6n_tool_ui_dod_audit_report_template.md‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Level 10.6N Tool UI DoD Audit Report
2+
3+
## Summary
4+
- Tools audited:
5+
- Missing required inputs found:
6+
- Missing controls found:
7+
- Controls using default/demo data:
8+
- Palette contract violations:
9+
- Recommended next PR:
10+
11+
## Tool: <tool id/name>
12+
13+
### Required inputs found
14+
15+
| Input | Source | Required? | Fetched? | Shape validated? | Notes |
16+
|---|---|---:|---:|---:|---|
17+
18+
### UI controls found
19+
20+
| Control | Required data | Bound to loaded data? | Empty/default risk? | Diagnostic exists? | Notes |
21+
|---|---|---:|---:|---:|---|
22+
23+
### Missing DoD fields or controls
24+
-
25+
26+
### Contract violations
27+
-
28+
29+
### Recommended fix scope
30+
- Smallest next PR:

‎docs/dev/reports/level_10_6o_requested_uat_failures.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Level 10.6O Requested UAT Failures
2+
3+
User-reported failures to fix:
4+
5+
- All tools: accordion closes about 1 second after opening.
6+
- Asset Browser / Import Hub: 0 approved assets.
7+
- Tilemap Studio: map not loaded; tile readiness uncertain.
8+
- Vector Asset Studio: palette, paint, and stroke not loaded.
9+
- Samples 1215, 1216, 1217 load SVG Background Canvas but are missing palette.
10+
- Vector Map Editor: no data loaded.
11+
- Samples 1212, 1213, 1214 are working and must not regress.
12+
13+
This PR is a targeted stabilization PR. It must not broaden into new architecture or unrelated tool cleanup.

‎docs/dev/reports/level_10_6o_tool_uat_failure_stabilization_report.md‎

Lines changed: 111 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,111 @@
1+
# Level 10.6O Tool UAT Failure Stabilization Report
2+
3+
## Scope
4+
Executed `BUILD_PR_LEVEL_10_6O_TOOL_UAT_FAILURE_STABILIZATION` as a diagnostics-plus-stabilization PR.
5+
6+
Implemented only the listed UAT-failure fixes:
7+
- accordion state persistence
8+
- Asset Browser approved-asset source resolution
9+
- Tilemap Studio sample load/readiness binding
10+
- Vector Asset Studio sample load + palette/paint/stroke readiness binding
11+
- Vector Map Editor failing-sample load binding while preserving 1212/1213/1214 behavior
12+
13+
No fallback/demo payloads or hardcoded sample-path logic were introduced.
14+
15+
## Files Inspected Before Edits
16+
- `tools/shared/platformShell.js`
17+
- `tools/shared/toolLoadDiagnostics.js`
18+
- `tools/Asset Browser/main.js`
19+
- `tools/Tilemap Studio/main.js`
20+
- `tools/Vector Asset Studio/main.js`
21+
- `tools/Vector Map Editor/editor/VectorMapEditorApp.js`
22+
- sample payloads and SVG sources for 0901/1204/1205/1208/1209/1210/1211/1212/1213/1214/1215/1216/1217
23+
24+
## Implemented Fixes
25+
26+
### 1. All tools: accordion closes after ~1 second
27+
- Updated `tools/shared/platformShell.js` accordion handling so rerenders no longer force-reset `details.open`.
28+
- Added per-accordion state tracking keyed by panel side + title.
29+
- Added structured control-readiness diagnostics for accordion state:
30+
- `[tool-ui:control-ready]` with `controlId=accordion:*`.
31+
32+
### 2. Asset Browser / Import Hub: `0 approved assets`
33+
- Updated `tools/Asset Browser/main.js` approved-asset loading pipeline to support both:
34+
- explicit game asset catalogs (`html-js-gaming.game-asset-catalog`)
35+
- explicit manifest-declared assets (`tools["asset-browser"].assets`) from manifest-shaped JSON sources.
36+
- Added active-project-manifest fallback extraction for declared asset-browser assets.
37+
- Added approved-asset-list readiness diagnostics:
38+
- `[tool-ui:control-ready]` with `controlId=approved-asset-list` and classification.
39+
40+
### 3. Tilemap Studio: map/document controls not bound from sample
41+
- Updated `tools/Tilemap Studio/main.js` sample extraction to support `payload` and `config` wrapper shapes, including:
42+
- `tileMapDocument`, `tilemapDocument`
43+
- `tileMapDocumentPath`, `tilemapDocumentPath`
44+
- related path aliases
45+
- Prevented silent fallback-to-root preset object by requiring an explicit document/doc-path extraction result.
46+
- Added readiness diagnostics:
47+
- `map-canvas`
48+
- `tile-palette-grid`
49+
- `selected-tile`
50+
with `[tool-ui:control-ready]` and explicit classification (`success|missing|empty|defaulted`).
51+
52+
### 4. Vector Asset Studio: palette/paint/stroke readiness for sample loads (incl. 1215/1216/1217)
53+
- Updated `tools/Vector Asset Studio/main.js` extraction to support both `payload` and `config` vector preset wrappers.
54+
- Added declared-input palette stabilization path:
55+
- if explicit palette selection is unresolved after preset load, derive/select a declared palette strictly from preset-declared options and loaded document colors (no demo/fallback data injection).
56+
- Added readiness diagnostics for required controls:
57+
- `svg-canvas`
58+
- `palette-controls`
59+
- `paint-fill-control`
60+
- `stroke-control`
61+
via `[tool-ui:control-ready]`.
62+
63+
### 5. Vector Map Editor: failing samples load no data; preserve 1212/1213/1214
64+
- Updated `tools/Vector Map Editor/editor/VectorMapEditorApp.js` extraction to support `payload` + `config` wrappers (`vectorMapDocument`, aliases).
65+
- Removed permissive fallback that treated wrapper roots as documents.
66+
- Added readiness diagnostics:
67+
- `document-canvas`
68+
- `data-list`
69+
via `[tool-ui:control-ready]`.
70+
- 1212/1213/1214 remained valid in regression validation (see test results).
71+
72+
### 6. Shared diagnostics extension
73+
- Extended `tools/shared/toolLoadDiagnostics.js`:
74+
- added classification values: `empty`, `defaulted`
75+
- enabled classification normalization/override handling
76+
- added `[tool-ui:control-ready]` logging export (`logToolUiControlReady`)
77+
78+
## Diagnostics Evidence
79+
Added/extended diagnostic families now emitted by fixed paths:
80+
- `[tool-load:classification]` with support for `success | missing | wrong-path | wrong-shape | empty | defaulted`
81+
- `[tool-ui:control-ready]` for all required controls listed in BUILD 10.6O minimum set
82+
83+
## Validation
84+
Executed required commands:
85+
86+
1. `npm run test:launch-smoke:games`
87+
- Result: PASS
88+
- Summary: `PASS=12 FAIL=0 TOTAL=12`
89+
90+
2. `npm run test:sample-standalone:data-flow`
91+
- Result: PASS
92+
- Key evidence from summary:
93+
- `schemaFailures: []`
94+
- `contractFailures: []`
95+
- `roundtripPathFailures: []`
96+
- `genericFailures: []`
97+
- vector-map-editor sample checks include successful load signals for `0901`, `1204`, `1205`, `1212`, `1213`, `1214`
98+
- vector-asset-studio sample checks include successful load signals for `0901`, `1204`, `1208`, `1215`, `1216`, `1217`
99+
100+
## Changed Files (this stabilization)
101+
- `tools/shared/toolLoadDiagnostics.js`
102+
- `tools/shared/platformShell.js`
103+
- `tools/Asset Browser/main.js`
104+
- `tools/Tilemap Studio/main.js`
105+
- `tools/Vector Asset Studio/main.js`
106+
- `tools/Vector Map Editor/editor/VectorMapEditorApp.js`
107+
- `docs/dev/reports/launch_smoke_report.md` (updated by required test run)
108+
- `docs/dev/reports/level_10_6o_tool_uat_failure_stabilization_report.md`
109+
110+
## Roadmap
111+
- No execution-backed Level 10.6O status marker was found in `docs/dev/roadmaps/MASTER_ROADMAP_ENGINE.md`; no roadmap text changes were made.

‎docs/pr/BUILD_PR_LEVEL_10_6N_TOOL_UI_DOD_AUDIT.md‎

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
# BUILD_PR_LEVEL_10_6N_TOOL_UI_DOD_AUDIT
2+
3+
## Purpose
4+
Validate the Tool UI Readiness Definition of Done against all game/sample-launched tools and report any missed required inputs, fields, controls, or readiness checks.
5+
6+
## Scope
7+
Docs-first audit only.
8+
9+
Codex must inspect the current repo tool/sample/game launch flow and produce a validation report. Codex must not implement fixes in this PR.
10+
11+
## Mandatory Audit Questions
12+
13+
For every tool reachable from `games/index.html`, `samples/index.html`, or sample/game manifests, Codex must answer:
14+
15+
1. What data inputs are required?
16+
2. What data inputs are optional?
17+
3. What files are fetched?
18+
4. What files are expected but not fetched?
19+
5. What UI controls are visible?
20+
6. What controls require loaded data?
21+
7. What controls are initialized from hardcoded/default/demo values?
22+
8. What controls can show success while required data is missing?
23+
9. What diagnostics exist for request/fetch/load/classification?
24+
10. What diagnostics are missing for UI control readiness?
25+
26+
## Required Tool Coverage
27+
28+
Codex must audit at least these areas if present in repo:
29+
30+
- Sprite Editor
31+
- Palette Browser
32+
- Animation / Sprite Animation Tool
33+
- Tilemap / Map Editor
34+
- Vector Map Editor
35+
- Vector Asset Studio
36+
- Replay / Event Tool
37+
- Manifest / Data Flow Inspector
38+
- Workspace Manager / Launcher Tool
39+
- Game launch tiles
40+
- Sample launch tiles
41+
42+
If Codex finds additional tools, include them in the report.
43+
44+
## Required Report Output
45+
46+
Create:
47+
48+
`docs/dev/reports/level_10_6n_tool_ui_dod_audit_report.md`
49+
50+
Report format:
51+
52+
```md
53+
# Level 10.6N Tool UI DoD Audit Report
54+
55+
## Summary
56+
- Tools audited:
57+
- Missing required inputs found:
58+
- Missing controls found:
59+
- Controls using default/demo data:
60+
- Palette contract violations:
61+
- Recommended next PR:
62+
63+
## Tool: <tool id/name>
64+
65+
### Required inputs found
66+
| Input | Source | Required? | Fetched? | Shape validated? | Notes |
67+
68+
### UI controls found
69+
| Control | Required data | Bound to loaded data? | Empty/default risk? | Diagnostic exists? | Notes |
70+
71+
### Missing DoD fields or controls
72+
- ...
73+
74+
### Contract violations
75+
- ...
76+
77+
### Recommended fix scope
78+
- Smallest next PR:
79+
```
80+
81+
## Acceptance Criteria
82+
83+
- Report exists at `docs/dev/reports/level_10_6n_tool_ui_dod_audit_report.md`
84+
- Report lists every discovered tool
85+
- Report identifies missed fields or controls
86+
- Report explicitly says whether sprite-editor requires and binds palette data to:
87+
- palette grid
88+
- Color 1
89+
- Color 2
90+
- active drawing color
91+
- sprite canvas
92+
- Report explicitly says whether palette-browser still depends on any `*.palette-browser.json`
93+
- No implementation code is changed
94+
- No roadmap text is rewritten
95+
- If roadmap is touched, only status marker progression is allowed

0 commit comments

Comments
 (0)