Skip to content

Commit 347ee37

Browse files
author
DavidQ
committed
BUILD_PR_TARGETED_REPO_CLEANUP_PASS_2
Adds legacy import guard and report.
1 parent 8b0dbf8 commit 347ee37

7 files changed

Lines changed: 62 additions & 58 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,4 @@ MODEL: GPT-5.3-codex
22
REASONING: high
33

44
COMMAND:
5-
Execute BUILD_PR_TARGETED_REPO_CLEANUP_PASS_1.
6-
7-
- Create `docs/dev/reports/cleanup_target_enforcement_map.md`, `docs/dev/reports/cleanup_execution_guard.md`, `docs/dev/reports/cleanup_target_normalization_report.md`, `docs/dev/reports/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_1_report.md`, and `docs/dev/reports/validation_checklist.txt` exactly as specified in `docs/pr/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_1.md`.
8-
- Use only the existing cleanup inventory, cleanup matrix, prior cleanup BUILD report, templates inventory, templates policy, templates validation guard, templates BUILD report, repo cleanup targets list, and master roadmap as source evidence.
9-
- Do not modify `templates/`, runtime code, test logic, repo structure, or protected start_of_day directories.
10-
- Do not introduce new cleanup targets.
11-
- If roadmap alignment is attempted, it must be bracket-only and only if the exact existing text already supports it.
12-
- Package output to:
13-
<project folder>/tmp/BUILD_PR_TARGETED_REPO_CLEANUP_PASS_1.zip
5+
Scan repo for legacy engine import paths and generate guard report.

docs/dev/COMMIT_COMMENT.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,3 @@
1-
BUILD_PR_TARGETED_REPO_CLEANUP_PASS_1 - targeted cleanup enforcement/normalization docs lane
1+
BUILD_PR_TARGETED_REPO_CLEANUP_PASS_2
2+
3+
Adds legacy import guard and report.

docs/dev/NEXT_COMMAND.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
After Codex completes this BUILD and the output files validate, the next testable lane should be a single-target cleanup BUILD such as a legacy-import-guard lane or an archived-notes-policy lane, chosen strictly from the approved cleanup target set.
1+
Proceed to APPLY_PR_TARGETED_REPO_CLEANUP_PASS_2 if validation passes.
Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,2 @@
1-
Bundle type: execution-ready BUILD docs only
2-
PR purpose: targeted cleanup enforcement/normalization pass
3-
Scope:
4-
- create cleanup target enforcement map
5-
- create cleanup execution guard
6-
- create cleanup target normalization report
7-
- create BUILD report
8-
- create validation checklist
9-
Constraints:
10-
- non-destructive
11-
- templates untouched
12-
- no runtime/test changes
13-
- no start_of_day changes
14-
- no new cleanup targets
1+
- Added legacy import guard report
2+
- No structural repo changes
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# Legacy Engine Import Path Guard Report
2+
3+
Generated: 2026-04-12 15:57:09 -04:00
4+
Scope: tools/src/games/samples/tests (excluding node_modules).
5+
6+
Result
7+
- Guard status: PASS
8+
- Total legacy signature matches: 0
9+
10+
Pattern Findings
11+
- Pattern: '/engine/ | Matches: 0
12+
- Pattern: "/engine/ | Matches: 0
13+
- Pattern: '../engine/ | Matches: 0
14+
- Pattern: "../engine/ | Matches: 0
15+
- Pattern: './engine/ | Matches: 0
16+
- Pattern: "./engine/ | Matches: 0
17+
- Pattern: require('/engine/ | Matches: 0
18+
- Pattern: require("/engine/ | Matches: 0
19+
- Pattern: require('../engine/ | Matches: 0
20+
- Pattern: require("../engine/ | Matches: 0
21+
- Pattern: import('/engine/ | Matches: 0
22+
- Pattern: import("/engine/ | Matches: 0
23+
- Pattern: import('../engine/ | Matches: 0
24+
- Pattern: import("../engine/ | Matches: 0
25+
26+
Command Pattern
27+
- rg -n -F --glob '!**/node_modules/**' <pattern> tools src games samples tests
28+
29+
Notes
30+
- This guard targets legacy signatures (/engine/, ../engine/, ./engine/) and excludes valid src/engine imports.
31+
- If future matches appear, block cleanup/apply lanes until paths are normalized to src/engine.
Lines changed: 4 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,4 @@
1-
BUILD_PR_TARGETED_REPO_CLEANUP_PASS_1
2-
Validation Checklist
3-
Generated: 2026-04-12
4-
5-
[PASS] no deletion/move/rename executed
6-
Evidence: `git diff --name-status` + structural guard => `STRUCTURAL_CHECK: PASS` (no D/R/C entries)
7-
8-
[PASS] `templates/` untouched
9-
Evidence: `git diff --name-status -- templates` => no entries (`TEMPLATES_TOUCH_CHECK: PASS`)
10-
11-
[PASS] no runtime code changes
12-
Evidence: `git diff --name-only -- tools src games samples tests` => no entries
13-
14-
[PASS] no test logic changes
15-
Evidence: `git diff --name-only -- tools src games samples tests` => no entries
16-
17-
[PASS] enforcement map created
18-
Evidence: `docs/dev/reports/cleanup_target_enforcement_map.md`
19-
20-
[PASS] cleanup execution guard created
21-
Evidence: `docs/dev/reports/cleanup_execution_guard.md`
22-
23-
[PASS] normalization report created
24-
Evidence: `docs/dev/reports/cleanup_target_normalization_report.md`
25-
26-
[PASS] no new cleanup targets introduced
27-
Evidence: enforcement map contains only approved six targets from PR spec
28-
29-
[PASS] roadmap unchanged or bracket-only if changed
30-
Evidence: `git diff --unified=0 -- docs/dev/roadmaps/MASTER_ROADMAP_HIGH_LEVEL.md` => no diff in this lane
31-
32-
[PASS] protected start_of_day directories untouched
33-
Evidence: `git status --short -- docs/dev/start_of_day/chatGPT docs/dev/start_of_day/codex` => no entries
1+
[PASS] no deletion/move/rename
2+
[PASS] templates untouched
3+
[PASS] no runtime changes
4+
[PASS] guard report created
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# BUILD_PR_TARGETED_REPO_CLEANUP_PASS_2
2+
3+
## Purpose
4+
Introduce enforceable guard for legacy engine import paths.
5+
6+
## Scope
7+
- Detect and prevent usage of:
8+
- /engine/
9+
- ../engine/
10+
- ./engine/
11+
12+
## Non-Goals
13+
- No code rewrites
14+
- No deletions
15+
- No moves
16+
- No templates changes
17+
18+
## Acceptance Criteria
19+
- Guard report created
20+
- Zero matches confirmed OR matches listed explicitly

0 commit comments

Comments
 (0)