Skip to content

Commit 273a915

Browse files
author
DavidQ
committed
Balance right column layout so Import/Export fills remaining height above validation viewer - PR_26124_046-right-column-height-balance
1 parent 9ee34b8 commit 273a915

9 files changed

Lines changed: 380 additions & 251 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,21 @@
1-
# PR_26124_045-palette-manager-hidden-header-wide-layout
1+
# Codex Commands - PR_26124_046-right-column-height-balance
22

3-
```bash
4-
npx @openai/codex run --model gpt-5.5 --reasoning high "Run full workflow for PR_26124_045-palette-manager-hidden-header-wide-layout. Follow PROJECT_INSTRUCTIONS.md exactly. Update only palette-manager-v2 layout behavior when the shared platform header/details area is hidden."
5-
```
3+
## Workflow
4+
- Read `docs/dev/PROJECT_INSTRUCTIONS.md`.
5+
- Read `docs/pr/PR_26124_046-right-column-height-balance/PLAN_PR.md`.
6+
- Created `docs/pr/PR_26124_046-right-column-height-balance/BUILD_PR.md`.
7+
- Updated `tools/palette-manager-v2/paletteManagerV2.css`.
8+
- Created `docs/pr/PR_26124_046-right-column-height-balance/APPLY_PR.md`.
69

710
## Validation Commands
11+
- Targeted browser layout check using Playwright from Node against `tools/palette-manager-v2/index.html`.
12+
- `git diff --check`
13+
- `git diff --name-only -- '*.js'`
14+
- `npm run test:workspace-v2`
815

9-
```bash
10-
node --check src/engine/theme/accordionV2/accordionV2.js
11-
node --check tools/palette-manager-v2/modules/PaletteManagerApp.js
12-
npm run test:workspace-v2
13-
```
14-
15-
## Manual Validation
16-
17-
- Open `tools/palette-manager-v2/index.html`.
18-
- Confirm normal layout is unchanged.
19-
- Click `Hide Header and Details`.
20-
- Confirm left/right panels anchor to the viewport sides.
21-
- Confirm center fills the space between them and uses available height.
22-
- Confirm accordionV2 behavior remains unchanged.
16+
## Validation Outcome
17+
- Targeted browser layout check: PASS.
18+
- `git diff --check`: PASS with Git line-ending warning for `tools/palette-manager-v2/paletteManagerV2.css`.
19+
- JavaScript syntax checks: no JavaScript files changed.
20+
- `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.
21+
- Full samples smoke test: skipped by instruction.

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Expand Palette Manager layout when platform header is hidden - PR_26124_045-palette-manager-hidden-header-wide-layout
1+
Balance Palette Manager right column section heights - PR_26124_046-right-column-height-balance
Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# PR_26124_046-right-column-height-balance Report
2+
3+
## Summary
4+
Updated Palette Manager V2 right-column CSS only. The right panel is now a flex column where Import/Export fills remaining height and Validation/Error Viewer stays capped and scrollable.
5+
6+
## Changed Runtime Files
7+
- `tools/palette-manager-v2/paletteManagerV2.css`
8+
9+
## Scope Confirmation
10+
- No workspace/toolState/session logic changed.
11+
- No sample JSON changed.
12+
- No `tools/shared` files changed.
13+
- No dependencies added.
14+
- No left or center panel layout rules changed.
15+
16+
## Validation Results
17+
- Targeted browser layout check: PASS.
18+
- Right panel display: `flex`.
19+
- Right panel flex direction: `column`.
20+
- Import/Export flex: `1 1 auto`.
21+
- Validation/Error flex: `0 0 auto`.
22+
- Validation/Error max-height: computed from `clamp(120px, 22vh, 260px)`.
23+
- Right-column occupied child height matched available content height.
24+
- `git diff --check`: PASS.
25+
- Warning observed: Git reports `tools/palette-manager-v2/paletteManagerV2.css` LF will be replaced by CRLF when Git next touches it.
26+
- JavaScript syntax checks: no JavaScript files changed.
27+
- `npm run test:workspace-v2`: FAIL.
28+
- Failure reason: `npm` reports missing script `test:workspace-v2`.
29+
- Full samples smoke test: skipped by instruction.
30+
31+
## Manual Validation
32+
1. Open `tools/palette-manager-v2/index.html`.
33+
2. Inspect the right column.
34+
3. Confirm Import/Export fills remaining height after Validation/Error Viewer.
35+
4. Confirm Validation/Error Viewer height is capped and scrollable.
36+
5. Confirm Import/Export scrolls internally when needed.
37+
6. Confirm left and center panels are unchanged.

docs/dev/reports/codex_changed_files.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
M docs/dev/commit_comment.txt
33
M docs/dev/reports/codex_review.diff
44
M tools/palette-manager-v2/paletteManagerV2.css
5-
?? docs/dev/reports/PR_26124_045_report.md
6-
?? docs/pr/PR_26124_045-palette-manager-hidden-header-wide-layout/
5+
?? docs/dev/reports/PR_26124_046_report.md
6+
?? docs/pr/PR_26124_046-right-column-height-balance/
77

8-
docs/dev/codex_commands.md | 13 +-
8+
docs/dev/codex_commands.md | 35 ++-
99
docs/dev/commit_comment.txt | 2 +-
10-
docs/dev/reports/codex_review.diff | 625 ++++++++------------------
11-
tools/palette-manager-v2/paletteManagerV2.css | 57 +++
12-
4 files changed, 255 insertions(+), 442 deletions(-)
10+
docs/dev/reports/codex_review.diff | 414 ++++++++++++--------------
11+
tools/palette-manager-v2/paletteManagerV2.css | 35 ++-
12+
4 files changed, 241 insertions(+), 245 deletions(-)

0 commit comments

Comments
 (0)