Preserve Sample Palette scroll position after individual pin actions - PR_26124_064-palette-manager-source-pin-scroll-preserve

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,28 +1,28 @@
-# Codex Commands - PR_26124_063-palette-manager-tag-sort-untagged-last
+# Codex Commands - PR_26124_064-palette-manager-source-pin-scroll-preserve
 
 ## Workflow
 - Read `docs/dev/PROJECT_INSTRUCTIONS.md`.
 - Used `.codex/skills/repo-build/SKILL.md`.
 - Checked git status before implementation.
-- Created `docs/pr/PR_26124_063-palette-manager-tag-sort-untagged-last/PLAN_PR.md`.
-- Created `docs/pr/PR_26124_063-palette-manager-tag-sort-untagged-last/BUILD_PR.md`.
+- Created `docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/PLAN_PR.md`.
+- Created `docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/BUILD_PR.md`.
 - Read the active BUILD doc before changing runtime files.
-- Updated only `tools/palette-manager-v2/modules/PaletteManagerApp.js`.
-- Created `docs/pr/PR_26124_063-palette-manager-tag-sort-untagged-last/APPLY_PR.md`.
+- Updated only `tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`.
+- Created `docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/APPLY_PR.md`.
 
 ## Validation Commands
-- `node --check tools/palette-manager-v2/modules/PaletteManagerApp.js`
-- Targeted served-browser Palette Manager V2 Tag ascending/descending sort validation using Playwright from Node.
+- `node --check tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`
+- Targeted served-browser Palette Manager V2 individual source pin/unpin scroll preservation validation using Playwright from Node.
 - `git diff --check`
 - `npm run test:workspace-v2`
 - `git diff --cached --check`
 - `npm run codex:review-artifacts`
-- Python `zipfile` packaging for `tmp/PR_26124_063-palette-manager-tag-sort-untagged-last_delta.zip`
+- Python `zipfile` packaging for `tmp/PR_26124_064-palette-manager-source-pin-scroll-preserve_delta.zip`
 
 ## Validation Outcome
 - JavaScript syntax check: PASS.
-- Targeted served-browser Palette Manager V2 Tag sort validation: PASS.
-- `git diff --check`: PASS.
+- Targeted served-browser Palette Manager V2 individual source pin/unpin scroll preservation validation: PASS.
+- `git diff --check`: PASS with Git LF-to-CRLF warning for generated review artifact.
 - `git diff --cached --check`: PASS.
 - `npm run test:workspace-v2`: FAILED because the script is missing from `package.json`.
 - Review artifacts: generated.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Keep untagged swatches last in Palette Manager Tag sort - PR_26124_063-palette-manager-tag-sort-untagged-last
+Preserve Palette Manager source scroll after pin render - PR_26124_064-palette-manager-source-pin-scroll-preserve

docs/dev/reports/PR_26124_064_report.md

@@ -0,0 +1,24 @@
+# PR_26124_064-palette-manager-source-pin-scroll-preserve Report
+
+## Summary
+Implemented a Palette Manager V2-only source grid scroll preservation timing fix.
+
+## Changes
+- `SourcePaletteBrowserControl.preserveSourceScrollDuring` now captures the source grid scroll position before the pin/unpin action.
+- The source grid scroll position is restored with `requestAnimationFrame` after the app render replaces the source grid contents.
+- Pin/unpin behavior itself is unchanged.
+- Pin All still uses the same helper and may benefit naturally from the post-render restore path.
+
+## Validation
+- `node --check tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js`: PASS.
+- Targeted served-browser Palette Manager V2 individual source pin/unpin scroll preservation validation: PASS.
+- `git diff --check`: PASS with Git LF-to-CRLF warning for generated review artifact.
+- `npm run test:workspace-v2`: FAIL, `package.json` does not define `test:workspace-v2`.
+- Full samples smoke test: skipped because this PR is limited to Palette Manager V2 source grid scroll timing and sample JSON remains out of scope.
+
+## Manual Test Notes
+1. Open Palette Manager V2.
+2. Scroll the Sample/Source Palette grid down.
+3. Click an individual red pin and confirm the source grid remains at the same scroll position after render.
+4. Click an individual green pin/unpin and confirm the source grid remains at the same scroll position after render.
+5. Confirm Clear checkbox behavior, tag sorting, pin button size, and Validation/Error Viewer behavior are unchanged.

docs/dev/reports/codex_changed_files.txt

@@ -1,19 +1,15 @@
 # git status --short
 M  docs/dev/codex_commands.md
 M  docs/dev/commit_comment.txt
-A  docs/dev/reports/PR_26124_061_report.md
-MM docs/dev/reports/codex_changed_files.txt
-MM docs/dev/reports/codex_review.diff
-A  docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/APPLY_PR.md
-A  docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/BUILD_PR.md
-A  docs/pr/PR_26124_061-palette-manager-tag-clear-undo-location-and-pin-scroll/PLAN_PR.md
+A  docs/dev/reports/PR_26124_064_report.md
+ M docs/dev/reports/codex_changed_files.txt
+ M docs/dev/reports/codex_review.diff
+A  docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/APPLY_PR.md
+A  docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/BUILD_PR.md
+A  docs/pr/PR_26124_064-palette-manager-source-pin-scroll-preserve/PLAN_PR.md
 M  tools/palette-manager-v2/controls/SourcePaletteBrowserControl.js
-M  tools/palette-manager-v2/controls/UserPaletteControl.js
-M  tools/palette-manager-v2/index.html
-M  tools/palette-manager-v2/modules/PaletteManagerApp.js
-M  tools/palette-manager-v2/paletteManagerV2.css
 
 # git diff --stat
-docs/dev/reports/codex_changed_files.txt |    8 +-
- docs/dev/reports/codex_review.diff       | 1231 +++++++++++++++++++++++++++++-
- 2 files changed, 1232 insertions(+), 7 deletions(-)
+docs/dev/reports/codex_changed_files.txt |   18 +-
+ docs/dev/reports/codex_review.diff       | 1738 +++---------------------------
+ 2 files changed, 129 insertions(+), 1627 deletions(-)