Make middle joint rounding fully independent per Shape Geometry point - PR_26133_079-independent-middle-joint-rounding

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
 # Playwright V8 Coverage Report
 
-PR: PR_26133_078-point-rounding-checkbox-correction
+PR: PR_26133_079-independent-middle-joint-rounding
 
 Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the latest npm run test:workspace-v2 run.
 
@@ -21,7 +21,7 @@ Source: docs/dev/reports/playwright_v8_coverage_report.txt generated by the late
 
 ## Changed Runtime JS Files Covered
 
-- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6968/6968; executed functions 717/751
+- (95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 6964/6964; executed functions 711/746
 
 ## Changed JS Files Considered
 

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,23 +1,22 @@
 # Playwright Workspace V2 Results
 
-PR: PR_26133_078-point-rounding-checkbox-correction
+PR: PR_26133_079-independent-middle-joint-rounding
 
 ## Validation
 
 - PASS: npm run test:workspace-v2
 - Result: 54 passed
-- Runtime: 5.2m
+- Runtime: 5.8m
 - Browser project: playwright
 - Workers: 1
 
 ## Targeted Checks Covered
 
-- Shape Geometry point rows now render exactly one checkbox per row.
-- The remaining checkbox is the Round control; unchecked rows render square and checked rows render round.
-- The old second point-selection checkbox was removed from polygon/polyline/triangle point rows.
-- Add/Delete point row targeting now uses row selection state instead of an extra checkbox.
-- No global Start/Joints/End or Joints point-style controls remain.
-- Independent per-point rounding coverage remains in place for open and closed multi-point geometry.
+- Shape Geometry point rows still render exactly one Round checkbox per row.
+- Checking one middle polyline point now renders only that point's round marker.
+- Other middle joints remain square/miter and are not globally rounded.
+- Start and end point rounding behavior remains independent.
+- No global Start/Joints/End or Joints point-style controls are used for point rounding.
 
 ## Console/Runtime Errors
 

tests/playwright/tools/WorkspaceManagerV2.spec.mjs

@@ -3792,19 +3792,33 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await clickObjectVectorLogicalPoint(page, 10, -40);
       await clickObjectVectorLogicalPoint(page, 20, -20);
       await clickObjectVectorLogicalPoint(page, 40, -40);
+      await clickObjectVectorLogicalPoint(page, 55, -20);
       await page.keyboard.press("Enter");
       await expect(page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-shape-point-style-field]")).toHaveCount(0);
-      await expect(page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true']")).toHaveCount(3);
-      await expect.poll(() => page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true']").evaluateAll((checkboxes) => checkboxes.map((checkbox) => checkbox.checked))).toEqual([false, false, false]);
+      await expect(page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true']")).toHaveCount(4);
+      await expect.poll(() => page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true']").evaluateAll((checkboxes) => checkboxes.map((checkbox) => checkbox.checked))).toEqual([false, false, false, false]);
       await page.locator("#objectVectorStudioV2ShapeGeometryDetails [data-polygon-point-round='true'][data-polygon-point-index='1']").check();
       await expect(page.locator("#statusLog")).toHaveValue(/OK Updated point 2 rounding to round for shape row \d+\./);
       const polylineIndex = await page.evaluate(() => window.__objectVectorStudioV2App.selectedShapeIndex);
-      const polylineJoinStyle = await page.locator(`#objectVectorStudioV2RenderSurface [data-shape-index="${polylineIndex}"]`).evaluate((shape) => ({
-        jointStyle: shape.dataset.pointStyle || "",
-        pointRounding: window.__objectVectorStudioV2App.selectedShape().style.pointRounding,
-        strokeLinejoin: shape.getAttribute("stroke-linejoin")
-      }));
-      expect(polylineJoinStyle).toEqual({ jointStyle: "round", pointRounding: [false, true, false], strokeLinejoin: "round" });
+      const polylineJoinStyle = await page.locator(`#objectVectorStudioV2RenderSurface [data-shape-index="${polylineIndex}"]`).evaluate((shape) => {
+        const markers = Array.from(document.querySelectorAll("#objectVectorStudioV2RenderSurface [data-point-style-caps='polyline'] [data-point-style-cap]")).map((marker) => ({
+          id: marker.dataset.pointStyleCap,
+          pointStyle: marker.dataset.pointStyle,
+          tag: marker.tagName.toLowerCase()
+        }));
+        return {
+          jointStyle: shape.dataset.pointStyle || "",
+          markers,
+          pointRounding: window.__objectVectorStudioV2App.selectedShape().style.pointRounding,
+          strokeLinejoin: shape.getAttribute("stroke-linejoin")
+        };
+      });
+      expect(polylineJoinStyle).toEqual({
+        jointStyle: "square",
+        markers: [{ id: "point-1", pointStyle: "round", tag: "circle" }],
+        pointRounding: [false, true, false, false],
+        strokeLinejoin: "miter"
+      });
 
       await page.locator('[data-shape-tool="text"]').click();
       await clickObjectVectorLogicalPoint(page, 70, 60);

tools/object-vector-studio-v2/js/ToolStarterApp.js

@@ -869,11 +869,11 @@ export class ToolStarterApp {
   shapeUnifiedPointStyle(shape) {
     const pointStyles = this.shapePointStyleValues(shape);
     if (pointStyles.length) {
-      const joinIndexes = this.shapeJoinPointIndexes(shape, pointStyles.length);
-      if (!joinIndexes.length) {
-        return this.pointStyleValue(shape?.style?.pointStyle ?? shape?.style?.strokeLinecap);
+      const geometryTool = shapeGeometryTool(shape);
+      if (geometryTool === "polygon" || geometryTool === "polyline") {
+        return "square";
       }
-      return joinIndexes.every((index) => pointStyles[index] === "round") ? "round" : "square";
+      return this.pointStyleValue(shape?.style?.pointStyle ?? shape?.style?.strokeLinecap);
     }
     return this.pointStyleValue(shape?.style?.pointStyle ?? shape?.style?.strokeLinecap);
   }
@@ -3170,13 +3170,10 @@ export class ToolStarterApp {
     }
     const points = this.shapeGeometryPoints(shape);
     const styles = this.shapePointStyleValues(shape);
-    const joinIndexes = this.shapeJoinPointIndexes(shape, points.length);
-    const allJoinsRound = joinIndexes.length && joinIndexes.every((index) => styles[index] === "round");
     return points
       .map((point, index) => ({ index, point, pointStyle: styles[index] }))
       .filter(({ index, pointStyle }) => pointStyle === "round"
-        && !(geometryTool === "polyline" && (index === 0 || index === points.length - 1))
-        && !(allJoinsRound && joinIndexes.includes(index)))
+        && !(geometryTool === "polyline" && (index === 0 || index === points.length - 1)))
       .map(({ index, point, pointStyle }) => ({
         markerId: `point-${index}`,
         point,
@@ -6243,8 +6240,7 @@ export class ToolStarterApp {
     delete shape.style.strokeLinecap;
     shape.style.startPointStyle = normalized[0] ? "round" : "square";
     shape.style.endPointStyle = normalized.at(-1) ? "round" : "square";
-    const joinIndexes = this.shapeJoinPointIndexes(shape, normalized.length);
-    shape.style.pointStyle = joinIndexes.length && joinIndexes.every((index) => normalized[index]) ? "round" : "square";
+    shape.style.pointStyle = "square";
   }
 
   rebuildPolygonPointList(points, pointRounding = null) {