Clean Object Transform display runtime tag validation and hub spacing - PR_26133_041-object-transform-summary-and-runtime-validation-cleanup

Author: DavidQ

docs/dev/reports/playwright_v8_coverage_report.md

@@ -1,6 +1,6 @@
-# PR_26133_040 Playwright V8 Coverage Report
+# PR_26133_041 Playwright V8 Coverage Report
 
-Task: PR_26133_040-object-transform-one-line-control-layout
+Task: PR_26133_041-object-transform-summary-and-runtime-validation-cleanup
 Date: 2026-05-15
 
 ## Result
@@ -26,15 +26,20 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 ## Changed Runtime JS Coverage
 
 ```text
-(94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 4709/4709; executed functions 487/516
+(94%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 4733/4733; executed functions 488/517
+(82%) games/Asteroids/game/asteroidsObjectVectorRoles.js - executed lines 176/176; executed functions 14/17
 ```
 
 ## Changed Test Coverage Note
 
 ```text
+(0%) tests/games/AsteroidsAssetReferenceAdoption.test.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/games/AsteroidsPlatformDemo.test.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/WorkspaceManagerV2.spec.mjs - changed JS file not collected as browser runtime coverage
 ```
 
+CSS changes in `tools/object-vector-studio-v2/styles/toolStarter.css` and `src/engine/ui/hubCommon.css` are verified through Playwright DOM/CSS assertions rather than V8 JavaScript coverage.
+
 ## Guardrail
 
 ```text
@@ -43,4 +48,4 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
 
 ## PR-Specific Note
 
-The Workspace V2 run exercised Object Vector Studio V2 one-line Move, Origin, Rotate, and Scale transform controls, transform summary rendering, preserved transform actions, and Object Transform no-console-error paths. Coverage remains advisory only.
+The Workspace V2 run exercised Object Vector Studio V2 Scale input styling, singular transform summary formatting, Rotate normalization, Object Geometry Delete Point(s) labeling, Asteroids runtime binding validation without object tag checks, and hub CSS spacing assertions. Coverage remains advisory only.

docs/dev/reports/playwright_workspace_v2_results.md

@@ -1,6 +1,6 @@
-# PR_26133_040 Workspace V2 Playwright Results
+# PR_26133_041 Workspace V2 Playwright Results
 
-Task: PR_26133_040-object-transform-one-line-control-layout
+Task: PR_26133_041-object-transform-summary-and-runtime-validation-cleanup
 Date: 2026-05-15
 
 ## Result
@@ -14,13 +14,14 @@ PASS - `npm run test:workspace-v2` completed successfully.
 
 ## PR-Specific Coverage
 
-- Verified Object Transform Move controls render on one line as `Move X [input] Y [input] [Move]`.
-- Verified Object Transform Origin controls render on one line as `Origin X [input] Y [input] [Apply]`.
-- Verified Object Transform Rotate controls render on one line as `Rotate [input] [Rotate]`.
-- Verified existing Scale controls remain one line as `Scale [--] [-] [scale input] [+] [++] [Resize]`.
-- Verified Move, Origin Apply, and Rotate buttons continue to update the selected shape transform.
-- Verified transform summary is horizontally centered and no longer starts with `Transform`.
+- Verified Object Transform Scale input renders with spinner-removal CSS (`appearance: textfield` and WebKit spin-button removal rule).
+- Verified transform summary renders singular same-axis scale text such as `x 0, y 0, rot 0, scale 1`.
+- Verified Rotate input constrains to `min=0` and `max=360`, normalizes out-of-range input before applying, and writes the normalized value back to the textbox.
+- Verified Object Geometry polygon action label renders `Delete Point(s)`.
+- Verified Asteroids runtime binding validation succeeds when object `tags` are removed from the runtime payload, keeping tags as Object Vector Studio V2 editor metadata rather than runtime validation data.
+- Verified hub page tool section margin resolves to `12px`.
+- Targeted Node validation also passed for `AsteroidsAssetReferenceAdoption` and `AsteroidsPlatformDemo`.
 
 ## Manual Verification Equivalent
 
-Targeted Object Vector Studio V2 browser automation covered the requested transform row layouts, preserved transform actions, centered summary text, retained Scale row layout, and no-console-error checks.
+Targeted Object Vector Studio V2 browser automation covered the requested Scale input styling, transform summary formatting, Rotate normalization, Delete Point(s) label, Asteroids runtime tag-validation cleanup, hub spacing contract, and no-console-error checks.

games/Asteroids/game/asteroidsObjectVectorRoles.js

@@ -1,30 +1,24 @@
 export const ASTEROIDS_RUNTIME_OBJECT_ROLES = Object.freeze({
   ship: Object.freeze({
     label: 'Ship',
-    tags: Object.freeze(['player', 'ship']),
   }),
   asteroidLarge: Object.freeze({
     label: 'Large Asteroid',
     size: 3,
-    tags: Object.freeze(['asteroid', 'large']),
   }),
   asteroidMedium: Object.freeze({
     label: 'Medium Asteroid',
     size: 2,
-    tags: Object.freeze(['asteroid', 'medium']),
   }),
   asteroidSmall: Object.freeze({
     label: 'Small Asteroid',
     size: 1,
-    tags: Object.freeze(['asteroid', 'small']),
   }),
   ufoLarge: Object.freeze({
     label: 'Large UFO',
-    tags: Object.freeze(['ufo', 'large']),
   }),
   ufoSmall: Object.freeze({
     label: 'Small UFO',
-    tags: Object.freeze(['ufo', 'small']),
   }),
 });
 
@@ -50,36 +44,21 @@ function normalizeString(value) {
   return String(value || '').trim();
 }
 
-function normalizeTag(value) {
+function normalizeSearchText(value) {
   return normalizeString(value).toLowerCase();
 }
 
-function normalizeTags(value) {
-  return asArray(value).map(normalizeTag).filter(Boolean);
-}
-
-function objectTagSet(object) {
-  return new Set(normalizeTags(object?.tags));
-}
-
-function hasTags(object, tags) {
-  const tagSet = objectTagSet(object);
-  return normalizeTags(tags).every((tag) => tagSet.has(tag));
-}
-
 function oldObjectSignal(object) {
   const text = [
     object?.id,
     object?.name,
-    ...asArray(object?.tags),
-  ].map(normalizeTag).join(' ');
+  ].map(normalizeSearchText).join(' ');
   return /(^|[.\s_-])(old|legacy|deprecated|archive|archived|renamed|stale)($|[.\s_-])/.test(text);
 }
 
 function candidateLabel(candidate) {
-  const tags = normalizeTags(candidate.object?.tags).join(',');
   const oldLabel = candidate.oldSignal ? ' old-signal' : '';
-  return `${candidate.object?.id || 'unknown'} tags=[${tags}] index=${candidate.index}${oldLabel}`;
+  return `${candidate.object?.id || 'unknown'} name="${candidate.object?.name || 'unknown'}" index=${candidate.index}${oldLabel}`;
 }
 
 function logResolution(logger, level, message, details = {}) {
@@ -101,15 +80,13 @@ export function runtimeObjectRoleOptions(roleId, runtimeBindings = {}) {
       objectId: '',
       requireManifestBinding: true,
       runtimeRole: roleId,
-      tags: [],
     };
   }
   const bindings = asRecord(runtimeBindings);
   return {
     objectId: normalizeString(bindings[roleId]),
     requireManifestBinding: true,
     runtimeRole: roleId,
-    tags: [...role.tags],
   };
 }
 
@@ -134,7 +111,7 @@ export function resolveAsteroidsObjectVectorRole(objects, roleId, {
       object,
       oldSignal: oldObjectSignal(object),
     }))
-    .filter((candidate) => candidate.object && hasTags(candidate.object, role.tags));
+    .filter((candidate) => candidate.object);
 
   if (!explicitObjectId) {
     logResolution(
@@ -144,7 +121,6 @@ export function resolveAsteroidsObjectVectorRole(objects, roleId, {
       {
         candidates: candidates.map(candidateLabel),
         objectCount: objectList.length,
-        tags: [...role.tags],
       }
     );
     return null;
@@ -159,7 +135,6 @@ export function resolveAsteroidsObjectVectorRole(objects, roleId, {
         candidates: candidates.map(candidateLabel),
         explicitObjectId,
         objectCount: objectList.length,
-        tags: [...role.tags],
       }
     );
     return null;
@@ -173,53 +148,11 @@ export function resolveAsteroidsObjectVectorRole(objects, roleId, {
       {
         candidates: candidates.map(candidateLabel),
         explicitObjectId,
-        tags: normalizeTags(explicitObject.tags),
-      }
-    );
-    return null;
-  }
-
-  if (!hasTags(explicitObject, role.tags)) {
-    logResolution(
-      logger,
-      'FAIL',
-      `Asteroids Object Vector runtime role ${roleId} manifest binding ${explicitObjectId} is missing required tags [${role.tags.join(', ')}].`,
-      {
-        candidates: candidates.map(candidateLabel),
-        explicitObjectId,
-        objectTags: normalizeTags(explicitObject.tags),
-        requiredTags: [...role.tags],
-      }
-    );
-    return null;
-  }
-
-  if (!candidates.some((candidate) => candidate.object.id === explicitObjectId)) {
-    logResolution(
-      logger,
-      'FAIL',
-      `Asteroids Object Vector runtime role ${roleId} manifest binding ${explicitObjectId} was not found in tag candidates [${role.tags.join(', ')}].`,
-      {
-        candidates: candidates.map(candidateLabel),
-        explicitObjectId,
-        requiredTags: [...role.tags],
       }
     );
     return null;
   }
 
-  if (candidates.length > 1) {
-    logResolution(
-      logger,
-      'WARN',
-      `Asteroids Object Vector runtime role ${roleId} matched multiple objects by tags [${role.tags.join(', ')}]; using explicit manifest binding ${explicitObjectId}.`,
-      {
-        candidates: candidates.map(candidateLabel),
-        selectedObjectId: explicitObjectId,
-      }
-    );
-  }
-
   return explicitObject;
 }
 

src/engine/ui/hubCommon.css

@@ -443,7 +443,7 @@ body.hub-page-tools {
 }
 
 .hub-page-tools section {
-  margin-top: 32px;
+  margin-top: 12px;
 }
 
 .hub-page-tools section:first-of-type {

tests/games/AsteroidsAssetReferenceAdoption.test.mjs

@@ -63,18 +63,14 @@ export async function run() {
   const bindingValidation = validateAsteroidsRuntimeObjectBindings(payload.objects, runtimeBindings);
   assert.equal(bindingValidation.ok, true);
   assert.equal(bindingValidation.objectsByRole.asteroidMedium.id, "object.asteroids.medium-asteroid");
-  assert.equal(bindingValidation.warnings.some((entry) => (
-    entry.message.includes("matched multiple objects by tags [asteroid, medium]")
-    && entry.details.candidates.some((candidate) => candidate.includes("object.asteroids.medium-asteroid-2"))
-  )), true);
+  assert.deepEqual(bindingValidation.warnings, []);
   const missingMediumBindings = { ...runtimeBindings };
   delete missingMediumBindings.asteroidMedium;
   const missingBindingValidation = validateAsteroidsRuntimeObjectBindings(payload.objects, missingMediumBindings);
   assert.equal(missingBindingValidation.ok, false);
   assert.equal(missingBindingValidation.errors.some((entry) => (
     entry.message.includes("objectIds.asteroidMedium")
     && entry.details.candidates.some((candidate) => candidate.includes("object.asteroids.medium-asteroid"))
-    && entry.details.candidates.some((candidate) => candidate.includes("object.asteroids.medium-asteroid-2"))
   )), true);
 
   const recreatedPayload = createPayloadWithRecreatedMediumAsteroid(payload);

tests/games/AsteroidsPlatformDemo.test.mjs

@@ -88,25 +88,21 @@ export async function run() {
   const bindingValidation = validateAsteroidsRuntimeObjectBindings(payload.objects, runtimeBindings);
   assert.equal(bindingValidation.ok, true);
   assert.equal(bindingValidation.objectsByRole.asteroidMedium.id, 'object.asteroids.medium-asteroid');
-  assert.equal(bindingValidation.warnings.some((entry) => (
-    entry.message.includes('matched multiple objects by tags [asteroid, medium]')
-    && entry.details.candidates.some((candidate) => candidate.includes('object.asteroids.medium-asteroid-2'))
-  )), true);
+  assert.deepEqual(bindingValidation.warnings, []);
   const missingMediumBindings = { ...runtimeBindings };
   delete missingMediumBindings.asteroidMedium;
   const missingBindingValidation = validateAsteroidsRuntimeObjectBindings(payload.objects, missingMediumBindings);
   assert.equal(missingBindingValidation.ok, false);
   assert.equal(missingBindingValidation.errors.some((entry) => (
     entry.message.includes('objectIds.asteroidMedium')
     && entry.details.candidates.some((candidate) => candidate.includes('object.asteroids.medium-asteroid'))
-    && entry.details.candidates.some((candidate) => candidate.includes('object.asteroids.medium-asteroid-2'))
   )), true);
   const invalidBindingValidation = validateAsteroidsRuntimeObjectBindings(payload.objects, {
     ...runtimeBindings,
     asteroidMedium: 'object.asteroids.large-asteroid'
   });
-  assert.equal(invalidBindingValidation.ok, false);
-  assert.equal(invalidBindingValidation.errors.some((entry) => entry.message.includes('missing required tags [asteroid, medium]')), true);
+  assert.equal(invalidBindingValidation.ok, true);
+  assert.equal(invalidBindingValidation.objectsByRole.asteroidMedium.id, 'object.asteroids.large-asteroid');
 
   const recreatedPayload = createPayloadWithRecreatedMediumAsteroid(payload);
   const recreatedBindings = {
@@ -147,15 +143,12 @@ export async function run() {
     sourceLabel: 'Asteroids recreated medium object-vector payload'
   });
   const resolvedMedium = runtime.resolveObject(recreatedAssetSet, {
+    objectId: 'object.asteroids.medium-asteroid-2',
     requireManifestBinding: true,
-    runtimeRole: 'asteroidMedium',
-    tags: ['asteroid', 'medium']
+    runtimeRole: 'asteroidMedium'
   });
   assert.equal(resolvedMedium.id, 'object.asteroids.medium-asteroid-2');
-  assert.equal(runtime.getDiagnostics().events.some((event) => (
-    event.level === 'WARN'
-    && event.message.includes('using explicit manifest binding object.asteroids.medium-asteroid-2')
-  )), true);
+  assert.equal(runtime.getDiagnostics().events.some((event) => event.message.includes('matched multiple objects by tags')), false);
 
   const smallPreview = runtime.createSvgString(assetSet, {
     objectId: 'object.asteroids.small-asteroid',