Skip to content

Commit 1e1d7f8

Browse files
author
DavidQ
committed
Reset /games/index.html to the new shared theme system and lock the updated shared-header rules.
Add Toolbox Aid as the first external menu item. Keep the shared header full width regardless of content. Require the header image to retain aspect ratio as viewport width changes. PR: BUILD_PR_STYLE_04_GAMES_INDEX_RESET_AND_HEADER_LOCKS
1 parent 2b44fcc commit 1e1d7f8

6 files changed

Lines changed: 28 additions & 21 deletions

File tree

docs/dev/reports/header_lock_carry_forward_notes.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ Locked for implementation:
55
- external link standard = class is-external + target _blank + rel noopener noreferrer
66
- header stretches full width regardless of content
77
- no centered container may constrain the header
8-
- header image preserves aspect ratio
8+
- header image retains aspect ratio as width changes
9+
- fixed-height header image behavior must be removed
910

1011
Execution slice:
1112
- reset /games/index.html only

docs/operations/dev/codex_commands.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,11 @@ Required work:
2121
<a href="https://toolboxaid.com" class="is-external" target="_blank" rel="noopener noreferrer">Toolbox Aid</a>
2222
</li>
2323
4. Ensure header styling keeps the header full width regardless of content.
24-
5. Ensure the header image area preserves aspect ratio and is not constrained by a centered content wrapper.
24+
5. Ensure the header image scales proportionally with viewport width:
25+
- retain aspect ratio
26+
- no fixed-height lock
27+
- no distortion
28+
- no cropping used to fake responsiveness
2529
6. Add or keep shared external-link styling under theme CSS if useful.
2630
7. Keep `/games/index.html` structurally close to `/index.html` and `/samples/index.html`.
2731
8. Package to:

docs/operations/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ Reset /games/index.html to the new shared theme system and lock the updated shar
22

33
Add Toolbox Aid as the first external menu item.
44
Keep the shared header full width regardless of content.
5-
Preserve shared header sourcing under src/engine/theme.
5+
Require the header image to retain aspect ratio as viewport width changes.
66

77
PR: BUILD_PR_STYLE_04_GAMES_INDEX_RESET_AND_HEADER_LOCKS

docs/pr/BUILD_PR_STYLE_04_GAMES_INDEX_RESET_AND_HEADER_LOCKS.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,18 @@ Reset `/games/index.html` onto the new Toolbox Aid-derived theme while carrying
1818
2. Header must stretch the full width of the screen regardless of content.
1919
- no centered max-width wrapper may constrain the header
2020
- header image area must remain full-width
21-
- image behavior must preserve aspect ratio
2221

23-
3. Shared header source remains under:
22+
3. Header image must retain aspect ratio as page width changes.
23+
- image width may scale up/down with viewport
24+
- image height must scale proportionally
25+
- do not hold image container to a fixed height
26+
- do not crop, squash, or distort the image
27+
- remove any fixed-height rule that prevents proportional scaling
28+
29+
4. Shared header source remains under:
2430
- `src/engine/theme/toolboxaid-header.html`
2531

26-
4. Shared header styling remains under:
32+
5. Shared header styling remains under:
2733
- `src/engine/theme/header.css`
2834
- plus shared base support in `src/engine/theme/main.css` as needed
2935

@@ -49,5 +55,7 @@ Optional shared visual cue:
4955
- header renders from shared source
5056
- Toolbox Aid link is first in menu and opens in new tab safely
5157
- header remains full width regardless of content
58+
- header image scales proportionally with viewport width
59+
- no fixed-height header image behavior remains
5260
- no embedded styling remains on `/games/index.html`
5361
- page is testable and narrow in scope

src/engine/theme/header.css

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
.header-image {
22
background-color: #3600af;
3-
background-image: url('/src/engine/theme/toolboxaid-header.png');
43
border-bottom: 8px solid #3600af;
54
}
65

@@ -39,24 +38,18 @@
3938

4039
.toolboxaid-theme-header #image {
4140
grid-area: image;
42-
min-height: 126px;
43-
display: flex;
44-
align-items: center;
45-
justify-content: center;
46-
padding: 18px 20px;
41+
display: block;
42+
padding: 0;
4743
border-radius: 0;
48-
background-size: cover;
49-
background-position: center;
5044
box-shadow: var(--theme-shadow);
51-
overflow: hidden;
52-
position: relative;
45+
overflow: visible;
46+
position: static;
5347
}
5448

55-
.toolboxaid-theme-header #image::after {
56-
content: '';
57-
position: absolute;
58-
inset: 0;
59-
background: linear-gradient(180deg, rgba(9, 19, 33, 0.18), rgba(9, 19, 33, 0.38));
49+
.toolboxaid-theme-header #image img {
50+
display: block;
51+
width: 100%;
52+
height: auto;
6053
}
6154

6255
.toolboxaid-theme-header #tagline {

src/engine/theme/toolboxaid-header.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<header class="toolboxaid-theme-header">
22
<div class="flex header-content">
33
<div id="image" class="header-image bg-image-fill site-tagline">
4+
<img src="/src/engine/theme/toolboxaid-header.png" alt="Toolbox Aid Header Banner" />
45
</div>
56

67
<div id="tagline" class="site-tagline site-tagline-alt align-center">

0 commit comments

Comments
 (0)