Move Asteroids vector maps to Object Vector Studio V2 ownership and deprecate Vector Map Editor usage - PR_26133_115-object-vector-studio-manifest-map-cleanup

Author: DavidQ

docs/dev/reports/PR_26133_115-object-vector-studio-manifest-map-cleanup_report.md

@@ -0,0 +1,63 @@
+# PR_26133_115 Object Vector Studio Manifest Map Cleanup Report
+
+## Summary
+- Read `docs/dev/PROJECT_INSTRUCTIONS.md` before implementation.
+- Used the current `PR_26133_114` workspace delta and `tmp/PR_26133_114-asteroids-manifest-geometry-completion_delta.zip` as the prior reference.
+- Moved Asteroids restored vector maps from `tools.vector-map-editor.vectorMapDocument` to `tools.object-vector-studio-v2.vectorMaps`.
+- Removed the separate `vector.asteroids.attract.*` map entries from the Asteroids manifest.
+- Updated `ASTEROIDS_VECTOR_MAP_IDS.attractAsteroid`, `attractShip`, and `attractUfo` to resolve to `object.asteroids.large-asteroid`, `object.asteroids.ship`, and `object.asteroids.large-ufo`.
+- Kept runtime vector-map loading manifest-only, with missing required vector maps or required Object Vector maps reported as actionable validation failures.
+- Marked `vector-map-editor` schema as deprecated and pointed future game-owned vector-map work to `object-vector-studio-v2.vectorMaps`.
+
+## Changed Files
+- `games/Asteroids/game.manifest.json`
+- `games/Asteroids/game/AsteroidsAttractAdapter.js`
+- `games/Asteroids/game/AsteroidsGameScene.js`
+- `games/Asteroids/game/asteroidsVectorMaps.js`
+- `tests/games/AsteroidsAssetReferenceAdoption.test.mjs`
+- `tests/games/AsteroidsPlatformDemo.test.mjs`
+- `tests/games/AsteroidsPresentation.test.mjs`
+- `tests/games/AsteroidsValidation.test.mjs`
+- `tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
+- `tools/schemas/game.manifest.schema.json`
+- `tools/schemas/tools/object-vector-studio-v2.schema.json`
+- `tools/schemas/tools/vector-map-editor.schema.json`
+- `docs/dev/reports/PR_26133_115-object-vector-studio-manifest-map-cleanup_report.md`
+
+## Validation
+- PASS: `node --check games/Asteroids/game/asteroidsVectorMaps.js`
+- PASS: `node --check games/Asteroids/game/AsteroidsAttractAdapter.js`
+- PASS: `node --check games/Asteroids/game/AsteroidsGameScene.js`
+- PASS: JSON parse validation for Asteroids manifest and impacted schemas.
+- PASS: targeted Asteroids manifest vector-map validation confirmed:
+  - `tools.vector-map-editor` is absent from `games/Asteroids/game.manifest.json`.
+  - restored vector maps live under `tools.object-vector-studio-v2.vectorMaps`.
+  - `vector.asteroids.attract.ship`, `vector.asteroids.attract.asteroid`, and `vector.asteroids.attract.ufo` are absent.
+  - attract constants resolve to the exact Object Vector map IDs requested.
+- PASS: targeted Object Vector runtime loader validation accepted the migrated Asteroids payload and resolved the three attract Object Vector IDs.
+- PASS: targeted Object Vector Studio schema validation accepted the migrated Asteroids payload.
+- PASS: targeted Asteroids tests:
+  - `AsteroidsValidation`
+  - `AsteroidsPresentation`
+  - `AsteroidsVectorTransforms`
+  - `AsteroidsAssetReferenceAdoption`
+  - `AsteroidsPlatformDemo`
+  - `AsteroidsHardening`
+  - `AsteroidsCollisionTimingStress`
+- PASS: targeted Playwright impacted tool validation:
+  - `loads Object Vector Studio V2 runtime assets into Asteroids gameplay rendering`
+  - `uses header lifecycle controls and launches tools from fixed Workspace Manager V2 tiles`
+- PASS: `git diff --check` (line-ending warnings only)
+
+## Skipped
+- Skipped `npm run test:workspace-v2` by request; current BUILD requested targeted Asteroids and impacted tool validation only.
+- Skipped full samples smoke test by request.
+
+## Expected Behavior
+- Asteroids loads restored vector maps only from `tools.object-vector-studio-v2.vectorMaps`.
+- Attract Ship, Asteroid, and UFO rendering use manifest-owned Object Vector objects instead of duplicate attract vector maps.
+- Missing `vector.asteroids.bullet` or a required attract Object Vector map fails validation with the missing ID named.
+- Workspace Manager V2 and Object Vector Studio V2 no longer select `vector-map-editor` for current Asteroids restored vector maps.
+
+## ZIP
+- Output path: `tmp/PR_26133_115-object-vector-studio-manifest-map-cleanup_delta.zip`

games/Asteroids/game.manifest.json

@@ -208,12 +208,15 @@
         }
       }
     },
-    "vector-map-editor": {
-      "vectorMapDocument": {
+    "object-vector-studio-v2": {
+      "version": 1,
+      "toolId": "object-vector-studio-v2",
+      "name": "Asteroids Object Vector Assets",
+      "vectorMaps": {
         "schema": "html-js-gaming.asteroids-vector-map",
         "version": 1,
-        "name": "Asteroids Manifest Vector Maps",
-        "source": "manifest",
+        "name": "Asteroids Object Vector Manifest Maps",
+        "source": "object-vector-studio-v2",
         "objectVectorRoles": {
           "ship": {
             "objectId": "object.asteroids.ship",
@@ -329,7 +332,11 @@
             "id": "vector.asteroids.bullet",
             "label": "Bullet",
             "kind": "polygon",
-            "usage": ["gameplay", "collision", "projectile"],
+            "usage": [
+              "gameplay",
+              "collision",
+              "projectile"
+            ],
             "points": [
               {
                 "x": -2,
@@ -491,92 +498,6 @@
               }
             ]
           },
-          {
-            "id": "vector.asteroids.attract.ship",
-            "label": "Attract Ship",
-            "kind": "polygon",
-            "usage": [
-              "attract"
-            ],
-            "points": [
-              {
-                "x": 16,
-                "y": 0
-              },
-              {
-                "x": -10,
-                "y": 9
-              },
-              {
-                "x": -5,
-                "y": 0
-              },
-              {
-                "x": -10,
-                "y": -9
-              }
-            ]
-          },
-          {
-            "id": "vector.asteroids.attract.asteroid",
-            "label": "Attract Asteroid",
-            "kind": "polyline",
-            "usage": [
-              "attract"
-            ],
-            "points": [
-              {
-                "x": -16,
-                "y": -5
-              },
-              {
-                "x": -7,
-                "y": 14
-              },
-              {
-                "x": 11,
-                "y": 12
-              },
-              {
-                "x": 15,
-                "y": -6
-              },
-              {
-                "x": 2,
-                "y": -16
-              },
-              {
-                "x": -16,
-                "y": -5
-              }
-            ]
-          },
-          {
-            "id": "vector.asteroids.attract.ufo",
-            "label": "Attract UFO",
-            "kind": "polygon",
-            "usage": [
-              "attract"
-            ],
-            "points": [
-              {
-                "x": -20,
-                "y": 5
-              },
-              {
-                "x": 20,
-                "y": 5
-              },
-              {
-                "x": 14,
-                "y": -4
-              },
-              {
-                "x": -14,
-                "y": -4
-              }
-            ]
-          },
           {
             "id": "vector.asteroids.ui.title",
             "label": "Asteroids Title",
@@ -594,12 +515,7 @@
             "points": []
           }
         ]
-      }
-    },
-    "object-vector-studio-v2": {
-      "version": 1,
-      "toolId": "object-vector-studio-v2",
-      "name": "Asteroids Object Vector Assets",
+      },
       "objects": [
         {
           "id": "object.asteroids.ship",

games/Asteroids/game/AsteroidsAttractAdapter.js

@@ -5,6 +5,7 @@ David Quesenberry
 AsteroidsAttractAdapter.js
 */
 import { clamp } from '../../../src/shared/utils/mathUtils.js';
+import { ASTEROIDS_VECTOR_MAP_IDS } from './asteroidsVectorMaps.js';
 
 function estimateTextWidth(text, fontPx) {
   return String(text ?? '').length * (fontPx * 0.62);
@@ -123,16 +124,19 @@ export default class AsteroidsAttractAdapter {
       ...this.scene.objectVectorRoleOptions('ship'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
+      objectId: ASTEROIDS_VECTOR_MAP_IDS.attractShip,
       rotation: (Math.PI / 2) - 0.28,
       scale: 1.1,
       stateId: 'idle',
       x: 328,
       y: 348,
     });
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractAsteroid', {
-      ...this.scene.objectVectorRoleOptions('asteroidSmall'),
+      ...this.scene.objectVectorRoleOptions('asteroidLarge'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
+      objectId: ASTEROIDS_VECTOR_MAP_IDS.attractAsteroid,
+      scale: 0.72,
       stateId: 'active',
       x: 632,
       y: 352,
@@ -209,6 +213,7 @@ export default class AsteroidsAttractAdapter {
       ...this.scene.objectVectorRoleOptions('ship'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
+      objectId: ASTEROIDS_VECTOR_MAP_IDS.attractShip,
       rotation: (Math.PI / 2) + Math.sin(this.demoTime * 0.9) * 1.2,
       stateId: 'idle',
       x,
@@ -218,17 +223,20 @@ export default class AsteroidsAttractAdapter {
     const rockX = 480 + Math.sin(this.demoTime * 0.5) * 250;
     const rockY = 330 + Math.cos(this.demoTime * 0.9) * 120;
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractAsteroid', {
-      ...this.scene.objectVectorRoleOptions('asteroidSmall'),
+      ...this.scene.objectVectorRoleOptions('asteroidLarge'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
+      objectId: ASTEROIDS_VECTOR_MAP_IDS.attractAsteroid,
+      scale: 0.72,
       stateId: 'active',
       x: rockX,
       y: rockY,
     });
     this.scene?.drawObjectVectorAsset?.(renderer, 'attractUfo', {
-      ...this.scene.objectVectorRoleOptions('ufoSmall'),
+      ...this.scene.objectVectorRoleOptions('ufoLarge'),
       elapsedMs: this.scene.objectVectorPlaybackMs,
       fps: 12,
+      objectId: ASTEROIDS_VECTOR_MAP_IDS.attractUfo,
       stateId: 'active',
       x: 480 + Math.cos(this.demoTime * 0.43) * 280,
       y: 284,

games/Asteroids/game/AsteroidsGameScene.js

@@ -969,6 +969,7 @@ export default class AsteroidsGameScene extends Scene {
         assetCount: this.objectVectorAssets?.objectsById?.size || 0,
         loaded: Boolean(this.objectVectorAssets),
         objectCount: this.objectVectorAssets?.objectsById?.size || 0,
+        objectVectorMapIds: this.vectorMaps?.objectVectorMaps?.map((object) => object.id) || [],
         runtimeObjectsValid: Boolean(this.objectVectorRuntimeObjectValidation?.ok),
         renderCounts: { ...this.objectVectorRenderCounts },
         vectorMapIds: this.vectorMaps?.vectors?.map((vector) => vector.id) || [],

games/Asteroids/game/asteroidsVectorMaps.js

@@ -1,10 +1,10 @@
-const ASTEROIDS_VECTOR_MAP_TOOL_KEY = 'vector-map-editor';
-const ASTEROIDS_VECTOR_MAP_DOCUMENT_KEY = 'vectorMapDocument';
+const ASTEROIDS_OBJECT_VECTOR_TOOL_KEY = 'object-vector-studio-v2';
+const ASTEROIDS_VECTOR_MAP_DOCUMENT_KEY = 'vectorMaps';
 
 export const ASTEROIDS_VECTOR_MAP_IDS = Object.freeze({
-  attractAsteroid: 'vector.asteroids.attract.asteroid',
-  attractShip: 'vector.asteroids.attract.ship',
-  attractUfo: 'vector.asteroids.attract.ufo',
+  attractAsteroid: 'object.asteroids.large-asteroid',
+  attractShip: 'object.asteroids.ship',
+  attractUfo: 'object.asteroids.large-ufo',
   bullet: 'vector.asteroids.bullet',
   shipCollision: 'vector.asteroids.ship.collision',
   shipLife: 'vector.asteroids.ship.life',
@@ -14,9 +14,6 @@ export const ASTEROIDS_VECTOR_MAP_IDS = Object.freeze({
 });
 
 export const ASTEROIDS_REQUIRED_VECTOR_MAP_IDS = Object.freeze([
-  ASTEROIDS_VECTOR_MAP_IDS.attractAsteroid,
-  ASTEROIDS_VECTOR_MAP_IDS.attractShip,
-  ASTEROIDS_VECTOR_MAP_IDS.attractUfo,
   ASTEROIDS_VECTOR_MAP_IDS.bullet,
   ASTEROIDS_VECTOR_MAP_IDS.shipCollision,
   ASTEROIDS_VECTOR_MAP_IDS.shipLife,
@@ -25,6 +22,12 @@ export const ASTEROIDS_REQUIRED_VECTOR_MAP_IDS = Object.freeze([
   ASTEROIDS_VECTOR_MAP_IDS.uiTitle,
 ]);
 
+export const ASTEROIDS_REQUIRED_OBJECT_VECTOR_MAP_IDS = Object.freeze([
+  ASTEROIDS_VECTOR_MAP_IDS.attractAsteroid,
+  ASTEROIDS_VECTOR_MAP_IDS.attractShip,
+  ASTEROIDS_VECTOR_MAP_IDS.attractUfo,
+]);
+
 export const ASTEROIDS_REQUIRED_OBJECT_VECTOR_ROLE_IDS = Object.freeze([
   'ship',
   'asteroidLarge',
@@ -148,15 +151,22 @@ export function loadAsteroidsVectorMapsFromManifest(manifest, {
   logger = null,
   sourceLabel = 'games/Asteroids/game.manifest.json',
 } = {}) {
-  const document = manifest?.tools?.[ASTEROIDS_VECTOR_MAP_TOOL_KEY]?.[ASTEROIDS_VECTOR_MAP_DOCUMENT_KEY];
+  const objectVectorPayload = manifest?.tools?.[ASTEROIDS_OBJECT_VECTOR_TOOL_KEY];
+  const document = objectVectorPayload?.[ASTEROIDS_VECTOR_MAP_DOCUMENT_KEY];
   const errors = [];
   if (!isRecord(document)) {
-    errors.push(`Asteroids vector map manifest is missing root.tools.${ASTEROIDS_VECTOR_MAP_TOOL_KEY}.${ASTEROIDS_VECTOR_MAP_DOCUMENT_KEY}.`);
+    errors.push(`Asteroids vector map manifest is missing root.tools.${ASTEROIDS_OBJECT_VECTOR_TOOL_KEY}.${ASTEROIDS_VECTOR_MAP_DOCUMENT_KEY}.`);
   }
   const vectors = Array.isArray(document?.vectors)
     ? document.vectors.map(normalizeVectorEntry).filter(Boolean)
     : [];
   const vectorsById = new Map(vectors.map((vector) => [vector.id, vector]));
+  const objectVectorMaps = Array.isArray(objectVectorPayload?.objects)
+    ? objectVectorPayload.objects
+      .filter((object) => isRecord(object) && normalizeString(object.id))
+      .map((object) => clone(object))
+    : [];
+  const objectVectorMapsById = new Map(objectVectorMaps.map((object) => [object.id, object]));
   ASTEROIDS_REQUIRED_VECTOR_MAP_IDS.forEach((id) => {
     const vector = vectorsById.get(id);
     if (!vector) {
@@ -168,6 +178,16 @@ export function loadAsteroidsVectorMapsFromManifest(manifest, {
       errors.push(`Asteroids vector map ${id} must contain at least ${minimumPoints} points.`);
     }
   });
+  ASTEROIDS_REQUIRED_OBJECT_VECTOR_MAP_IDS.forEach((id) => {
+    const object = objectVectorMapsById.get(id);
+    if (!object) {
+      errors.push(`Asteroids Object Vector manifest map ${id} is missing from root.tools.${ASTEROIDS_OBJECT_VECTOR_TOOL_KEY}.objects.`);
+      return;
+    }
+    if (!Array.isArray(object.shapes) || !object.shapes.length) {
+      errors.push(`Asteroids Object Vector manifest map ${id} must contain at least one shape.`);
+    }
+  });
   const objectVectorRoles = normalizeObjectVectorRoleBindings(document, errors);
   if (errors.length) {
     errors.forEach((message) => logValidation(logger, 'FAIL', message, { sourceLabel }));
@@ -179,6 +199,8 @@ export function loadAsteroidsVectorMapsFromManifest(manifest, {
   }
   const vectorMaps = {
     document: clone(document),
+    objectVectorMaps,
+    objectVectorMapsById,
     objectVectorRoles,
     sourceLabel,
     usageCounts: usageCounts(vectors),

tests/games/AsteroidsAssetReferenceAdoption.test.mjs

@@ -53,7 +53,8 @@ export async function run() {
   const profiles = createAsteroidsTestGeometryProfiles();
   const manifestText = JSON.stringify(manifest);
 
-  assert.equal(Array.isArray(manifest.tools["vector-map-editor"].vectorMapDocument.vectors), true);
+  assert.equal(manifest.tools["vector-map-editor"], undefined);
+  assert.equal(Array.isArray(manifest.tools["object-vector-studio-v2"].vectorMaps.vectors), true);
   assert.equal(vectorMaps.vectorsById.has("vector.asteroids.ship.collision"), true);
   assert.equal(vectorMaps.vectorsById.has("vector.asteroids.ui.title"), true);
   assert.equal(manifest.game["workspace"], undefined);

tests/games/AsteroidsPlatformDemo.test.mjs

@@ -72,7 +72,8 @@ export async function run() {
   const vectorMaps = loadAsteroidsVectorMaps();
   const manifestText = JSON.stringify(manifest);
 
-  assert.equal(Array.isArray(manifest.tools['vector-map-editor'].vectorMapDocument.vectors), true);
+  assert.equal(manifest.tools['vector-map-editor'], undefined);
+  assert.equal(Array.isArray(manifest.tools['object-vector-studio-v2'].vectorMaps.vectors), true);
   assert.equal(vectorMaps.vectorsById.has('vector.asteroids.ship.collision'), true);
   assert.equal(vectorMaps.vectorsById.has('vector.asteroids.ui.title'), true);
   assert.equal(manifest.game["workspace"], undefined);

tests/games/AsteroidsPresentation.test.mjs

@@ -211,8 +211,8 @@ function testAsteroidsAttractObjectsLoadFromManifestRoles() {
 
   const objectIds = renderCalls.map((call) => call.objectId);
   assert.equal(objectIds.includes('object.asteroids.ship'), true);
-  assert.equal(objectIds.includes('object.asteroids.small-asteroid'), true);
-  assert.equal(objectIds.includes('object.asteroids.small-ufo'), true);
+  assert.equal(objectIds.includes('object.asteroids.large-asteroid'), true);
+  assert.equal(objectIds.includes('object.asteroids.large-ufo'), true);
 }
 
 function testAsteroidsGameplayBulletsUseManifestVectorMap() {