Skip to content

Commit 1c053cc

Browse files
author
DavidQ
committed
Fix next failing tool from audit to enforce strict Workspace V2 contract - PR_11_327
1 parent 57646ab commit 1c053cc

6 files changed

Lines changed: 87 additions & 2 deletions

File tree

docs/dev/codex_commands.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,3 +264,10 @@ PR_11_321
264264
```bash
265265
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_321: Document the Workspace V2 Playwright validation gate for repeatable local testing."
266266
```
267+
268+
---
269+
PR_11_327
270+
271+
```bash
272+
npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_327: fix the next failing tool from tool_completion_audit.md with a minimal single-tool change and required Workspace V2 Playwright gate validation."
273+
```

docs/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Scope Asset Manager V2 persistence to explicit add/remove actions and remove passive render-time mutation writes - PR 11.326
1+
Align Palette Manager V2 launch label mapping with asset-manager-v2 contract name (Asset Manager V2) - PR 11.327
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# PR_11_327 Report
2+
3+
## Scope
4+
- Single tool fix only: `palette-manager-v2`
5+
- No schema changes
6+
- No cross-tool behavior changes
7+
8+
## Files Changed
9+
- `tools/palette-manager-v2/index.js`
10+
- `docs/pr/PR_11_327_PALETTE_MANAGER_LABEL_CONTRACT_ALIGNMENT/PLAN_PR.md`
11+
- `docs/pr/PR_11_327_PALETTE_MANAGER_LABEL_CONTRACT_ALIGNMENT/BUILD_PR.md`
12+
- `docs/dev/reports/PR_11_327_report.md`
13+
- `docs/dev/codex_commands.md`
14+
- `docs/dev/commit_comment.txt`
15+
16+
## Implementation
17+
- Corrected stale user-facing tool label mapping:
18+
- `asset-manager-v2` now displays as `Asset Manager V2` in Palette Manager V2 navigation labels.
19+
20+
## Validation
21+
- `node --check tools/palette-manager-v2/index.js` -> PASS
22+
- `npm run test:workspace-v2` -> PASS
23+
- `1 passed`
24+
- `Workspace V2 Playwright Gate Summary: passed=1 failed=0`
25+
26+
## Full Samples Smoke
27+
- Skipped.
28+
- Reason: scoped one-line UI label correction in one tool, with no shared schema/runtime contract changes.
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# BUILD_PR — PR_11_327
2+
3+
## Scope
4+
- One tool only: `palette-manager-v2`
5+
- Minimal/surgical code change only
6+
- No schema edits
7+
- No unrelated runtime edits
8+
9+
## Change
10+
- Updated `toolLabel` mapping in `tools/palette-manager-v2/index.js`:
11+
- from `"Asset Browser V2"`
12+
- to `"Asset Manager V2"`
13+
14+
## Why This Fix
15+
- Aligns launch/breadcrumb UI contract with the current tool ID rename (`asset-manager-v2`).
16+
- Prevents mismatched standalone/workspace launch wording for the same tool.
17+
18+
## Validation Performed
19+
1. `node --check tools/palette-manager-v2/index.js` -> PASS
20+
2. `npm run test:workspace-v2` -> PASS (`1 passed`, `failed=0`)
21+
22+
## Full Samples Smoke
23+
- Skipped.
24+
- Reason: single-line, single-tool label correction with no engine/schema/sample/runtime-contract mutation.
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PLAN_PR — PR_11_327
2+
3+
## Purpose
4+
Fix the next failing tool from `tool_completion_audit.md` with a single-tool, minimal implementation.
5+
6+
## Target Tool
7+
- `palette-manager-v2`
8+
9+
## Problem Chosen
10+
- User-facing launch label drift remained in `palette-manager-v2` after the repo-wide rename from Asset Browser to Asset Manager.
11+
- `toolLabel("asset-manager-v2")` still returned `"Asset Browser V2"`.
12+
13+
## Scoped Implementation
14+
1. Update `tools/palette-manager-v2/index.js` label mapping:
15+
- `asset-manager-v2` -> `"Asset Manager V2"`
16+
2. No schema changes.
17+
3. No cross-tool/runtime refactors.
18+
19+
## Validation
20+
1. `node --check tools/palette-manager-v2/index.js`
21+
2. `npm run test:workspace-v2`
22+
23+
## Packaging
24+
- Build repo-structured ZIP at:
25+
- `tmp/PR_11_327_<timestamp>.zip`
26+
- `tmp/PR_11_327_delta.zip`

tools/palette-manager-v2/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class PaletteManagerV2 {
5151
}
5252

5353
toolLabel(toolId) {
54-
if (toolId === "asset-manager-v2") return "Asset Browser V2";
54+
if (toolId === "asset-manager-v2") return "Asset Manager V2";
5555
if (toolId === "palette-manager-v2") return "Palette Manager V2";
5656
if (toolId === "svg-asset-studio-v2") return "SVG Asset Studio V2";
5757
if (toolId === "tilemap-studio-v2") return "Tilemap Studio V2";

0 commit comments

Comments
 (0)