Skip to content

Commit 1915d59

Browse files
author
DavidQ
committed
Compact Object Details geometry layouts and clarify palette and triangle selection - PR_26133_017-object-details-geometry-layout-and-palette-selection
1 parent c49644a commit 1915d59

16 files changed

Lines changed: 393 additions & 43 deletions
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# PR_26133_016 Playwright V8 Coverage Report
1+
# PR_26133_017 Playwright V8 Coverage Report
22

33
Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed by the final `npm run test:workspace-v2` run.
44

@@ -7,12 +7,12 @@ Coverage source: `docs/dev/reports/playwright_v8_coverage_report.txt`, refreshed
77
- Coverage is advisory only; no thresholds are enforced.
88
- Workspace Manager V2 entry point: 91%.
99
- Object Vector Studio V2 runtime coverage entries from the generated report:
10-
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 92%, executed lines 3737/3737, executed functions 400/434.
10+
- `tools/object-vector-studio-v2/js/ToolStarterApp.js`: 93%, executed lines 3735/3735, executed functions 403/434.
1111
- The generated report lists `tests/playwright/tools/WorkspaceManagerV2.spec.mjs` as changed JS not collected by browser runtime coverage.
1212

1313
## Validation Context
1414

1515
- Main command: `npm run test:workspace-v2`.
16-
- Result: 47 passed.
17-
- Focused Object Vector Studio V2 layout, preview coordinate, mouse-editing, animation-state, and asset-authoring scenarios passed as part of the workspace-v2 run.
18-
- Coverage includes the runtime paths for object tile rendering, compact icon controls, runtime lock/visibility controls, and targeted object tile deletion.
16+
- Result: 48 passed.
17+
- Focused Object Vector Studio V2 layout, preview coordinate, geometry-layout, mouse-editing, animation-state, and asset-authoring scenarios passed as part of the workspace-v2 run.
18+
- Coverage includes the runtime paths for compact Object Details geometry rendering, selected-shape summary cleanup, selected palette swatch styling, and Triangle tool display labeling.

docs/dev/reports/playwright_workspace_v2_results.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
# PR_26133_016 Workspace V2 Results
1+
# PR_26133_017 Workspace V2 Results
22

33
## Command Results
44

55
- `node --check tools/object-vector-studio-v2/js/ToolStarterApp.js`: passed.
66
- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`: passed.
7-
- `npm run test:workspace-v2`: 47 passed.
7+
- `npm run test:workspace-v2`: 48 passed.
88
- `git diff --check`: passed with LF-to-CRLF working-copy warnings for touched files.
99

1010
## Targeted Object Vector Studio V2 Verification
1111

12-
- Confirmed object tile Delete renders as a textless X icon button at the far right of each object tile.
13-
- Confirmed object tile actions are stacked compactly in order: Show/Hide, Lock, Delete.
14-
- Confirmed object tile action buttons use the reduced 26px control size.
15-
- Confirmed Delete is disabled while the object is runtime-locked, while existing Show/Hide and Lock behavior remains intact.
16-
- Confirmed tile Delete removes only the targeted object tile; the Shield Pickup tile delete removed `object.asteroids.shield-pickup` while preserving `object.asteroids.object-1`.
12+
- Confirmed Object Details no longer renders the `Fill Color` summary row/value.
13+
- Confirmed Rectangle, Circle, Ellipse, Line, Arc, and Text Geometry controls use compact reduced spacing.
14+
- Confirmed requested geometry input rows render on the same line: rectangle `x/y` and `width/height`, circle `cx/cy` and inline `r`, ellipse `cx/cy` and `rx/ry`, line `x1/y1` and `x2/y2`, arc `cx/cy`, and text `x/y` plus inline `fontSize` and `text` fields.
15+
- Confirmed the selected palette swatch renders with a visible selected state, outline, shadow, and check mark.
16+
- Confirmed Triangle tool creation displays `Triangle Geometry`, not `Polygon Geometry`, while preserving schema-valid polygon storage.
1717
- Confirmed workspace-v2 Object Vector Studio V2 scenarios reported no console/page errors.
1818

1919
## Scope Checks
2.29 MB
Binary file not shown.
2.33 MB
Binary file not shown.
2.29 MB
Binary file not shown.
2.3 MB
Binary file not shown.
2.34 MB
Binary file not shown.
2.3 MB
Binary file not shown.
2.29 MB
Binary file not shown.
2.33 MB
Binary file not shown.

0 commit comments

Comments
 (0)