Rebuild Palette Manager V2 accordions for stable anchored scroll layout - PR_26124_043-palette-manager-accordion-v2

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,357 +1,20 @@
-MODEL: gpt-5.3-codex
-REASONING: medium
-
-# PR_11_198 — Tilemap Studio V2 Completion + Validation
-
-## Execute
-Implement the smallest valid testable change for Tilemap Studio V2.
-
-## Hard Boundaries
-- Codex writes implementation code.
-- Do not change schemas.
-- Do not change samples.
-- Do not change games.
-- Do not touch Workspace Manager v1.
-- Do not patch legacy tools.
-- Do not use platformShell.
-- Do not use tools/shared except the explicitly required theme/header mount path already used by the repo theme system.
-- Do not copy old tool code. Re-engineer the V2 tool.
-
-## Required Files To Inspect/Edit
-- tools/tilemap-studio-v2/index.html
-- tools/tilemap-studio-v2/index.js
-
-If either file does not exist, create only the missing file required for this tool.
-
-## Implementation Rules
-1. `tools/tilemap-studio-v2/index.html` must own the static shell:
-   - include theme CSS
-   - include `<div id="shared-theme-header"></div>`
-   - include static page shell/root container
-   - include static menuTool section
-   - include static menuWorkspace section
-   - include `../../src/engine/theme/mount-shared-header.js`
-   - include `./index.js`
-
-2. `tools/tilemap-studio-v2/index.js` must be behavior-only:
-   - single class
-   - no helper classes
-   - no alias/pass-through variables
-   - no full-page `innerHTML` construction
-   - no CSS injection
-   - no dynamic header injection
-   - read session only
-   - update existing DOM nodes only
-   - handle missing, invalid, and valid session states
-
-3. Enforce naming:
-   - visible name: `Tilemap Studio V2`
-   - `document.title`: `Tilemap Studio V2`
-   - `data-tool-id`: `tilemap-studio-v2`
-
-4. Session rules:
-   - no fallback data
-   - no defaults
-   - no fetch
-   - no guessed payloads
-   - no hidden samples
-
-## Validation Commands
-Run targeted validation only:
-
-```powershell
-node --check tools/tilemap-studio-v2/index.js
-```
-
-Manual validation:
-- Open `tools/tilemap-studio-v2/index.html`.
-- Confirm shared header renders in `#shared-theme-header`.
-- Confirm missing session shows clear actionable state.
-- Confirm valid session renders tilemap content.
-- Confirm browser console has no errors.
-
-## Evidence Report
-Create or update:
-
-```text
-docs/dev/reports/PR_11_198_report.md
-```
-
-Report must include:
-- files changed
-- validation commands run
-- pass/fail results
-- manual test notes
-- statement that full samples smoke was skipped and why
-
-## Local ZIP Output
-After validation, Codex must create:
-
-```text
-<project folder>/tmp/PR_11_198.zip
-```
-
-The ZIP must preserve repo-relative structure and include the final changed files plus docs/dev evidence.
-
-
----
-PR_11_310
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_310 ..."
-```
-
-
----
-PR_11_311
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_311 ..."
-```
-
-
----
-PR_11_312
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_312 ..."
-```
-
-
----
-PR_11_313
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_313 ..."
-```
-
----
-PR_11_313 (Workspace V2 launcher + Asset Manager V2 UI labels)
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_313: Workspace V2 tool launcher UI + Asset Manager V2 user-facing rename."
-```
-
----
-PR_11_313 (single contract rename: asset-manager-v2)
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_313: rename legacy asset browser v2 id to asset-manager-v2 across tool ID, paths, payloads, registry links, tests, and docs with zero old references."
-```
-
----
-PR_11_314
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_314: persist valid Asset Manager V2 payloadJson.assetCatalog into Workspace V2 active session/export path and block invalid writes."
-```
-
----
-PR_11_315
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_315: Enable core asset management actions in Asset Manager V2 (add/remove entries) with strict required-field validation and workspace persistence."
-```
-
----
-PR_11_316
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_316: Harden Asset Manager V2 add/remove actions by rejecting duplicate ids, blank/whitespace fields, and missing remove ids with actionable status messages while preserving valid persistence behavior."
-```
-
----
-PR_11_317
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_317: Clarify Workspace V2 Asset Manager launcher with explicit no-session vs active-session state while preserving session-routed launch behavior."
-```
-
----
-PR_11_318
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318: Add Asset Manager V2 row selection + details panel with UI-only selection state and no payload mutation."
-```
-
----
-PR_11_318A
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318A: Remove test-to-test imports by extracting RuntimeSceneLoaderHotReload shared logic into tests/helpers and updating final/tool tests to consume helper."
-```
-
----
-PR_11_318B
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318B: Add first Playwright UI test for Workspace V2 launching Asset Manager V2, add/remove asset flow, and export verification."
-```
-
----
-PR_11_318C
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318C: Redirect Playwright outputs to tests/results/** and avoid default output folders with config-only changes."
-```
-
----
-PR_11_318D
+# PR_26124_043-palette-manager-accordion-v2
 
 ```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318D: Expand Workspace V2 Playwright UI coverage into full Asset Manager regression with launch/add/remove/validation/export/import round-trip assertions."
+npx @openai/codex run --model gpt-5.5 --reasoning high "Run full workflow for PR_26124_043-palette-manager-accordion-v2. Follow PROJECT_INSTRUCTIONS.md exactly. Rewrite only palette-manager-v2 center accordion HTML/JS/CSS to use a local accordionV2 structure instead of details/summary."
 ```
 
----
-PR_11_318E
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318E: Configure Playwright HTML reporter to open automatically after targeted UI test runs."
-```
-
----
-PR_11_319
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_319: Add required Workspace V2 Playwright gate command with explicit pass/fail summary and non-zero failure handling."
-```
-
----
-PR_11_320
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_320: Update Workspace V2 Playwright gate to execute installed Playwright command path only, preserving fail-fast and summary output."
-```
-
----
-PR_11_322
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_322: Run Workspace V2 Playwright tests automatically via CI."
-```
-
----
-PR_11_323
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_323: Add full Workspace V2 Playwright coverage beyond Asset Manager."
-```
-
----
-PR_11_324
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_324: Audit all tools for Workspace V2 compliance and completion status."
-```
-
----
-PR_11_325
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_325: Fix the highest-impact failing Workspace V2 tool interaction from tool_completion_audit.md."
-```
-
----
-PR_11_326
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_326: Fix the next failing tool from tool_completion_audit.md."
-```
-
----
-PR_11_321
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_321: Document the Workspace V2 Playwright validation gate for repeatable local testing."
-```
-
----
-PR_11_327
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_327: fix the next failing tool from tool_completion_audit.md with a minimal single-tool change and required Workspace V2 Playwright gate validation."
-```
-
----
-PR_26123_001-project-instructions-update
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PROJECT_INSTRUCTIONS update: add PR naming standard, update ChatGPT output contract (command + commit comment + Playwright coverage + manual test steps), and enforce ChatGPT non-ZIP ownership language while keeping Codex ZIP ownership intact."
-```
-
----
-PR_26124_002-palette-manager-strict-payload-guard
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_002: fix the next failing tool from tool_completion_audit.md with a minimal single-tool palette-manager-v2 guard that rejects legacy payloadJson.paletteDocument.colors before render and validates required swatches contract."
-```
-
----
-PR_26124_003-validation-scope-sample-exclusion
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_003: adjust validation scope to exclude sample-launch requirements until sample JSON is schema-compliant, update docs/dev validation wording, and keep Playwright workspace lifecycle/payload/roundtrip coverage sample-independent."
-```
-
----
-PR_26124_004-workspace-v2-launch-toolid-guard
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_004: fix next failing Workspace V2 tool lane issue with a minimal guard that blocks launch when active session.toolId does not match selected tool and preserves strict payload behavior."
-```
-
----
-PR_26124_006-playwright-ctrl-tap-debug
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_006: add shared Ctrl tap (Control down/up) before key Playwright click actions for Workspace V2 navigation/tool/workspace interaction points without changing runtime behavior."
-```
-
----
-PR_26124_007-tool-payload-guards-group
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_007: fix next small group of failing tools (asset-manager-v2 + palette-manager-v2) by adding strict pre-render cross-tool payload guards while preserving workspace launch behavior."
-```
-
----
-PR_26124_008-next-fail-group-fix
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_008: extract next 3 FAIL tools from tool_completion_audit.md, fix only that group with minimal contract-safe changes, update audit statuses for those tools only, and validate with npm run test:workspace-v2."
-```
-
----
-PR_26124_009-empty-fail-batch-capture
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_009: extract next FAIL tools from tool_completion_audit.md, record explicit batch fail list, and if no FAIL tools remain capture the empty batch with validation evidence and no runtime changes."
-```
-
----
-PR_26124_014-include-review-diff
-
-```bash
-npm run codex:review-artifacts
-```
-
----
-PR_26124_018-clarify-tools-vs-toolstate-ux
-
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_018-clarify-tools-vs-toolstate-ux."
-```
-
----
-PR_26124_018-workspace-toolstate-lifecycle-ux
+## Validation Commands
 
 ```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_018-workspace-toolstate-lifecycle-ux."
+node --check tools/palette-manager-v2/modules/PaletteManagerApp.js
+npm run test:workspace-v2
 ```
 
----
-PR_26124_020-workspace-tools-reengineering-design-docs
+## Manual Validation
 
-```bash
-npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_26124_020-workspace-tools-reengineering-design-docs."
-```
+- Open `tools/palette-manager-v2/index.html`.
+- Confirm User Palette and Add User Swatch use accordionV2 button headers.
+- Confirm both open panels share center height.
+- Collapse either panel and confirm the other fills available center height.
+- Confirm source select, search, sort, size, pin, and unpin still work.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Add Workspace V2 and full tool reengineering design docs with explicit ownership boundaries and contract inventories - PR_26124_020-workspace-tools-reengineering-design-docs
+Replace Palette Manager center accordions with local accordionV2 layout - PR_26124_043-palette-manager-accordion-v2