Perform final manifest-driven tooling and asset audit cleanup - PR_26139_022-final-manifest-audit-and-cleanup

Author: DavidQ

docs/dev/reports/PR_26139_022-final-manifest-audit-and-cleanup_report.md

@@ -0,0 +1,63 @@
+# PR_26139_022 Final Manifest Audit And Cleanup Report
+
+## Scope
+
+- Final manifest/tooling audit cleanup after PR_26139_021.
+- Kept changes limited to manifest-facing metadata, validation, Asset Manager V2 chrome asset lookup, and targeted validation expectations.
+- Did not introduce new game runtime behavior.
+
+## Cleanup
+
+- `games/metadata/games.index.metadata.json`
+  - Synced active game `toolsUsed` from each `game.manifest.json` tool map.
+  - Synced manifest preview metadata where the manifest preview role differed, including Pong `preview1.svg`.
+  - Replaced remaining deprecated planned-game tool tokens with current active tool IDs.
+
+- `games/index.render.js`
+  - Removed the hardcoded Skin Editor filter injection so the games index filter list comes from normalized metadata only.
+
+- `scripts/validate-json-contracts.mjs`
+  - Removed legacy `asset-browser` validation from game manifest validation.
+  - Removed exact Asteroids filename checks for background/bezel/font assets.
+  - Added generic Asset Manager V2 preview/background/bezel local file validation by role.
+  - Added explicit deprecated game-manifest tool-key rejection.
+
+- `src/engine/runtime/fullscreenBezel.js`
+  - Removed Asteroids-specific bezel stretch config path redirection.
+  - Restricted manifest stretchOverride scanning to `tools.asset-manager-v2.assets`.
+
+- `tests/playwright/tools/ObjectVectorStudioV2FirstClassToolStarter.spec.mjs`
+  - Updated the targeted Object Vector Studio V2 validation fixture and expectations to current schema/UI behavior:
+    - `objects[].tags` required.
+    - object count includes state count.
+    - Shape Geometry/Shape Transform labels are current.
+    - Tools button reflects the current accordion label.
+
+## Audit Results
+
+- Game manifests validated against current schema: PASS, 11 manifests, 0 invalid.
+- Asset Manager V2 preview role exists for every game manifest: PASS.
+- Preview/background/bezel file paths are validated by Asset Manager V2 role instead of hardcoded filenames: PASS.
+- Deprecated game-manifest tool keys (`asset-browser`, `palette-browser`, `primitive-skin-editor`, `vector-map-editor`): none found.
+- Games index metadata deprecated/unknown tool IDs: none found.
+- Active audited runtime/tool paths contain no hardcoded `assets/images/background.png` or old Pong `/games/Pong/assets/images/preview.svg` request strings.
+- Object Vector Studio V2 manifest geometry audit found no `objectVectorRoles`, `vectorMaps`, or `vector-map-editor` markers in game manifests.
+
+## Validation
+
+- `npm run build:manifest` PASS.
+- `node scripts/validate-json-contracts.mjs --mode=games --details` PASS.
+- Custom metadata tool audit PASS.
+- Custom game manifest deprecated-tool and preview-role audit PASS.
+- Custom Object Vector Studio V2 manifest marker audit PASS.
+- Hardcoded preview/background request scan PASS.
+- `npx playwright test tests/playwright/games/GameIndexPreviewManifestResolution.spec.mjs --project=playwright --workers=1 --reporter=list` PASS, 4 passed.
+- `npx playwright test tests/playwright/tools/AsteroidsBackgroundAssetResolution.spec.mjs --project=playwright --workers=1 --reporter=list` PASS, 3 passed.
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "discovers Active Game options from selected repo manifests"` PASS, 1 passed.
+- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs --project=playwright --workers=1 --reporter=list --grep "uses header lifecycle controls and launches tools from fixed Workspace Manager V2 tiles"` PASS, 1 passed.
+- `npx playwright test tests/playwright/tools/ObjectVectorStudioV2FirstClassToolStarter.spec.mjs --project=playwright --workers=1 --reporter=list` PASS, 4 passed.
+
+## Notes
+
+- Full samples smoke test was not run because this PR is a final manifest/tooling cleanup pass and does not broadly modify shared sample loading.
+- The first Object Vector Studio V2 validation run exposed stale test expectations from prior schema/UI cleanup; the spec was updated narrowly and rerun successfully.

games/index.render.js

@@ -183,11 +183,6 @@ function buildRows(metadata, pinnedSet, toolLabelMap, previewMap) {
   ).entries()]
     .map(([value, label]) => ({ value, label }))
     .sort((a, b) => a.label.localeCompare(b.label, undefined, { sensitivity: "base" }));
-  const skinEditorLabel = toolLabelMap.get("skin-editor");
-  if (skinEditorLabel && !tools.some((entry) => entry.value === "skin-editor")) {
-    tools.push({ value: "skin-editor", label: skinEditorLabel });
-    tools.sort((a, b) => a.label.localeCompare(b.label, undefined, { sensitivity: "base" }));
-  }
   const tags = [...new Set(rows.flatMap((row) => row.tags))].sort((a, b) => a.localeCompare(b, undefined, { sensitivity: "base" }));
   return { rows, levels, classes, tools, tags };
 }

games/metadata/games.index.metadata.json

@@ -15,7 +15,7 @@
       "sampleTrack": false,
       "debugShowcase": false,
       "requiresService": false,
-      "toolsUsed": ["palette-browser", "skin-editor", "asset-browser"]
+      "toolsUsed": ["asset-manager-v2"]
     },
     {
       "id": "Breakout",
@@ -31,7 +31,7 @@
       "debugShowcase": true,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/input/index/GamepadInputAdapter", "engine/input/index/InputService", "engine/scene/index/Scene", "engine/utils/math/clamp"],
-      "toolsUsed": ["palette-browser", "skin-editor", "asset-browser"]
+      "toolsUsed": ["asset-manager-v2"]
     },
     {
       "id": "SolarSystem",
@@ -47,7 +47,7 @@
       "debugShowcase": false,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/input/index/InputService", "engine/scene/index/Scene"],
-      "toolsUsed": ["palette-browser", "skin-editor", "asset-browser"]
+      "toolsUsed": ["asset-manager-v2"]
     },
     {
       "id": "GravityWell",
@@ -63,7 +63,7 @@
       "debugShowcase": false,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/debug/index/drawPanel", "engine/input/index/InputService", "engine/rendering/VectorDrawing/drawVectorShape", "engine/rendering/VectorDrawing/transformPoints", "engine/replay/index/ReplaySystem", "engine/scene/index/Scene", "engine/utils/index/clamp", "engine/utils/index/distance"],
-      "toolsUsed": ["asset-browser", "svg-asset-studio"]
+      "toolsUsed": ["palette-manager-v2", "asset-manager-v2"]
     },
     {
       "id": "Pong",
@@ -73,13 +73,13 @@
       "status": "playable",
       "classValues": ["games/collision/paddle"],
       "tags": ["arcade", "collision", "multimode"],
-      "preview": "/games/Pong/assets/images/preview.svg",
+      "preview": "/games/Pong/assets/images/preview1.svg",
       "href": "/games/Pong/index.html",
       "sampleTrack": true,
       "debugShowcase": false,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/input/index/GamepadInputAdapter", "engine/input/index/InputService", "engine/scene/index/Scene", "engine/utils/math/clamp"],
-      "toolsUsed": ["palette-browser", "skin-editor", "asset-browser"]
+      "toolsUsed": ["palette-manager-v2", "asset-manager-v2"]
     },
     {
       "id": "Asteroids",
@@ -95,7 +95,7 @@
       "debugShowcase": true,
       "requiresService": false,
       "engineClassesUsed": ["engine/audio/index/GaplessLoopPlayer", "engine/audio/index/HtmlAudioMediaBackend", "engine/audio/index/MediaTrackService", "engine/collision/index/arePolygonsColliding", "engine/core/Engine", "engine/debug/inspectors/shared/inspectorUtils/asArray", "engine/debug/inspectors/shared/inspectorUtils/asObject", "engine/fx/index/ParticleSystem", "engine/input/index/InputService", "engine/persistence/index/StorageService", "engine/rendering/index/transformPoints", "engine/scene/index/AttractModeController", "engine/scene/index/Scene", "engine/utils/index/distance", "engine/utils/index/randomRange", "engine/utils/index/wrap", "engine/utils/math/clamp"],
-      "toolsUsed": ["palette-browser", "asset-browser", "sprite-editor", "tile-map-editor", "parallax-editor", "svg-asset-studio", "asset-pipeline"]
+      "toolsUsed": ["palette-manager-v2", "asset-manager-v2", "object-vector-studio-v2"]
     },
     {
       "id": "SpaceInvaders",
@@ -111,7 +111,7 @@
       "debugShowcase": false,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/input/index/GamepadInputAdapter", "engine/input/index/InputService", "engine/persistence/index/StorageService", "engine/scene/index/AttractModeController", "engine/scene/index/Scene", "engine/utils/math/clamp"],
-      "toolsUsed": ["palette-browser", "asset-browser"]
+      "toolsUsed": ["asset-manager-v2"]
     },
     {
       "id": "SpaceDuel",
@@ -127,7 +127,7 @@
       "debugShowcase": false,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/input/index/ActionInputMap", "engine/input/index/ActionInputService", "engine/persistence/index/StorageService", "engine/scene/index/AttractModeController", "engine/scene/index/Scene", "engine/utils/math/clamp"],
-      "toolsUsed": ["palette-browser", "asset-browser"]
+      "toolsUsed": ["asset-manager-v2"]
     },
     {
       "id": "AITargetDummy",
@@ -143,7 +143,7 @@
       "debugShowcase": false,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/input/index/GamepadInputAdapter", "engine/input/index/InputService", "engine/scene/index/Scene", "engine/utils/math/clamp"],
-      "toolsUsed": ["asset-browser"]
+      "toolsUsed": ["asset-manager-v2"]
     },
     {
       "id": "Pacman",
@@ -159,7 +159,7 @@
       "debugShowcase": false,
       "requiresService": false,
       "engineClassesUsed": ["engine/core/Engine", "engine/input/index/GamepadInputAdapter", "engine/input/index/InputService", "engine/scene/index/Scene"],
-      "toolsUsed": ["asset-browser"]
+      "toolsUsed": ["asset-manager-v2"]
     },
     {
       "id": "vector-arcade-sample",
@@ -169,12 +169,12 @@
       "status": "playable",
       "classValues": ["games/template/vector"],
       "tags": ["template", "vector", "sample"],
-      "preview": "/games/vector-arcade-sample/assets/data/parallax/template-backdrop.svg",
+      "preview": "/games/vector-arcade-sample/assets/images/preview.svg",
       "href": "/games/vector-arcade-sample/index.html",
       "sampleTrack": true,
       "debugShowcase": false,
       "requiresService": false,
-      "toolsUsed": ["palette-browser", "parallax-editor", "asset-browser", "sprite-editor", "tile-map-editor", "svg-asset-studio"]
+      "toolsUsed": ["asset-manager-v2", "object-vector-studio-v2"]
     },
     {
       "id": "Frogger",
@@ -204,7 +204,7 @@
       "sampleTrack": false,
       "debugShowcase": false,
       "requiresService": false,
-      "toolsUsed": ["sprite-editor", "vector-map-editor", "performance-profiler"]
+      "toolsUsed": ["sprite-editor", "world-vector-studio-v2", "performance-profiler"]
     },
     {
       "id": "ArenaShooter",
@@ -339,7 +339,7 @@
       "sampleTrack": false,
       "debugShowcase": false,
       "requiresService": false,
-      "toolsUsed": ["tile-map-editor", "vector-map-editor", "state-inspector"]
+      "toolsUsed": ["tile-map-editor", "world-vector-studio-v2", "state-inspector"]
     },
     {
       "id": "FullArenaShooter",
@@ -399,7 +399,7 @@
       "sampleTrack": false,
       "debugShowcase": false,
       "requiresService": false,
-      "toolsUsed": ["vector-map-editor", "svg-asset-studio", "tile-map-editor"]
+      "toolsUsed": ["world-vector-studio-v2", "svg-asset-studio", "tile-map-editor"]
     },
     {
       "id": "TicTacToe",

scripts/validate-json-contracts.mjs

@@ -5,9 +5,7 @@ import path from "node:path";
 const ROOT = process.cwd();
 const REPORT_DIR = path.join(ROOT, "docs", "dev", "reports");
 const SCHEMA_ROOT = path.join(ROOT, "tools", "schemas");
-const ASSET_ID_PATTERN = /^(image|audio|font)\.[a-z0-9-]+\.[a-z0-9-]+(?:\.[a-z0-9-]+)*$/;
-const ASSET_KIND_SET = new Set(["image", "audio", "font"]);
-const ASSET_SOURCE_SET = new Set(["workspace-manager", "asset-browser", "asset-manager-v2", "manifest"]);
+const DEPRECATED_GAME_TOOL_IDS = new Set(["asset-browser", "palette-browser", "primitive-skin-editor", "vector-map-editor"]);
 
 function parseArgs(argv) {
   const args = {
@@ -678,6 +676,26 @@ function resolveManifestAssetPath(manifestPath, assetPath) {
   return path.join(path.dirname(manifestPath), normalized);
 }
 
+function assetManagerImageEntriesByRole(assetManagerAssets, role) {
+  const normalizedRole = String(role || "").trim().toLowerCase();
+  if (!normalizedRole || !isPlainObject(assetManagerAssets)) {
+    return [];
+  }
+  return Object.entries(assetManagerAssets)
+    .filter(([, entry]) => entry?.type === "image" && String(entry?.role || "").trim().toLowerCase() === normalizedRole);
+}
+
+function validateLocalAssetFiles(filePath, entries, role, errors) {
+  for (const [assetId, entry] of entries) {
+    const resolvedAssetPath = resolveManifestAssetPath(filePath, entry.path);
+    if (!resolvedAssetPath) {
+      errors.push(`${role} asset ${assetId} has a non-local or empty path: ${entry.path || "(empty)"}`);
+    } else if (!fs.existsSync(resolvedAssetPath)) {
+      errors.push(`${role} asset ${assetId} file is missing: ${normalizeRel(resolvedAssetPath)}`);
+    }
+  }
+}
+
 function validateGames(schemaIndex, validate) {
   const files = walkFiles(path.join(ROOT, "games"), (filePath) => path.basename(filePath).toLowerCase() === "game.manifest.json");
   const gameManifestSchemaPath = "tools/schemas/game.manifest.schema.json";
@@ -702,70 +720,20 @@ function validateGames(schemaIndex, validate) {
       if (!assetManagerAssets || typeof assetManagerAssets !== "object" || Array.isArray(assetManagerAssets)) {
         errors.push("tools.asset-manager-v2.assets must be an object");
       } else {
-        const previewEntries = Object.entries(assetManagerAssets)
-          .filter(([, entry]) => entry?.type === "image" && String(entry?.role || "").trim().toLowerCase() === "preview");
+        const previewEntries = assetManagerImageEntriesByRole(assetManagerAssets, "preview");
         if (previewEntries.length === 0) {
           errors.push("tools.asset-manager-v2.assets must include an image preview asset");
         }
-        for (const [assetId, entry] of previewEntries) {
-          const resolvedPreviewPath = resolveManifestAssetPath(filePath, entry.path);
-          if (!resolvedPreviewPath) {
-            errors.push(`preview asset ${assetId} has a non-local or empty path: ${entry.path || "(empty)"}`);
-          } else if (!fs.existsSync(resolvedPreviewPath)) {
-            errors.push(`preview asset ${assetId} file is missing: ${normalizeRel(resolvedPreviewPath)}`);
-          }
-        }
-      }
-
-      const assets = manifest?.tools?.["asset-browser"]?.assets;
-      if (manifest?.tools?.["asset-browser"]) {
-        if (!assets || typeof assets !== "object" || Array.isArray(assets)) {
-          errors.push("tools.asset-browser.assets must be an object");
-        } else {
-          if (Object.prototype.hasOwnProperty.call(assets, "media")) {
-            errors.push("tools.asset-browser.assets.media is not allowed");
-          }
-          for (const [assetId, entry] of Object.entries(assets)) {
-            if (!ASSET_ID_PATTERN.test(assetId)) {
-              errors.push(`invalid asset id pattern: ${assetId}`);
-            }
-            if (!isPlainObject(entry)) {
-              errors.push(`asset entry must be object: ${assetId}`);
-              continue;
-            }
-            if (typeof entry.path !== "string" || !entry.path.trim()) {
-              errors.push(`asset entry missing path: ${assetId}`);
-            }
-            if (!ASSET_KIND_SET.has(String(entry.kind || ""))) {
-              errors.push(`asset entry invalid kind: ${assetId}`);
-            }
-            if (!ASSET_SOURCE_SET.has(String(entry.source || ""))) {
-              errors.push(`asset entry invalid source: ${assetId}`);
-            }
-            if (Object.prototype.hasOwnProperty.call(entry, "stretchOverride")) {
-              if (!/^image\.[a-z0-9-]+(?:\.[a-z0-9-]+)*\.bezel$/.test(assetId)) {
-                errors.push(`stretchOverride only allowed on image.*.bezel entries: ${assetId}`);
-              }
-              if (!isPlainObject(entry.stretchOverride) || typeof entry.stretchOverride.uniformEdgeStretchPx !== "number") {
-                errors.push(`invalid stretchOverride payload: ${assetId}`);
-              }
-            }
-          }
-        }
+        validateLocalAssetFiles(filePath, previewEntries, "preview", errors);
+        validateLocalAssetFiles(filePath, assetManagerImageEntriesByRole(assetManagerAssets, "background"), "background", errors);
+        validateLocalAssetFiles(filePath, assetManagerImageEntriesByRole(assetManagerAssets, "bezel"), "bezel", errors);
       }
 
-      if (rel === "games/Asteroids/game.manifest.json") {
-        const astAssets = manifest?.tools?.["asset-manager-v2"]?.assets || {};
-        if (astAssets?.["assets.image.bezel.bezel"]?.path !== "assets/images/bezel.png") {
-          errors.push("Asteroids bezel path must be assets/images/bezel.png");
-        }
-        if (astAssets?.["assets.image.background.deluxe"]?.path !== "assets/images/deluxe.png") {
-          errors.push("Asteroids background path must be assets/images/deluxe.png");
+      Object.keys(manifest?.tools || {}).forEach((toolId) => {
+        if (DEPRECATED_GAME_TOOL_IDS.has(toolId)) {
+          errors.push(`deprecated game manifest tool is not allowed: tools.${toolId}`);
         }
-        if (astAssets?.["assets.font.ui.vector-battle"]?.path !== "src/assets/fonts/vector_battle/vector_battle.ttf") {
-          errors.push("Asteroids assets.font.ui.vector-battle must point to src/assets/fonts/vector_battle/vector_battle.ttf");
-        }
-      }
+      });
     }
 
     rows.push({
@@ -852,10 +820,7 @@ function writeUsageReport(reportDir, usageSummary) {
   lines.push("# Schema Usage Code Updates");
   lines.push("");
   lines.push("## Updated Runtime/Validation Paths");
-  lines.push("- tools/Workspace Manager/main.js: schema runtime validator now supports anyOf/allOf/not, propertyNames, and typed additionalProperties.");
-  lines.push("- tools/schemas/workspace.manifest.schema.json: removed duplicate palette alias key `palette-browser` from workspace tools contract.");
-  lines.push("- tools/schemas/tools/asset-browser.schema.json: tightened asset id/kind/source rules and stretchOverride placement.");
-  lines.push("- samples/phase-19/1902/sample.1902.workspace-all-tools.json: removed duplicate `palette-browser` block and normalized asset-browser asset ids.");
+  lines.push("- scripts/validate-json-contracts.mjs: validates game manifests against the current schema, Asset Manager V2 preview/background/bezel asset file paths, and deprecated game-manifest tool keys.");
   lines.push("");
   lines.push("## Validation Summary");
   lines.push(`- Tool schema rows: ${usageSummary.toolRows}`);