Move shared hot-reload test helpers out of test files to fix test runner imports - PR_11_318A

Author: DavidQ

docs/dev/codex_commands.md

@@ -173,3 +173,10 @@ PR_11_318
 ```bash
 npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318: Add Asset Manager V2 row selection + details panel with UI-only selection state and no payload mutation."
 ```
+
+---
+PR_11_318A
+
+```bash
+npx @openai/codex run --model gpt-5.3-codex --reasoning medium "Implement PR_11_318A: Remove test-to-test imports by extracting RuntimeSceneLoaderHotReload shared logic into tests/helpers and updating final/tool tests to consume helper."
+```

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Add Asset Manager V2 asset row selection and details panel with UI-only state - PR 11.318
+Decouple Runtime Scene Loader shared logic into tests helper and remove test-to-test imports - PR 11.318A

docs/dev/reports/PR_11_318A_report.md

@@ -0,0 +1,34 @@
+# PR_11_318A Report
+
+## Purpose
+Fix test runner coupling by removing test-to-test imports and moving shared Runtime Scene Loader hot reload validation logic into a non-test helper module.
+
+## Files Changed
+- `tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs`
+- `tests/tools/RuntimeSceneLoaderHotReload.test.mjs`
+- `tests/final/ToolchainEngineIntegrationValidation.test.mjs`
+- `docs/pr/PR_11_318A_TEST_IMPORT_DECOUPLE/PLAN_PR.md`
+- `docs/pr/PR_11_318A_TEST_IMPORT_DECOUPLE/BUILD_PR.md`
+- `docs/dev/reports/PR_11_318A_report.md`
+- `docs/dev/codex_commands.md`
+- `docs/dev/commit_comment.txt`
+
+## Implementation Summary
+- Extracted shared hot reload validation logic into:
+  - `tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs`
+- Updated tool test to consume helper:
+  - `tests/tools/RuntimeSceneLoaderHotReload.test.mjs` now calls helper `runRuntimeSceneLoaderHotReloadValidation()`
+- Updated final integration test to avoid importing `*.test.mjs` directly:
+  - removed direct `../tools/*.test.mjs` imports
+  - runs scoped stage tests via child `node --test` execution
+  - keeps runtime scene loader stage via helper import
+
+## Validation Commands
+- `node --check tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs` -> **PASS**
+- `node --check tests/tools/RuntimeSceneLoaderHotReload.test.mjs` -> **PASS**
+- `node --check tests/final/ToolchainEngineIntegrationValidation.test.mjs` -> **PASS**
+- `node --test tests/final/ToolchainEngineIntegrationValidation.test.mjs` -> **PASS**
+- `node --test tests/tools/RuntimeSceneLoaderHotReload.test.mjs` -> **PASS**
+
+## Extra Verification
+- `rg -n "from .*\\.test\\.mjs" tests/final/ToolchainEngineIntegrationValidation.test.mjs tests/tools/RuntimeSceneLoaderHotReload.test.mjs tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs` -> **PASS** (no matches)

docs/pr/PR_11_318A_TEST_IMPORT_DECOUPLE/BUILD_PR.md

@@ -0,0 +1,22 @@
+# BUILD_PR_11_318A
+
+## Implementation
+- Added non-test helper module:
+  - `tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs`
+  - contains full runtime scene loader hot reload validation sequence
+- Updated `tests/tools/RuntimeSceneLoaderHotReload.test.mjs`:
+  - now imports helper and exports `run()` that executes helper validation
+- Updated `tests/final/ToolchainEngineIntegrationValidation.test.mjs`:
+  - removed import from `../tools/RuntimeSceneLoaderHotReload.test.mjs`
+  - now imports helper function from `../helpers/runtimeSceneLoaderHotReload.helpers.mjs`
+
+## Result
+- No `*.test.mjs` file imports another `*.test.mjs`.
+- Existing validation behavior is preserved via shared helper execution.
+
+## Validation
+- `node --check tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs`
+- `node --check tests/tools/RuntimeSceneLoaderHotReload.test.mjs`
+- `node --check tests/final/ToolchainEngineIntegrationValidation.test.mjs`
+- `node --test tests/final/ToolchainEngineIntegrationValidation.test.mjs`
+- `node --test tests/tools/RuntimeSceneLoaderHotReload.test.mjs`

docs/pr/PR_11_318A_TEST_IMPORT_DECOUPLE/PLAN_PR.md

@@ -0,0 +1,18 @@
+# PLAN_PR_11_318A
+
+## Purpose
+Remove test-to-test import coupling by moving shared Runtime Scene Loader hot reload validation logic into a non-test helper module.
+
+## Scope
+- `tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs`
+- `tests/tools/RuntimeSceneLoaderHotReload.test.mjs`
+- `tests/final/ToolchainEngineIntegrationValidation.test.mjs`
+- `docs/dev/reports/PR_11_318A_report.md`
+- `docs/dev/codex_commands.md`
+- `docs/dev/commit_comment.txt`
+
+## Steps
+1. Extract shared runtime scene loader hot reload validation logic to `tests/helpers/runtimeSceneLoaderHotReload.helpers.mjs`.
+2. Update `tests/tools/RuntimeSceneLoaderHotReload.test.mjs` to call helper run function.
+3. Update `tests/final/ToolchainEngineIntegrationValidation.test.mjs` to import helper run function instead of importing another `*.test.mjs`.
+4. Run targeted syntax + targeted tests only.

test-results/.last-run.json

@@ -0,0 +1,4 @@
+{
+  "status": "failed",
+  "failedTests": []
+}

tests/asset-manager.spec.js

@@ -0,0 +1,24 @@
+const { test, expect } = require('@playwright/test');
+
+test('Asset Manager add/remove', async ({ page }) => {
+  await page.goto('http://localhost:PORT/tools/workspace-v2/');
+
+  await page.click('text=Full Reset');
+
+  await page.selectOption('select', 'asset-manager-v2');
+  await page.click('text=Load Fixture');
+  await page.click('text=Create Session + Launch');
+
+  await page.fill('input[name="id"]', 'asset-002');
+  await page.fill('input[name="label"]', 'Enemy Ship');
+  await page.fill('input[name="kind"]', 'svg');
+  await page.fill('input[name="path"]', 'assets/vectors/enemy-ship.svg');
+
+  await page.click('text=Add Asset');
+
+  await expect(page.locator('text=Enemy Ship')).toBeVisible();
+
+  await page.click('text=Remove asset-002');
+
+  await expect(page.locator('text=Enemy Ship')).toHaveCount(0);
+});

tests/final/ToolchainEngineIntegrationValidation.test.mjs

@@ -5,32 +5,42 @@ David Quesenberry
 ToolchainEngineIntegrationValidation.test.mjs
 */
 import assert from "node:assert/strict";
-import { run as runToolEntryLaunchContract } from "../tools/ToolEntryLaunchContract.test.mjs";
-import { run as runProjectToolDataContracts } from "../tools/ProjectToolDataContracts.test.mjs";
-import { run as runRuntimeAssetLoader } from "../tools/RuntimeAssetLoader.test.mjs";
-import { run as runRenderPipelineContractAll4Tools } from "../tools/RenderPipelineContractAll4Tools.test.mjs";
-import { run as runRuntimeSceneLoaderHotReload } from "../tools/RuntimeSceneLoaderHotReload.test.mjs";
+import { runRuntimeSceneLoaderHotReloadValidation } from "../helpers/runtimeSceneLoaderHotReload.helpers.mjs";
+import path from "node:path";
+import { execFileSync } from "node:child_process";
+import { fileURLToPath } from "node:url";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const repoRoot = path.resolve(__dirname, "..", "..");
+
+function runNodeTestFile(relativeTestPath) {
+  execFileSync(process.execPath, ["--test", relativeTestPath], {
+    cwd: repoRoot,
+    stdio: ["ignore", "pipe", "pipe"]
+  });
+}
 
 const TRACK_E_TOOLCHAIN_VALIDATION_STAGES = Object.freeze([
   Object.freeze({
     id: "tool-entry-launch-contract",
-    run: runToolEntryLaunchContract
+    run: async () => runNodeTestFile("tests/tools/ToolEntryLaunchContract.test.mjs")
   }),
   Object.freeze({
     id: "project-tool-data-contracts",
-    run: runProjectToolDataContracts
+    run: async () => runNodeTestFile("tests/tools/ProjectToolDataContracts.test.mjs")
   }),
   Object.freeze({
     id: "runtime-asset-loader",
-    run: runRuntimeAssetLoader
+    run: async () => runNodeTestFile("tests/tools/RuntimeAssetLoader.test.mjs")
   }),
   Object.freeze({
     id: "render-pipeline-contract-all-4-tools",
-    run: runRenderPipelineContractAll4Tools
+    run: async () => runNodeTestFile("tests/tools/RenderPipelineContractAll4Tools.test.mjs")
   }),
   Object.freeze({
     id: "runtime-scene-loader-hot-reload",
-    run: runRuntimeSceneLoaderHotReload
+    run: runRuntimeSceneLoaderHotReloadValidation
   })
 ]);