Remove Text to Speech V2 queue mode and fix direct launch layout - PR_26130_026-text-to-speech-v2-queue-removal-and-layout-fix

Author: DavidQ

docs/dev/reports/PR_26130_026-text-to-speech-v2-queue-removal-and-layout-fix.md

@@ -0,0 +1,58 @@
+# PR_26130_026-text-to-speech-v2-queue-removal-and-layout-fix
+
+## Summary
+
+Updated Text to Speech V2 and direct Workspace Manager V2/tool references for Queue Mode removal, canonical `text2speech-V2` launch paths, textarea sizing, status Clear behavior, and Speech Options internal scrolling.
+
+## Changes
+
+- Removed `queueMode` from Text to Speech V2 schema, defaults, sample JSON, UI controls, control hydration, engine runtime metadata, import/copy/export payloads, and positive Playwright expectations.
+- Kept `queueMode` only in negative Playwright coverage to prove payloads containing the field fail schema validation.
+- Removed the misspelled `text2speach-V2` redirect page, redirect script, alias schema file, alias sample JSON, tool registry alias, and Workspace Manager migration code.
+- Updated Text to Speech V2 to use direct canonical `text2speech-V2` references for registry, workspace launch, sample launch, schema validation, and tests.
+- Changed browser speech playback so Speak enqueues through `speechSynthesis.speak()` without a Queue Mode field or mode log; Stop remains the explicit queue clear action.
+- Made `textarea#text2speech-V2SpeechText` fill `div#text2speech-V2TextContent.accordion-v2__content`, resize with accordion height, and keep manual resize disabled.
+- Added internal vertical scrolling for Speech Options and preserved internal scrolling for Summary/Named Sentences.
+- Stopped Clear button click propagation so Clear no longer toggles the Status accordion.
+
+## Schema And Migration Notes
+
+- `tools/schemas/tools/text2speech-V2.schema.json` remains a root array schema with `minItems: 1`.
+- Each named speech item now requires: `id`, `name`, `text`, `gender`, `language`, `voice`, `voiceAge`, `volume`, `rate`, `pitch`, `characterPreset`, and `ssmlLikePreset`.
+- `queueMode` is no longer allowed by `additionalProperties: false`.
+- No `queueMode` import migration path is included in this PR. Existing payloads containing `queueMode` are rejected before render/import/save with an actionable schema validation message.
+- The deleted `text2speach-V2` route/schema/sample are no longer redirect aliases. Legacy URL checks return 404 in Playwright, while canonical `text2speech-V2` launch paths continue to work.
+
+## Validation
+
+- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs` passed.
+- `node --check tests/runtime/SampleStandaloneToolDataFlow.test.mjs` passed.
+- `node --check` passed for changed Text to Speech V2/runtime JS files.
+- `git diff --check` passed.
+- `npm run test:workspace-v2` passed: 35 tests.
+- Playwright V8 coverage report was produced at `docs/dev/reports/playwright_v8_coverage_report.txt`.
+- Coverage guardrail was produced at `docs/dev/reports/coverage_changed_js_guardrail.txt` with no changed-runtime-JS warnings.
+
+## Playwright Coverage
+
+- Queue Mode is absent from UI/schema/sample/exported JSON.
+- Payloads containing `queueMode` fail schema validation.
+- Text to Speech V2 direct launch works from tools index, workspace launch, and sample 1903 wiring.
+- Legacy `text2speach-V2` path/schema/sample references no longer redirect or load.
+- Text to Speak textarea fills its accordion content and has resize disabled.
+- Clear does not toggle the Status accordion.
+- Speech Options scrolls internally.
+- Workspace Manager V2 keeps Text to Speech V2 available after repo and game selection.
+
+## Full Samples Smoke Test
+
+Skipped. This PR is limited to Text to Speech V2 direct behavior and Workspace Manager V2 launch references, and `npm run test:workspace-v2` covers the requested behavior. The full samples smoke test remains out of scope because it is broad and long-running.
+
+## Manual Validation
+
+1. Open `/tools/text2speech-V2/index.html?samplePresetPath=/samples/phase-19/1903/sample.1903.text2speech-V2.json`.
+2. Confirm Queue Mode is not visible and Output Summary contains only the named speech item array.
+3. Confirm Import JSON rejects an item containing `queueMode`.
+4. Confirm the Text to Speak textarea expands with the accordion and has no manual resize handle.
+5. Confirm clicking Clear empties Status without collapsing the Status accordion.
+6. Confirm `/tools/text2speach-V2/index.html` no longer redirects to the canonical tool.

samples/phase-19/1903/sample.1903.text2speach-V2.json

@@ -10,7 +10,6 @@
     "volume": 1,
     "rate": 1,
     "pitch": 1,
-    "queueMode": "replace",
     "characterPreset": "narrator",
     "ssmlLikePreset": "normal"
   },
@@ -25,23 +24,35 @@
     "volume": 1,
     "rate": 1.2,
     "pitch": 1.4,
-    "queueMode": "append",
     "characterPreset": "dramatic",
     "ssmlLikePreset": "normal"
   },
   {
     "id": "alert-warning",
     "name": "Alert warning",
     "text": "Warning. Incoming hazard detected. Please confirm the next action.",
-    "gender": "female-preferred",
-    "language": "en-US",
-    "voice": "mock-microsoft-zira",
-    "voiceAge": "adult",
-    "volume": 0.9,
-    "rate": 1.3,
+    "characterPreset": "alert",
+    "gender": "any",
+    "language": "ja-JP",
     "pitch": 0.9,
-    "queueMode": "replace",
+    "rate": 1.3,
+    "ssmlLikePreset": "normal",
+    "voice": "Google 日本語",
+    "voiceAge": "adult",
+    "volume": 0.9
+  },
+  {
+    "id": "alert-warning-2",
+    "name": "Alert warning 2",
+    "text": "Warning. Incoming hazard detected. Please confirm the next action.",
     "characterPreset": "alert",
-    "ssmlLikePreset": "normal"
+    "gender": "any",
+    "language": "zh-CN",
+    "pitch": 0.9,
+    "rate": 1.3,
+    "ssmlLikePreset": "normal",
+    "voice": "Google 普通话（中国大陆）",
+    "voiceAge": "adult",
+    "volume": 0.9
   }
-]
+]

samples/phase-19/1903/sample.1903.text2speech-V2.json

@@ -33,11 +33,6 @@ const TEXT_TO_SPEECH_VOICE_AGE_PRESET_DEFAULTS = Object.freeze({
   teen: Object.freeze({ pitchOffset: 0.2, rateMultiplier: 1.08 })
 });
 
-const TEXT_TO_SPEECH_QUEUE_MODE_OPTIONS = Object.freeze([
-  Object.freeze({ label: "Append to queue", value: "append" }),
-  Object.freeze({ label: "Replace current speech", value: "replace" })
-]);
-
 const TEXT_TO_SPEECH_CHARACTER_PRESET_OPTIONS = Object.freeze([
   Object.freeze({ label: "Manual", value: "manual" }),
   Object.freeze({ label: "Alert", value: "alert" }),
@@ -87,7 +82,6 @@ const TEXT_TO_SPEECH_QUEUE_ITEM_REQUIRED_FIELDS = Object.freeze([
   "volume",
   "rate",
   "pitch",
-  "queueMode",
   "characterPreset",
   "ssmlLikePreset"
 ]);
@@ -97,7 +91,6 @@ const TEXT_TO_SPEECH_DEFAULT_OPTIONS = Object.freeze({
   gender: "any",
   language: "en-US",
   pitch: TEXT_TO_SPEECH_CHARACTER_PRESET_DEFAULTS.manual.pitch,
-  queueMode: "replace",
   rate: TEXT_TO_SPEECH_CHARACTER_PRESET_DEFAULTS.manual.rate,
   ssmlLikePreset: TEXT_TO_SPEECH_CHARACTER_PRESET_DEFAULTS.manual.ssmlLikePreset,
   voice: "",
@@ -119,7 +112,6 @@ export {
   TEXT_TO_SPEECH_GENDER_FILTER_OPTIONS,
   TEXT_TO_SPEECH_LANGUAGE_OPTIONS,
   TEXT_TO_SPEECH_QUEUE_ITEM_REQUIRED_FIELDS,
-  TEXT_TO_SPEECH_QUEUE_MODE_OPTIONS,
   TEXT_TO_SPEECH_RANGE_DEFAULTS,
   TEXT_TO_SPEECH_SCHEMA_ID,
   TEXT_TO_SPEECH_SSML_LIKE_PRESET_DEFAULTS,

src/engine/audio/TextToSpeechDefaults.js

@@ -151,7 +151,6 @@ class TextToSpeechEngine {
     gender = TEXT_TO_SPEECH_DEFAULTS.gender,
     language = TEXT_TO_SPEECH_DEFAULTS.language,
     pitch = TEXT_TO_SPEECH_DEFAULTS.pitch,
-    queueMode = TEXT_TO_SPEECH_DEFAULTS.queueMode,
     rate = TEXT_TO_SPEECH_DEFAULTS.rate,
     speechItemId = "",
     speechItemName = "",
@@ -166,15 +165,6 @@ class TextToSpeechEngine {
       return firstUtterance;
     }
 
-    if (queueMode !== "append" && queueMode !== "replace") {
-      return { message: `Unsupported ${TEXT_TO_SPEECH_DISPLAY_NAME} queueMode: ${queueMode}.`, ok: false };
-    }
-
-    if (queueMode === "replace") {
-      this.speechSynthesis.cancel();
-      this.queuedSpeechItems.clear();
-    }
-
     this.queueSequence += 1;
     const selectedSpeechItemId = String(speechItemId || speechItemName || `speech-item-${Date.now().toString(36)}`);
     const queuedSpeechItemId = `${selectedSpeechItemId || "speech-item"}::${this.queueSequence}`;
@@ -184,7 +174,6 @@ class TextToSpeechEngine {
       language: firstUtterance.utterance.lang,
       name: queuedSpeechItemName,
       pitch: firstUtterance.utterance.pitch,
-      queueMode,
       rate: firstUtterance.utterance.rate,
       speechItemId: selectedSpeechItemId,
       status: "queued",
@@ -214,7 +203,6 @@ class TextToSpeechEngine {
       ok: true,
       pitch: firstUtterance.utterance.pitch,
       queuedSpeechItems: this.queuedSpeechItemList(),
-      queueMode,
       rate: firstUtterance.utterance.rate,
       speechItemId: selectedSpeechItemId,
       speechItemName: queuedSpeechItemName,