Skip to content

Commit 08492f2

Browse files
author
DavidQ
committed
Move state selection to object level and place shape actions under selected shape list - PR_26133_049-state-selector-and-object-shape-action-placement
1 parent a7826c4 commit 08492f2

7 files changed

Lines changed: 340 additions & 185 deletions

File tree

docs/dev/reports/playwright_v8_coverage_report.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# PR_26133_048 Playwright V8 Coverage Report
1+
# PR_26133_049 Playwright V8 Coverage Report
22

3-
Task: PR_26133_048-frame-state-schema-ssot-and-palette-filter-layout
3+
Task: PR_26133_049-state-selector-and-object-shape-action-placement
44
Date: 2026-05-15
55

66
## Result
@@ -10,7 +10,7 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
1010
- Coverage source: Playwright/Chromium built-in V8 coverage.
1111
- Thresholds: none enforced.
1212
- Coverage is advisory for this PR.
13-
- Source report: `docs/dev/reports/playwright_v8_coverage.txt`.
13+
- Source report: `docs/dev/reports/playwright_v8_coverage_report.txt`.
1414

1515
## Exercised Tool Entry Points
1616

@@ -24,10 +24,8 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
2424
## Relevant Runtime Coverage
2525

2626
```text
27-
(80%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 97/97; executed functions 4/5
28-
(90%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 3187/3187; executed functions 331/369
29-
(95%) tools/object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js - executed lines 409/409; executed functions 53/56
30-
(91%) tools/workspace-manager-v2/js/services/WorkspaceManagerV2ContextService.js - executed lines 1598/1598; executed functions 145/159
27+
(83%) tools/object-vector-studio-v2/js/bootstrap.js - executed lines 105/105; executed functions 5/6
28+
(95%) tools/object-vector-studio-v2/js/ToolStarterApp.js - executed lines 5014/5014; executed functions 518/548
3129
```
3230

3331
## Guardrail
@@ -38,4 +36,4 @@ PASS - Coverage reporting was generated during `npm run test:workspace-v2`.
3836

3937
## PR-Specific Note
4038

41-
The Workspace V2 run exercised Object Vector Studio V2 palette sort layout, frame-tile state dropdown/help controls, Object Vector state schema validation, Workspace Manager game-manifest validation with an external Object Vector schema reference, and Asteroids runtime object-vector rendering.
39+
The Workspace V2 run exercised Object Vector Studio V2 state selection from object tiles, selected-state frame timelines, selected-shape action placement, palette Width layout, Object Vector schema validation, and Asteroids runtime object-vector rendering.
Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# PR_26133_048 Workspace V2 Playwright Results
1+
# PR_26133_049 Workspace V2 Playwright Results
22

3-
Task: PR_26133_048-frame-state-schema-ssot-and-palette-filter-layout
3+
Task: PR_26133_049-state-selector-and-object-shape-action-placement
44
Date: 2026-05-15
55

66
## Result
@@ -14,14 +14,12 @@ PASS - `npm run test:workspace-v2` completed successfully.
1414

1515
## PR-Specific Coverage
1616

17-
- Verified Hue, Sat, Bri, and Name palette sort controls fit on one line with reduced text and icon sizing.
18-
- Verified `thrust` is removed from the Object Vector Studio V2 state enum.
19-
- Verified `game.manifest.schema.json` references the Object Vector Studio V2 `objectState` definition instead of duplicating a local state enum.
20-
- Verified Asteroids runtime state selection now uses `move` for thrust visuals.
21-
- Verified each frame tile renders a compact state dropdown directly under the frame tile label.
22-
- Verified each frame tile renders a `?` hover help button using the contextual state help text.
17+
- Verified state dropdown/help controls render under the selected object tile, not inside frame tiles.
18+
- Verified state tiles select the current object state while frames remain scoped to the selected state timeline.
19+
- Verified selected shape move/order/group controls render as icon-only buttons under `object-vector-studio-v2__object-tile-shapes`.
20+
- Verified moved shape actions still update z-order and grouping behavior.
21+
- Verified Palette Width input has enough visible width for `xx.x` values while Paint, Stroke, and Width remain on one line.
2322

2423
## Additional Validation
2524

26-
- Targeted Playwright checks passed for Object Vector Studio V2 shell/schema/palette layout and animation frame controls.
2725
- `git diff --check` passed.

0 commit comments

Comments
 (0)