Add Workspace all-tools integration sample with JSON-backed tool data - PR 11.11 Rebuild sample 1902 as clean Workspace all-tools integration without palette sidecar - PR 11.12

Author: DavidQ

docs/dev/codex_commands.md

@@ -3,18 +3,17 @@
 model: gpt-5.3-codex
 reasoning: medium
 
-Apply PR_11_10_ALL_SAMPLES_STANDALONE_TOOL_JSON_SSOT_ENFORCEMENT.
+Apply PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS.
 
 Required:
-- Scan every sample under samples/ for standalone tool ties.
-- Enforce JSON as the only canonical source for all tool-visible data.
-- Include color, palette, fill, stroke, style, and preview/render config in the SSoT check.
-- Remove or demote JS mirror data modules that duplicate JSON payloads.
-- Ensure standalone tools load sample JSON directly.
-- Use standalone sample/tool validation as primary proof, not workspace-only validation.
-- Preserve empty state when no explicit JSON exists.
-- Do not add fallback/default/hidden sample data.
-- Do not scrape JS source.
+- Rebuild sample 1902 as a clean Workspace all-tools integration sample.
+- Delete `samples/phase-19/1902/sample.1902.palette.json`; there should be no palette sidecar.
+- Normalize `sample.1902.workspace-all-tools.json` into a single clear workspace manifest/payload with one source of truth.
+- Remove duplicated palette/config/payload sections and unrelated garbage payloads.
+- Ensure Workspace recognizes every active workspace-supported tool, not only Palette.
+- Sample 1902 page primary action must open Workspace with the all-tools manifest, not just standalone tool links.
+- Standalone tool samples remain separate and unchanged.
+- Do not add fallback/default/hidden data.
 - Do not modify start_of_day folders.
-- Add validation report at docs/dev/reports/PR_11_10_ALL_SAMPLES_STANDALONE_TOOL_JSON_SSOT_ENFORCEMENT_report.md.
-- Return ZIP artifact at tmp/PR_11_10_ALL_SAMPLES_STANDALONE_TOOL_JSON_SSOT_ENFORCEMENT_delta.zip.
+- Add validation report at docs/dev/reports/PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS_report.md.
+- Return ZIP artifact at tmp/PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS_delta.zip.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Enforce JSON SSoT for all sample standalone tool data including colors and styles - PR 11.10
+Rebuild sample 1902 as clean Workspace all-tools integration without palette sidecar - PR 11.12

docs/dev/reports/PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE_report.md

@@ -0,0 +1,82 @@
+# PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE Report
+
+## Result
+- PASS
+
+## Sample Path
+- `samples/phase-19/1902/`
+
+## Tools Included
+- vector-map-editor
+- vector-asset-studio
+- tile-map-editor
+- parallax-editor
+- sprite-editor
+- skin-editor
+- asset-browser
+- palette-browser
+- state-inspector
+- replay-visualizer
+- performance-profiler
+- physics-sandbox
+- asset-pipeline-tool
+- tile-model-converter
+- 3d-json-payload-normalizer
+- 3d-asset-viewer
+- 3d-camera-path-editor
+
+## Tools Excluded With Reason
+- `sprite-editor-old-keep`: inactive legacy entry (`active=false`, `visibleInToolsList=false`) in `tools/toolRegistry.js`.
+
+## JSON Payload Files Created
+- `samples/phase-19/1902/sample.1902.workspace-all-tools.json`
+- `samples/phase-19/1902/sample.1902.palette.json`
+
+## Validation Performed
+1. Tool coverage check against active + visible registry tools.
+   - `active_visible_count=17`
+   - `included_count=17`
+   - `missing=[]`
+   - `extra=[]`
+2. Contract presence check for each included tool block inside `sample.1902.workspace-all-tools.json`.
+   - All 17 tool payload blocks present.
+3. Syntax check.
+   - `node --check samples/phase-19/1902/main.js` PASS.
+4. Sample-local destination hint rule check.
+   - `rg -n "games/<project>/" samples/phase-19/1902 samples/metadata/samples.index.metadata.json` produced no matches.
+5. Launch smoke regression coverage.
+   - `npm run test:launch-smoke -- --tools` PASS.
+   - Summary: `PASS=287 FAIL=0 TOTAL=287` (includes sample `1902`, Workspace Manager, and all active tools).
+
+## JSON SSoT Confirmation
+- The workspace integration sample uses explicit sample-owned JSON payload files as source-of-truth for tool-visible fields.
+- Unified payload includes explicit blocks for palette, fill/stroke/editor options, preview/render docs, asset catalog entries, and per-tool input blocks.
+- Sprite Editor required palette input is explicitly wired through metadata `roundtripToolPresets.palettePath` to canonical `sample.1902.palette.json`.
+
+## Workspace Switching / Fullscreen Notes
+- Workspace launch target is sample-owned and explicit:
+  - `/tools/Workspace%20Manager/index.html?tool=vector-map-editor&sampleId=1902&samplePresetPath=/samples/phase-19/1902/sample.1902.workspace-all-tools.json`
+- No Workspace shell/tool runtime implementation code was modified in this PR; existing PREV/NEXT and fullscreen behavior remains inherited.
+- Launch smoke passed for Workspace Manager and all tools after this change.
+
+## Fallback / Hidden Data Confirmation
+- No fallback/default/hidden sample data was added.
+- No canonical tool data was hardcoded in JS runtime; canonical sample data is in sample-owned JSON.
+
+## Index Update
+- `samples/index.html` updated with a line clarifying workspace integration samples launch Workspace Manager.
+
+## Start_of_day Confirmation
+- No `start_of_day` folders were modified.
+
+## Files Changed For This PR
+- `samples/index.html`
+- `samples/metadata/samples.index.metadata.json`
+- `samples/phase-19/1902/index.html`
+- `samples/phase-19/1902/main.js`
+- `samples/phase-19/1902/sample.1902.workspace-all-tools.json`
+- `samples/phase-19/1902/sample.1902.palette.json`
+- `samples/phase-19/1902/assets/images/preview.svg`
+- `samples/phase-19/1902/assets/data/parallax/sample-0306-far.svg`
+- `samples/phase-19/1902/assets/data/parallax/sample-0306-near.svg`
+- `docs/dev/reports/PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE_report.md`

docs/dev/reports/REPORT_PR_11_11.md

@@ -0,0 +1,10 @@
+# REPORT_PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE
+
+## Summary
+Adds a dedicated sample that validates Workspace orchestration across every active tool.
+
+## Target
+- Workspace launches as the sample target.
+- Every active tool is represented.
+- Tool-visible data is JSON SSoT.
+- Standalone tool samples remain separate.

docs/dev/reports/REPORT_PR_11_12.md

@@ -0,0 +1,13 @@
+# REPORT_PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS
+
+## Summary
+Rebuilds the broken 1902 workspace integration sample instead of polishing the incorrect output.
+
+## Evidence
+Uploaded 1902 payload contains a separate palette sidecar and duplicated palette/config/payload sections. Workspace currently recognizes Palette as the only valid tool.
+
+## Target
+- One clean workspace JSON payload.
+- No palette sidecar.
+- Workspace launches every active supported tool.
+- Sample page validates Workspace, not standalone tool links.

docs/pr/PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE/BUILD.md

@@ -0,0 +1,51 @@
+# BUILD_PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE
+
+## Required Codex Work
+
+### 1. Choose sample placement
+Add the sample in the next appropriate samples phase/location based on current repo conventions.
+
+Preferred naming:
+- Title: `Workspace All Tools Integration`
+- Purpose: workspace orchestration sample for every active tool
+
+### 2. Add JSON SSoT payload
+Create sample-owned JSON payloads for each tool, or one workspace manifest that references explicit per-tool JSON payloads.
+
+Required:
+- Asset Browser data
+- Sprite Editor data
+- Tilemap Studio data
+- Vector Asset Studio data
+- Vector Map Editor data
+- all color/palette/fill/stroke/style config in JSON
+- import/export destination hints must be sample-local, not `games/<project>/...`
+
+### 3. Launch workspace
+The sample page must launch Workspace as the test target.
+This is intentionally different from standalone tool samples.
+
+### 4. Tool coverage
+Use the tool registry to identify every active workspace-supported tool.
+If a tool is inactive/deprecated, document why it is excluded.
+
+### 5. Validation report
+Create:
+docs/dev/reports/PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE_report.md
+
+Report must include:
+- sample path
+- tools included
+- tools excluded with reason
+- JSON payload files created
+- validation that all tool-visible data is JSON-owned
+- validation that workspace switching works across every included tool
+- validation that fullscreen enter/exit still works
+- confirmation no fallback/default/hidden data
+- confirmation no start_of_day changes
+
+## Constraints
+- One PR purpose only.
+- No broad tool refactor.
+- No unrelated sample changes.
+- No schema rewrite unless minimal compatible payload addition is required.

docs/pr/PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE/PLAN.md

@@ -0,0 +1,34 @@
+# PLAN_PR_11_11_WORKSPACE_ALL_TOOLS_INTEGRATION_SAMPLE
+
+## Purpose
+Add one workspace integration sample that launches Workspace with every active tool using explicit JSON-backed data.
+
+## Scope
+- Add a new sample dedicated to Workspace + all tools integration.
+- The sample must use Workspace as the container.
+- The sample must include every active tool:
+  - Asset Browser
+  - Sprite Editor
+  - Tilemap Studio
+  - Vector Asset Studio
+  - Vector Map Editor
+  - any currently active workspace-supported tool discovered in tool registry
+- All tool-visible data must come from JSON.
+- No fallback/hidden/default data.
+- Do not modify start_of_day folders.
+
+## Non-Goals
+- Do not replace standalone tool samples.
+- Do not move tools into samples.
+- Do not create new tool features.
+- Do not hardcode sample data in JS.
+
+## Acceptance
+- New sample appears in samples/index.html.
+- Opening the sample launches Workspace.
+- Workspace can switch through every active tool.
+- Each tool loads explicit JSON data.
+- Each tool has first selection and visible state where data exists.
+- Fullscreen header behavior still works.
+- PREV/NEXT navigation still works.
+- Report confirms standalone samples remain separate from this workspace integration sample.

docs/pr/PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS/BUILD.md

@@ -0,0 +1,79 @@
+# BUILD_PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS
+
+## Required Codex Work
+
+### 1. Remove incorrect palette sidecar
+Delete:
+`samples/phase-19/1902/sample.1902.palette.json`
+
+Do not replace it with another sidecar unless an existing schema strictly requires it and the report proves why.
+
+### 2. Rebuild workspace JSON
+Rewrite/normalize:
+`samples/phase-19/1902/sample.1902.workspace-all-tools.json`
+
+Rules:
+- one manifest/payload source only
+- no duplicated `palette` blocks in multiple places
+- no duplicated `config` and `payload` copies
+- no unrelated sample dump data
+- one clear tool payload section per active workspace-supported tool
+- all color/style/palette data lives inside the relevant tool payload or shared workspace theme section
+- no hidden fallback/default data
+
+### 3. Fix tool availability
+Ensure Workspace resolves all included tools from registry/tool ids correctly.
+Current bad behavior: only Palette is recognized as valid.
+
+Workspace must expose all active workspace-supported tools, including at minimum:
+- Vector Map Editor
+- Vector Asset Studio
+- Tilemap Studio
+- Parallax Scene Studio
+- Sprite Editor
+- Primitive Skin Editor
+- Asset Browser / Import Hub
+- State Inspector
+- Replay Visualizer
+- Performance Profiler
+- Physics Sandbox
+- Asset Pipeline Tool
+- Tile Model Converter
+- 3D JSON Payload Normalizer
+- 3D Asset Viewer
+- 3D Camera Path Editor
+
+If any listed tool is inactive/not workspace-supported, exclude it only with report justification.
+
+### 4. Fix sample page behavior
+Sample 1902 page must validate Workspace integration.
+Primary action must open Workspace with the all-tools manifest.
+
+Do not make the page a list of standalone tool links as the main proof.
+
+Standalone links may remain only as secondary references if clearly labeled, but primary validation is Workspace.
+
+### 5. Keep standalone sample testing separate
+Do not alter standalone tool sample expectations from PR 11.10.
+
+### 6. Validation report
+Create:
+docs/dev/reports/PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS_report.md
+
+Report must include:
+- files changed
+- files deleted
+- final sample 1902 JSON structure summary
+- included tools
+- excluded tools with reason
+- proof Workspace shows more than Palette and includes all expected active tools
+- confirmation no palette sidecar remains
+- confirmation no duplicated config/payload ownership
+- confirmation no fallback/default/hidden data
+- confirmation no start_of_day changes
+
+## Constraints
+- One PR purpose only.
+- Do not broadly refactor Workspace.
+- Do not change standalone sample links elsewhere.
+- Do not modify game samples.

docs/pr/PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS/PLAN.md

@@ -0,0 +1,31 @@
+# PLAN_PR_11_12_REBUILD_SAMPLE_1902_WORKSPACE_ALL_TOOLS
+
+## Purpose
+Rebuild sample 1902 as a clean Workspace all-tools integration sample.
+
+## Problem
+PR 11.11 produced a noisy/incorrect 1902 sample:
+- separate `sample.1902.palette.json` exists, but there should be no palette sidecar for this sample
+- workspace payload contains duplicated palette sections
+- Workspace loads Palette as the only valid tool
+- sample page links standalone tools instead of validating Workspace orchestration
+- sample payload contains too much unrelated mixed data and duplicate config/payload sections
+
+## Scope
+- Sample 1902 only
+- Workspace all-tools integration only
+- Remove palette sidecar file and duplicate palette ownership
+- Rebuild sample 1902 JSON as one clean workspace manifest/payload
+- Make sample page launch Workspace as the primary target
+- Include every active workspace-supported tool with explicit JSON-backed data
+- Do not modify standalone tool samples
+- Do not modify start_of_day folders
+
+## Acceptance
+- No `sample.1902.palette.json`
+- No duplicated top-level `palette`, `config.palette`, and `payload.palette` ownership
+- Workspace opens with all active tools available, not only Palette
+- Sample page primary action opens Workspace, not standalone tool links
+- Tool-specific data is grouped clearly per tool
+- All colors/palettes/styles are inside the single 1902 workspace JSON payload
+- Report documents included/excluded tools and why

samples/index.html

@@ -24,6 +24,7 @@ <h1>Samples Hub</h1>
         Browse phase-based sample collections that demonstrate engine systems and gameplay patterns.
         Start from the phase links below and open individual sample entries from each phase page.
         Tool preset launch samples are listed alongside gameplay samples in this hub.
+        Workspace integration samples launch Workspace Manager directly when opened.
       </p>
     </section>