[Bug Report]: Gilded Glory Armor is inconsistent.

[Creepachu43]

Describe the bug; What happened?

The Gilded Glory Armor activates when the wearer has Hero Of The Village. Right clicking with 10 emeralds give the wearer Hero of the village until they die. However, the problem is with the Hero of the Village effect it gives. It seems that the armor gives the player 2 seconds of Hero of the Village and when the timer goes down to 1 second it is reset to 2. However, if the player is unloaded for more than 2 seconds, for instance, when teleporting or loading a new area via JourneyMap, the effect is not refreshed. I was able to fix this by creating a command block chain which checks if a player has hero of the village and then if they are wearing the gilded glory armor and if so then it applies Hero of the Villager for 9999 seconds, which is an indefinite effect in Minecraft. This seems to have fixed the issue and the effect still goes away after the user dies and false idol activates.

Expected Behavior

Instead of the Hero of the village effect being set to 2 seconds it should be set to 9999.

Mod Version

1.19.2

Minecraft Launcher

CurseForge

Operating System

Windows

Modpack

BigChadGuysPlus

Additional context

Thank you for reading, hopefully this actually works as it has for me and is helpful for the betterment of the mod. I just wanted to bring it up since I noticed it and thought it might be worth looking in to.

[chronosacaria]

Thanks for catching this edge case :)

[Creepachu43]

Thanks for catching this edge case :)
Yeah of course, happy to help. Also I meant that the effect goes away as intended when Gilded Totem activates, not when False Idol activates, but you probably assumed that. :)