Issue with subtracting health

[Valgorn]

Hello, I play with an origin mod my friend made and we cant use your mod because it doesnt allow for abilities that cost health. We are currently on the Fantasy MC modpack and would love to not have to disable your mod each time we update. Thank you vary much for taking the time to check this out and I hope its an easy fix. If you need more info let me know.

Here is a code example of what his mod is trying to do:

{
    "name": "Subtract HP",
    "description": "Subtracts 2 health on activation",
    "type": "origins:active_self",
    "cooldown": 1,
    "key": {
        "key": "key.origins.primary_active"
    },
    "entity_action":
    {
        "type": "origins:heal",
        "amount": -2
    }
}

[TheWinABagel]

Is there not a origins:damage type? Negative healing is kinda strange

[Valgorn]

we're using negative damage to avoid triggering damage visuals, since the ability has a health cost, not actual damage.

[TheWinABagel]

Ah, makes sense. 99% sure I know the issue, will investigate

[Valgorn]

Thanks

[Valgorn]

hello again! any update on this? it looks like it could be caused by return amount >= 0 ? amount : 0; at line 94 of LivingEntityMixin.java?