perf(namekey): Remove superfluous AsciiString allocations for name key lookups #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons, misc formatting tweaks
xezon
added
Minor
1 task
Skyaero42
reviewed
Dec 7, 2025
| #include "Common/AsciiString.h" | ||
|
|
||
| //------------------------------------------------------------------------------------------------- | ||
| /** |
There was a problem hiding this comment.
Is there a particular reason why removing /**? A quick search yields its applied over 9,000 in the code. Do we want to fix it everywhere?
Author
There was a problem hiding this comment.
I am in favor of replacing all block comments with inline comments. It caused syntax coloring issues in Visual Studio.
xezon
commented
Dec 8, 2025
| void load( Int textureSize ); ///< load images | ||
|
|
||
| const Image *findImageByName( const AsciiString& name ); ///< find image based on name | ||
| const Image *findImageByName( const AsciiString& name ) const; ///< find image based on name |
Author
There was a problem hiding this comment.
this looks wrong in isolation. Would make first commit fail compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change removes superfluous
AsciiStringallocations for name key lookups. It was applied by hand. It is split into 2 commits for a cleaner file diff.It cuts many allocations and can help loading and runtime performance a bit.
Adjacent to Name Key, some functions that did Name Key lookups and do not necessarily need to be given an
AsciiStringhave been given a new function overload takingconst char*.The identified and affected functions are:
There are probably plenty more functions of this kind but this change is already large enough as is and this seemed to be all directly related to Name Key things.
TODO