forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 125
bugfix(mouse): Prevent cursor capture when mouse is outside of app window #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyaero42
approved these changes
Dec 5, 2025
Skyaero42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, this fixes the problem.
…Main, Mouse, HeaderTemplate (#1939)
aa9904c to
ca4c963
Compare
Author
|
Now also renamed the Replicated in Generals with conflicts in WinMain.cpp |
xezon
added a commit
that referenced
this pull request
Dec 7, 2025
…Main, Mouse, HeaderTemplate (#1939)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something is not working right, typically is user facing
Input
Minor
Severity: Minor < Major < Critical < Blocker
ThisProject
The issue was introduced by this project, or this task is specific to this project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
The first commit applies a bit of refactoring to WinMain and Mouse because there is some chaos.
The second commit prevents the cursor capture when the mouse is outside of the app window. This avoid inconcienences when grapping the top window bar to move the window. Also it acts more graceful this way no longer teleporting the cursor into the game window when focus is regained. The user now can move his cursor back into the window before it is recaptured.
TODO