-
Notifications
You must be signed in to change notification settings - Fork 125
refactor: modernize NULL to nullptr #1938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: modernize NULL to nullptr #1938
Conversation
5903988 to
af7b405
Compare
050b3f0 to
e6c28a4
Compare
149474b to
5f9990b
Compare
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the CppMacros include everwhere should not be necessary.
| * DecalGeneratorClass::Set_Mesh_Transform -- sets the current mesh coordinate system * | ||
| * - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - */ | ||
|
|
||
| #include <Utility/CppMacros.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These includes should not be necessary in most cases. The include should come through WWCommon already. If not, then an always.h (WWVegas) or PreRTS.h (GameEngine) include is missing somewhere. GameEngineDevice does not use PreRTS.h there is may be necessary sometimes, but I would expect not in many cases because WWVegas stuff gets always.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I removed it from files that include always.h, PreRTS.h, and BaseType.h - cleaned up 387 of 395 of them
13beb77 to
252dac3
Compare
|
Can you merge the last commit with the first, to see which includes are left over? |
|
If you interactively rebase you should be able to drop the first and last commit entirely during the rebase so you only have the wanted commits left. |
|
It depends if there are any includes left added. But it is hard to review because github has trouble showing the diff :D |
252dac3 to
fa822b2
Compare
Done |
|
This needs another pass because #1594 has added a few new NULL's |
fa822b2 to
d88acf7
Compare
xezon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I search for NULL across whole project, then it finds 20231 NULLs, but this change only touched 8724 NULLs. Why is there this large discrepancy?
d88acf7 to
f312de3
Compare
Tested build and played a game successfully.
A Follow up PR can: