refactor(perf): change aiDoCommand to take non-const pointer for move semantics

bobtista · bobtista · commit df75f5d2506f · 2025-11-29T13:59:47.000-05:00
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/AI.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/AI.h
@@ -449,7 +449,7 @@ class AICommandParmsStorage
 	Path*										m_path;
 
 public:
-	void store(const AICommandParms& parms);
+	void store(AICommandParms& parms);
 	void reconstitute(AICommandParms& parms) const;
 	void doXfer(Xfer *xfer);
 	AICommandType getCommandType() const { return m_cmd; }
@@ -466,7 +466,7 @@ class AICommandInterface
 {
 public:
 
-	virtual void aiDoCommand(const AICommandParms* parms) = 0;
+	virtual void aiDoCommand(AICommandParms* parms) = 0;
 
 	inline void aiMoveToPosition( const Coord3D *pos, CommandSourceType cmdSource )
 	{
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/AIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/AIUpdate.h
@@ -353,7 +353,7 @@ class AIUpdateInterface : public UpdateModule, public AICommandInterface
 	virtual void onObjectCreated();
 	virtual void doQuickExit( const std::vector<Coord3D>* path );			///< get out of this Object
 
-	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 
 	virtual const Coord3D *getGuardLocation( void ) const { return &m_locationToGuard;	}
 	virtual ObjectID getGuardObject( void ) const { return m_objectToGuard; }
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/AssaultTransportAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/AssaultTransportAIUpdate.h
@@ -90,7 +90,7 @@ class AssaultTransportAIUpdate : public AIUpdateInterface, public AssaultTranspo
 	AssaultTransportAIUpdate( Thing *thing, const ModuleData* moduleData );
 	// virtual destructor prototype provided by memory pool declaration
 
- 	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 	virtual Bool isIdle() const;
 	virtual UpdateSleepTime update();
 	virtual AssaultTransportAIInterface* getAssaultTransportAIInterface() { return this; }
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/ChinookAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/ChinookAIUpdate.h
@@ -86,7 +86,7 @@ class ChinookAIUpdate : public SupplyTruckAIUpdate
 	// virtual destructor prototype provided by memory pool declaration
 
 	virtual UpdateSleepTime update();
- 	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 	virtual Bool chooseLocomotorSet(LocomotorSetType wst);
 	// this is present solely for some transports to override, so that they can land before
 	// allowing people to exit...
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/DeployStyleAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/DeployStyleAIUpdate.h
@@ -98,7 +98,7 @@ class DeployStyleAIUpdate : public AIUpdateInterface
 	DeployStyleAIUpdate( Thing *thing, const ModuleData* moduleData );
 	// virtual destructor prototype provided by memory pool declaration
 
- 	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 	virtual Bool isIdle() const;
 	virtual UpdateSleepTime update();
 
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/DozerAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/DozerAIUpdate.h
@@ -266,7 +266,7 @@ class DozerAIUpdate : public AIUpdateInterface, public DozerAIInterface
 	// the following methods must be overridden so that if a player issues a command the dozer
 	// can exit the internal state machine and do whatever the player says
 	//
-	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 
 
 protected:
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/FlightDeckBehavior.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/FlightDeckBehavior.h
@@ -148,7 +148,7 @@ class FlightDeckBehavior : public AIUpdateInterface,
 	virtual Bool calcBestParkingAssignment( ObjectID id, Coord3D *pos, Int *oldIndex = NULL, Int *newIndex = NULL );
 
 	// AIUpdateInterface
-	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 
 	virtual const std::vector<Coord3D>* getTaxiLocations( ObjectID id ) const;
 	virtual const std::vector<Coord3D>* getCreationLocations( ObjectID id ) const;
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/HackInternetAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/HackInternetAIUpdate.h
@@ -195,7 +195,7 @@ class HackInternetAIUpdate : public AIUpdateInterface, public HackInternetAIInte
 	HackInternetAIUpdate( Thing *thing, const ModuleData* moduleData );
 	// virtual destructor prototype provided by memory pool declaration
 
- 	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 
 	Real getPackUnpackVariationFactor() const { return getHackInternetAIUpdateModuleData()->m_packUnpackVariationFactor; }
 	UnsignedInt getUnpackTime()					const;
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/JetAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/JetAIUpdate.h
@@ -87,7 +87,7 @@ class JetAIUpdate : public AIUpdateInterface
 	virtual JetAIUpdate* getJetAIUpdate() { return this; }
 	virtual const JetAIUpdate* getJetAIUpdate() const { return this; }
 
- 	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 	virtual Bool chooseLocomotorSet(LocomotorSetType wst);
 	virtual void setLocomotorGoalNone();
 	virtual Bool isIdle() const;
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/POWTruckAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/POWTruckAIUpdate.h
@@ -105,7 +105,7 @@ class POWTruckAIUpdate : public AIUpdateInterface,
 	// the following methods must be overridden so that if a player issues a command the dozer
 	// can exit the internal state machine and do whatever the player says
 	//
-	virtual void aiDoCommand( const AICommandParms *parms );
+	virtual void aiDoCommand( AICommandParms *parms );
 
 protected:
 
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/RailedTransportAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/RailedTransportAIUpdate.h
@@ -64,7 +64,7 @@ class RailedTransportAIUpdate : public AIUpdateInterface
 	// virtual destructor prototype provided by memory pool declaration
 
 	// AIUpdate interface methods
-	virtual void aiDoCommand( const AICommandParms *parms );
+	virtual void aiDoCommand( AICommandParms *parms );
 	virtual UpdateSleepTime update( void );
 
 protected:
diff --git a/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/WorkerAIUpdate.h b/GeneralsMD/Code/GameEngine/Include/GameLogic/Module/WorkerAIUpdate.h
@@ -174,7 +174,7 @@ class WorkerAIUpdate : public AIUpdateInterface, public DozerAIInterface, public
 	// the following methods must be overridden so that if a player issues a command the dozer
 	// can exit the internal state machine and do whatever the player says
 	//
-	virtual void aiDoCommand(const AICommandParms* parms);
+	virtual void aiDoCommand(AICommandParms* parms);
 
 // Supply truck stuff
 	virtual Int getNumberBoxes() const { return m_numberBoxes; }
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp
@@ -69,7 +69,6 @@
 #include "GameLogic/Module/PhysicsUpdate.h"
 #include "GameLogic/Module/StealthUpdate.h"
 
-
 static Bool cannotPossiblyAttackObject( State *thisState, void* userData );
 
 //----------------------------------------------------------------------------------------------------------
@@ -90,15 +89,15 @@ AICommandParms::AICommandParms(AICommandType cmd, CommandSourceType cmdSource) :
 }
 
 //----------------------------------------------------------------------------------------------------------
-void AICommandParmsStorage::store(const AICommandParms& parms)
+void AICommandParmsStorage::store(AICommandParms& parms)
 {
 	m_cmd = parms.m_cmd;
   m_cmdSource = parms.m_cmdSource;
   m_pos = parms.m_pos;
   m_obj = parms.m_obj ? parms.m_obj->getID() : INVALID_ID;
   m_otherObj = parms.m_otherObj ? parms.m_otherObj->getID() : INVALID_ID;
   m_teamName = parms.m_team ? parms.m_team->getName() : AsciiString::TheEmptyString;
-	m_coords = parms.m_coords;
+	move_or_swap(m_coords, parms.m_coords);
   m_waypoint = parms.m_waypoint;
   m_polygon = parms.m_polygon;
   m_intValue = parms.m_intValue;       /// misc usage
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/FlightDeckBehavior.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/FlightDeckBehavior.cpp
@@ -1390,7 +1390,7 @@ void FlightDeckBehavior::unreserveDoorForExit( ExitDoorType exitDoor )
 }
 
 //-------------------------------------------------------------------------------------------------
-void FlightDeckBehavior::aiDoCommand(const AICommandParms* parms)
+void FlightDeckBehavior::aiDoCommand(AICommandParms* parms)
 {
 	//Inspect the command and reset everything when necessary.
 	if( parms->m_cmdSource != CMD_FROM_AI )
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp
@@ -2615,7 +2615,7 @@ Bool AIUpdateInterface::isAllowedToRespondToAiCommands(const AICommandParms* par
 }
 
 //-------------------------------------------------------------------------------------------------
-void AIUpdateInterface::aiDoCommand(const AICommandParms* parms)
+void AIUpdateInterface::aiDoCommand(AICommandParms* parms)
 {
 	// TheSuperHackers @info The AiCommandParms for m_obj, m_otherObj and m_team should be null tested before use.
 	// These variables could relate to a deleted object when a pending command is reconstituted.
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/AssaultTransportAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/AssaultTransportAIUpdate.cpp
@@ -80,7 +80,7 @@ AssaultTransportAIUpdate::~AssaultTransportAIUpdate( void )
 }
 
 //-------------------------------------------------------------------------------------------------
-void AssaultTransportAIUpdate::aiDoCommand(const AICommandParms* parms)
+void AssaultTransportAIUpdate::aiDoCommand(AICommandParms* parms)
 {
 	//Inspect the command and reset everything when necessary.
 	if( parms->m_cmdSource != CMD_FROM_AI )
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/ChinookAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/ChinookAIUpdate.cpp
@@ -1256,7 +1256,7 @@ void ChinookAIUpdate::privateCombatDrop( Object* target, const Coord3D& pos, Com
 }
 
 //-------------------------------------------------------------------------------------------------
-void ChinookAIUpdate::aiDoCommand(const AICommandParms* parms)
+void ChinookAIUpdate::aiDoCommand(AICommandParms* parms)
 {
 	// this gets reset every time a command is issued.
 	setAirfieldForHealing(INVALID_ID);
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/DeployStyleAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/DeployStyleAIUpdate.cpp
@@ -70,7 +70,7 @@ Bool DeployStyleAIUpdate::isIdle() const
 }
 
 //-------------------------------------------------------------------------------------------------
-void DeployStyleAIUpdate::aiDoCommand( const AICommandParms* parms )
+void DeployStyleAIUpdate::aiDoCommand( AICommandParms* parms )
 {
 	if (!isAllowedToRespondToAiCommands(parms))
 		return;
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/DozerAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/DozerAIUpdate.cpp
@@ -2334,7 +2334,7 @@ Real DozerAIUpdate::getBoredRange( void ) const
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
 //-------------------------------------------------------------------------------------------------
-void DozerAIUpdate::aiDoCommand(const AICommandParms* parms)
+void DozerAIUpdate::aiDoCommand(AICommandParms* parms)
 {
 
 	//
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/HackInternetAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/HackInternetAIUpdate.cpp
@@ -121,7 +121,7 @@ UpdateSleepTime HackInternetAIUpdate::update( void )
 }
 
 //-------------------------------------------------------------------------------------------------
-void HackInternetAIUpdate::aiDoCommand(const AICommandParms* parms)
+void HackInternetAIUpdate::aiDoCommand(AICommandParms* parms)
 {
 	if (!isAllowedToRespondToAiCommands(parms))
 		return;
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/JetAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/JetAIUpdate.cpp
@@ -2530,7 +2530,7 @@ Bool JetAIUpdate::isParkedAt(const Object* obj) const
 }
 
 //-------------------------------------------------------------------------------------------------
-void JetAIUpdate::aiDoCommand(const AICommandParms* parms)
+void JetAIUpdate::aiDoCommand(AICommandParms* parms)
 {
 	// call this from aiDoCommand as well as update, because this can
 	// be called before update ever is... if the unit is placed on a map,
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/POWTruckAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/POWTruckAIUpdate.cpp
@@ -111,7 +111,7 @@ void POWTruckAIUpdate::onDelete( void )
 
 // ------------------------------------------------------------------------------------------------
 //-------------------------------------------------------------------------------------------------
-void POWTruckAIUpdate::aiDoCommand( const AICommandParms *parms )
+void POWTruckAIUpdate::aiDoCommand( AICommandParms *parms )
 {
 
 	if (!isAllowedToRespondToAiCommands(parms))
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/RailedTransportAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/RailedTransportAIUpdate.cpp
@@ -260,7 +260,7 @@ UpdateSleepTime RailedTransportAIUpdate::update( void )
 
 // ------------------------------------------------------------------------------------------------
 //-------------------------------------------------------------------------------------------------
-void RailedTransportAIUpdate::aiDoCommand( const AICommandParms *parms )
+void RailedTransportAIUpdate::aiDoCommand( AICommandParms *parms )
 {
 
 	// if not allowed to respond to any command get out of here
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/WorkerAIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate/WorkerAIUpdate.cpp
@@ -950,7 +950,7 @@ const Coord3D* WorkerAIUpdate::getDockPoint( DozerTask task, DozerDockPoint poin
 // ------------------------------------------------------------------------------------------------
 
 //-------------------------------------------------------------------------------------------------
-void WorkerAIUpdate::aiDoCommand(const AICommandParms* parms)
+void WorkerAIUpdate::aiDoCommand(AICommandParms* parms)
 {
 
 	//

Original file line number	Diff line number	Diff line change
`@@ -449,7 +449,7 @@ class AICommandParmsStorage`
`449`	`449`	`Path* m_path;`
`450`	`450`
`451`	`451`	`public:`
`452`		`- void store(const AICommandParms& parms);`
	`452`	`+ void store(AICommandParms& parms);`
`453`	`453`	`void reconstitute(AICommandParms& parms) const;`
`454`	`454`	`void doXfer(Xfer *xfer);`
`455`	`455`	`AICommandType getCommandType() const { return m_cmd; }`
`@@ -466,7 +466,7 @@ class AICommandInterface`
`466`	`466`	`{`
`467`	`467`	`public:`
`468`	`468`
`469`		`- virtual void aiDoCommand(const AICommandParms* parms) = 0;`
	`469`	`+ virtual void aiDoCommand(AICommandParms* parms) = 0;`
`470`	`470`
`471`	`471`	`inline void aiMoveToPosition( const Coord3D *pos, CommandSourceType cmdSource )`
`472`	`472`	`{`