Take AsciiString reference in CommandSetUpgrade::upgradeImplementation

xezon · xezon · commit d47b78638f8e · 2025-12-07T11:21:48.000+01:00
diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Upgrade/CommandSetUpgrade.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Upgrade/CommandSetUpgrade.cpp
@@ -68,7 +68,7 @@ void CommandSetUpgrade::upgradeImplementation( )
 {
 	Object *obj = getObject();
 
-	AsciiString upgradeAlt = getCommandSetUpgradeModuleData()->m_triggerAlt;
+	const AsciiString& upgradeAlt = getCommandSetUpgradeModuleData()->m_triggerAlt;
 	const UpgradeTemplate *upgradeTemplate = TheUpgradeCenter->findUpgrade( upgradeAlt.str() );
 
 	if (upgradeTemplate)

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ void CommandSetUpgrade::upgradeImplementation( )`
`68`	`68`	`{`
`69`	`69`	`Object *obj = getObject();`
`70`	`70`
`71`		`- AsciiString upgradeAlt = getCommandSetUpgradeModuleData()->m_triggerAlt;`
	`71`	`+ const AsciiString& upgradeAlt = getCommandSetUpgradeModuleData()->m_triggerAlt;`
`72`	`72`	`const UpgradeTemplate *upgradeTemplate = TheUpgradeCenter->findUpgrade( upgradeAlt.str() );`
`73`	`73`
`74`	`74`	`if (upgradeTemplate)`