chore: Change GraphicsObjects to use smart pointers for transitions

Use smart pointers instead of raw pointers for the BaseTransition class.
This removes a small amount of resource handling code in quit().

Author: ThePythonator

include/framework/GraphicsObjects.hpp

@@ -19,7 +19,7 @@ namespace Framework {
 		std::vector<std::unique_ptr<Image>> image_ptrs;
 		std::vector<Spritesheet> spritesheets;
 		std::vector<Font> fonts;
-		std::vector<BaseTransition*> transition_ptrs;
+		std::vector<std::unique_ptr<BaseTransition>> transition_ptrs;
 
 		std::vector<Button::ButtonImages> button_image_groups;
 	};

src/framework/BaseGame.cpp

@@ -145,7 +145,7 @@ namespace Framework {
 		graphics_objects.image_ptrs = std::vector<std::unique_ptr<Framework::Image>>(GRAPHICS_OBJECTS::IMAGES::TOTAL_IMAGES);
 		graphics_objects.spritesheets = std::vector<Framework::Spritesheet>(GRAPHICS_OBJECTS::SPRITESHEETS::TOTAL_SPRITESHEETS);
 		graphics_objects.fonts = std::vector<Framework::Font>(GRAPHICS_OBJECTS::FONTS::TOTAL_FONTS);
-		graphics_objects.transition_ptrs = std::vector<Framework::BaseTransition*>(GRAPHICS_OBJECTS::TRANSITIONS::TOTAL_TRANSITIONS);
+		graphics_objects.transition_ptrs = std::vector<std::unique_ptr<Framework::BaseTransition>>(GRAPHICS_OBJECTS::TRANSITIONS::TOTAL_TRANSITIONS);
 		graphics_objects.button_image_groups = std::vector<Framework::Button::ButtonImages>(GRAPHICS_OBJECTS::BUTTON_IMAGE_GROUPS::TOTAL_BUTTON_IMAGE_GROUPS);
 
 		// Load game data
@@ -158,15 +158,6 @@ namespace Framework {
 		// Clear game data
 		clear_data();
 
-		// Clear graphics objects stuff
-
-		// Clear transitions
-		for (Framework::BaseTransition* transition_ptr : graphics_objects.transition_ptrs) {
-			if (!transition_ptr) continue;
-			delete transition_ptr;
-		}
-		graphics_objects.transition_ptrs.clear();
-		
 		// Destroy renderer and window
 		SDL_DestroyRenderer(renderer);
 		SDL_DestroyWindow(window);

src/game/Game.cpp

@@ -60,7 +60,7 @@ void Game::load_data() {
 
 
 	// Create transitions
-	graphics_objects.transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION] = new Framework::FadeTransition(&graphics_objects.graphics, COLOURS::BLACK, TRANSITIONS::FADE_TIME);
+	graphics_objects.transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION] = std::make_unique<Framework::FadeTransition>(&graphics_objects.graphics, COLOURS::BLACK, TRANSITIONS::FADE_TIME);
 }
 
 void Game::clear_data() {

src/game/GameStages.cpp

@@ -4,7 +4,7 @@
 
 void GameStage::start() {
 	// Set transition
-	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION]);
+	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION].get());
 
 	// Start transition
 	transition->open();
@@ -52,7 +52,7 @@ void PausedStage::start() {
 	);
 
 	// Set transition
-	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION]);
+	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION].get());
 }
 
 bool PausedStage::update(float dt) {

src/game/MenuStages.cpp

@@ -8,7 +8,7 @@ void IntroStage::start() {
 	intro_timer.stop();
 
 	// Start transition
-	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION]);
+	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION].get());
 	transition->open();
 }
 
@@ -63,7 +63,7 @@ void TitleStage::start() {
 	);
 
 	// Set transition
-	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION]);
+	set_transition(graphics_objects->transition_ptrs[GRAPHICS_OBJECTS::TRANSITIONS::FADE_TRANSITION].get());
 
 	// Start transition
 	transition->open();