Skip to content

Drops first char when parsing address from .asm for Insertion Address when CRLF newline type #4

@dreamsyntax

Description

@dreamsyntax

Affected Version

CodeWrite 1.0.6

The Problem

When using the Open ASM File... feature from a previously valid saved 'Save ASM File` works as expected.
However if committing these files in something like a git repo, with the standard newline configuration (LF being replaced with CRLF) results in bad behavior.

Example:

802D1BE8

With ASM
  li r18, 0x0

Opening this with LF line endings has the proper insertion address of
802D1BE8

Opening this with CRLF line endings results in:
02D1BE8

Alternatively you can clone this repo to experience the CRLF behavior:
https://github.com/ShadowSpeedrun/ShadowSX/tree/main/ASM%20Changes

Notice the newline is included and the 8 is dropped

Proposed Solution

Parse CRLF as LF OR read the first 8 chars of the insertion address, truncating the rest

Interim Solution if there is never another update

On your repo make .gitattributes with this as content:
*.asm text eol=lf

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions