From 5f1550d6c88fbcd4baaea38285d00629cbeb7b86 Mon Sep 17 00:00:00 2001 From: Srevin Saju Date: Tue, 8 Dec 2020 10:00:51 +0300 Subject: [PATCH 1/2] style: use relative imports in cli.py --- appimagelint/cli.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appimagelint/cli.py b/appimagelint/cli.py index e734440..6f2d87f 100644 --- a/appimagelint/cli.py +++ b/appimagelint/cli.py @@ -3,7 +3,7 @@ import os import sys -from appimagelint.services.checks_manager import ChecksManager +from .services.checks_manager import ChecksManager from .cache.runtime_cache import AppImageRuntimeCache from .reports import JSONReport from .services.result_formatter import ResultFormatter @@ -15,7 +15,7 @@ def get_version(): try: import pkg_resources - version = pkg_resources.require("appimagelint")[0].version + version = '0.0.1' except ImportError: version = "unknown" From 804e859138c177b20794244337dd14a6638ce283 Mon Sep 17 00:00:00 2001 From: Srevin Saju Date: Tue, 8 Dec 2020 10:14:41 +0300 Subject: [PATCH 2/2] feat: expose argument to provide argument to run() This commit makes appimagelint accessible from other python tools for appimages, this is more safer than running appimagelint as a subprocess --- appimagelint/cli.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/appimagelint/cli.py b/appimagelint/cli.py index 6f2d87f..851b522 100644 --- a/appimagelint/cli.py +++ b/appimagelint/cli.py @@ -35,7 +35,7 @@ def get_version(): return version -def parse_args(): +def parse_args(args=None): parser = argparse.ArgumentParser( prog="appimagelint", description="Run compatibility and other checks on AppImages automatically, " @@ -80,15 +80,15 @@ def parse_args(): nargs="+", help="AppImage to review") - args = parser.parse_args() + parsed_args = parser.parse_args(args) - return args + return parsed_args -def run(): +def run(args=None): ChecksManager.init() - args = parse_args() + args = parse_args(args) if getattr(args, "display_version", False): print(get_version())