From 262585aeab564e03855e1325a1e3e64516d0b690 Mon Sep 17 00:00:00 2001
From: Alison Zhang <alisonzthu@gmail.com>
Date: Mon, 24 Apr 2017 11:59:47 -0700
Subject: [PATCH 1/6] mend DM button, comment out retrieveMessages for removing
 frontend error

---
 client/src/components/Artist.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/src/components/Artist.jsx b/client/src/components/Artist.jsx
index 8031204..9a48e34 100644
--- a/client/src/components/Artist.jsx
+++ b/client/src/components/Artist.jsx
@@ -188,7 +188,7 @@ class Artist extends Component {
               <Container>
                 <span>{first_name} {last_name}</span>
                 {' '}
-                <button onClick={this.directMessageHandler}>Direct message</button>
+                {this.props.userId ? <Button onClick={this.directMessageHandler} content="Direct message"/> : null}
                 {' '}
                 {fb_link ? <Button circular color='facebook' icon='facebook' onClick={() => {
                   this._socialMedia(fb_link);

From 9e92ac574ed4208861f50baea33db010b94acd87 Mon Sep 17 00:00:00 2001
From: Alison Zhang <alisonzthu@gmail.com>
Date: Mon, 24 Apr 2017 12:10:52 -0700
Subject: [PATCH 2/6] change pwd form toggles after successfully change pwd

---
 client/src/components/UserSettings.jsx | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/client/src/components/UserSettings.jsx b/client/src/components/UserSettings.jsx
index 00d2f72..d81632a 100644
--- a/client/src/components/UserSettings.jsx
+++ b/client/src/components/UserSettings.jsx
@@ -1,5 +1,5 @@
 import React, { Component } from 'react';
-import { Container, Image } from 'semantic-ui-react';
+import { Container, Image, Button, Input } from 'semantic-ui-react';
 import { connect } from 'react-redux';
 
 let currentPassword = null;
@@ -17,14 +17,14 @@ const ChangePassword = () => {
     <span>
       <br />
       Current password:
-      <input type="password" placeholder="current password" ref={node => currentPassword = node} />
+      <Input type="password" placeholder="current password" ref={node => currentPassword = node} />
       <br />
       New password:
-      <input type="password" placeholder="new password" ref={node => newPassword = node} />
+      <Input type="password" placeholder="new password" ref={node => newPassword = node} />
       <br />
       Confirm password:
-      <input type="password" placeholder="confirm password" ref={node => confirmPassword = node} />
-      <input type="submit" value="Submit" />
+      <Input type="password" placeholder="confirm password" ref={node => confirmPassword = node} />
+      <Input type="submit" value="Submit" />
     </span>
   );
 }
@@ -81,6 +81,7 @@ class UserSettings extends Component {
             } else {
               alert('Successfully changed password');
               _setInputsToNull();
+              this.setState({toggle: !this.state.toggle});
             }
           })
         } else {
@@ -110,7 +111,7 @@ class UserSettings extends Component {
           <br />
           Phone number: xxxxxxx
           <br />
-          <button onClick={(e) => {this._clickHandler(e)}}>Change password</button>
+          <Button onClick={(e) => {this._clickHandler(e)}} content="Change password" />
           {this.state.toggle? <ChangePassword /> : null}
           </form>
         </Container>

From 4992d89a954a22f5ac16ee72650b19380f0267ba Mon Sep 17 00:00:00 2001
From: Alison Zhang <alisonzthu@gmail.com>
Date: Mon, 24 Apr 2017 12:16:34 -0700
Subject: [PATCH 3/6] segment the change password

---
 client/src/components/UserSettings.jsx | 6 +++---
 client/src/components/WriteMessage.jsx | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/client/src/components/UserSettings.jsx b/client/src/components/UserSettings.jsx
index d81632a..2172720 100644
--- a/client/src/components/UserSettings.jsx
+++ b/client/src/components/UserSettings.jsx
@@ -1,5 +1,5 @@
 import React, { Component } from 'react';
-import { Container, Image, Button, Input } from 'semantic-ui-react';
+import { Container, Image, Button, Input, Segment} from 'semantic-ui-react';
 import { connect } from 'react-redux';
 
 let currentPassword = null;
@@ -14,7 +14,7 @@ const _setInputsToNull = () => {
 
 const ChangePassword = () => {
   return (
-    <span>
+    <Segment>
       <br />
       Current password:
       <Input type="password" placeholder="current password" ref={node => currentPassword = node} />
@@ -25,7 +25,7 @@ const ChangePassword = () => {
       Confirm password:
       <Input type="password" placeholder="confirm password" ref={node => confirmPassword = node} />
       <Input type="submit" value="Submit" />
-    </span>
+    </Segment>
   );
 }
 
diff --git a/client/src/components/WriteMessage.jsx b/client/src/components/WriteMessage.jsx
index 7f0b359..6b1b4a3 100644
--- a/client/src/components/WriteMessage.jsx
+++ b/client/src/components/WriteMessage.jsx
@@ -49,8 +49,9 @@ class WriteMessage extends React.Component {
       dispatch(ChatActions.chatMessage(messagePayload));
     })
     .catch((error) => {
+      //this can dispatch an error to the reducer and when the fronend detects error, render something differently
       console.log('handleFormSubmit failed! Error: ', error);
-    })
+    });
   }
 
   // retrieveMessages() {

From 62972e4740421ea910f8fcf56cf96935a63a8215 Mon Sep 17 00:00:00 2001
From: Alison Zhang <alisonzthu@gmail.com>
Date: Tue, 25 Apr 2017 12:19:36 -0700
Subject: [PATCH 4/6] in the middle of fixing change password

---
 client/src/components/UserSettings.jsx | 119 ++++++++++++-------------
 package.json                           |   1 +
 server/controllers/loginSignup.js      |  24 +++--
 server/controllers/user.js             |  27 +++++-
 4 files changed, 94 insertions(+), 77 deletions(-)

diff --git a/client/src/components/UserSettings.jsx b/client/src/components/UserSettings.jsx
index 2172720..8bbf721 100644
--- a/client/src/components/UserSettings.jsx
+++ b/client/src/components/UserSettings.jsx
@@ -12,21 +12,31 @@ const _setInputsToNull = () => {
   confirmPassword.value = '';
 };
 
-const ChangePassword = () => {
-  return (
-    <Segment>
-      <br />
-      Current password:
-      <Input type="password" placeholder="current password" ref={node => currentPassword = node} />
-      <br />
-      New password:
-      <Input type="password" placeholder="new password" ref={node => newPassword = node} />
-      <br />
-      Confirm password:
-      <Input type="password" placeholder="confirm password" ref={node => confirmPassword = node} />
-      <Input type="submit" value="Submit" />
-    </Segment>
-  );
+class ChangePassword extends Component {
+//please do NOT change the input into semantic Input, things break!!!
+//NEED TO SET THE WIDTH OF THE FORM:
+  render() {
+    return (
+      <span className="ui form">
+        <br />
+        Current password:
+        <input as='input' type="password" placeholder="current password" ref={node => {
+          currentPassword = node
+        }} />
+        <br />
+        New password:
+        <input as='input' type="password" placeholder="new password" ref={node => {
+          newPassword = node
+        }} />
+        <br />
+        Confirm password:
+        <input type="password" placeholder="confirm password" ref={node => {
+          confirmPassword = node
+        }} />
+        <Input type="submit" value="Submit" />
+      </span>
+    );
+  }
 }
 
 class UserSettings extends Component {
@@ -47,56 +57,37 @@ class UserSettings extends Component {
   _submitHandler(e) {
     e.preventDefault();
     let { userId } = this.props.user;
-    fetch('/user/' + userId, {
-      method: 'GET',
-      headers: {
-        'Authorization': `Bearer ${sessionStorage.getItem('authToken')}`
-      }
-    })
-    .then(response => {
-      if (!response.ok) {
-        throw Error(response.statusText);
-      }
-
-      return response.json();
-    })
-    .then(data => {
-      if (currentPassword.value === data.password) {
-        if (newPassword.value === confirmPassword.value) {
-          fetch('/user/' + userId + '/changePassword', {
-            headers: {
-            'Accept': 'application/json',
-            'Content-Type': 'application/json',
-            'Authorization': `Bearer ${sessionStorage.getItem('authToken')}`
-            },
-            method: 'POST',
-            body: JSON.stringify({
-              userId: userId,
-              password: newPassword.value
-            })
-          })
-          .then(response => {
-            if (!response.ok) {
-              throw Error('error');
-            } else {
-              alert('Successfully changed password');
-              _setInputsToNull();
-              this.setState({toggle: !this.state.toggle});
-            }
-          })
-        } else {
-          alert('Please enter the same password');
-          _setInputsToNull();
+    // _setInputsToNull();
+    // this.setState({toggle: !this.state.toggle});
+    if (newPassword.value !== confirmPassword.value) {
+      alert('Please enter the same password');
+      _setInputsToNull();
+    } else {
+      fetch('/user/' + userId + '/changePassword', {
+        headers: new Headers({
+          'Content-Type': 'application/json',
+          'Authorization': `Bearer ${sessionStorage.getItem('authToken')}`
+        }),
+        method: 'POST',
+        body: JSON.stringify({
+          currentPassword: currentPassword.value,
+          newPassword: newPassword.value
+        })
+      })
+      .then(response => {
+        if (!response.ok) {
+          console.log(response.statusText);
+          throw Error('ah!');
         }
-      } else {
-        alert('You entered the wrong current password');
-        _setInputsToNull();
-      }
-    })
-    .catch(err => {
-      alert('Error: change password failed!');
-       _setInputsToNull();
-    });
+        return response.text();
+      })
+      .then(data => {
+        console.log('im data : ', data);
+      })
+      .catch(err => {
+        console.log('error: ', err.message);
+      })
+    }
   }
 
   render(){
diff --git a/package.json b/package.json
index 0177257..a250708 100644
--- a/package.json
+++ b/package.json
@@ -27,6 +27,7 @@
     "babel-preset-react": "^6.23.0",
     "babel-preset-stage-2": "^6.24.1",
     "bcrypt": "^1.0.2",
+    "bcrypt-promised": "^1.0.1",
     "body-parser": "^1.17.1",
     "cloudinary": "^1.8.0",
     "cookie-parser": "^1.4.3",
diff --git a/server/controllers/loginSignup.js b/server/controllers/loginSignup.js
index 73c0373..95e33f8 100644
--- a/server/controllers/loginSignup.js
+++ b/server/controllers/loginSignup.js
@@ -2,6 +2,7 @@ const router = require('express').Router();
 const model = require('../database/queries');
 const Moment = require('moment');
 const jwt = require('jsonwebtoken');
+const bcrypt = require('bcrypt-promised');
 
 const serverErr = { ERR: { status: 500, message: 'Something went wrong. So Sorry!' } };
 
@@ -14,9 +15,8 @@ router.post('/login', (req, res) => {
     if(response.length === 0) {
       throw Error('user does not exist!');
     } else {
-    //check if password matches the ones in database, consider HASH
-      if (response[0].password === password) {
-        //succeed! we can assign a token here!
+      bcrypt.compare(password, response[0].password)
+      .then(result => {
         let authToken = jwt.sign({
           username: username,
           userId: response[0].id,
@@ -24,15 +24,12 @@ router.post('/login', (req, res) => {
           isAuthenticated: true,
           exp: Math.floor(Date.now() / 1000) + (60 * 60 * 24)
         }, process.env.jwtSecret);
-        
         res.setHeader('x-username', username);
         res.setHeader('x-userId', response[0].id);
         res.setHeader('x-type', response[0].type);
         res.cookie('jwt', authToken);
         res.status(201).send(JSON.stringify(authToken));
-      } else {
-        throw Error('Wrong password');
-      }
+      });
     }
   })
   .catch(err => {
@@ -58,10 +55,19 @@ router.post('/signup', (req, res) => {
       //   email:
       //   type:
       // };
-      return model.createUser(req.body);
+      const saltRounds = 10;
+      return bcrypt.hash(password, saltRounds)
+            .then(hash => {
+              let userObj = Object.assign({}, req.body);
+              userObj.password = hash;
+              return userObj;
+            });
     }
   })
-  .then((result) => {
+  .then(result => {
+    return model.createUser(result);
+  })
+  .then(result => {
     let authToken = jwt.sign({
           username: username,
           userId: result[0].id,
diff --git a/server/controllers/user.js b/server/controllers/user.js
index 2965485..454eb8d 100644
--- a/server/controllers/user.js
+++ b/server/controllers/user.js
@@ -1,6 +1,6 @@
 const router = require('express').Router();
 const model = require('../database/queries');
-const bcrypt = require('bcrypt');
+const bcrypt = require('bcrypt-promised');
 const authenticate = require('../middlewares/authenticate.js');
 
 const serverErr = { ERR: { status: 500, message: 'Something went wrong. So Sorry!' } };
@@ -20,12 +20,31 @@ router.get('/:userId', authenticate, (req, res) => {
 });
 
 router.post('/:userId/changePassword', authenticate, (req, res) => {
-  model.changeUserPassword(req.body.userId, req.body.password)
+  let { currentPassword, newPassword } = req.body;
+  let { userId } = req.user;
+
+  model.getUser(userId)
   .then(response => {
-    res.status(201).send('changed password');
+    bcrypt.compare(currentPassword, response[0].password)
+    .then(result => {
+      if (result) {
+        //hash password and update password
+        const saltRounds = 10;
+        bcrypt.hash(newPassword, saltRounds)
+        .then(hash => {
+          return model.changeUserPassword(userId, hash)
+          .then(response => {
+            res.status(201).send('Successfully changed password');
+          });
+        });
+      } else {
+        console.log('wrong');
+        throw Error('Wrong current password!');
+      }
+    });
   })
   .catch(err => {
-    res.status(400).send('failed to change password');
+    res.status(400).send('Failed to change password');
   });
 });
 

From c5f6a8daabd01e0da45cc5a4327599027c637b71 Mon Sep 17 00:00:00 2001
From: Alison Zhang <alisonzthu@gmail.com>
Date: Tue, 25 Apr 2017 13:46:42 -0700
Subject: [PATCH 5/6] finished hash password

---
 client/src/components/UserSettings.jsx | 11 +++++++----
 server/controllers/user.js             | 26 +++++++++++++-------------
 2 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/client/src/components/UserSettings.jsx b/client/src/components/UserSettings.jsx
index 8bbf721..6881bd5 100644
--- a/client/src/components/UserSettings.jsx
+++ b/client/src/components/UserSettings.jsx
@@ -13,7 +13,7 @@ const _setInputsToNull = () => {
 };
 
 class ChangePassword extends Component {
-//please do NOT change the input into semantic Input, things break!!!
+//please do NOT change the input into semantic Input, things break!!! and don't change the outer most span into semantic-ui thing. it breaks as well.
 //NEED TO SET THE WIDTH OF THE FORM:
   render() {
     return (
@@ -76,16 +76,19 @@ class UserSettings extends Component {
       })
       .then(response => {
         if (!response.ok) {
-          console.log(response.statusText);
           throw Error('ah!');
         }
         return response.text();
       })
       .then(data => {
-        console.log('im data : ', data);
+         alert('Successfully changed the password');
+         this.setState({
+          toggle: !this.state.toggle
+         });
       })
       .catch(err => {
-        console.log('error: ', err.message);
+        alert('Failed to change password');
+        _setInputsToNull();
       })
     }
   }
diff --git a/server/controllers/user.js b/server/controllers/user.js
index 454eb8d..d8c6b87 100644
--- a/server/controllers/user.js
+++ b/server/controllers/user.js
@@ -27,20 +27,20 @@ router.post('/:userId/changePassword', authenticate, (req, res) => {
   .then(response => {
     bcrypt.compare(currentPassword, response[0].password)
     .then(result => {
-      if (result) {
-        //hash password and update password
-        const saltRounds = 10;
-        bcrypt.hash(newPassword, saltRounds)
-        .then(hash => {
-          return model.changeUserPassword(userId, hash)
-          .then(response => {
-            res.status(201).send('Successfully changed password');
-          });
+      const saltRounds = 10;
+      bcrypt.hash(newPassword, saltRounds)
+      .then(hash => {
+        return model.changeUserPassword(userId, hash)
+        .then(response => {
+          res.status(201).send('Successfully changed password');
+        })
+        .catch(err => {
+          res.status(400).send('Failed to change password');
         });
-      } else {
-        console.log('wrong');
-        throw Error('Wrong current password!');
-      }
+      });
+    })
+    .catch(err => {
+      res.status(400).send('Failed to change password');
     });
   })
   .catch(err => {

From 00c0fd3c4f13675fdc8e3141117fefa830fc226c Mon Sep 17 00:00:00 2001
From: Alison Zhang <alisonzthu@gmail.com>
Date: Tue, 25 Apr 2017 13:56:18 -0700
Subject: [PATCH 6/6] cleaned up change password

---
 client/src/components/UserSettings.jsx | 4 +---
 server/controllers/user.js             | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/client/src/components/UserSettings.jsx b/client/src/components/UserSettings.jsx
index 6881bd5..e7c4f7a 100644
--- a/client/src/components/UserSettings.jsx
+++ b/client/src/components/UserSettings.jsx
@@ -57,8 +57,6 @@ class UserSettings extends Component {
   _submitHandler(e) {
     e.preventDefault();
     let { userId } = this.props.user;
-    // _setInputsToNull();
-    // this.setState({toggle: !this.state.toggle});
     if (newPassword.value !== confirmPassword.value) {
       alert('Please enter the same password');
       _setInputsToNull();
@@ -76,7 +74,7 @@ class UserSettings extends Component {
       })
       .then(response => {
         if (!response.ok) {
-          throw Error('ah!');
+          throw Error('Failed');
         }
         return response.text();
       })
diff --git a/server/controllers/user.js b/server/controllers/user.js
index d8c6b87..3bae8f4 100644
--- a/server/controllers/user.js
+++ b/server/controllers/user.js
@@ -40,7 +40,7 @@ router.post('/:userId/changePassword', authenticate, (req, res) => {
       });
     })
     .catch(err => {
-      res.status(400).send('Failed to change password');
+      res.status(400).send('You entered wrong current password');
     });
   })
   .catch(err => {