Skip to content

fix(9router-health): move restart_command from required to optional schema#127

Open
TechNickAI wants to merge 1 commit into
mainfrom
fix/9router-health-review-sweep
Open

fix(9router-health): move restart_command from required to optional schema#127
TechNickAI wants to merge 1 commit into
mainfrom
fix/9router-health-review-sweep

Conversation

@TechNickAI
Copy link
Copy Markdown
Owner

Summary

Follow-up PR from bot review sweep on #126.

  • restart_command was listed as a required schema key in workflows/9router-health/AGENT.md, but automatic restarts are explicitly disabled by the Remediation Posture
  • A host that omitted this unused key would silently enter report-only mode (no alerts), including killing P1 process-down alerting
  • Fix: moved to a new ### Optional schema section with a clear note that it's reserved for future restart policy

What was triaged

Bot Comment Disposition
chatgpt-codex-connector[bot] README missing 9router-health workflow entry Incorrect — already present at README.md line 155
cursor[bot] Circuit breakers declared but never defined Incorrect## Circuit Breakers section fully defined (added in c1fb507)
cursor[bot] No log rotation for health check logs Incorrect### Log Retention with 30-day find … -delete added in c1fb507
cursor[bot] Stale-config discovery may overwrite manual config Incorrect — "Do not invent or overwrite" guard added in c1fb507
cursor[bot] restart_command required but unused, suppresses all alerts Fixed in this PR

🤖 Generated with Claude Code

…chema

Required but unused key caused report-only mode (no alerts) for any host
that omitted it — silently killing P1 alerting. Since automatic restarts
are explicitly disabled by the Remediation Posture, restart_command should
be optional until a host-local restart policy is explicitly set.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@TechNickAI TechNickAI added review-sweep Follow-up fixes from PR review comments Hex Created by Hex labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hex Created by Hex review-sweep Follow-up fixes from PR review comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant