Skip to content

Return false silently when WorldRegexMatcher tests an unloaded world #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Combustible wants to merge 1 commit into from
Closed

Return false silently when WorldRegexMatcher tests an unloaded world #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugin/src/main/java/com/playmonumenta/scriptedquests/utils/WorldRegexMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ public void onUnloadWorld(World world) {
public boolean matches(World world, String worldRegex) {
Set<String> matches = mWorldPatternMatches.get(world.getName());
if (matches == null) {
if (Bukkit.getWorld(world.getName()) == null) {
// World is unloaded; no zone can contain an entity in an unloaded world
return false;
}
MMLog.severe(
"Falling back to slow regex .matches() to test unloaded world: '" + world.getName() + "' against regex: '" + worldRegex + "'",
new IllegalStateException("WorldRegexMatcher testing against an unloaded world")
Expand Down
Loading