WD SNe are not recorded in the Supernovae output files

[jeffriley]

None of the WD SNe types (AIC, SNIA, HeSD) are recorded in either the SSE or BSE Supernovae logs.

Unless someone wants this fixed sooner, I will fix it as part of the implementation of #805

Versioning (please complete the following information):

• OS: Ubuntu 22.04.2 LTS
• COMPAS v03.15.00

[ilyamandel]

@SimonStevenson , when you showed that AICs were created following the fixes in #1386, were you looking at BSE_Supernova logs or elsewhere?

[SimonStevenson]

Yeah I was just looking at 'SN_Type(SN)' in BSE_Supernovae

[ilyamandel]

Then I think this is a non-issue as stated following the changes in #1386 , though I know @jeffriley wants to standardise the way supernovae are resolved.

(ResolveHeSD() is never called as noted in #1386 -- so whether it should be called, or should be removed, could form another part of this issue.)

[nrsegovia]

As mentioned above, HeSD are not being recorded because ResolveHeSD is never called. I believe that there should be a distinction between normal SN Type Ia and He-shell detonation (double detonation), as the latter can be sub-Chandrasekhar. Right now, it seems that the process for COWDs is: ShouldEvolveOnPhase is false when m_OffCenterIgnition || !IsSupernova(), after which COWD::EvolveToNextPhase is called. For SNe events, ResolveSNIa() is immediately called without distinction between the two types since IsSupernova returns m_HeShellDetonation || IsMassAboveChandrasekhar(). If you agree, I think that the fix is straightforward:

STELLAR_TYPE COWD::EvolveToNextPhase() {

    STELLAR_TYPE stellarType;

    if (m_OffCenterIgnition) {
        stellarType = STELLAR_TYPE::OXYGEN_NEON_WHITE_DWARF;
    }
    else {                                         
        stellarType = m_HeShellDetonation ? ResolveHeSD() : ResolveSNIa();  // This line has been changed
    }
    return stellarType;
}

An alternative would be removing HeSD-related code and implementing the conditional statement within ResolveSNIa() instead.

[jeffriley]

@SimonStevenson

Yeah I was just looking at 'SN_Type(SN)' in BSE_Supernovae

Can you give me a commandline example that creates a WD SN (bonus if it is logged in the BSE_SNe file)?

[SimonStevenson]

@jeffriley The example in #1384 should work

./COMPAS -n 1 --mode BSE --initial-mass-1 7.3 --initial-mass-2 5.7 --semi-major-axis 9.0 --evolve-double-white-dwarfs TRUE --emit-gravitational-radiation TRUE --detailed-output TRUE --evolve-unbound-systems FALSE --maximum-neutron-star-mass 2.3

That produces an AIC: SN_Type(SN) == 32 in BSE_Supernovae.

I don't have the exact parameters for a SN1A, but those were found in a (more or less standard) population run with:

./COMPAS -n 50000 --mode BSE --evolve-double-white-dwarfs TRUE --emit-gravitational-radiation TRUE --evolve-unbound-systems FALSE --maximum-neutron-star-mass 2.3

[jeffriley]

Thanks @SimonStevenson . I stand corrected - it seems they are logged to the SNe file. @reinhold-willcox wasn't able to see the either - maybe we were both just doing something wrong...

I'm happy to close this as a user misunderstanding if nobody else particularly wants it open. I'll clean up the code when I'm doing other changes.

[SimonStevenson]

I think they genuinely didn't exist before #1384 was merged, that's why you couldn't see them before (as shown in that PR, the previous dev produced 0 AIC/SN1A). As discussed above, HeSD still do not exist, but we have now identified why, and that will be fixed shortly.