Code cleaning -- gbParams #1297
Description
The solution to #1245 seems to be add two additional lines
gbParams(p) = CalculateCoreMass_Luminosity_p_Static(p_Mass, p_MassCutoffs);
gbParams(q) = CalculateCoreMass_Luminosity_q_Static(p_Mass, p_MassCutoffs);
in
HeHG::CalculateGBParams_Static().
We actually set these parameters just above, via a call to GiantBranch::CalculateGBParams_Static(), which calls the GiantBranch versions of the same functions CalculateCoreMass_Luminosity_p_Static() and CalculateCoreMass_Luminosity_q_Static(). However, these GiantBranch versions have different returns than HeHG versions. E.g., p=6 with the GiantBranch version and p=5 with the HeHG version on the following command with COMPAS 3.10.0:
./COMPAS -n 1 --random-seed 1724542090 --kick-magnitude-distribution ZERO --mass-ratio-distribution DUQUENNOYMAYOR1991 --semi-major-axis-distribution SANA2012 --minimum-secondary-mass 5 --metallicity-distribution LOGUNIFORM --tides-prescription PERFECT
We should return to this to make sure that we understand what we really want the code to do and whether it needs to be quite so convoluted.