Update to v1.8.3 (#122)

Author: Gregory Mitchell

README.md

@@ -36,6 +36,11 @@ With the freedom to have your own symbols, icons, conversion rates, and even int
   - Fix 1.20.2 Errors
   - Update Lamp to v3.1.7
     - Fix Command Errors 
+- **v1.8.3**
+  - Fix various SQL and SQL-Conversion related errors
+  - Fix Business Setting Serializability Errors
+  - Fix NBT Product Errors
+  - Fix Natural Increase sounds being played when not enabled
 
 ### 👔 1.7.0 Update: Cunning Corporations
 - New Features

api/src/main/java/us/teaminceptus/novaconomy/api/settings/Settings.java

@@ -224,12 +224,12 @@ public static final class Business<T> implements NovaSetting<T>, Serializable {
         private static final long serialVersionUID = -7174484717138758485L;
 
         private final String key;
-        private final Supplier<T> defaultValue;
+        private final T defaultValue;
         private final String dKey;
         private final Set<T> possibleValues;
         private final Class<T> clazz;
 
-        private Business(String key, String dKey, Class<T> clazz, Supplier<T> defaultValue, Set<T> possibleValues) {
+        private Business(String key, String dKey, Class<T> clazz, T defaultValue, Set<T> possibleValues) {
             this.key = key;
             this.dKey = dKey;
             this.defaultValue = defaultValue;
@@ -238,20 +238,20 @@ private Business(String key, String dKey, Class<T> clazz, Supplier<T> defaultVal
         }
 
         private static <T extends Enum<T>> Business<T> ofEnum(String key, String dKey, Class<T> clazz, T defaultValue) {
-            return new Business<>(key, dKey, clazz, () -> defaultValue, ImmutableSet.copyOf(defaultValue.getDeclaringClass().getEnumConstants()));
+            return new Business<>(key, dKey, clazz, defaultValue, ImmutableSet.copyOf(defaultValue.getDeclaringClass().getEnumConstants()));
         }
 
         private static Business<Boolean> ofBoolean(String key, String dKey, boolean defaultValue) {
-            return new Business<>(key, dKey, Boolean.class, () -> defaultValue, ImmutableSet.of(true, false));
+            return new Business<>(key, dKey, Boolean.class, defaultValue, ImmutableSet.of(true, false));
         }
 
         private static Business<Boolean> ofBoolean(String key, String dKey, Supplier<Boolean> defaultValue) {
-            return new Business<>(key, dKey, Boolean.class, defaultValue, ImmutableSet.of(true, false));
+            return new Business<>(key, dKey, Boolean.class, defaultValue.get(), ImmutableSet.of(true, false));
         }
 
         @Override
         public T getDefaultValue() {
-            return defaultValue.get();
+            return defaultValue;
         }
 
         @Override

build.gradle.kts

@@ -11,7 +11,7 @@ plugins {
 }
 
 val pGroup = "us.teaminceptus.novaconomy"
-val pVersion = "1.8.2-SNAPSHOT"
+val pVersion = "1.8.3-SNAPSHOT"
 val pAuthor = "Team-Inceptus"
 
 sonarqube {

nms/1_10_R1/src/main/java/us/teaminceptus/novaconomy/v1_10_R1/NBTWrapper1_10_R1.java

@@ -166,6 +166,7 @@ public void set(String key, Product product) {
         novaconomy.set(key, productT);
         tag.set(ROOT, novaconomy);
         nmsitem.setTag(tag);
+        item = CraftItemStack.asBukkitCopy(nmsitem);
     }
 
 }

nms/1_11_R1/src/main/java/us/teaminceptus/novaconomy/v1_11_R1/NBTWrapper1_11_R1.java

@@ -166,6 +166,7 @@ public void set(String key, Product product) {
         novaconomy.set(key, productT);
         tag.set(ROOT, novaconomy);
         nmsitem.setTag(tag);
+        item = CraftItemStack.asBukkitCopy(nmsitem);
     }
 
 }

nms/1_12_R1/src/main/java/us/teaminceptus/novaconomy/v1_12_R1/NBTWrapper1_12_R1.java

@@ -166,6 +166,7 @@ public void set(String key, Product product) {
         novaconomy.set(key, productT);
         tag.set(ROOT, novaconomy);
         nmsitem.setTag(tag);
+        item = CraftItemStack.asBukkitCopy(nmsitem);
     }
 
 }

nms/1_13_R1/src/main/java/us/teaminceptus/novaconomy/v1_13_R1/NBTWrapper1_13_R1.java

@@ -164,6 +164,7 @@ public void set(String key, Product product) {
         novaconomy.set(key, productT);
         tag.set(ROOT, novaconomy);
         nmsitem.setTag(tag);
+        item = CraftItemStack.asBukkitCopy(nmsitem);
     }
 
 }

nms/1_13_R2/src/main/java/us/teaminceptus/novaconomy/v1_13_R2/NBTWrapper1_13_R2.java

@@ -164,6 +164,7 @@ public void set(String key, Product product) {
         novaconomy.set(key, productT);
         tag.set(ROOT, novaconomy);
         nmsitem.setTag(tag);
+        item = CraftItemStack.asBukkitCopy(nmsitem);
     }
 
 }

nms/1_14_R1/src/main/java/us/teaminceptus/novaconomy/v1_14_R1/NBTWrapper1_14_R1.java

@@ -164,6 +164,7 @@ public void set(String key, Product product) {
         novaconomy.set(key, productT);
         tag.set(ROOT, novaconomy);
         nmsitem.setTag(tag);
+        item = CraftItemStack.asBukkitCopy(nmsitem);
     }
 
 }

nms/1_15_R1/src/main/java/us/teaminceptus/novaconomy/v1_15_R1/NBTWrapper1_15_R1.java

@@ -164,6 +164,7 @@ public void set(String key, Product product) {
         novaconomy.set(key, productT);
         tag.set(ROOT, novaconomy);
         nmsitem.setTag(tag);
+        item = CraftItemStack.asBukkitCopy(nmsitem);
     }
 
 }