Time does not freeze while in fishing

[shuhaowu]

When pause mode is set to ANY, and when a player enters fishing, time does not freeze. I can see this both via the golden clock and in the SMAPI logs.

I read through the code and don't completely understand how the playerstates are supposed to be transmitted, but since we're using the vanilla shouldTimePass function, I'm not sure why this would fail.

[shuhaowu]

It looks like Game1.shouldTimePass is bugged? The code there checks:

if (activeClickableMenu != null && !(activeClickableMenu is BobberBar)) {
  return false;

When you're fishing, the expression above is true && false == false. The overall method for shouldTimePass also returns true. Somehow, the fishing activity is pausing time slightly differently than everything else...

[shuhaowu]

In Game1._update, I see code like:

if (IsMultiplayer || (activeClickableMenu == null && currentMinigame == null))
{
	UpdateGameClock(gameTime);
}

Don't think this is the right code, but it probably suggest this is worked around somewhere else in singleplayer?

[shuhaowu]

That's definitely the right code after reading through a bit more, specifically, this information helped. So the way to maybe fix this is to patch UpdateGameClock with Harmony: if we see any player's currentMinigame != null, then we can skip executing the function (depending on the any/all setting). Not sure what kind of side effect this might have, especially since UpdateGameClock is also called in a few other places:

StardewValley/Events/FairyEvent.cs:87:                  Game1.UpdateGameClock(time);
StardewValley/Events/WitchEvent.cs:97:                  Game1.UpdateGameClock(time);
StardewValley/Events/WorldChangeEvent.cs:797:                   Game1.UpdateGameClock(time);
StardewValley/Game1.cs:4815:                                                            UpdateGameClock(gameTime);
StardewValley/Game1.cs:6340:            public static void UpdateGameClock(GameTime time)

Another way might be manipulating gameTimeInterval, which is what other mods do.