bugs improvement

Author: andrey-serdyuk

Directory.Build.props

@@ -4,7 +4,7 @@
 		<ImplicitUsings>enable</ImplicitUsings>
 		<Nullable>enable</Nullable>
 		<IsPackable>true</IsPackable>
-		<Version>2.3.16</Version>
+		<Version>2.3.19</Version>
 		<Authors>Andrey Serdyuk</Authors>
 		<Company>TaskHub</Company>
 		<Title>TaskHub.Shared - Reusable Primitives for .NET Microservices</Title>

TaskHub.Observability.OpenTelemetry/Bootstrap/OpenTelemetryBootstrap.cs

@@ -22,6 +22,9 @@ public static void AddAppOpenTelemetry(this IServiceCollection services, Action<
             t.AddAttributes([new("deployment.environment", options.Environment)]);
         }).WithTracing(t =>
         {
+            t.AddSource("CommandsBus", "NominatimClient", "NominatimService");
+            t.AddSource([.. options.Sources]);
+
             if (options.Sampling.IsEnabled)
             {
                 switch (options.Sampling.Type)
@@ -48,10 +51,6 @@ public static void AddAppOpenTelemetry(this IServiceCollection services, Action<
                 t.SetSampler(new AlwaysOffSampler());
             }
 
-            t.SetSampler(new TraceIdRatioBasedSampler(0.1f));
-            t.AddSource("CommandsBus", "NominatimClient", "NominatimService");
-            t.AddSource([.. options.Sources]);
-
             if (options.IsHttpTracesEnabled) t.AddHttpClientInstrumentation(o =>
             {
                 o.RecordException = options.RecordException;

TaskHub.Shared.Bootstraper.Full/FullHostBuilder.cs

@@ -49,9 +49,8 @@ protected override void AppStart()
         {
             Builder.Configuration.GetSection("OpenTelemetry").Bind(o);
 
-            var appInfo = Builder.Configuration.GetSection("ServiceInfo").Get<ServiceInfo>() ?? new();
-            o.ServiceName = appInfo.Name;
-            o.ServiceVersion = appInfo.Version;
+            o.ServiceName = Builder.Services.ServiceInfo.Name;
+            o.ServiceVersion = Builder.Services.ServiceInfo.Version;
         });
         Builder.Services.AddAppRedis(Builder.Configuration.GetSection("Redis").Bind);
         Builder.Services.AddAppSwagger(Builder.Configuration.GetSection("Swagger").Bind);

TaskHub.Shared.Networking.Implementation/Bootstrap/AppHttpClient.cs

@@ -16,8 +16,6 @@ public static void AddAppNetworkingSettings(this IServiceCollection services, Ac
     {
         var settings = new NetworkOptions();
         action(settings);
-        services.AddHttpClient();
-        services.AddSingleton(settings.Defaults);
         foreach (var (name, node) in settings.Services)
         {
             services.AddAppHttpClient(name, settings.Defaults, new OptionsResolver(settings.Defaults, node).Resolve());

TaskHub.Shared.Refactoring/Bootstrap/ServiceInfoBootsrap.cs

@@ -1,27 +1,40 @@
 using Microsoft.Extensions.DependencyInjection;
+using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using TaskHub.Shared.Refactoring.Models;
 
 namespace TaskHub.Shared.Refactoring.Bootstrap;
 
+[SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "<Pending>")]
+[SuppressMessage("Performance", "CA1822:Mark members as static", Justification = "<Pending>")]
 public static class ServiceInfoBootsrap
 {
-    public static void AddServiceInfo(this IServiceCollection services)
+    
+    private static ServiceInfo serviceInfo { get; set; } = null!;
+    extension(IServiceCollection services)
     {
-        var asm = Assembly.GetEntryAssembly()!;
-        var asmName = asm.GetName();
-        services.AddSingleton(new ServiceInfo
+
+        public ServiceInfo ServiceInfo => serviceInfo;
+
+        public void AddServiceInfo()
         {
-            Name = asmName.Name ?? AppDomain.CurrentDomain.FriendlyName,
-            Version = asm.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion ?? asmName.Version?.ToString() ?? "unknown",
-            VersionDotNet = Environment.Version.ToString()
-        });
-    }
+            var asm = Assembly.GetEntryAssembly()!;
+            var asmName = asm.GetName();
+            serviceInfo = new ServiceInfo
+            {
+                Name = asmName.Name ?? AppDomain.CurrentDomain.FriendlyName,
+                Version = asm.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion ?? asmName.Version?.ToString() ?? "unknown",
+                VersionDotNet = Environment.Version.ToString()
+            };
 
-    public static void AppAppServiceInfo(this IServiceCollection services, Action<ServiceInfo> action)
-    {
-        var settings = new ServiceInfo();
-        action(settings);
-        services.AddSingleton(settings);
+            services.AddSingleton(serviceInfo);
+        }
+
+        public void AppAppServiceInfo(Action<ServiceInfo> action)
+        {
+            serviceInfo = new ServiceInfo();
+            action(serviceInfo);
+            services.AddSingleton(serviceInfo);
+        }
     }
 }