!winrate Threshold of 4 hours should be configurable

[MazGrasl]

It should be possible to filter for 'last 24 hours' or 'last week'

[Taloth]

The underlying code already has support for this https://github.com/Taloth/Aoe4bot/blob/main/aoe4/handlers.js#L6 but it uses default 4 hour rolling window atm.

What'd I'd like is:

1. Support a threshold/duration/window/timespan query parameter, that follows the same logic. so duration=24 means last 24h. and duration=-12 means all games where the gap between games is less than 12h.
2. Support a !winrate vs TheViper last 30 h. Where the syntax should support last \d+ ?(h|hours?|d|days?|m|months?). However if we do, then we need to start fetching more pages of the /games endpoint.
3. Ask aoe4world dev to provide a filter /games?opponent={profile_id}, reducing the api calls and database joins of unrelated player details. (This doesn't work with the rolling window, only the 'last 7 days' stuff)

1 provides the defaults, and 2 really empowers players to see the winrate between players in a particular period. Although it lacks custom games atm.

[MazGrasl]

1. The gap between games parameter is pretty non-intuitive. Especially when the user has to enter it as a -X value. As it is now, specifying the gap between games and the timeframe is mutually exclusive. This should be handled as 2 different parameters IMHO.
2. Agreed, and it should probably include years too. The multiple fetching could be an issue, especially since you have to get them in chunks. Maybe Rene can add a parameter for the games list to specify a timestamp from where games should be counted.
3. Agreed, this should be added.

[Taloth]

Re 1: Yeah, we can have multiple query parameters. We can also just have two parameters on the function itself. Sugestions on the query parameter name?

Re 2: Dunno about that, imo 'years' isn't a relevant statistic, and would introduce a lot of api calls given the number of games involved. At least, till 3 is supported. As for someone's own overal winrate, I think limiting that to 1 month ought to be fine.

[MazGrasl]

1. I'd say timespan and gap. gap is not quite as descriptive, but that can be handled in the readme.
2. It's not relevant right now, but it might be in the future (maybe not for ranked, if they have seasons - but unranked could be a possibility). It does put some stress on the AoE4W API though (not as much if we can load it within 1 request), so maybe there should be some measure that it can't be spammed from twitch chat.

[Taloth]

Coded up some stuff. (just the timespan parsing, no paging yet)

Cmd: !winrate vs TheViper last 5 days
Output: Beastyqt played 4 games (3-1 | 75%) lasting 1 hour vs GL.TheViper in the last 5 days, 2 days ago

Doesn't quite 'flow', mentions 3 timespans.
~~ I could drop the last part , 2 days ago when a timespan is specified. Or leave it as is. what do you think?~~
Changed it to:
Beastyqt played 4 games (3-1 | 75%) totaling 1 hour vs GL.TheViper in the last 5 days [last played 3 days ago]
and
Beastyqt played 12 games (12-0 | 100%) totaling 3 hours in their last session [last played 1 hour ago]

How about 'idletime' instead of 'gap'?

[Taloth]

Merged but there's a performance thing that we need to fix once aoe4world api implements filtering opponents