Skip to content

Commit ed5c8a1

Browse files
committed
fix(changelog,plugin-oracle): drop non-canonical CHANGELOG section, narrow Oracle classifier to true SSL errors
1 parent 206db0d commit ed5c8a1

4 files changed

Lines changed: 3 additions & 16 deletions

File tree

CHANGELOG.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3131
- Welcome screen connection errors (single-click connect, sample database launch) also surface the structured SSL handshake message when applicable
3232
- All driver SSL mapping logic now lives in dedicated `XxxSSLMapping` files (PostgreSQL, MSSQL, Cassandra, MongoDB, Oracle); ClickHouse and Redis keep their existing encapsulated helpers
3333

34-
### Known limitations
35-
36-
- iOS app SSL form still uses a binary Toggle for non-MSSQL engines (mysql, mariadb, postgresql, redshift). Verify CA and Verify Identity are not yet exposed on iOS. macOS users get the full per-engine picker. Will be addressed in a follow-up.
37-
3834
### Fixed
3935

4036
- PostgreSQL connections to AWS RDS, Cloud SQL, Azure, and other hosted Postgres now succeed out of the box instead of failing with "no pg_hba.conf entry for host" (#1298)

Plugins/OracleDriverPlugin/OracleConnection.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,6 @@ final class OracleConnectionWrapper: @unchecked Sendable {
215215
if lower.contains("ora-28860") {
216216
return .cipherMismatch(serverMessage: message)
217217
}
218-
if lower.contains("ora-12537") || lower.contains("ora-12606") {
219-
return .serverRejectedPlaintext(serverMessage: message)
220-
}
221218
if lower.contains("certificate") && (lower.contains("verify") || lower.contains("untrusted")) {
222219
return .untrustedCertificate(serverMessage: message)
223220
}

TableProTests/PluginTestSources/PluginSSLClassifiers.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,6 @@ enum OracleClassifier {
125125
if lower.contains("ora-28860") {
126126
return .cipherMismatch(serverMessage: message)
127127
}
128-
if lower.contains("ora-12537") || lower.contains("ora-12606") {
129-
return .serverRejectedPlaintext(serverMessage: message)
130-
}
131128
if lower.contains("certificate") && (lower.contains("verify") || lower.contains("untrusted")) {
132129
return .untrustedCertificate(serverMessage: message)
133130
}

TableProTests/Plugins/PluginSSLClassifierTests.swift

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -169,12 +169,9 @@ struct OracleClassifierTests {
169169
}
170170
}
171171

172-
@Test("ORA-12606 → serverRejectedPlaintext")
173-
func testORA12606() {
174-
guard case .serverRejectedPlaintext = OracleClassifier.classifySSLError("ORA-12606: TNS: Application timeout occurred") else {
175-
Issue.record("Expected serverRejectedPlaintext")
176-
return
177-
}
172+
@Test("Network timeout (ORA-12606) is not classified as SSL")
173+
func testTimeoutNotSSL() {
174+
#expect(OracleClassifier.classifySSLError("ORA-12606: TNS: Application timeout occurred") == nil)
178175
}
179176

180177
@Test("ORA-28759 → clientCertRequired")

0 commit comments

Comments
 (0)