fix(datagrid): release table data via direct call instead of connection-scoped broadcast (#1139)

Author: datlechin

CHANGELOG.md

@@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Foreign key navigation from a table with unsaved edits opens the referenced table in a new window tab to preserve the edit buffer. Closing that new tab no longer wipes the original tab's data grid. Previously the new tab's teardown broadcast a connection-scoped event that other coordinators on the same connection received, causing them to release their cell data.
 - Tables sidebar refreshes automatically after a successful SQL import; the refresh notification now fires after the success sheet's dismissal animation, so the main window is key when the observer runs (#1114)
 - PostgreSQL connections honor the import dialog's "Disable foreign key checks" option via `SET session_replication_role = replica` (requires REPLICATION role or superuser; managed Postgres typically rejects it) (#1114)
 - PostgreSQL SQL exports preserve GENERATED ALWAYS AS IDENTITY values on round-trip (using OVERRIDING SYSTEM VALUE) and skip GENERATED ... STORED columns (#1114)

TablePro/Core/Events/AppEvents.swift

@@ -34,7 +34,6 @@ final class AppEvents {
 
     let databaseDidConnect = PassthroughSubject<DatabaseDidConnect, Never>()
 
-    let mainCoordinatorTeardown = PassthroughSubject<MainCoordinatorTeardown, Never>()
 
     // MARK: - Window
 
@@ -76,6 +75,3 @@ struct DatabaseDidConnect: Sendable {
     let connectionId: UUID
 }
 
-struct MainCoordinatorTeardown: Sendable {
-    let connectionId: UUID
-}

TablePro/Views/Main/MainContentCoordinator.swift

@@ -562,9 +562,7 @@ final class MainContentCoordinator {
         for task in activeSortTasks.values { task.cancel() }
         activeSortTasks.removeAll()
 
-        AppEvents.shared.mainCoordinatorTeardown.send(
-            MainCoordinatorTeardown(connectionId: connection.id)
-        )
+        dataTabDelegate?.tableViewCoordinator?.releaseData()
 
         tabSessionRegistry.removeAll()
         querySortCache.removeAll()

TablePro/Views/Results/DataGridCoordinator.swift

@@ -186,25 +186,12 @@ final class TableViewCoordinator: NSObject, NSTableViewDelegate, NSTableViewData
             }
     }
 
-    func observeTeardown(connectionId: UUID) {
-        teardownCancellable = AppEvents.shared.mainCoordinatorTeardown
-            .filter { $0.connectionId == connectionId }
-            .receive(on: RunLoop.main)
-            .sink { [weak self] _ in
-                Task {
-                    self?.releaseData()
-                }
-            }
-    }
-
-    private func releaseData() {
+    func releaseData() {
         overlayEditor?.dismiss(commit: false)
         settingsCancellable?.cancel()
         settingsCancellable = nil
         themeCancellable?.cancel()
         themeCancellable = nil
-        teardownCancellable?.cancel()
-        teardownCancellable = nil
         visualIndex.clear()
         displayCache.removeAllObjects()
         columnDisplayFormats = []
@@ -224,8 +211,6 @@ final class TableViewCoordinator: NSObject, NSTableViewDelegate, NSTableViewData
         activeFKPreviewPopover = nil
     }
 
-    private(set) var teardownCancellable: AnyCancellable?
-
     func updateCache() {
         let tableRows = tableRowsProvider()
         cachedRowCount = sortedIDs?.count ?? tableRows.count

TablePro/Views/Results/DataGridView.swift

@@ -124,9 +124,6 @@ struct DataGridView: NSViewRepresentable {
         context.coordinator.tableName = configuration.tableName
         context.coordinator.primaryKeyColumns = configuration.primaryKeyColumns
         context.coordinator.tabType = configuration.tabType
-        if let connectionId = configuration.connectionId {
-            context.coordinator.observeTeardown(connectionId: connectionId)
-        }
 
         return scrollView
     }
@@ -160,10 +157,6 @@ struct DataGridView: NSViewRepresentable {
             }
         }
 
-        if let connectionId = configuration.connectionId, coordinator.teardownCancellable == nil {
-            coordinator.observeTeardown(connectionId: connectionId)
-        }
-
         let latestRows = tableRowsProvider()
         let rowDisplayCount = sortedIDs?.count ?? latestRows.count
         let columnCount = latestRows.columns.count