some minor cleanup

Author: zhuzilin

slime/backends/megatron_utils/actor.py

@@ -468,7 +468,7 @@ def train_actor(self, rollout_id: int, rollout_data: RolloutBatch) -> None:
                 compute_advantages_and_returns(self.args, rollout_data)
 
             if self.rollout_data_postprocess is not None:
-                self.rollout_data_postprocess(self.args)
+                self.rollout_data_postprocess(self.args, rollout_id, rollout_data)
 
             log_rollout_data(
                 rollout_id,

slime/backends/sglang_utils/sglang_engine.py

@@ -51,7 +51,7 @@ def _to_local_gpu_id(physical_gpu_id: int) -> int:
 
 
 def launch_server_process(server_args: ServerArgs) -> multiprocessing.Process:
-    if hasattr(server_args, "encoder_only") and server_args.encoder_only:
+    if getattr(server_args, "encoder_only", False):
         from sglang.srt.disaggregation.encode_server import launch_server
     else:
         from sglang.srt.entrypoints.http_server import launch_server
@@ -250,13 +250,12 @@ def health_generate(self, timeout: float = 5.0) -> bool:
         if self.node_rank != 0:
             return True
 
-        url = f"http://{self.server_host}:{self.server_port}/health_generate"
-        try:
-            response = requests.get(url, timeout=timeout)
-            response.raise_for_status()
-            return True
-        except requests.RequestException:
-            raise
+        response = requests.get(
+            f"http://{self.server_host}:{self.server_port}/health_generate",
+            timeout=timeout,
+        )
+        response.raise_for_status()
+        return True
 
     def update_weights_from_tensor(
         self,

slime/utils/eval_config.py

@@ -122,6 +122,8 @@ class EvalDatasetConfig:
     # If set, eval will use ServerGenerationProxy to generate through AppServer
     app_service: str | None = None
 
+    eval_task_timeout: int | None = None
+
     metadata_overrides: dict[str, Any] = field(default_factory=dict)
 
     def __post_init__(self) -> None:

slime/utils/wandb_utils.py

@@ -89,8 +89,13 @@ def reinit_wandb_primary_with_open_metrics(args, router_addr):
     """
     if not args.use_wandb or _is_offline_mode(args):
         return
+    if getattr(args, "wandb_mode", None) == "disabled":
+        return
     if router_addr is None:
         return
+    wandb_run_id = getattr(args, "wandb_run_id", None)
+    if wandb_run_id is None:
+        return
 
     import sglang_router
 
@@ -105,7 +110,7 @@ def reinit_wandb_primary_with_open_metrics(args, router_addr):
     wandb.finish()
 
     init_kwargs = {
-        "id": args.wandb_run_id,
+        "id": wandb_run_id,
         "entity": args.wandb_team,
         "project": args.wandb_project,
         "resume": "allow",
@@ -123,6 +128,7 @@ def reinit_wandb_primary_with_open_metrics(args, router_addr):
     }
 
     if args.wandb_dir:
+        os.makedirs(args.wandb_dir, exist_ok=True)
         init_kwargs["dir"] = args.wandb_dir
 
     wandb.init(**init_kwargs)