From fa11ddf7d293602b9df61cf55cf76d07a264dae8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Sun, 3 May 2026 15:00:11 +0200 Subject: [PATCH 01/14] Add simple check for unexpected toasts at the end of tests and before visits / reloads --- tests/Frontend/e2e/AdminIndex.cy.js | 10 ++++ tests/Frontend/e2e/AdminRolesEdit.cy.js | 12 ++++ tests/Frontend/e2e/AdminRolesIndex.cy.js | 12 ++++ .../e2e/AdminRolesIndexRoleActions.cy.js | 5 ++ tests/Frontend/e2e/AdminRolesNew.cy.js | 8 +++ tests/Frontend/e2e/AdminRolesView.cy.js | 12 ++++ .../e2e/AdminRolesViewRoleActions.cy.js | 3 + tests/Frontend/e2e/AdminRoomTypesEdit.cy.js | 9 +++ tests/Frontend/e2e/AdminRoomTypesIndex.cy.js | 9 +++ .../AdminRoomTypesIndexRoomTypeActions.cy.js | 7 +++ tests/Frontend/e2e/AdminRoomTypesNew.cy.js | 7 +++ tests/Frontend/e2e/AdminRoomTypesView.cy.js | 7 +++ .../AdminRoomTypesViewRoomTypeActions.cy.js | 5 ++ tests/Frontend/e2e/AdminServerPoolsEdit.cy.js | 7 +++ .../Frontend/e2e/AdminServerPoolsIndex.cy.js | 11 ++++ ...minServerPoolsIndexServerPoolActions.cy.js | 5 ++ tests/Frontend/e2e/AdminServerPoolsNew.cy.js | 6 ++ tests/Frontend/e2e/AdminServerPoolsView.cy.js | 6 ++ ...dminServerPoolsViewServerPoolActions.cy.js | 3 + tests/Frontend/e2e/AdminServersEdit.cy.js | 6 ++ tests/Frontend/e2e/AdminServersIndex.cy.js | 11 ++++ .../e2e/AdminServersIndexServerActions.cy.js | 6 ++ tests/Frontend/e2e/AdminServersNew.cy.js | 4 ++ tests/Frontend/e2e/AdminServersView.cy.js | 8 +++ .../e2e/AdminServersViewServerActions.cy.js | 7 +++ tests/Frontend/e2e/AdminSettingsEdit.cy.js | 11 ++++ tests/Frontend/e2e/AdminSettingsGeneral.cy.js | 6 ++ tests/Frontend/e2e/AdminSettingsView.cy.js | 7 +++ tests/Frontend/e2e/AdminStreamingEdit.cy.js | 8 +++ tests/Frontend/e2e/AdminStreamingView.cy.js | 3 + tests/Frontend/e2e/AdminUsersEdit.cy.js | 6 ++ tests/Frontend/e2e/AdminUsersEditBase.cy.js | 4 ++ tests/Frontend/e2e/AdminUsersEditEmail.cy.js | 3 + tests/Frontend/e2e/AdminUsersEditOthers.cy.js | 2 + .../Frontend/e2e/AdminUsersEditSecurity.cy.js | 8 +++ tests/Frontend/e2e/AdminUsersIndex.cy.js | 14 +++++ .../e2e/AdminUsersIndexUserActions.cy.js | 7 +++ tests/Frontend/e2e/AdminUsersNew.cy.js | 9 +++ tests/Frontend/e2e/AdminUsersView.cy.js | 10 ++++ .../e2e/AdminUsersViewUserActions.cy.js | 5 ++ tests/Frontend/e2e/Banner.cy.js | 3 + tests/Frontend/e2e/Footer.cy.js | 13 +++++ tests/Frontend/e2e/ForgotPassword.cy.js | 5 ++ tests/Frontend/e2e/GeneralApplication.cy.js | 14 +++++ tests/Frontend/e2e/Login.cy.js | 23 ++++++++ tests/Frontend/e2e/Logout.cy.js | 3 + tests/Frontend/e2e/MeetingsIndex.cy.js | 9 +++ tests/Frontend/e2e/PasswordReset.cy.js | 5 ++ tests/Frontend/e2e/RoomsIndex.cy.js | 14 +++++ .../e2e/RoomsIndexCreateNewRoom.cy.js | 10 ++++ .../e2e/RoomsViewBrowserNotification.cy.js | 8 +++ tests/Frontend/e2e/RoomsViewDescription.cy.js | 6 ++ .../RoomsViewDescriptionTipTapEditor.cy.js | 7 +++ tests/Frontend/e2e/RoomsViewFiles.cy.js | 12 ++++ .../e2e/RoomsViewFilesFileActions.cy.js | 19 +++++++ tests/Frontend/e2e/RoomsViewGeneral.cy.js | 34 +++++++++++ tests/Frontend/e2e/RoomsViewHistory.cy.js | 5 ++ .../e2e/RoomsViewHistoryMeetingActions.cy.js | 4 ++ tests/Frontend/e2e/RoomsViewMeetings.cy.js | 56 +++++++++++++++++++ tests/Frontend/e2e/RoomsViewMembers.cy.js | 8 +++ .../e2e/RoomsViewMembersBulkActions.cy.js | 6 ++ .../e2e/RoomsViewMembersMemberActions.cy.js | 6 ++ .../e2e/RoomsViewPersonalizedLinks.cy.js | 7 +++ ...omsViewPersonalizedLinksTokenActions.cy.js | 7 +++ tests/Frontend/e2e/RoomsViewRecordings.cy.js | 12 ++++ .../RoomsViewRecordingsRecordingActions.cy.js | 11 ++++ tests/Frontend/e2e/RoomsViewSettings.cy.js | 10 ++++ .../RoomsViewSettingsRoomTypeActions.cy.js | 6 ++ tests/Frontend/e2e/RoomsViewStreaming.cy.js | 8 +++ .../e2e/RoomsViewStreamingConfigActions.cy.js | 5 ++ tests/Frontend/e2e/UserProfile.cy.js | 4 ++ tests/Frontend/e2e/UserProfileBase.cy.js | 5 ++ tests/Frontend/e2e/UserProfileEmail.cy.js | 4 ++ tests/Frontend/e2e/UserProfileOthers.cy.js | 2 + tests/Frontend/e2e/UserProfileSecurity.cy.js | 5 ++ tests/Frontend/e2e/VerifyEmail.cy.js | 4 ++ .../support/commands/generalCommands.js | 36 ++++++++++++ 77 files changed, 685 insertions(+) diff --git a/tests/Frontend/e2e/AdminIndex.cy.js b/tests/Frontend/e2e/AdminIndex.cy.js index 6b92cdbcb..bf4faf656 100644 --- a/tests/Frontend/e2e/AdminIndex.cy.js +++ b/tests/Frontend/e2e/AdminIndex.cy.js @@ -13,6 +13,7 @@ describe("Admin index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin"); + cy.checkFinalState(); }); it("visit without permission to view admin pages", function () { @@ -26,6 +27,7 @@ describe("Admin index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check admin index with all permissions", function () { @@ -93,6 +95,7 @@ describe("Admin index", function () { .and("have.attr", "href", "/admin") .and("include.text", "app.streaming") .and("include.text", "admin.streaming.tile_description"); + cy.checkFinalState(); }); it("open admin settings", function () { @@ -136,6 +139,7 @@ describe("Admin index", function () { cy.get('[data-test="admin-settings-link"]').click(); cy.url().should("include", "/admin/settings"); + cy.checkFinalState(); }); it("open admin users", function () { @@ -186,6 +190,7 @@ describe("Admin index", function () { cy.get('[data-test="admin-users-link"]').click(); cy.url().should("include", "/admin/users"); + cy.checkFinalState(); }); it("open admin roles", function () { @@ -228,6 +233,7 @@ describe("Admin index", function () { cy.get('[data-test="admin-roles-link"]').click(); cy.url().should("include", "/admin/roles"); + cy.checkFinalState(); }); it("open admin room types", function () { @@ -266,6 +272,7 @@ describe("Admin index", function () { cy.get('[data-test="admin-room-types-link"]').click(); cy.url().should("include", "/admin/room_types"); + cy.checkFinalState(); }); it("open admin servers", function () { @@ -308,6 +315,7 @@ describe("Admin index", function () { cy.get('[data-test="admin-servers-link"]').click(); cy.url().should("include", "/admin/servers"); + cy.checkFinalState(); }); it("open admin server pools", function () { @@ -350,6 +358,7 @@ describe("Admin index", function () { cy.get('[data-test="admin-server-pools-link"]').click(); cy.url().should("include", "/admin/server_pools"); + cy.checkFinalState(); }); it("open admin streaming", function () { @@ -403,5 +412,6 @@ describe("Admin index", function () { cy.get('[data-test="admin-streaming-link"]').click(); cy.url().should("include", "/admin/streaming_settings"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesEdit.cy.js b/tests/Frontend/e2e/AdminRolesEdit.cy.js index 352ac78d5..d1bf55b65 100644 --- a/tests/Frontend/e2e/AdminRolesEdit.cy.js +++ b/tests/Frontend/e2e/AdminRolesEdit.cy.js @@ -23,6 +23,7 @@ describe("Admin roles edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles/2/edit"); + cy.checkFinalState(); }); it("visit with user without permission to edit roles", function () { @@ -45,6 +46,7 @@ describe("Admin roles edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/roles/2/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("edit role", function () { @@ -522,6 +524,7 @@ describe("Admin roles edit", function () { "include.text", 'admin.breadcrumbs.roles.view_{"name":"Standard role"}', ); + cy.checkFinalState(); }); it("edit role with different room limits", function () { @@ -742,6 +745,7 @@ describe("Admin roles edit", function () { // Check that role page is shown cy.url().should("include", "/admin/roles/2"); cy.url().should("not.include", "/edit"); + cy.checkFinalState(); }); it("check permission list with different permission dependencies", function () { @@ -993,6 +997,7 @@ describe("Admin roles edit", function () { cy.checkPermissionGroup(4, "serverPools.delete", true, true, false); }); }); + cy.checkFinalState(); }); it("check permission list with restricted permissions", function () { @@ -1388,6 +1393,7 @@ describe("Admin roles edit", function () { ); }); }); + cy.checkFinalState(); }); it("edit role errors", function () { @@ -1676,6 +1682,7 @@ describe("Admin roles edit", function () { cy.url().should("include", "/login?redirect=/admin/roles/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load permissions errors", function () { @@ -1756,6 +1763,7 @@ describe("Admin roles edit", function () { cy.url().should("include", "/login?redirect=/admin/roles/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load role errors", function () { @@ -1839,6 +1847,7 @@ describe("Admin roles edit", function () { cy.url().should("include", "/login?redirect=/admin/roles/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -1871,6 +1880,7 @@ describe("Admin roles edit", function () { .should("be.visible") .and("not.be.disabled") .and("include.text", "app.save"); + cy.checkFinalState(); }); it("check view for user that is superuser", function () { @@ -2034,6 +2044,7 @@ describe("Admin roles edit", function () { cy.checkPermissionGroup(30, "serverPools.update", true, true, true); cy.checkPermissionGroup(31, "serverPools.create", true, true, true); cy.checkPermissionGroup(32, "serverPools.delete", true, true, true); + cy.checkFinalState(); }); it("check view for user that is no superuser", function () { @@ -2198,5 +2209,6 @@ describe("Admin roles edit", function () { cy.checkPermissionGroup(30, "serverPools.update", true, true, true); cy.checkPermissionGroup(31, "serverPools.create", true, true, true); cy.checkPermissionGroup(32, "serverPools.delete", true, true, true); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesIndex.cy.js b/tests/Frontend/e2e/AdminRolesIndex.cy.js index d392055e9..1a89bfd3a 100644 --- a/tests/Frontend/e2e/AdminRolesIndex.cy.js +++ b/tests/Frontend/e2e/AdminRolesIndex.cy.js @@ -16,6 +16,7 @@ describe("Admin roles index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles"); + cy.checkFinalState(); }); it("visit with user without permission to view roles", function () { @@ -35,6 +36,7 @@ describe("Admin roles index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/roles"); cy.get("h1").should("be.visible").and("contain", "home.title"); + cy.checkFinalState(); }); it("load roles", function () { @@ -117,6 +119,7 @@ describe("Admin roles index", function () { .should("include.text", "Students") .and("not.include.text", "admin.roles.superuser"); }); + cy.checkFinalState(); }); it("load roles errors", function () { @@ -266,6 +269,7 @@ describe("Admin roles index", function () { cy.url().should("include", "/login?redirect=/admin/roles"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load roles page out of bounds", function () { @@ -346,6 +350,7 @@ describe("Admin roles index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("role search", function () { @@ -525,6 +530,7 @@ describe("Admin roles index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("sort roles", function () { @@ -687,6 +693,7 @@ describe("Admin roles index", function () { .eq(0) .should("include.text", "Superuser") .and("include.text", "admin.roles.superuser"); + cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -739,6 +746,7 @@ describe("Admin roles index", function () { cy.get('[data-test="roles-edit-button"]').should("not.exist"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -798,6 +806,7 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -860,6 +869,7 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -923,6 +933,7 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("be.visible"); }); + cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -987,6 +998,7 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("be.visible"); }); + cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js b/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js index e7bb1f004..f65925625 100644 --- a/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js +++ b/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js @@ -105,6 +105,7 @@ describe("Admin roles index role actions", function () { .should("have.text", "app.no") .click(); cy.get('[data-test="roles-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete role errors", function () { @@ -175,6 +176,7 @@ describe("Admin roles index role actions", function () { cy.url().should("include", "/login?redirect=/admin/roles"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("open add new role page", function () { @@ -185,6 +187,7 @@ describe("Admin roles index role actions", function () { cy.get('[data-test="roles-add-button"]').click(); cy.url().should("include", "/admin/roles/new"); + cy.checkFinalState(); }); it("open edit role page", function () { @@ -198,6 +201,7 @@ describe("Admin roles index role actions", function () { .find('[data-test="roles-edit-button"]') .click(); cy.url().should("include", "/admin/roles/2/edit"); + cy.checkFinalState(); }); it("open view role page", function () { @@ -211,5 +215,6 @@ describe("Admin roles index role actions", function () { .find('[data-test="roles-view-button"]') .click(); cy.url().should("include", "/admin/roles/2"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesNew.cy.js b/tests/Frontend/e2e/AdminRolesNew.cy.js index e66f2b71d..1317f22c8 100644 --- a/tests/Frontend/e2e/AdminRolesNew.cy.js +++ b/tests/Frontend/e2e/AdminRolesNew.cy.js @@ -23,6 +23,7 @@ describe("Admin roles new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles/new"); + cy.checkFinalState(); }); it("visit with user without permission to add new roles", function () { @@ -43,6 +44,7 @@ describe("Admin roles new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/room_types"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("add new role", function () { @@ -488,6 +490,7 @@ describe("Admin roles new", function () { "include.text", 'admin.breadcrumbs.roles.view_{"name":"Standard role"}', ); + cy.checkFinalState(); }); it("add new role with different room limits", function () { @@ -689,6 +692,7 @@ describe("Admin roles new", function () { // Check that role page is shown cy.url().should("include", "/admin/roles/40"); + cy.checkFinalState(); }); it("check permission list with different permission dependencies", function () { @@ -931,6 +935,7 @@ describe("Admin roles new", function () { cy.checkPermissionGroup(4, "serverPools.delete", true, true, false); }); }); + cy.checkFinalState(); }); it("check permission list with restricted permissions", function () { @@ -1317,6 +1322,7 @@ describe("Admin roles new", function () { ); }); }); + cy.checkFinalState(); }); it("add roles errors", function () { @@ -1395,6 +1401,7 @@ describe("Admin roles new", function () { cy.url().should("include", "/login?redirect=/admin/roles/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load permissions errors", function () { @@ -1471,5 +1478,6 @@ describe("Admin roles new", function () { cy.url().should("include", "/login?redirect=/admin/roles/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesView.cy.js b/tests/Frontend/e2e/AdminRolesView.cy.js index 726a7a879..5b5ea2fab 100644 --- a/tests/Frontend/e2e/AdminRolesView.cy.js +++ b/tests/Frontend/e2e/AdminRolesView.cy.js @@ -20,6 +20,7 @@ describe("Admin roles view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles/2"); + cy.checkFinalState(); }); it("visit with user without permission to view roles", function () { @@ -37,6 +38,7 @@ describe("Admin roles view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check rolesView shown correctly", function () { @@ -278,6 +280,7 @@ describe("Admin roles view", function () { ); }); }); + cy.checkFinalState(); }); it("check rolesView with no permissions available", function () { @@ -335,6 +338,7 @@ describe("Admin roles view", function () { cy.get('[data-test="permission-list"]').should("not.exist"); cy.contains("admin.roles.no_options").should("be.visible"); + cy.checkFinalState(); }); it("check rolesView with different permission dependencies", function () { @@ -507,6 +511,7 @@ describe("Admin roles view", function () { ); }); }); + cy.checkFinalState(); }); it("check rolesView with different room limit settings", function () { @@ -632,6 +637,7 @@ describe("Admin roles view", function () { .and("have.value", "2") .and("be.disabled"); }); + cy.checkFinalState(); }); it("load role errors", function () { @@ -715,6 +721,7 @@ describe("Admin roles view", function () { cy.url().should("include", "/login?redirect=/admin/roles/2"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load permissions errors", function () { @@ -790,6 +797,7 @@ describe("Admin roles view", function () { cy.url().should("include", "/login?redirect=/admin/roles/2"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -817,6 +825,7 @@ describe("Admin roles view", function () { .and("have.attr", "href", "/admin/roles/2/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); cy.get('[data-test="roles-save-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -848,6 +857,7 @@ describe("Admin roles view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="roles-save-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility for user that is superuser", function () { @@ -902,6 +912,7 @@ describe("Admin roles view", function () { .and("include.text", "app.edit") .and("have.attr", "href", "/admin/roles/2/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -958,5 +969,6 @@ describe("Admin roles view", function () { .and("include.text", "app.edit") .and("have.attr", "href", "/admin/roles/2/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js b/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js index 0f4f99da8..c5e99b522 100644 --- a/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js +++ b/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js @@ -85,6 +85,7 @@ describe("Admin roles view role actions", function () { // Check that dialog was closed cy.get('[data-test="roles-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete role errors", function () { @@ -150,6 +151,7 @@ describe("Admin roles view role actions", function () { cy.url().should("include", "/login?redirect=/admin/roles/2"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -390,5 +392,6 @@ describe("Admin roles view role actions", function () { cy.get('[data-test="roles-save-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js b/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js index 101f907f6..e36580373 100644 --- a/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js @@ -24,6 +24,7 @@ describe("Admin room types edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types/3/edit"); + cy.checkFinalState(); }); it("visit with user without permission to edit room types", function () { @@ -42,6 +43,7 @@ describe("Admin room types edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("edit room type", function () { @@ -869,6 +871,7 @@ describe("Admin room types edit", function () { "include.text", 'admin.breadcrumbs.room_types.view_{"name":"Exam 01"}', ); + cy.checkFinalState(); }); it("edit room type with restrictions", function () { @@ -1181,6 +1184,7 @@ describe("Admin room types edit", function () { // Check that room type view page is shown cy.url().should("include", "/admin/room_types/3"); cy.url().should("not.include", "/edit"); + cy.checkFinalState(); }); it("edit room type errors", function () { @@ -2118,6 +2122,7 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load room type errors", function () { @@ -2196,6 +2201,7 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -2229,6 +2235,7 @@ describe("Admin room types edit", function () { .should("be.visible") .and("not.be.disabled") .and("include.text", "app.save"); + cy.checkFinalState(); }); it("load roles errors", function () { @@ -2436,6 +2443,7 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load server pools errors", function () { @@ -2602,5 +2610,6 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js b/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js index 85c27bd08..07917f27b 100644 --- a/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js @@ -16,6 +16,7 @@ describe("Admin room types index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types"); + cy.checkFinalState(); }); it("load room types", function () { @@ -85,6 +86,7 @@ describe("Admin room types index", function () { .eq(0) .should("have.text", "Lecture"); }); + cy.checkFinalState(); }); it("load room types errors", function () { @@ -151,6 +153,7 @@ describe("Admin room types index", function () { cy.url().should("include", "/login?redirect=/admin/room_types"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load room types with no data", function () { @@ -163,6 +166,7 @@ describe("Admin room types index", function () { }); cy.visit("/admin/room_types"); + cy.checkFinalState(); }); it("room type search and sorting", function () { @@ -286,6 +290,7 @@ describe("Admin room types index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -324,6 +329,7 @@ describe("Admin room types index", function () { cy.get('[data-test="room-types-edit-button"]').should("not.exist"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -372,6 +378,7 @@ describe("Admin room types index", function () { .and("have.attr", "href", "/admin/room_types/1/edit"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -423,6 +430,7 @@ describe("Admin room types index", function () { .and("have.attr", "href", "/admin/room_types/1/edit"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -475,6 +483,7 @@ describe("Admin room types index", function () { .and("have.attr", "href", "/admin/room_types/1/edit"); cy.get('[data-test="room-types-delete-button"]').should("be.visible"); }); + cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js b/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js index 00ba597ad..10a9a2778 100644 --- a/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js @@ -142,6 +142,7 @@ describe("Admin room types index room type actions", function () { "include.text", 'admin.room_types.delete.confirm_{"name":"Meeting"}', ); + cy.checkFinalState(); }); it("delete room type with replacement", function () { @@ -252,6 +253,7 @@ describe("Admin room types index room type actions", function () { // Check that dialog is closed cy.get('[data-test="room-types-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete room type errors", function () { @@ -392,6 +394,7 @@ describe("Admin room types index room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load replacement room types errors", function () { @@ -489,6 +492,7 @@ describe("Admin room types index room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("open add new room type page", function () { @@ -501,6 +505,7 @@ describe("Admin room types index room type actions", function () { cy.get('[data-test="room-types-add-button"]').click(); cy.url().should("include", "/admin/room_types/new"); + cy.checkFinalState(); }); it("open edit room type page", function () { @@ -516,6 +521,7 @@ describe("Admin room types index room type actions", function () { .click(); cy.url().should("include", "/admin/room_types/3/edit"); + cy.checkFinalState(); }); it("open view room type page", function () { @@ -532,5 +538,6 @@ describe("Admin room types index room type actions", function () { cy.url().should("include", "/admin/room_types/3"); cy.url().should("not.include", "/edit"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesNew.cy.js b/tests/Frontend/e2e/AdminRoomTypesNew.cy.js index c68f5b30c..dcef9b3cc 100644 --- a/tests/Frontend/e2e/AdminRoomTypesNew.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesNew.cy.js @@ -24,6 +24,7 @@ describe("Admin room types new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types/new"); + cy.checkFinalState(); }); it("visit with user without permission to add new room types", function () { @@ -46,6 +47,7 @@ describe("Admin room types new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/room_types"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("add new room type", function () { @@ -741,6 +743,7 @@ describe("Admin room types new", function () { "include.text", 'admin.breadcrumbs.room_types.view_{"name":"Exam 01"}', ); + cy.checkFinalState(); }); it("add new room type with restrictions", function () { @@ -1074,6 +1077,7 @@ describe("Admin room types new", function () { // Check that room type page is shown cy.url().should("include", "/admin/room_types/30"); + cy.checkFinalState(); }); it("add new room type errors", function () { @@ -1543,6 +1547,7 @@ describe("Admin room types new", function () { cy.url().should("include", "/login?redirect=/admin/room_types/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load roles errors", function () { @@ -1688,6 +1693,7 @@ describe("Admin room types new", function () { cy.url().should("include", "/login?redirect=/admin/room_types/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load server pools errors", function () { @@ -1844,5 +1850,6 @@ describe("Admin room types new", function () { cy.url().should("include", "/login?redirect=/admin/room_types/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesView.cy.js b/tests/Frontend/e2e/AdminRoomTypesView.cy.js index 3ec2cd60f..64e97d860 100644 --- a/tests/Frontend/e2e/AdminRoomTypesView.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesView.cy.js @@ -16,6 +16,7 @@ describe("Admin room types view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types/3"); + cy.checkFinalState(); }); it("visit with user without permission to view room types", function () { @@ -34,6 +35,7 @@ describe("Admin room types view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check roomTypeView shown correctly", function () { @@ -534,6 +536,7 @@ describe("Admin room types view", function () { ) .and("be.disabled"); }); + cy.checkFinalState(); }); it("check restrictions shown correctly", function () { @@ -585,6 +588,7 @@ describe("Admin room types view", function () { .should("not.exist"); }); }); + cy.checkFinalState(); }); it("open view errors", function () { @@ -664,6 +668,7 @@ describe("Admin room types view", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -692,6 +697,7 @@ describe("Admin room types view", function () { .and("have.attr", "href", "/admin/room_types/3/edit"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); cy.get('[data-test="room-types-save-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -725,5 +731,6 @@ describe("Admin room types view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="room-types-save-button"]').should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js b/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js index 6234d50dd..a9648108d 100644 --- a/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js @@ -113,6 +113,7 @@ describe("Admin room types view room type actions", function () { // Check that redirect worked cy.url().should("not.include", "/admin/room_types/3"); cy.url().should("include", "/admin/room_types"); + cy.checkFinalState(); }); it("delete room type with replacement", function () { @@ -213,6 +214,7 @@ describe("Admin room types view room type actions", function () { // Check that redirect worked cy.url().should("not.include", "/admin/room_types/3"); cy.url().should("include", "/admin/room_types"); + cy.checkFinalState(); }); it("delete room type errors", function () { @@ -300,6 +302,7 @@ describe("Admin room types view room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load replacement room types errors", function () { @@ -389,6 +392,7 @@ describe("Admin room types view room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -962,5 +966,6 @@ describe("Admin room types view room type actions", function () { cy.get('[data-test="room-types-save-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js b/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js index f68700754..2d62d68a2 100644 --- a/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js @@ -24,6 +24,7 @@ describe("Admin server pools edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools/1"); + cy.checkFinalState(); }); it("visit with user without permission to edit server pools", function () { @@ -47,6 +48,7 @@ describe("Admin server pools edit", function () { cy.url().should("not.include", "/admin/server_pools/1/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); }); + cy.checkFinalState(); }); it("edit server pool", function () { @@ -385,6 +387,7 @@ describe("Admin server pools edit", function () { "include.text", 'admin.breadcrumbs.server_pools.view_{"name":"Server Pool 1"}', ); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -655,6 +658,7 @@ describe("Admin server pools edit", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -689,6 +693,7 @@ describe("Admin server pools edit", function () { .should("be.visible") .and("not.be.disabled") .and("include.text", "app.save"); + cy.checkFinalState(); }); it("load server pool errors", function () { @@ -767,6 +772,7 @@ describe("Admin server pools edit", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load servers errors", function () { @@ -916,5 +922,6 @@ describe("Admin server pools edit", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js b/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js index e365e1568..8ead7e82c 100644 --- a/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js @@ -16,6 +16,7 @@ describe("Admin server pools index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools"); + cy.checkFinalState(); }); it("visit with user without permission to view server pools", function () { @@ -33,6 +34,7 @@ describe("Admin server pools index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/servers"); cy.get("h1").should("be.visible").and("contain", "home.title"); + cy.checkFinalState(); }); it("load server pools", function () { @@ -115,6 +117,7 @@ describe("Admin server pools index", function () { .eq(1) .should("have.text", "1"); }); + cy.checkFinalState(); }); it("load server pools errors", function () { @@ -268,6 +271,7 @@ describe("Admin server pools index", function () { cy.url().should("include", "/login?redirect=/admin/server_pools"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load server pools page out of bounds", function () { @@ -331,6 +335,7 @@ describe("Admin server pools index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("server pools search", function () { @@ -506,6 +511,7 @@ describe("Admin server pools index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("sort server pools", function () { @@ -758,6 +764,7 @@ describe("Admin server pools index", function () { .eq(0) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); + cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -799,6 +806,7 @@ describe("Admin server pools index", function () { cy.get('[data-test="server-pools-edit-button"]').should("not.exist"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -846,6 +854,7 @@ describe("Admin server pools index", function () { .and("have.attr", "href", "/admin/server_pools/2/edit"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -896,6 +905,7 @@ describe("Admin server pools index", function () { .and("have.attr", "href", "/admin/server_pools/2/edit"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -947,6 +957,7 @@ describe("Admin server pools index", function () { .and("have.attr", "href", "/admin/server_pools/2/edit"); cy.get('[data-test="server-pools-delete-button"]').should("be.visible"); }); + cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js b/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js index b55176956..4911afb9c 100644 --- a/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js @@ -109,6 +109,7 @@ describe("Admin server pools index server pool actions", function () { // Cancel delete of server pool cy.get('[data-test="dialog-cancel-button"]').click(); cy.get('[data-test="server-pools-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete server pool errors", function () { @@ -210,6 +211,7 @@ describe("Admin server pools index server pool actions", function () { cy.url().should("include", "/login?redirect=/admin/server_pools"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("open add new server pool page", function () { @@ -222,6 +224,7 @@ describe("Admin server pools index server pool actions", function () { cy.get('[data-test="server-pools-add-button"]').click(); cy.url().should("include", "/admin/server_pools/new"); + cy.checkFinalState(); }); it("open edit server pool page", function () { @@ -237,6 +240,7 @@ describe("Admin server pools index server pool actions", function () { .click(); cy.url().should("include", "/admin/server_pools/1/edit"); + cy.checkFinalState(); }); it("open view server pool page", function () { @@ -253,5 +257,6 @@ describe("Admin server pools index server pool actions", function () { cy.url().should("include", "/admin/server_pools/1"); cy.url().should("not.include", "/edit"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsNew.cy.js b/tests/Frontend/e2e/AdminServerPoolsNew.cy.js index 7e50d0d0a..dbdc32440 100644 --- a/tests/Frontend/e2e/AdminServerPoolsNew.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsNew.cy.js @@ -24,6 +24,7 @@ describe("Admin server pools new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools/new"); + cy.checkFinalState(); }); it("visit with user without permission to add new server pools", function () { @@ -48,6 +49,7 @@ describe("Admin server pools new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("add new server pool with 1 server", function () { @@ -224,6 +226,7 @@ describe("Admin server pools new", function () { // Check that server pool page is shown cy.url().should("include", "/admin/server_pools/20"); + cy.checkFinalState(); }); it("add new server pool with several servers", function () { @@ -437,6 +440,7 @@ describe("Admin server pools new", function () { // Check that user page is shown cy.url().should("include", "/admin/server_pools/20"); + cy.checkFinalState(); }); it("add new server pool errors", function () { @@ -534,6 +538,7 @@ describe("Admin server pools new", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load servers errors", function () { @@ -680,5 +685,6 @@ describe("Admin server pools new", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsView.cy.js b/tests/Frontend/e2e/AdminServerPoolsView.cy.js index 6fef329d9..b4bc4a2a9 100644 --- a/tests/Frontend/e2e/AdminServerPoolsView.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsView.cy.js @@ -20,6 +20,7 @@ describe("Admin server pools view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools/1"); + cy.checkFinalState(); }); it("visit with user without permission to view server pools", function () { @@ -38,6 +39,7 @@ describe("Admin server pools view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/servers/1"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check serverPoolView shown correctly", function () { @@ -121,6 +123,7 @@ describe("Admin server pools view", function () { .should("not.exist"); }); }); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -150,6 +153,7 @@ describe("Admin server pools view", function () { .and("have.attr", "href", "/admin/server_pools/1/edit"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); cy.get('[data-test="server-pools-save-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -183,6 +187,7 @@ describe("Admin server pools view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="server-pools-save-button"]').should("not.exist"); + cy.checkFinalState(); }); it("open view errors", function () { @@ -261,5 +266,6 @@ describe("Admin server pools view", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js b/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js index 0f0d98e74..b83aa46a3 100644 --- a/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js @@ -82,6 +82,7 @@ describe("Admin server pools view", function () { // Check that redirect worked cy.url().should("not.include", "/admin/server_pools/1"); cy.url().should("include", "/admin/server_pools"); + cy.checkFinalState(); }); it("delete server pool errors", function () { @@ -175,6 +176,7 @@ describe("Admin server pools view", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -312,5 +314,6 @@ describe("Admin server pools view", function () { cy.get('[data-test="server-pools-save-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersEdit.cy.js b/tests/Frontend/e2e/AdminServersEdit.cy.js index 47999c57f..b287c519e 100644 --- a/tests/Frontend/e2e/AdminServersEdit.cy.js +++ b/tests/Frontend/e2e/AdminServersEdit.cy.js @@ -23,6 +23,7 @@ describe("Admin servers edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers/1/edit"); + cy.checkFinalState(); }); it("visit with user without permission to edit servers", function () { @@ -46,6 +47,7 @@ describe("Admin servers edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/users/2/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("edit server", function () { @@ -345,6 +347,7 @@ describe("Admin servers edit", function () { // Check that delete button is now hidden because server is enabled and // therefore cannot be deleted cy.get('[data-test="servers-delete-button"]').should("not.exist"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -676,6 +679,7 @@ describe("Admin servers edit", function () { cy.url().should("include", "/login?redirect=/admin/servers/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -780,6 +784,7 @@ describe("Admin servers edit", function () { .and("not.be.disabled"); cy.get('[data-test="servers-panic-button"]').should("not.exist"); + cy.checkFinalState(); }); it("load server errors", function () { @@ -857,5 +862,6 @@ describe("Admin servers edit", function () { cy.url().should("include", "/login?redirect=/admin/servers/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersIndex.cy.js b/tests/Frontend/e2e/AdminServersIndex.cy.js index 63ab49733..d310836d2 100644 --- a/tests/Frontend/e2e/AdminServersIndex.cy.js +++ b/tests/Frontend/e2e/AdminServersIndex.cy.js @@ -16,6 +16,7 @@ describe("Admin servers index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers"); + cy.checkFinalState(); }); it("visit with user without permission to view servers", function () { @@ -36,6 +37,7 @@ describe("Admin servers index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/servers"); cy.get("h1").should("be.visible").and("contain", "home.title"); + cy.checkFinalState(); }); it("load servers", function () { @@ -272,6 +274,7 @@ describe("Admin servers index", function () { .eq(6) .should("have.text", " --- "); }); + cy.checkFinalState(); }); it("load servers errors", function () { @@ -444,6 +447,7 @@ describe("Admin servers index", function () { cy.url().should("include", "/login?redirect=/admin/servers"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load servers page out of bounds", function () { @@ -522,6 +526,7 @@ describe("Admin servers index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("server search", function () { @@ -710,6 +715,7 @@ describe("Admin servers index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("sort servers", function () { @@ -1048,6 +1054,7 @@ describe("Admin servers index", function () { .eq(6) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); + cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -1109,6 +1116,7 @@ describe("Admin servers index", function () { cy.get('[data-test="servers-edit-button" ]').should("not.exist"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -1188,6 +1196,7 @@ describe("Admin servers index", function () { .and("have.attr", "href", "/admin/servers/4/edit"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -1270,6 +1279,7 @@ describe("Admin servers index", function () { .and("have.attr", "href", "/admin/servers/4/edit"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -1352,5 +1362,6 @@ describe("Admin servers index", function () { .and("have.attr", "href", "/admin/servers/4/edit"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js b/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js index de197e493..c48ea35ea 100644 --- a/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js +++ b/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js @@ -113,6 +113,7 @@ describe("Admin servers index server actions", function () { // Cancel delete of server cy.get('[data-test="dialog-cancel-button"]').click(); cy.get('[data-test="servers-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete server errors", function () { @@ -162,6 +163,7 @@ describe("Admin servers index server actions", function () { cy.url().should("include", "/login?redirect=/admin/servers"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("reload servers", function () { @@ -385,6 +387,7 @@ describe("Admin servers index server actions", function () { cy.get('[data-test="paginator-page"]') .eq(1) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("open add new server page", function () { @@ -395,6 +398,7 @@ describe("Admin servers index server actions", function () { cy.get('[data-test="servers-add-button"]').click(); cy.url().should("include", "/admin/servers/new"); + cy.checkFinalState(); }); it("open edit server page", function () { @@ -410,6 +414,7 @@ describe("Admin servers index server actions", function () { .click(); cy.url().should("include", "/admin/servers/1/edit"); + cy.checkFinalState(); }); it("open view server page", function () { @@ -426,5 +431,6 @@ describe("Admin servers index server actions", function () { cy.url().should("include", "/admin/servers/1"); cy.url().should("not.include", "/edit"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersNew.cy.js b/tests/Frontend/e2e/AdminServersNew.cy.js index 3d8bdc4ac..13ee16dbc 100644 --- a/tests/Frontend/e2e/AdminServersNew.cy.js +++ b/tests/Frontend/e2e/AdminServersNew.cy.js @@ -23,6 +23,7 @@ describe("Admin servers view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers/new"); + cy.checkFinalState(); }); it("visit with user without permission to add new servers", function () { @@ -47,6 +48,7 @@ describe("Admin servers view", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("add new server", function () { @@ -290,6 +292,7 @@ describe("Admin servers view", function () { "include.text", 'admin.breadcrumbs.servers.view_{"name":"Server 01"}', ); + cy.checkFinalState(); }); it("add new server errors", function () { @@ -450,5 +453,6 @@ describe("Admin servers view", function () { cy.url().should("include", "/login?redirect=/admin/servers/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersView.cy.js b/tests/Frontend/e2e/AdminServersView.cy.js index ffd6144e3..4aca496bc 100644 --- a/tests/Frontend/e2e/AdminServersView.cy.js +++ b/tests/Frontend/e2e/AdminServersView.cy.js @@ -20,6 +20,7 @@ describe("Admin servers view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers/1"); + cy.checkFinalState(); }); it("visit with user without permission to view servers", function () { @@ -38,6 +39,7 @@ describe("Admin servers view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/servers/1"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check serverView shown correctly (server enabled)", function () { @@ -207,6 +209,7 @@ describe("Admin servers view", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check serverView shown correctly (server draining)", function () { @@ -265,6 +268,7 @@ describe("Admin servers view", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check serverView shown correctly (server disabled)", function () { @@ -327,6 +331,7 @@ describe("Admin servers view", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -427,6 +432,7 @@ describe("Admin servers view", function () { .and("not.be.disabled"); cy.get('[data-test="servers-panic-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -531,6 +537,7 @@ describe("Admin servers view", function () { .and("not.be.disabled"); cy.get('[data-test="servers-panic-button"]').should("not.exist"); + cy.checkFinalState(); }); it("open view errors", function () { @@ -609,5 +616,6 @@ describe("Admin servers view", function () { cy.url().should("include", "/login?redirect=/admin/servers/1"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersViewServerActions.cy.js b/tests/Frontend/e2e/AdminServersViewServerActions.cy.js index 024f069f4..66da67f33 100644 --- a/tests/Frontend/e2e/AdminServersViewServerActions.cy.js +++ b/tests/Frontend/e2e/AdminServersViewServerActions.cy.js @@ -94,6 +94,7 @@ describe("Admin servers view server actions", function () { // Check that dialog is closed cy.get('[data-test="servers-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete server errors", function () { @@ -148,6 +149,7 @@ describe("Admin servers view server actions", function () { cy.url().should("include", "/login?redirect=/admin/servers/1"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check connection", function () { @@ -262,6 +264,7 @@ describe("Admin servers view server actions", function () { "not.include.text", "admin.servers.offline_reason", ); + cy.checkFinalState(); }); it("check connection errors", function () { @@ -308,6 +311,7 @@ describe("Admin servers view server actions", function () { cy.url().should("include", "/login?redirect=/admin/servers/1"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("panic", function () { @@ -383,6 +387,7 @@ describe("Admin servers view server actions", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); + cy.checkFinalState(); }); it("panic errors", function () { @@ -421,6 +426,7 @@ describe("Admin servers view server actions", function () { cy.url().should("include", "/login?redirect=/admin/servers/1"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -593,5 +599,6 @@ describe("Admin servers view server actions", function () { cy.get('[data-test="servers-save-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminSettingsEdit.cy.js b/tests/Frontend/e2e/AdminSettingsEdit.cy.js index 1b892e85a..5a9517a99 100644 --- a/tests/Frontend/e2e/AdminSettingsEdit.cy.js +++ b/tests/Frontend/e2e/AdminSettingsEdit.cy.js @@ -359,6 +359,7 @@ describe("Admin settings with edit permission", function () { "Europe/Berlin", ); cy.get("#no-welcome-page").should("not.be.checked"); + cy.checkFinalState(); }); it("change theme settings that do not trigger reload", function () { @@ -706,6 +707,7 @@ describe("Admin settings with edit permission", function () { // Check that page was not reloaded (settingsReloadRequest was not called) cy.get("@settingsReloadRequest").should("be.null"); + cy.checkFinalState(); }); it("change theme favicon setting", function () { @@ -830,6 +832,7 @@ describe("Admin settings with edit permission", function () { .find('[data-test="settings-image-preview"]') .should("have.attr", "src") .and("include", "/images/favicon3.ico"); + cy.checkFinalState(); }); it("change theme favicon dark setting", function () { @@ -956,6 +959,7 @@ describe("Admin settings with edit permission", function () { .find('[data-test="settings-image-preview"]') .should("have.attr", "src") .and("include", "/images/favicon-dark3.ico"); + cy.checkFinalState(); }); it("change theme custom css setting", function () { @@ -1080,6 +1084,7 @@ describe("Admin settings with edit permission", function () { cy.get('[data-test="settings-file-view-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("change banner settings", function () { @@ -1762,6 +1767,7 @@ describe("Admin settings with edit permission", function () { .should("not.have.class", "selected"); } }); + cy.checkFinalState(); }); it("change room settings", function () { @@ -2262,6 +2268,7 @@ describe("Admin settings with edit permission", function () { ); cy.get("#room-file-terms-of-use").should("have.value", ""); cy.get("#room-hide-owner").should("not.be.checked"); + cy.checkFinalState(); }); it("change user settings", function () { @@ -2324,6 +2331,7 @@ describe("Admin settings with edit permission", function () { // Check that settings are shown correctly cy.get("#password-change-allowed").should("not.be.checked"); + cy.checkFinalState(); }); it("change recording and statistics settings", function () { @@ -2718,6 +2726,7 @@ describe("Admin settings with edit permission", function () { "have.text", "admin.settings.one_week", ); + cy.checkFinalState(); }); it("change bbb settings", function () { @@ -3101,6 +3110,7 @@ describe("Admin settings with edit permission", function () { // Check that config is loaded cy.wait("@configRequest"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -3619,5 +3629,6 @@ describe("Admin settings with edit permission", function () { cy.url().should("include", "/login?redirect=/admin/settings"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminSettingsGeneral.cy.js b/tests/Frontend/e2e/AdminSettingsGeneral.cy.js index ad01d2e98..f587fbf70 100644 --- a/tests/Frontend/e2e/AdminSettingsGeneral.cy.js +++ b/tests/Frontend/e2e/AdminSettingsGeneral.cy.js @@ -20,6 +20,7 @@ describe("Admin settings general", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/settings"); + cy.checkFinalState(); }); it("visit with user without permission to view settings", function () { @@ -38,6 +39,7 @@ describe("Admin settings general", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check loading only view", function () { @@ -79,6 +81,7 @@ describe("Admin settings general", function () { cy.get('[data-test="admin-breadcrumb"]') .should("be.visible") .should("include.text", "admin.breadcrumbs.settings"); + cy.checkFinalState(); }); it("check loading with edit permission", function () { @@ -112,6 +115,7 @@ describe("Admin settings general", function () { cy.get('[data-test="admin-breadcrumb"]') .should("be.visible") .should("include.text", "admin.breadcrumbs.settings"); + cy.checkFinalState(); }); it("load settings errors", function () { @@ -155,6 +159,7 @@ describe("Admin settings general", function () { cy.url().should("include", "/login?redirect=/admin/settings"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load timezones error", function () { @@ -242,5 +247,6 @@ describe("Admin settings general", function () { cy.url().should("include", "/login?redirect=/admin/settings"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminSettingsView.cy.js b/tests/Frontend/e2e/AdminSettingsView.cy.js index 5949309da..b031eebd3 100644 --- a/tests/Frontend/e2e/AdminSettingsView.cy.js +++ b/tests/Frontend/e2e/AdminSettingsView.cy.js @@ -166,6 +166,7 @@ describe("Admin settings with edit permission", function () { .and("be.disabled"); }); }); + cy.checkFinalState(); }); it("check theme settings with only view permission", function () { @@ -236,6 +237,7 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.checkSettingsFileSelectorOnlyView(""); }); + cy.checkFinalState(); }); it("check banner settings with only view permission", function () { @@ -511,6 +513,7 @@ describe("Admin settings with edit permission", function () { .should("have.value", "#ef4444") .and("be.disabled"); }); + cy.checkFinalState(); }); it("check room settings with only view permission", function () { @@ -712,6 +715,7 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.get("#room-hide-owner").should("be.checked").and("be.disabled"); }); + cy.checkFinalState(); }); it("check user settings with only view permission", function () { @@ -727,6 +731,7 @@ describe("Admin settings with edit permission", function () { .should("be.checked") .and("be.disabled"); }); + cy.checkFinalState(); }); it("check recording and statistics settings with only view permission", function () { @@ -832,6 +837,7 @@ describe("Admin settings with edit permission", function () { ); }); }); + cy.checkFinalState(); }); it("check bbb settings with only view permission", function () { @@ -911,5 +917,6 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.checkSettingsFileSelectorOnlyView("/files/testFile.txt"); }); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminStreamingEdit.cy.js b/tests/Frontend/e2e/AdminStreamingEdit.cy.js index 24c202665..db5febf1f 100644 --- a/tests/Frontend/e2e/AdminStreamingEdit.cy.js +++ b/tests/Frontend/e2e/AdminStreamingEdit.cy.js @@ -221,6 +221,7 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.checkSettingsFileSelector("", "streaming.css", true); }); + cy.checkFinalState(); }); it("edit settings saving error", function () { @@ -328,6 +329,7 @@ describe("Admin settings with edit permission", function () { "not.include.text", "The userdata-bbb_hide_notifications parameter is missing a value.", ); + cy.checkFinalState(); }); it("edit settings loading error", function () { @@ -389,6 +391,7 @@ describe("Admin settings with edit permission", function () { // Check save button is enabled cy.get('[data-test="save-button"]').should("not.be.disabled"); + cy.checkFinalState(); }); it("check settings with update permission", function () { @@ -473,6 +476,7 @@ describe("Admin settings with edit permission", function () { ) .and("not.be.disabled"); }); + cy.checkFinalState(); }); it("check room type settings table", function () { @@ -644,6 +648,7 @@ describe("Admin settings with edit permission", function () { .find(".fa-solid.fa-check") .should("exist"); }); + cy.checkFinalState(); }); it("edit room type settings", function () { @@ -894,6 +899,7 @@ describe("Admin settings with edit permission", function () { .find(".fa-solid.fa-times") .should("exist"); }); + cy.checkFinalState(); }); it("edit room type settings saving error", function () { @@ -980,6 +986,7 @@ describe("Admin settings with edit permission", function () { "not.include.text", "The Default pause image must have a resolution of 1920x1080 pixels.", ); + cy.checkFinalState(); }); it("edit room type settings loading error", function () { @@ -1048,5 +1055,6 @@ describe("Admin settings with edit permission", function () { // Check save button is enabled cy.get('[data-test="dialog-save-button"]').should("not.be.disabled"); }); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminStreamingView.cy.js b/tests/Frontend/e2e/AdminStreamingView.cy.js index 89bfad1c9..a3844cb25 100644 --- a/tests/Frontend/e2e/AdminStreamingView.cy.js +++ b/tests/Frontend/e2e/AdminStreamingView.cy.js @@ -35,6 +35,7 @@ describe("Admin settings with edit permission", function () { // check 404 cy.url().should("include", "/404"); + cy.checkFinalState(); }); it("check settings with only view permission", function () { @@ -111,6 +112,7 @@ describe("Admin settings with edit permission", function () { ) .and("be.disabled"); }); + cy.checkFinalState(); }); it("check room type settings table", function () { @@ -282,5 +284,6 @@ describe("Admin settings with edit permission", function () { .find(".fa-solid.fa-check") .should("exist"); }); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEdit.cy.js b/tests/Frontend/e2e/AdminUsersEdit.cy.js index b49417d8c..ec1e37ced 100644 --- a/tests/Frontend/e2e/AdminUsersEdit.cy.js +++ b/tests/Frontend/e2e/AdminUsersEdit.cy.js @@ -32,6 +32,7 @@ describe("Admin users edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users/2/edit"); + cy.checkFinalState(); }); it("visit with user without permission to edit users", function () { @@ -56,6 +57,7 @@ describe("Admin users edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/users/2/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check visiting edit user page of a superuser", function () { @@ -126,6 +128,7 @@ describe("Admin users edit", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); + cy.checkFinalState(); }); it("visit edit user page", function () { @@ -190,6 +193,7 @@ describe("Admin users edit", function () { cy.get('[data-test="email-tab-button"]').should("be.visible"); cy.get('[data-test="security-tab-button"]').should("be.visible"); cy.get('[data-test="others-tab-button"]').should("be.visible"); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -228,6 +232,7 @@ describe("Admin users edit", function () { cy.get('[data-test="user-tab-profile-save-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); it("visit edit user page errors", function () { @@ -305,5 +310,6 @@ describe("Admin users edit", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditBase.cy.js b/tests/Frontend/e2e/AdminUsersEditBase.cy.js index c1e11bde8..72b17871b 100644 --- a/tests/Frontend/e2e/AdminUsersEditBase.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditBase.cy.js @@ -571,6 +571,7 @@ describe("Admin users edit base", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -755,6 +756,7 @@ describe("Admin users edit base", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("view as external user", function () { @@ -813,6 +815,7 @@ describe("Admin users edit base", function () { "true", ); }); + cy.checkFinalState(); }); it("load timezones error", function () { @@ -902,5 +905,6 @@ describe("Admin users edit base", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditEmail.cy.js b/tests/Frontend/e2e/AdminUsersEditEmail.cy.js index e0f70bd5f..861106712 100644 --- a/tests/Frontend/e2e/AdminUsersEditEmail.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditEmail.cy.js @@ -117,6 +117,7 @@ describe("Admin users edit email", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -212,6 +213,7 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("view for external user", function () { @@ -240,5 +242,6 @@ describe("Admin users edit email", function () { .and("have.value", "LauraWRivera@domain.tld"); cy.get('[data-test="user-tab-email-save-button"]').should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditOthers.cy.js b/tests/Frontend/e2e/AdminUsersEditOthers.cy.js index a8bf24088..4f4e8ab83 100644 --- a/tests/Frontend/e2e/AdminUsersEditOthers.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditOthers.cy.js @@ -107,6 +107,7 @@ describe("Admin users edit others", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -242,5 +243,6 @@ describe("Admin users edit others", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js b/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js index a396123a4..7a1c87888 100644 --- a/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js @@ -82,6 +82,7 @@ describe("Admin users edit email", function () { // Check that essions are not shown cy.get('[data-test="session-panel"]').should("not.exist"); + cy.checkFinalState(); }); it("check view with external user", function () { @@ -122,6 +123,7 @@ describe("Admin users edit email", function () { // Check that sessions are not shown cy.get('[data-test="session-panel"]').should("not.exist"); + cy.checkFinalState(); }); it("change role", function () { @@ -422,6 +424,7 @@ describe("Admin users edit email", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); + cy.checkFinalState(); }); it("check that superuser role is disabled for users that are not superusers", function () { @@ -485,6 +488,7 @@ describe("Admin users edit email", function () { .eq(4) .should("include.text", "admin.roles.no_data") .and("not.be.visible"); + cy.checkFinalState(); }); it("change role errors", function () { @@ -625,6 +629,7 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("change password", function () { @@ -704,6 +709,7 @@ describe("Admin users edit email", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); + cy.checkFinalState(); }); it("change password errors", function () { @@ -838,6 +844,7 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load roles errors", function () { @@ -977,5 +984,6 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersIndex.cy.js b/tests/Frontend/e2e/AdminUsersIndex.cy.js index 462b679c6..7b2018ca1 100644 --- a/tests/Frontend/e2e/AdminUsersIndex.cy.js +++ b/tests/Frontend/e2e/AdminUsersIndex.cy.js @@ -29,6 +29,7 @@ describe("Admin users index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users"); + cy.checkFinalState(); }); it("visit with user without permission to view users", function () { @@ -48,6 +49,7 @@ describe("Admin users index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("contain", "home.title"); + cy.checkFinalState(); }); it("load users", function () { @@ -299,6 +301,7 @@ describe("Admin users index", function () { ); }); }); + cy.checkFinalState(); }); it("load users errors", function () { @@ -464,6 +467,7 @@ describe("Admin users index", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load users page out of bounds", function () { @@ -542,6 +546,7 @@ describe("Admin users index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("load roles errors", function () { @@ -725,6 +730,7 @@ describe("Admin users index", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("user search", function () { @@ -901,6 +907,7 @@ describe("Admin users index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("filter users", function () { @@ -1227,6 +1234,7 @@ describe("Admin users index", function () { .should("include.text", "admin.users.role_filter"); cy.get('[data-test="clear-roles-button"]').should("not.exist"); + cy.checkFinalState(); }); it("sort users", function () { @@ -1534,6 +1542,7 @@ describe("Admin users index", function () { .eq(5) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); + cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -1600,6 +1609,7 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -1725,6 +1735,7 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -1865,6 +1876,7 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -1944,6 +1956,7 @@ describe("Admin users index", function () { "be.visible", ); }); + cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -2020,6 +2033,7 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js b/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js index 278a9b46b..18d9de6d0 100644 --- a/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js +++ b/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js @@ -116,6 +116,7 @@ describe("Admin users index user actions", function () { // Cancel delete cy.get('[data-test="dialog-cancel-button"]').click(); cy.get('[data-test="users-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete user errors", function () { @@ -166,6 +167,7 @@ describe("Admin users index user actions", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("reset password", function () { @@ -220,6 +222,7 @@ describe("Admin users index user actions", function () { // Check that dialog is closed cy.get('[data-test="users-reset-password-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("reset password errors", function () { @@ -268,6 +271,7 @@ describe("Admin users index user actions", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("open add new user page", function () { @@ -280,6 +284,7 @@ describe("Admin users index user actions", function () { cy.get('[data-test="users-add-button"]').click(); cy.url().should("include", "/admin/users/new"); + cy.checkFinalState(); }); it("open edit user page", function () { @@ -323,6 +328,7 @@ describe("Admin users index user actions", function () { .click(); cy.url().should("include", "/admin/users/1/edit"); + cy.checkFinalState(); }); it("open view user page", function () { @@ -372,5 +378,6 @@ describe("Admin users index user actions", function () { cy.url().should("include", "/admin/users/1"); cy.url().should("not.include", "/edit"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersNew.cy.js b/tests/Frontend/e2e/AdminUsersNew.cy.js index 0473d7005..e76258e09 100644 --- a/tests/Frontend/e2e/AdminUsersNew.cy.js +++ b/tests/Frontend/e2e/AdminUsersNew.cy.js @@ -33,6 +33,7 @@ describe("Admin users new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users/new"); + cy.checkFinalState(); }); it("visit with user without permission to add new users", function () { @@ -57,6 +58,7 @@ describe("Admin users new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("visit with local auth disabled", function () { @@ -66,6 +68,7 @@ describe("Admin users new", function () { cy.url().should("not.include", "/admin/users/new"); cy.url().should("include", "/404"); + cy.checkFinalState(); }); it("add new user with custom password and 1 role", function () { @@ -380,6 +383,7 @@ describe("Admin users new", function () { "include.text", 'admin.breadcrumbs.users.view_{"firstname":"Max","lastname":"Doe"}', ); + cy.checkFinalState(); }); it("add new user with generated password and several roles", function () { @@ -625,6 +629,7 @@ describe("Admin users new", function () { // Check that user page is shown cy.url().should("include", "/admin/users/20"); + cy.checkFinalState(); }); it("add new user errors", function () { @@ -776,6 +781,7 @@ describe("Admin users new", function () { cy.url().should("include", "/login?redirect=/admin/users/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load timezones errors", function () { @@ -853,6 +859,7 @@ describe("Admin users new", function () { cy.url().should("include", "/login?redirect=/admin/users/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("check that superuser role is disabled for users that are not superusers", function () { @@ -912,6 +919,7 @@ describe("Admin users new", function () { .eq(4) .should("include.text", "admin.roles.no_data") .and("not.be.visible"); + cy.checkFinalState(); }); it("load roles errors", function () { @@ -1043,5 +1051,6 @@ describe("Admin users new", function () { cy.url().should("include", "/login?redirect=/admin/users/new"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersView.cy.js b/tests/Frontend/e2e/AdminUsersView.cy.js index 8c9d4f792..8748b8a57 100644 --- a/tests/Frontend/e2e/AdminUsersView.cy.js +++ b/tests/Frontend/e2e/AdminUsersView.cy.js @@ -31,6 +31,7 @@ describe("Admin users view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users/"); + cy.checkFinalState(); }); it("visit with user without permission to view users", function () { @@ -54,6 +55,7 @@ describe("Admin users view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/users/2"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("check userView shown correctly", function () { @@ -247,6 +249,7 @@ describe("Admin users view", function () { // Check that others save button is hidden cy.get('[data-test="user-tab-others-save-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check userView with ldap user", function () { @@ -312,6 +315,7 @@ describe("Admin users view", function () { cy.get('[data-test="others-tab-button"]').click(); cy.get("#bbb_skip_check_audio").should("not.be.checked").and("be.disabled"); + cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -343,6 +347,7 @@ describe("Admin users view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="users-delete-button"]').should("not.exist"); + cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -378,6 +383,7 @@ describe("Admin users view", function () { cy.get('[data-test="users-delete-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); it("check button visibility for user that is superuser", function () { @@ -448,6 +454,7 @@ describe("Admin users view", function () { cy.get('[data-test="users-delete-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -511,6 +518,7 @@ describe("Admin users view", function () { cy.get('[data-test="users-edit-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); cy.get('[data-test="users-delete-button"]').should("not.exist"); + cy.checkFinalState(); }); it("open view errors", function () { @@ -589,6 +597,7 @@ describe("Admin users view", function () { cy.url().should("include", "/login?redirect=/admin/users/2"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load timezones error", function () { @@ -659,5 +668,6 @@ describe("Admin users view", function () { cy.url().should("include", "/login?redirect=/admin/users/2"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js b/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js index 3c8057ff7..fd59f75f2 100644 --- a/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js +++ b/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js @@ -95,6 +95,7 @@ describe("Admin users view user actions", function () { // Check that dialog is closed cy.get('[data-test="users-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete user errors", function () { @@ -140,6 +141,7 @@ describe("Admin users view user actions", function () { cy.url().should("include", "/login?redirect=/admin/users/2"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("reset password", function () { @@ -191,6 +193,7 @@ describe("Admin users view user actions", function () { // Check that dialog is closed cy.get('[data-test="users-reset-password-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("reset password errors", function () { @@ -236,6 +239,7 @@ describe("Admin users view user actions", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -627,5 +631,6 @@ describe("Admin users view user actions", function () { cy.get('[data-test="user-tab-others-save-button"]') .should("be.visible") .and("not.be.disabled"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Banner.cy.js b/tests/Frontend/e2e/Banner.cy.js index 4a1c3e282..2846b3120 100644 --- a/tests/Frontend/e2e/Banner.cy.js +++ b/tests/Frontend/e2e/Banner.cy.js @@ -81,6 +81,7 @@ describe("Banner", function () { cy.get('[data-test="banner-link-button"]').should("not.exist"); }); }); + cy.checkFinalState(); }); it("check banner link works correctly", function () { @@ -148,6 +149,7 @@ describe("Banner", function () { .and("have.attr", "data-p-severity", "danger") .and("not.have.class", "p-0 underline"); }); + cy.checkFinalState(); }); it("check banner hidden if disabled", function () { @@ -171,5 +173,6 @@ describe("Banner", function () { // Check that banner is shown correctly cy.get('[data-test="app-banner"]').should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Footer.cy.js b/tests/Frontend/e2e/Footer.cy.js index 0fbc8362f..6078c8e0c 100644 --- a/tests/Frontend/e2e/Footer.cy.js +++ b/tests/Frontend/e2e/Footer.cy.js @@ -57,6 +57,7 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.0.0"); }); + cy.checkFinalState(); }); it("check footer shown correctly with only legal notice link, no version and whitelabel", function () { @@ -94,6 +95,7 @@ describe("Footer", function () { cy.get('[data-test="github-button"]').should("not.exist"); cy.get('[data-test="version"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check footer shown correctly with only privacy policy link, no version and whitelabel", function () { @@ -130,6 +132,7 @@ describe("Footer", function () { cy.get('[data-test="github-button"]').should("not.exist"); cy.get('[data-test="version"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check footer shown correctly with no links, no version and no whitelabel", function () { @@ -162,6 +165,7 @@ describe("Footer", function () { .and("have.attr", "href", "https://github.com/THM-Health/PILOS"); cy.get('[data-test="version"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check footer shown correctly with no links, version and whitelabel", function () { @@ -193,6 +197,7 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.0.0"); }); + cy.checkFinalState(); }); it("check footer shown correctly with 2 links, version and whitelabel", function () { @@ -245,6 +250,7 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.0.0"); }); + cy.checkFinalState(); }); it("check footer shown correctly with 2 links, no version and whitelabel", function () { @@ -294,6 +300,7 @@ describe("Footer", function () { cy.get('[data-test="github-button"]').should("not.exist"); cy.get('[data-test="version"]').should("not.exist"); }); + cy.checkFinalState(); }); it("check footer hidden with no links, no version and whitelabel", function () { @@ -312,6 +319,7 @@ describe("Footer", function () { cy.wait("@configRequest"); cy.get('[data-test="app-footer"]').should("not.exist"); + cy.checkFinalState(); }); it("check footer shown correctly with only legal notice link, version and whitelabel", function () { @@ -351,6 +359,7 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.2.0"); }); + cy.checkFinalState(); }); it("check footer shown correctly with only privacy policy link, version and whitelabel", function () { @@ -389,6 +398,7 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 2.1.0"); }); + cy.checkFinalState(); }); it("open legal notice link", function () { @@ -407,6 +417,7 @@ describe("Footer", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/legal?foo=a&bar=b`, ); + cy.checkFinalState(); }); it("open accessibility link", function () { @@ -425,6 +436,7 @@ describe("Footer", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/accessibility?foo=a&bar=b`, ); + cy.checkFinalState(); }); it("open privacy policy link", function () { @@ -443,5 +455,6 @@ describe("Footer", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/privacy?foo=a&bar=b`, ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/ForgotPassword.cy.js b/tests/Frontend/e2e/ForgotPassword.cy.js index 6720f8d97..3b1df271d 100644 --- a/tests/Frontend/e2e/ForgotPassword.cy.js +++ b/tests/Frontend/e2e/ForgotPassword.cy.js @@ -27,6 +27,7 @@ describe("Forgot password", function () { cy.visit("/forgot_password"); cy.url().should("include", "/404").and("not.include", "/forgot_password"); + cy.checkFinalState(); }); it("check with password change forbidden", function () { @@ -43,6 +44,7 @@ describe("Forgot password", function () { cy.visit("/forgot_password"); cy.url().should("include", "/404").and("not.include", "/forgot_password"); + cy.checkFinalState(); }); it("visit with logged in user", function () { @@ -59,6 +61,7 @@ describe("Forgot password", function () { // Check that user is redirected to home page cy.url().should("not.include", "/forgot_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("forgot password", function () { @@ -126,6 +129,7 @@ describe("Forgot password", function () { // Check that user is redirected to home page cy.url().should("not.include", "/forgot_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("forgot password errors", function () { @@ -174,5 +178,6 @@ describe("Forgot password", function () { cy.get('[data-test="email-field"]') .should("be.visible") .and("not.include.text", "The email fiel is required."); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/GeneralApplication.cy.js b/tests/Frontend/e2e/GeneralApplication.cy.js index 8c4b7dd34..52a0cfd55 100644 --- a/tests/Frontend/e2e/GeneralApplication.cy.js +++ b/tests/Frontend/e2e/GeneralApplication.cy.js @@ -28,6 +28,7 @@ describe("General", function () { .should("exist") .should("have.text", "Français"); }); + cy.checkFinalState(); }); it("hide locale menu if only one locale is available", function () { @@ -39,6 +40,7 @@ describe("General", function () { // Check locale select is not shown cy.get('[data-test="navbar-locale"]').should("not.exist"); + cy.checkFinalState(); }); it("changing selected locale", function () { @@ -86,6 +88,7 @@ describe("General", function () { // Check that the menu is closed cy.get('[data-test="submenu"]').should("not.be.visible"); + cy.checkFinalState(); }); it("changing selected locale error", function () { @@ -153,6 +156,7 @@ describe("General", function () { 'app.flash.server_error.message_{"message":["Test"]}', 'app.flash.server_error.error_code_{"statusCode":500}', ]); + cy.checkFinalState(); }); it("PrimeVue uses locale with exact match", function () { @@ -194,6 +198,7 @@ describe("General", function () { cy.get('[data-test="paginator-page"]') .first() .should("have.attr", "aria-label", "Seite 1"); + cy.checkFinalState(); }); it("PrimeVue uses parent locale for invalid language-region codes (de-XX -> de)", function () { @@ -248,6 +253,7 @@ describe("General", function () { cy.get('[data-test="paginator-page"]') .first() .should("have.attr", "aria-label", "Seite 1"); + cy.checkFinalState(); }); it("PrimeVue uses local fallback (en) for unsupported PrimeLocale locales", function () { @@ -302,6 +308,7 @@ describe("General", function () { cy.get('[data-test="paginator-page"]') .last() .should("have.attr", "aria-label", "Page 1"); + cy.checkFinalState(); }); it("disabled welcome page redirect unauthenticated users to login", function () { @@ -323,6 +330,7 @@ describe("General", function () { cy.url().should("contain", "/login?redirect=/rooms"); cy.get('[data-test="login-tab-button-local"]').should("be.visible"); + cy.checkFinalState(); }); it("disabled welcome page redirect authenticated users to rooms overview", function () { @@ -340,6 +348,7 @@ describe("General", function () { // Should be redirected to rooms overview cy.url().should("contain", "/rooms"); + cy.checkFinalState(); }); it("welcome page shown", function () { @@ -348,6 +357,7 @@ describe("General", function () { // Check if the welcome page is shown cy.get("h1").should("be.visible").and("contain", "home.title"); + cy.checkFinalState(); }); it("check help button if help url specified", function () { @@ -375,6 +385,7 @@ describe("General", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/help?foo=a&bar=b`, ); + cy.checkFinalState(); }); it("check help button hidden if help url not specified", function () { @@ -386,6 +397,7 @@ describe("General", function () { cy.visit("/"); cy.get('[data-test="navbar-help"]').should("not.exist"); + cy.checkFinalState(); }); it("change to dark mode", function () { @@ -414,6 +426,7 @@ describe("General", function () { cy.get('[data-test="navbar-dark-mode"]') .find("svg") .should("have.attr", "data-test", "navbar-dark-mode-disabled-icon"); + cy.checkFinalState(); }); it("change to light mode", function () { @@ -446,5 +459,6 @@ describe("General", function () { cy.get('[data-test="navbar-dark-mode"]') .find("svg") .should("have.attr", "data-test", "navbar-dark-mode-enabled-icon"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Login.cy.js b/tests/Frontend/e2e/Login.cy.js index 35858e129..c2355adf5 100644 --- a/tests/Frontend/e2e/Login.cy.js +++ b/tests/Frontend/e2e/Login.cy.js @@ -88,6 +88,7 @@ describe("Login", function () { cy.checkToastMessage("auth.flash.login"); // Check if redirect works cy.url().should("include", "/rooms").and("not.include", "/login"); + cy.checkFinalState(); }); it("hide ldap login if disabled", function () { @@ -108,6 +109,7 @@ describe("Login", function () { cy.get('[data-test="login-tab-button-local"]').should("exist"); cy.get('[data-test="login-tab-button-ldap"]').should("not.exist"); + cy.checkFinalState(); }); it("ldap login with redirect query set", function () { @@ -154,6 +156,7 @@ describe("Login", function () { // Check if redirect works cy.url().should("include", "/admin").and("not.include", "/login"); + cy.checkFinalState(); }); it("local login", function () { @@ -247,6 +250,7 @@ describe("Login", function () { cy.checkToastMessage("auth.flash.login"); // Check if redirect works cy.url().should("include", "/rooms").and("not.include", "/login"); + cy.checkFinalState(); }); it("open forgot password page", function () { @@ -278,6 +282,7 @@ describe("Login", function () { .click(); cy.url().should("include", "/forgot_password").and("not.include", "/login"); + cy.checkFinalState(); }); it("hide local login if disabled", function () { @@ -297,6 +302,7 @@ describe("Login", function () { cy.get('[data-test="login-tab-button-ldap"]').should("exist"); cy.get('[data-test="login-tab-button-local"]').should("not.exist"); + cy.checkFinalState(); }); it("local login with redirect query set", function () { @@ -342,6 +348,7 @@ describe("Login", function () { // Check if redirect works cy.url().should("include", "/admin").and("not.include", "/login"); + cy.checkFinalState(); }); it("local login errors", function () { @@ -466,6 +473,7 @@ describe("Login", function () { cy.checkToastMessage("app.flash.guests_only"); cy.url().should("not.include", "/login"); + cy.checkFinalState(); }); it("ldap login errors", function () { @@ -598,6 +606,7 @@ describe("Login", function () { cy.checkToastMessage("app.flash.guests_only"); cy.url().should("not.include", "/login"); + cy.checkFinalState(); }); it("visit login page with already logged in user", function () { @@ -617,6 +626,7 @@ describe("Login", function () { // Check with redirect query parameter cy.visit("/login?redirect=/admin"); cy.url().should("include", "/admin").and("not.include", "/login"); + cy.checkFinalState(); }); it("shibboleth login", function () { @@ -645,6 +655,7 @@ describe("Login", function () { cy.visit("/external_login"); cy.url().should("include", "/rooms").and("not.include", "/login"); + cy.checkFinalState(); }); it("hide shibboleth login if disabled", function () { @@ -664,6 +675,7 @@ describe("Login", function () { cy.wait("@configRequest"); cy.get('[data-test="login-tab-button-local"]').should("exist"); cy.get('[data-test="login-tab-button-shibboleth"]').should("not.exist"); + cy.checkFinalState(); }); it("shibboleth login with redirect query set", function () { @@ -706,6 +718,8 @@ describe("Login", function () { // Check admin page is shown (loading is finished) and toast message is shown cy.contains("admin.title").should("be.visible"); cy.checkToastMessage("auth.flash.login"); + + cy.checkFinalState(); }); it("external login callback missing attributes error", function () { @@ -721,6 +735,8 @@ describe("Login", function () { .should("be.visible") .should("have.text", "auth.login") .should("have.attr", "href", "/login"); + + cy.checkFinalState(); }); it("external login callback duplicate session error", function () { @@ -738,6 +754,8 @@ describe("Login", function () { .should("be.visible") .should("have.text", "auth.login") .should("have.attr", "href", "/login"); + + cy.checkFinalState(); }); it("external login callback invalid request", function () { @@ -753,6 +771,8 @@ describe("Login", function () { .should("be.visible") .should("have.text", "auth.login") .should("have.attr", "href", "/login"); + + cy.checkFinalState(); }); it("external login callback openid connect network exception", function () { @@ -825,6 +845,7 @@ describe("Login", function () { cy.visit("/external_login"); cy.url().should("include", "/rooms").and("not.include", "/login"); + cy.checkFinalState(); }); it("hide oidc login if disabled", function () { @@ -844,6 +865,7 @@ describe("Login", function () { cy.wait("@configRequest"); cy.get('[data-test="login-tab-button-local"]').should("exist"); cy.get('[data-test="login-tab-button-oidc"]').should("not.exist"); + cy.checkFinalState(); }); it("oidc login with redirect query set", function () { @@ -908,5 +930,6 @@ describe("Login", function () { // Check admin page is shown (loading is finished) and no toast message is shown cy.contains("admin.title").should("be.visible"); cy.get(".p-toast-message").should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Logout.cy.js b/tests/Frontend/e2e/Logout.cy.js index 07dfe0bad..a36dcb902 100644 --- a/tests/Frontend/e2e/Logout.cy.js +++ b/tests/Frontend/e2e/Logout.cy.js @@ -33,6 +33,7 @@ describe("Logout", function () { // Check redirect to home page cy.get('[data-test="home-button"]').should("have.text", "app.home").click(); cy.url().should("not.include", "/logout"); + cy.checkFinalState(); }); it("successful logout with redirect", function () { @@ -59,6 +60,7 @@ describe("Logout", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/idp?foo=a&bar=b`, ); + cy.checkFinalState(); }); it("failed logout", function () { @@ -89,5 +91,6 @@ describe("Logout", function () { .should("include", "/rooms") .and("not.include", "/logout") .and("not.include", "/login"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/MeetingsIndex.cy.js b/tests/Frontend/e2e/MeetingsIndex.cy.js index a7ff04203..b2d228b2e 100644 --- a/tests/Frontend/e2e/MeetingsIndex.cy.js +++ b/tests/Frontend/e2e/MeetingsIndex.cy.js @@ -16,6 +16,7 @@ describe("Meetings index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/meetings"); + cy.checkFinalState(); }); it("visit with user without permission to view meetings", function () { @@ -31,6 +32,7 @@ describe("Meetings index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/meetings"); cy.get("h1").should("be.visible").and("contain", "home.title"); + cy.checkFinalState(); }); it("load meetings", function () { @@ -269,6 +271,7 @@ describe("Meetings index", function () { .and("have.attr", "href", "/rooms/def-abc-456"); }); }); + cy.checkFinalState(); }); it("load meetings errors", function () { @@ -431,6 +434,7 @@ describe("Meetings index", function () { cy.url().should("include", "/login?redirect=/meetings"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load meetings page out of bounds", function () { @@ -510,6 +514,7 @@ describe("Meetings index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("meeting search", function () { @@ -694,6 +699,7 @@ describe("Meetings index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("sort meetings", function () { @@ -1005,6 +1011,7 @@ describe("Meetings index", function () { .eq(7) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); + cy.checkFinalState(); }); it("reload meetings", function () { @@ -1094,6 +1101,7 @@ describe("Meetings index", function () { .eq(0) .should("include.text", "02/12/2021, 19:10") .and("include.text", "Meeting Two"); + cy.checkFinalState(); }); it("view room of meeting", function () { @@ -1115,6 +1123,7 @@ describe("Meetings index", function () { // Check that redirect worked cy.url().should("include", "/rooms/abc-def-123"); cy.url().should("not.include", "/meetings"); + cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/PasswordReset.cy.js b/tests/Frontend/e2e/PasswordReset.cy.js index 8f1d11aec..43de7b4cc 100644 --- a/tests/Frontend/e2e/PasswordReset.cy.js +++ b/tests/Frontend/e2e/PasswordReset.cy.js @@ -27,6 +27,7 @@ describe("Password reset", function () { cy.visit("/reset_password"); cy.url().should("include", "/404").and("not.include", "/forgot_password"); + cy.checkFinalState(); }); it("visit with logged in user", function () { @@ -43,6 +44,7 @@ describe("Password reset", function () { // Check that user is redirected to home page cy.url().should("not.include", "/forgot_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("reset password of existing user", function () { @@ -128,6 +130,7 @@ describe("Password reset", function () { // Check that user is redirected to home page cy.url().should("not.include", "/reset_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkFinalState(); }); it("reset password view for new user", function () { @@ -141,6 +144,7 @@ describe("Password reset", function () { "have.text", "auth.set_password", ); + cy.checkFinalState(); }); it("reset password errors", function () { @@ -245,5 +249,6 @@ describe("Password reset", function () { // Check that error message is shown cy.checkToastMessage("app.flash.too_many_requests"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsIndex.cy.js b/tests/Frontend/e2e/RoomsIndex.cy.js index 3cd1d5504..3a95d3714 100644 --- a/tests/Frontend/e2e/RoomsIndex.cy.js +++ b/tests/Frontend/e2e/RoomsIndex.cy.js @@ -8,6 +8,7 @@ describe("Room Index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/rooms"); + cy.checkFinalState(); }); it("check list of rooms and opening room view", function () { @@ -171,6 +172,7 @@ describe("Room Index", function () { }); cy.url().should("include", "/rooms/abc-def-123"); + cy.checkFinalState(); }); it("check list of rooms with rooms.filterAll permission", function () { @@ -267,6 +269,7 @@ describe("Room Index", function () { // Check if rooms are shown cy.get('[data-test="room-card"]').should("have.length", 3); + cy.checkFinalState(); }); it("click on room card to open room view", function () { @@ -295,6 +298,7 @@ describe("Room Index", function () { cy.wait("@roomRequest"); cy.get('[data-test="no-room-overlay"]').should("not.exist"); + cy.checkFinalState(); }); it("sorting", function () { @@ -447,6 +451,7 @@ describe("Room Index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("search", function () { @@ -624,6 +629,7 @@ describe("Room Index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("filter room type", function () { @@ -857,6 +863,7 @@ describe("Room Index", function () { // Check all rooms are shown cy.get('[data-test="room-card"]').should("have.length", 3); + cy.checkFinalState(); }); it("filter without viewAll permission", function () { @@ -1043,6 +1050,7 @@ describe("Room Index", function () { cy.get('[data-test="rooms-filter-button"]') .eq(0) .should("have.attr", "aria-pressed", "false"); + cy.checkFinalState(); }); it("filter with viewAll permission", function () { @@ -1314,6 +1322,7 @@ describe("Room Index", function () { .eq(2) .should("have.text", "rooms.index.show_public") .and("have.attr", "aria-pressed", "true"); + cy.checkFinalState(); }); it("show favorites", function () { @@ -1507,6 +1516,7 @@ describe("Room Index", function () { cy.get('[data-test="room-card"]') .should("have.length", 1) .and("include.text", "Meeting One"); + cy.checkFinalState(); }); it("trigger favorites button", function () { @@ -1932,6 +1942,7 @@ describe("Room Index", function () { page: "1", }); }); + cy.checkFinalState(); }); it("trigger favorites button errors", function () { @@ -2061,6 +2072,7 @@ describe("Room Index", function () { cy.url().should("include", "/login?redirect=/rooms"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("error loading rooms", function () { @@ -2286,6 +2298,7 @@ describe("Room Index", function () { cy.url().should("include", "/login"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("error loading room types", function () { @@ -2364,5 +2377,6 @@ describe("Room Index", function () { cy.url().should("include", "/login?redirect=/rooms"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js b/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js index dbd4c3e3c..0758c4be9 100644 --- a/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js +++ b/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js @@ -23,6 +23,7 @@ describe("Rooms index create new room", function () { cy.get('[data-test="room-create-button"]').should("not.exist"); // Check that room limit tag does not exist cy.contains("rooms.room_limit").should("not.exist"); + cy.checkFinalState(); }); it("create new room", function () { @@ -368,6 +369,7 @@ describe("Rooms index create new room", function () { // Check if redirected to the created room cy.url().should("include", "/rooms/abc-def-123"); + cy.checkFinalState(); }); it("create new room with features enabled", function () { @@ -468,6 +470,7 @@ describe("Rooms index create new room", function () { ); }); }); + cy.checkFinalState(); }); it("create new room with features disabled", function () { @@ -539,6 +542,7 @@ describe("Rooms index create new room", function () { cy.get('[data-test="room-type-features"]').should("not.exist"); }); }); + cy.checkFinalState(); }); it("create new room with features disabled and show disabled features", function () { @@ -622,6 +626,7 @@ describe("Rooms index create new room", function () { ); }); }); + cy.checkFinalState(); }); it("create new room errors", function () { @@ -855,6 +860,7 @@ describe("Rooms index create new room", function () { cy.url().should("include", "/login?redirect=/rooms"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("create new room limit reached", function () { @@ -980,6 +986,7 @@ describe("Rooms index create new room", function () { // Check if room limit is updated and create button is disabled cy.get('[data-test="room-create-button"]').should("be.disabled"); cy.contains('rooms.room_limit_{"has":1,"max":1}').should("be.visible"); + cy.checkFinalState(); }); it("create new room limit reached when visiting", function () { @@ -1010,6 +1017,7 @@ describe("Rooms index create new room", function () { // Check if room limit is shown and create button is disabled cy.get('[data-test="room-create-button"]').should("be.disabled"); cy.contains('rooms.room_limit_{"has":1,"max":1}').should("be.visible"); + cy.checkFinalState(); }); it("cancel create new room", function () { @@ -1057,6 +1065,7 @@ describe("Rooms index create new room", function () { cy.get("#room-name").should("have.value", ""); cy.get('[data-test="room-type-details"]').should("not.exist"); }); + cy.checkFinalState(); }); it("errors loading room types", function () { @@ -1166,5 +1175,6 @@ describe("Rooms index create new room", function () { cy.url().should("include", "/login?redirect=/rooms"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js b/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js index 386b0eb8d..c47940690 100644 --- a/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js +++ b/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js @@ -31,6 +31,7 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.disable", ); + cy.checkFinalState(); }); it("enable notifications with denied permission", function () { @@ -55,6 +56,7 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.enable", ); + cy.checkFinalState(); }); it("enable notification with default permission, but granted on request", function () { @@ -97,6 +99,7 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.disable", ); + cy.checkFinalState(); }); it("enable notification with default permission, but denied on request", function () { @@ -136,6 +139,7 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.enable", ); + cy.checkFinalState(); }); it("hide enable button if not supported by browser", function () { @@ -148,6 +152,7 @@ describe("Rooms view browser notification", function () { cy.wait("@roomRequest"); cy.get('[data-test="room-notification-button"]').should("not.exist"); + cy.checkFinalState(); }); it("hide enable button if not fully supported", function () { @@ -170,6 +175,7 @@ describe("Rooms view browser notification", function () { .and("be.calledWith", ""); cy.get('[data-test="room-notification-button"]').should("not.exist"); + cy.checkFinalState(); }); it("change status from not running to running", function () { @@ -347,6 +353,7 @@ describe("Rooms view browser notification", function () { "rooms.notification.enable", ); cy.checkToastMessage("rooms.notification.disabled"); + cy.checkFinalState(); }); it("change status from not running to running errors", function () { @@ -385,5 +392,6 @@ describe("Rooms view browser notification", function () { cy.checkToastMessage("rooms.notification.browser_support"); cy.get('[data-test="room-notification-button"]').should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewDescription.cy.js b/tests/Frontend/e2e/RoomsViewDescription.cy.js index 58076a92c..0e3bda658 100644 --- a/tests/Frontend/e2e/RoomsViewDescription.cy.js +++ b/tests/Frontend/e2e/RoomsViewDescription.cy.js @@ -130,6 +130,7 @@ describe("Rooms view description", function () { cy.get('[data-test="room-description-edit-button"]') .should("have.text", "app.edit") .and("not.be.disabled"); + cy.checkFinalState(); }); it("edit description", function () { @@ -387,6 +388,7 @@ describe("Rooms view description", function () { }); cy.get('[data-test="tip-tap-editor"]').should("not.exist"); cy.get('[data-test="room-description-edit-button"]').should("be.visible"); + cy.checkFinalState(); }); it("edit description errors", function () { @@ -462,6 +464,7 @@ describe("Rooms view description", function () { "api/v1/rooms/abc-def-123/description", "description", ); + cy.checkFinalState(); }); it("description changes", function () { @@ -543,6 +546,7 @@ describe("Rooms view description", function () { .and("be.visible"); }); cy.get('[data-test="tip-tap-editor"]').should("not.exist"); + cy.checkFinalState(); }); it("open external link", function () { @@ -617,6 +621,7 @@ describe("Rooms view description", function () { `${Cypress.expose("redirectBaseUrl")}/?foo=a&bar=b`, "_blank", ); + cy.checkFinalState(); }); it("sanitize html", function () { @@ -689,5 +694,6 @@ describe("Rooms view description", function () { `${Cypress.expose("redirectBaseUrl")}/?foo=a&bar=b`, ); }); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js b/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js index 2b96f3ca6..d3fd463af 100644 --- a/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js +++ b/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js @@ -98,6 +98,7 @@ describe("Rooms view description TipTap Editor", function () { .and("have.attr", "alt", "Test image") .and("have.css", "width", "250px"); }); + cy.checkFinalState(); }); it("edit image", function () { @@ -182,6 +183,7 @@ describe("Rooms view description TipTap Editor", function () { .and("have.attr", "alt", "Test image 2") .and("have.css", "width", "300px"); }); + cy.checkFinalState(); }); it("delete image", function () { @@ -235,6 +237,7 @@ describe("Rooms view description TipTap Editor", function () { .within(() => { cy.get("img").should("not.exist"); }); + cy.checkFinalState(); }); it("add link", function () { @@ -348,6 +351,7 @@ describe("Rooms view description TipTap Editor", function () { const selectedText = selection.toString(); expect(selectedText).to.eq("Room description"); }); + cy.checkFinalState(); }); it("edit link", function () { @@ -447,6 +451,7 @@ describe("Rooms view description TipTap Editor", function () { .and("have.text", "Test Link") .click(); }); + cy.checkFinalState(); }); it("delete link", function () { @@ -512,6 +517,7 @@ describe("Rooms view description TipTap Editor", function () { cy.get("a").should("not.exist"); cy.get("p").should("have.text", "Test Link"); }); + cy.checkFinalState(); }); it("change source code", function () { @@ -580,5 +586,6 @@ describe("Rooms view description TipTap Editor", function () { cy.get("p").should("have.text", "Room description"); cy.get("h1").should("have.text", "Additional room description"); }); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewFiles.cy.js b/tests/Frontend/e2e/RoomsViewFiles.cy.js index 03855a221..f4a6b3014 100644 --- a/tests/Frontend/e2e/RoomsViewFiles.cy.js +++ b/tests/Frontend/e2e/RoomsViewFiles.cy.js @@ -179,6 +179,7 @@ describe("Rooms View Files", function () { .eq(0) .find('button[data-test="room-files-delete-button"]') .should("not.be.disabled"); + cy.checkFinalState(); }); it("load files with access code", function () { @@ -285,6 +286,7 @@ describe("Rooms View Files", function () { .eq(1) .find('[data-test="room-files-delete-button"]') .should("not.exist"); + cy.checkFinalState(); }); it("load files with access code errors", function () { @@ -431,6 +433,8 @@ describe("Rooms View Files", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); + cy.contains("rooms.flash.access_code_invalid").should("be.visible"); + cy.checkFinalState(); }); it("load files with personalized link", function () { @@ -525,6 +529,7 @@ describe("Rooms View Files", function () { .eq(1) .find('[data-test="room-files-delete-button"]') .should("not.exist"); + cy.checkFinalState(); }); it("load files with personalized link errors", function () { @@ -616,6 +621,7 @@ describe("Rooms View Files", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); + cy.checkFinalState(); }); it("load files errors", function () { @@ -777,6 +783,7 @@ describe("Rooms View Files", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("load files page out of range", function () { @@ -851,6 +858,7 @@ describe("Rooms View Files", function () { page: "1", }); }); + cy.checkFinalState(); }); it("view with different permissions", function () { @@ -1421,6 +1429,7 @@ describe("Rooms View Files", function () { .eq(2) .find('[data-test="room-files-delete-button"]') .should("not.be.disabled"); + cy.checkFinalState(); }); it("search files", function () { @@ -1601,6 +1610,7 @@ describe("Rooms View Files", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("filter files", function () { @@ -1829,6 +1839,7 @@ describe("Rooms View Files", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("sort files", function () { @@ -2043,5 +2054,6 @@ describe("Rooms View Files", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js b/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js index 9275dbc52..0d9dcb40b 100644 --- a/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js @@ -235,6 +235,8 @@ describe("Rooms view files file actions", function () { cy.get('[data-test="room-file-item"]') .eq(4) .should("include.text", "rooms.files.use_in_next_meeting_disabled"); + + cy.checkFinalState(); }); it("upload file errors", function () { @@ -332,6 +334,8 @@ describe("Rooms view files file actions", function () { "/api/v1/rooms/abc-def-123/files", "files", ); + + cy.checkFinalState(); }); it("delete file", function () { @@ -400,6 +404,8 @@ describe("Rooms view files file actions", function () { // Check that dialog is closed cy.get('[data-test="room-files-delete-dialog"]').should("not.exist"); + + cy.checkFinalState(); }); it("delete file errors", function () { @@ -504,6 +510,8 @@ describe("Rooms view files file actions", function () { "/api/v1/rooms/abc-def-123/files/1", "files", ); + + cy.checkFinalState(); }); it("change file settings", function () { @@ -596,6 +604,8 @@ describe("Rooms view files file actions", function () { .and("include.text", "rooms.files.use_in_next_meeting") .and("not.include.text", "rooms.files.download_visible") .and("not.include.text", "rooms.files.use_in_next_meeting_disabled"); + + cy.checkFinalState(); }); it("change file settings errors", function () { @@ -724,6 +734,8 @@ describe("Rooms view files file actions", function () { "/api/v1/rooms/abc-def-123/files/1", "files", ); + + cy.checkFinalState(); }); it("download file with terms of use", function () { @@ -779,6 +791,8 @@ describe("Rooms view files file actions", function () { ) .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); + + cy.checkFinalState(); }); it("download file with access code errors", function () { @@ -898,6 +912,8 @@ describe("Rooms view files file actions", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); + + cy.checkFinalState(); }); it("download file with personalized link errors", function () { @@ -985,6 +1001,8 @@ describe("Rooms view files file actions", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); + + cy.checkFinalState(); }); it("download file errors", function () { @@ -1242,5 +1260,6 @@ describe("Rooms view files file actions", function () { // Check that files were not reloaded cy.get("@reloadRoomFilesRequest").should("be.null"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewGeneral.cy.js b/tests/Frontend/e2e/RoomsViewGeneral.cy.js index 943ff144c..80f5a4d73 100644 --- a/tests/Frontend/e2e/RoomsViewGeneral.cy.js +++ b/tests/Frontend/e2e/RoomsViewGeneral.cy.js @@ -101,6 +101,7 @@ describe("Room View general", function () { cy.get("#tab-recordings").should("be.visible"); cy.get("#tab-history").should("not.exist"); cy.get("#tab-settings").should("not.exist"); + cy.checkFinalState(); }); it("room view with access code", function () { @@ -391,6 +392,7 @@ describe("Room View general", function () { }); cy.get('[data-test="room-access-code-overlay"]').should("not.exist"); + cy.checkFinalState(); }); it("room view with legacy access code", function () { @@ -498,6 +500,7 @@ describe("Room View general", function () { // Check that the correct tab is shown cy.contains("rooms.description.title").should("be.visible"); + cy.checkFinalState(); }); it("room auth with access code errors", function () { @@ -693,6 +696,7 @@ describe("Room View general", function () { // Check that access code overlay is hidden cy.get('[data-test="room-access-code-overlay"]').should("not.exist"); + cy.checkFinalState(); }); it("room view with access code errors", function () { @@ -835,6 +839,7 @@ describe("Room View general", function () { cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); cy.get("#access-code").should("not.be.disabled"); cy.get('[data-test="room-login-button"]').should("not.be.disabled"); + cy.checkFinalState(); }); it("room view as member", function () { @@ -888,6 +893,7 @@ describe("Room View general", function () { // Check if share button is hidden cy.get('[data-test="room-share-button"]').should("not.exist"); + cy.checkFinalState(); }); it("room view as moderator", function () { @@ -939,6 +945,7 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); + cy.checkFinalState(); }); it("share room", function () { @@ -1137,6 +1144,7 @@ describe("Room View general", function () { cy.get('[data-test="room-invitation-copy-code-button"]').should( "not.exist", ); + cy.checkFinalState(); }); it("room view as co-owner", function () { @@ -1190,6 +1198,7 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); + cy.checkFinalState(); }); it("room view as owner", function () { @@ -1235,6 +1244,7 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); + cy.checkFinalState(); }); it("room view with personalized link (participant)", function () { @@ -1346,6 +1356,7 @@ describe("Room View general", function () { // Check that error message is shown cy.checkToastMessage("rooms.flash.personalized_link_invalid"); cy.contains("rooms.invalid_personalized_link").should("be.visible"); + cy.checkFinalState(); }); it("room view with personalized link (moderator)", function () { @@ -1426,6 +1437,7 @@ describe("Room View general", function () { // Check if share button is hidden cy.get('[data-test="room-share-button"]').should("not.exist"); + cy.checkFinalState(); }); it("room auth with personalized link errors", function () { @@ -1589,6 +1601,7 @@ describe("Room View general", function () { cy.contains("rooms.index.room_component.never_started").should( "be.visible", ); + cy.checkFinalState(); }); it("room view with personalized link errors", function () { @@ -1781,6 +1794,7 @@ describe("Room View general", function () { // Check that room auth request was not sent again cy.get("@differentRoomAuthRequest").should("be.null"); + cy.checkFinalState(); }); it("room view with rooms.viewAll permission", function () { @@ -1838,6 +1852,7 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); + cy.checkFinalState(); }); it("room view streaming enabled", function () { @@ -1883,6 +1898,7 @@ describe("Room View general", function () { cy.get("#tab-streaming") .should("be.visible") .should("have.attr", "data-feature-disabled", "false"); + cy.checkFinalState(); }); it("room view streaming disabled", function () { @@ -1983,6 +1999,7 @@ describe("Room View general", function () { 'rooms.feature_disabled_system_{"name":"rooms.streaming.title"}', ); cy.get('[data-test="dialog-close-button"]').click(); + cy.checkFinalState(); }); it("membership button", function () { @@ -2136,6 +2153,7 @@ describe("Room View general", function () { // Check that no error message is shown even though room request returned authenticated false again cy.get(".p-toast-message").should("not.exist"); + cy.checkFinalState(); }); it("membership button errors", function () { @@ -2451,6 +2469,7 @@ describe("Room View general", function () { // Check that access code overlay is shown cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); + cy.checkFinalState(); }); it("trigger favorites button", function () { @@ -2556,6 +2575,7 @@ describe("Room View general", function () { "aria-label", "rooms.favorites.add", ); + cy.checkFinalState(); }); it("trigger favorites button errors", function () { @@ -2699,6 +2719,7 @@ describe("Room View general", function () { // Check that access code overlay is shown cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); + cy.checkFinalState(); }); it("visit with guest forbidden", function () { @@ -2721,6 +2742,7 @@ describe("Room View general", function () { "href", "/login?redirect=/rooms/abc-def-123", ); + cy.checkFinalState(); }); it("visit with personalized link as authenticated user", function () { @@ -2750,6 +2772,7 @@ describe("Room View general", function () { "not.include", "/rooms/abc-def-123/xWDCevVTcMys1ftzt3nFPgU56Wf32fopFWgAEBtklSkFU22z1ntA4fBHsHeMygMiOa9szJbNEfBAgEWSLNWg2gcF65PwPZ2ylPQR", ); + cy.checkFinalState(); }); it("visit with general error", function () { @@ -2783,6 +2806,7 @@ describe("Room View general", function () { // Check that overlay is hidden cy.get('[data-test="no-room-overlay"]').should("not.exist"); + cy.checkFinalState(); }); it("visit with room not found", function () { @@ -2798,6 +2822,7 @@ describe("Room View general", function () { cy.url() .should("include", "/404") .should("not.include", "/rooms/abc-def-123"); + cy.checkFinalState(); }); it("auto-reload", function () { @@ -2827,6 +2852,7 @@ describe("Room View general", function () { // Wait more than 60 seconds (due to reload randomness) for a auto-reload cy.tick(100000); cy.get("@roomRequest.all").should("have.length", 2); + cy.checkFinalState(); }); it("auto-reload disabled on error", function () { @@ -2855,6 +2881,7 @@ describe("Room View general", function () { // Wait more than 60 seconds (due to reload randomness) for no auto-reload cy.tick(100000); cy.get("@roomRequest.all").should("have.length", 1); + cy.checkFinalState(); }); it("reload with errors", function () { @@ -2933,6 +2960,7 @@ describe("Room View general", function () { cy.url() .should("include", "/404") .should("not.include", "/rooms/abc-def-123"); + cy.checkFinalState(); }); it("reload with access code errors", function () { @@ -3045,6 +3073,7 @@ describe("Room View general", function () { cy.contains("rooms.flash.access_code_invalid").should("be.visible"); cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); + cy.checkFinalState(); }); it("reload with personalized link errors", function () { @@ -3155,6 +3184,7 @@ describe("Room View general", function () { cy.url() .should("not.include", "/rooms") .and("not.include", "rooms/abc-def-123"); + cy.checkFinalState(); }); it("logged in status change", function () { @@ -3232,6 +3262,7 @@ describe("Room View general", function () { cy.get("#tab-recordings").should("be.visible"); cy.get("#tab-history").should("be.visible"); cy.get("#tab-settings").should("be.visible"); + cy.checkFinalState(); }); it("displays meeting ended reason", function () { @@ -3260,6 +3291,7 @@ describe("Room View general", function () { // Check reason message is removed from URL cy.url().should("not.include", "reason"); + cy.checkFinalState(); }); it("displays bbb error messages", function () { @@ -3328,6 +3360,7 @@ describe("Room View general", function () { // Check url is updated (no errors) cy.url().should("not.include", "errors"); + cy.checkFinalState(); }); it("hide room owner if not provided", function () { @@ -3349,5 +3382,6 @@ describe("Room View general", function () { // room should not contain owner name cy.contains("John Doe").should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewHistory.cy.js b/tests/Frontend/e2e/RoomsViewHistory.cy.js index 7af126f5e..d0ce9ddd9 100644 --- a/tests/Frontend/e2e/RoomsViewHistory.cy.js +++ b/tests/Frontend/e2e/RoomsViewHistory.cy.js @@ -159,6 +159,7 @@ describe("Rooms view history", function () { cy.get('[data-test="room-history-item"]').should("have.length", 0); cy.contains("meetings.no_historical_data").should("be.visible"); + cy.checkFinalState(); }); it("load history errors", function () { @@ -496,6 +497,7 @@ describe("Rooms view history", function () { "api/v1/rooms/abc-def-123/meetings*", "history", ); + cy.checkFinalState(); }); it("load history page out of range", function () { @@ -570,6 +572,7 @@ describe("Rooms view history", function () { page: "1", }); }); + cy.checkFinalState(); }); it("load history retention period", function () { @@ -614,6 +617,7 @@ describe("Rooms view history", function () { "include.text", 'meetings.attendance.retention_period_{"days":30}', ); + cy.checkFinalState(); }); it("sort history", function () { @@ -831,5 +835,6 @@ describe("Rooms view history", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js b/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js index edd734fd7..6795a9ded 100644 --- a/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js @@ -62,6 +62,7 @@ describe("Rooms view history meeting actions", function () { 1163 * window.devicePixelRatio, ); }); + cy.checkFinalState(); }); it("show stats errors", function () { @@ -176,6 +177,7 @@ describe("Rooms view history meeting actions", function () { "api/v1/meetings/3a3e504a-d2c4-431c-8ca1-a62598e66761/stats", "history", ); + cy.checkFinalState(); }); it("show attendance", function () { @@ -370,6 +372,7 @@ describe("Rooms view history meeting actions", function () { 0, ); }); + cy.checkFinalState(); }); it("show attendance errors", function () { @@ -514,5 +517,6 @@ describe("Rooms view history meeting actions", function () { "api/v1/meetings/3a3e504a-d2c4-431c-8ca1-a62598e66761/attendance", "history", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMeetings.cy.js b/tests/Frontend/e2e/RoomsViewMeetings.cy.js index bf8c83785..09fab0504 100644 --- a/tests/Frontend/e2e/RoomsViewMeetings.cy.js +++ b/tests/Frontend/e2e/RoomsViewMeetings.cy.js @@ -86,6 +86,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting with attendance logging", function () { @@ -172,6 +174,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting with streaming", function () { @@ -258,6 +262,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting with recording", function () { @@ -347,6 +353,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting with recording without video", function () { @@ -416,6 +424,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting guests", function () { @@ -492,6 +502,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting guests errors", function () { @@ -601,6 +613,8 @@ describe("Rooms view meetings", function () { 'app.flash.server_error.message_{"message":"Test"}', 'app.flash.server_error.error_code_{"statusCode":500}', ]); + + cy.checkFinalState(); }); it("join running meeting with access code", function () { @@ -717,6 +731,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting access code errors", function () { @@ -892,6 +908,8 @@ describe("Rooms view meetings", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); + + cy.checkFinalState(); }); it("join running meeting with personalized link", function () { @@ -989,6 +1007,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("join running meeting with personalized link errors", function () { @@ -1061,6 +1081,8 @@ describe("Rooms view meetings", function () { cy.checkToastMessage("rooms.flash.personalized_link_invalid"); cy.contains("rooms.invalid_personalized_link").should("be.visible"); + + cy.checkFinalState(); }); it("join meeting errors", function () { @@ -1344,6 +1366,8 @@ describe("Rooms view meetings", function () { "have.text", "rooms.start", ); + + cy.checkFinalState(); }); it("join meeting load requirements errors", function () { @@ -1552,6 +1576,8 @@ describe("Rooms view meetings", function () { // Check dialog is closed cy.get('[data-test="room-join-dialog"]').should("not.exist"); + + cy.checkFinalState(); }); it("join running meeting with dark mode", function () { @@ -1615,6 +1641,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting", function () { @@ -1683,6 +1711,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting with attendance logging", function () { @@ -1760,6 +1790,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting with streaming", function () { @@ -1837,6 +1869,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting with recording", function () { @@ -1917,6 +1951,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting with recording without video", function () { @@ -1973,6 +2009,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting guests", function () { @@ -2042,6 +2080,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting guests errors", function () { @@ -2143,6 +2183,8 @@ describe("Rooms view meetings", function () { 'app.flash.server_error.message_{"message":"Test"}', 'app.flash.server_error.error_code_{"statusCode":500}', ]); + + cy.checkFinalState(); }); it("start meeting with access code", function () { @@ -2245,6 +2287,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting access code errors", function () { @@ -2396,6 +2440,8 @@ describe("Rooms view meetings", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); + + cy.checkFinalState(); }); it("start meeting with personalized link", function () { @@ -2482,6 +2528,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting with personalized link errors", function () { @@ -2558,6 +2606,8 @@ describe("Rooms view meetings", function () { cy.checkToastMessage("rooms.flash.personalized_link_invalid"); cy.contains("rooms.invalid_personalized_link").should("be.visible"); + + cy.checkFinalState(); }); it("start meeting errors", function () { @@ -2913,6 +2963,8 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); it("start meeting load requirements errors", function () { @@ -3141,6 +3193,8 @@ describe("Rooms view meetings", function () { // Check dialog is closed cy.get('[data-test="room-join-dialog"]').should("not.exist"); + + cy.checkFinalState(); }); it("start meeting with dark mode", function () { @@ -3191,5 +3245,7 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); + + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMembers.cy.js b/tests/Frontend/e2e/RoomsViewMembers.cy.js index 3f1215a14..a83556aaa 100644 --- a/tests/Frontend/e2e/RoomsViewMembers.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembers.cy.js @@ -125,6 +125,7 @@ describe("Rooms view members", function () { .eq(2) .find("img") .should("have.attr", "src", "test.jpg"); + cy.checkFinalState(); }); it("load members errors", function () { @@ -484,6 +485,7 @@ describe("Rooms view members", function () { "api/v1/rooms/abc-def-123/member*", "members", ); + cy.checkFinalState(); }); it("load members page out of range", function () { @@ -558,6 +560,7 @@ describe("Rooms view members", function () { page: "1", }); }); + cy.checkFinalState(); }); it("search members", function () { @@ -748,6 +751,7 @@ describe("Rooms view members", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("filter members", function () { @@ -991,6 +995,7 @@ describe("Rooms view members", function () { "have.text", "rooms.members.filter.all", ); + cy.checkFinalState(); }); it("sort members", function () { @@ -1210,6 +1215,7 @@ describe("Rooms view members", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("check button visibility co_owner", function () { @@ -1392,6 +1398,7 @@ describe("Rooms view members", function () { cy.get('[data-test="room-members-select-all-checkbox"]').should( "not.exist", ); + cy.checkFinalState(); }); it("check button visibility with rooms.viewAll and rooms.manage permissions", function () { @@ -1570,5 +1577,6 @@ describe("Rooms view members", function () { cy.get('[data-test="room-members-bulk-delete-button"]').should( "be.visible", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js b/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js index 52a7fd3e7..188932882 100644 --- a/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js @@ -246,6 +246,7 @@ describe("Rooms view members bulk actions", function () { // Check that bulk edit dialog is closed and bulk edit button is hidden cy.get('[data-test="room-members-bulk-edit-dialog"]').should("not.exist"); cy.get('[data-test="room-members-bulk-edit-button"]').should("not.exist"); + cy.checkFinalState(); }); it("bulk edit members errors", function () { @@ -408,6 +409,7 @@ describe("Rooms view members bulk actions", function () { "api/v1/rooms/abc-def-123/member/bulk", "members", ); + cy.checkFinalState(); }); it("bulk delete members", function () { @@ -576,6 +578,7 @@ describe("Rooms view members bulk actions", function () { // Check that users were removed cy.get('[data-test="room-member-item"]').should("have.length", 0); cy.contains("rooms.members.nodata").should("be.visible"); + cy.checkFinalState(); }); it("bulk delete members errors", function () { @@ -682,6 +685,7 @@ describe("Rooms view members bulk actions", function () { "api/v1/rooms/abc-def-123/member/bulk", "members", ); + cy.checkFinalState(); }); it("bulk import members", function () { @@ -1281,6 +1285,7 @@ describe("Rooms view members bulk actions", function () { cy.get('[data-test="room-members-bulk-import-dialog"]').should("not.exist"); cy.get('[data-test="room-member-item"]').should("have.length", 5); + cy.checkFinalState(); }); it("bulk import members errors", function () { @@ -1386,5 +1391,6 @@ describe("Rooms view members bulk actions", function () { "api/v1/rooms/abc-def-123/member/bulk", "members", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js b/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js index d2fea1dd4..5a51ed5c1 100644 --- a/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js @@ -239,6 +239,7 @@ describe("Rooms view members member actions", function () { cy.get('[data-test="room-member-item"]') .eq(3) .should("include.text", "rooms.roles.moderator"); + cy.checkFinalState(); }); it("add new member errors", function () { @@ -432,6 +433,7 @@ describe("Rooms view members member actions", function () { "/api/v1/rooms/abc-def-123/member", "members", ); + cy.checkFinalState(); }); it("edit member", function () { @@ -521,6 +523,7 @@ describe("Rooms view members member actions", function () { cy.get('[data-test="room-member-item"]') .eq(0) .should("include.text", "rooms.roles.moderator"); + cy.checkFinalState(); }); it("edit member errors", function () { @@ -636,6 +639,7 @@ describe("Rooms view members member actions", function () { "/api/v1/rooms/abc-def-123/member/6", "members", ); + cy.checkFinalState(); }); it("delete member", function () { @@ -704,6 +708,7 @@ describe("Rooms view members member actions", function () { // Check that delete dialog is closed cy.get('[data-test="room-members-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete member errors", function () { @@ -797,5 +802,6 @@ describe("Rooms view members member actions", function () { "/api/v1/rooms/abc-def-123/member/6", "members", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js index 721f7b187..530cf923d 100644 --- a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js +++ b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js @@ -127,6 +127,7 @@ describe("Rooms view personalized links", function () { 'rooms.personalized_links.expires_at_{"date":"10/20/2021, 11:17"}', ) .should("include.text", "rooms.roles.moderator"); + cy.checkFinalState(); }); it("load personalized links errors", function () { @@ -496,6 +497,7 @@ describe("Rooms view personalized links", function () { "api/v1/rooms/abc-def-123/personalizedLinks*", "tokens", ); + cy.checkFinalState(); }); it("load personalized links page out of range", function () { @@ -570,6 +572,7 @@ describe("Rooms view personalized links", function () { page: "1", }); }); + cy.checkFinalState(); }); it("view with different permissions", function () { @@ -794,6 +797,7 @@ describe("Rooms view personalized links", function () { "be.visible", ); }); + cy.checkFinalState(); }); it("search personalized links", function () { @@ -989,6 +993,7 @@ describe("Rooms view personalized links", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("filter personalized links", function () { @@ -1238,6 +1243,7 @@ describe("Rooms view personalized links", function () { "have.text", "rooms.personalized_links.filter.all", ); + cy.checkFinalState(); }); it("sort personalized links", function () { @@ -1468,5 +1474,6 @@ describe("Rooms view personalized links", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js b/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js index ba56784e5..ef92c9932 100644 --- a/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js @@ -137,6 +137,7 @@ describe("Rooms view personalized links actions", function () { .and("include.text", "rooms.roles.participant") .and("not.include.text", "rooms.personalized_links.last_used_at") .and("not.include.text", "rooms.personalized_links.expires_at"); + cy.checkFinalState(); }); it("add new personalized link errors", function () { @@ -234,6 +235,7 @@ describe("Rooms view personalized links actions", function () { "/api/v1/rooms/abc-def-123/personalizedLinks/", "tokens", ); + cy.checkFinalState(); }); it("edit personalized link", function () { @@ -374,6 +376,7 @@ describe("Rooms view personalized links actions", function () { "include.text", 'rooms.personalized_links.expires_at_{"date":"10/17/2021, 14:21"}', ); + cy.checkFinalState(); }); it("edit personalized link errors", function () { @@ -523,6 +526,7 @@ describe("Rooms view personalized links actions", function () { "/api/v1/rooms/abc-def-123/personalizedLinks/1", "tokens", ); + cy.checkFinalState(); }); it("delete personalized link", function () { @@ -600,6 +604,7 @@ describe("Rooms view personalized links actions", function () { "have.length", 2, ); + cy.checkFinalState(); }); it("delete personalized link errors", function () { @@ -716,6 +721,7 @@ describe("Rooms view personalized links actions", function () { "/api/v1/rooms/abc-def-123/personalizedLinks/1", "tokens", ); + cy.checkFinalState(); }); it("copy personalized link", function () { @@ -742,5 +748,6 @@ describe("Rooms view personalized links actions", function () { cy.checkToastMessage( 'rooms.personalized_links.room_link_copied_{"firstname":"John","lastname":"Doe"}', ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewRecordings.cy.js b/tests/Frontend/e2e/RoomsViewRecordings.cy.js index 517ff15a7..77563746d 100644 --- a/tests/Frontend/e2e/RoomsViewRecordings.cy.js +++ b/tests/Frontend/e2e/RoomsViewRecordings.cy.js @@ -307,6 +307,8 @@ describe("Rooms view recordings", function () { .eq(0) .find('button[data-test="room-recordings-delete-button"]') .should("not.be.disabled"); + + cy.checkFinalState(); }); it("load recordings with access code", function () { @@ -391,6 +393,7 @@ describe("Rooms view recordings", function () { .should("be.visible") .and("include.text", "rooms.recordings.retention_period.title") .and("include.text", "rooms.recordings.retention_period.unlimited"); + cy.checkFinalState(); }); it("load recordings with access code errors", function () { @@ -537,6 +540,7 @@ describe("Rooms view recordings", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); + cy.checkFinalState(); }); it("load recordings with personalized link", function () { @@ -609,6 +613,7 @@ describe("Rooms view recordings", function () { .should("be.visible") .and("include.text", "rooms.recordings.retention_period.title") .and("include.text", "rooms.recordings.retention_period.unlimited"); + cy.checkFinalState(); }); it("load recordings with personalized link errors", function () { @@ -701,6 +706,7 @@ describe("Rooms view recordings", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); + cy.checkFinalState(); }); it("load recordings errors", function () { @@ -866,6 +872,7 @@ describe("Rooms view recordings", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("load recordings page out of range", function () { @@ -939,6 +946,7 @@ describe("Rooms view recordings", function () { page: "1", }); }); + cy.checkFinalState(); }); it("view with different permissions", function () { @@ -1446,6 +1454,7 @@ describe("Rooms view recordings", function () { "include.text", 'rooms.recordings.retention_period.days_{"days":365}', ); + cy.checkFinalState(); }); it("search recordings", function () { @@ -1626,6 +1635,7 @@ describe("Rooms view recordings", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("filter recordings", function () { @@ -1882,6 +1892,7 @@ describe("Rooms view recordings", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); it("sort recordings", function () { @@ -2096,5 +2107,6 @@ describe("Rooms view recordings", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js b/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js index be0f1f879..a2461a38d 100644 --- a/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js @@ -66,6 +66,7 @@ describe("Rooms view recordings recording actions", function () { .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); }); + cy.checkFinalState(); }); it("view recording with access code", function () { @@ -169,6 +170,7 @@ describe("Rooms view recordings recording actions", function () { ) .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); + cy.checkFinalState(); }); it("view recording with access code errors", function () { @@ -298,6 +300,8 @@ describe("Rooms view recordings recording actions", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); + + cy.checkFinalState(); }); it("view recording with personalized link", function () { @@ -390,6 +394,7 @@ describe("Rooms view recordings recording actions", function () { ) .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); + cy.checkFinalState(); }); it("view recording with personalized link errors", function () { @@ -488,6 +493,7 @@ describe("Rooms view recordings recording actions", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); + cy.checkFinalState(); }); it("view recording with errors", function () { @@ -740,6 +746,7 @@ describe("Rooms view recordings recording actions", function () { cy.get(".p-toast-message").should("not.exist"); cy.get("@reloadRoomRecordingsRequest").should("be.null"); + cy.checkFinalState(); }); it("delete recording", function () { @@ -806,6 +813,7 @@ describe("Rooms view recordings recording actions", function () { // Check that dialog is closed cy.get('[data-test="room-recordings-delete-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("delete recording errors", function () { @@ -911,6 +919,7 @@ describe("Rooms view recordings recording actions", function () { "api/v1/rooms/abc-def-123/recordings/e0cfa18c5fd75a42bd7947d8549321b03abf1daf-1660728035", "recordings", ); + cy.checkFinalState(); }); it("edit recording", function () { @@ -1101,6 +1110,7 @@ describe("Rooms view recordings recording actions", function () { .eq(0) .should("include.text", "rooms.recordings.format_types.screenshare"); }); + cy.checkFinalState(); }); it("edit recording errors", function () { @@ -1264,5 +1274,6 @@ describe("Rooms view recordings recording actions", function () { "api/v1/rooms/abc-def-123/recordings/e0cfa18c5fd75a42bd7947d8549321b03abf1daf-1660728035", "recordings", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewSettings.cy.js b/tests/Frontend/e2e/RoomsViewSettings.cy.js index fb9eeed22..4111c0977 100644 --- a/tests/Frontend/e2e/RoomsViewSettings.cy.js +++ b/tests/Frontend/e2e/RoomsViewSettings.cy.js @@ -364,6 +364,7 @@ describe("Rooms view settings", function () { .should("have.text", "rooms.settings.advanced.visibility.public") .and("have.attr", "aria-pressed", "true"); }); + cy.checkFinalState(); }); it("load settings errors", function () { @@ -414,6 +415,7 @@ describe("Rooms view settings", function () { "api/v1/rooms/abc-def-123/settings", "settings", ); + cy.checkFinalState(); }); it("load settings with different permissions", function () { @@ -834,6 +836,7 @@ describe("Rooms view settings", function () { .should("have.text", "rooms.settings.advanced.visibility.public") .and("have.attr", "aria-pressed", "true") .and("not.be.disabled"); + cy.checkFinalState(); }); it("change settings", function () { @@ -1234,6 +1237,7 @@ describe("Rooms view settings", function () { "have.text", "rooms.settings.expert_mode.activate", ); + cy.checkFinalState(); }); it("change settings with GL3 access code", function () { @@ -1301,6 +1305,7 @@ describe("Rooms view settings", function () { // Check that settings are shown correctly cy.get("#room-setting-name").should("have.value", "Meeting Two"); + cy.checkFinalState(); }); it("change settings errors", function () { @@ -1644,6 +1649,7 @@ describe("Rooms view settings", function () { "api/v1/rooms/abc-def-123", "settings", ); + cy.checkFinalState(); }); it("delete room", function () { @@ -1700,6 +1706,7 @@ describe("Rooms view settings", function () { cy.wait("@roomDeleteRequest"); cy.url().should("include", "/rooms").and("not.include", "/abc-def-123"); + cy.checkFinalState(); }); it("delete room errors", function () { @@ -1769,6 +1776,7 @@ describe("Rooms view settings", function () { "api/v1/rooms/abc-def-123", "settings", ); + cy.checkFinalState(); }); it("transfer ownership", function () { @@ -2083,6 +2091,7 @@ describe("Rooms view settings", function () { // Check that access code overlay is shown cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); + cy.checkFinalState(); }); it("transfer ownership errors", function () { @@ -2257,5 +2266,6 @@ describe("Rooms view settings", function () { "api/v1/rooms/abc-def-123/transfer", "settings", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js b/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js index 46cdb882f..9ba5f4d1f 100644 --- a/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js @@ -1448,6 +1448,7 @@ describe("Rooms view settings room type actions", function () { .eq(1) .should("have.attr", "aria-pressed", "false") .and("be.disabled"); + cy.checkFinalState(); }); it("change room type with features enabled", function () { @@ -1594,6 +1595,7 @@ describe("Rooms view settings room type actions", function () { ); }); }); + cy.checkFinalState(); }); it("change room type with features disabled", function () { @@ -1643,6 +1645,7 @@ describe("Rooms view settings room type actions", function () { cy.get('[data-test="room-type-features"]').should("not.exist"); }); }); + cy.checkFinalState(); }); it("change room type with features disabled and show disabled features", function () { @@ -1719,6 +1722,7 @@ describe("Rooms view settings room type actions", function () { ); }); }); + cy.checkFinalState(); }); it("change room type no expert", function () { @@ -2510,6 +2514,7 @@ describe("Rooms view settings room type actions", function () { ); cy.get('[data-test="room-type-change-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("errors loading room types", function () { @@ -2615,5 +2620,6 @@ describe("Rooms view settings room type actions", function () { "api/v1/roomTypes*", "settings", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewStreaming.cy.js b/tests/Frontend/e2e/RoomsViewStreaming.cy.js index ee3d562e5..89de79f45 100644 --- a/tests/Frontend/e2e/RoomsViewStreaming.cy.js +++ b/tests/Frontend/e2e/RoomsViewStreaming.cy.js @@ -39,6 +39,7 @@ describe("Rooms view streaming", function () { cy.get('[data-test="streaming-stop-button"]').should("be.disabled"); cy.get('[data-test="streaming-pause-button"]').should("be.disabled"); cy.get('[data-test="streaming-resume-button"]').should("be.disabled"); + cy.checkFinalState(); }); it("no running meeting, meeting ended", function () { @@ -69,6 +70,7 @@ describe("Rooms view streaming", function () { cy.get('[data-test="streaming-stop-button"]').should("be.disabled"); cy.get('[data-test="streaming-pause-button"]').should("be.disabled"); cy.get('[data-test="streaming-resume-button"]').should("be.disabled"); + cy.checkFinalState(); }); it("running meeting, streaming disabled", function () { @@ -107,6 +109,7 @@ describe("Rooms view streaming", function () { cy.get('[data-test="streaming-stop-button"]').should("be.disabled"); cy.get('[data-test="streaming-pause-button"]').should("be.disabled"); cy.get('[data-test="streaming-resume-button"]').should("be.disabled"); + cy.checkFinalState(); }); it("fps counter is shown", function () { @@ -172,6 +175,7 @@ describe("Rooms view streaming", function () { // Check if fps counter is not shown cy.get('[data-test="streaming-fps-counter"]').should("not.exist"); + cy.checkFinalState(); }); it("start, pause, resume and stop streaming", function () { @@ -458,6 +462,7 @@ describe("Rooms view streaming", function () { "contain", "rooms.streaming.failed", ); + cy.checkFinalState(); }); it("load settings with different permissions", function () { @@ -578,6 +583,7 @@ describe("Rooms view streaming", function () { "contain", "rooms.streaming.running", ); + cy.checkFinalState(); }); it("auto reloading", function () { @@ -642,6 +648,7 @@ describe("Rooms view streaming", function () { "rooms.streaming.running", ); }); + cy.checkFinalState(); }); it("error handling", function () { @@ -786,5 +793,6 @@ describe("Rooms view streaming", function () { "contain", "rooms.streaming.no_running_meeting", ); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js b/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js index a24011106..a7014eaba 100644 --- a/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js @@ -212,6 +212,7 @@ describe("Rooms view streaming config actions", function () { // Close dialog cy.get('[data-test="dialog-cancel-button"]').click(); }); + cy.checkFinalState(); }); it("load with error", function () { @@ -277,6 +278,7 @@ describe("Rooms view streaming config actions", function () { // Close dialog cy.get('[data-test="dialog-cancel-button"]').click(); }); + cy.checkFinalState(); }); it("edit settings", function () { @@ -490,6 +492,7 @@ describe("Rooms view streaming config actions", function () { // Check dialog closed cy.get('[data-test="room-streaming-config-dialog"]').should("not.exist"); + cy.checkFinalState(); }); it("edit settings errors", function () { @@ -598,6 +601,7 @@ describe("Rooms view streaming config actions", function () { // Close dialog cy.get('[data-test="dialog-cancel-button"]').click(); }); + cy.checkFinalState(); }); it("view/edit settings with different permissions", function () { @@ -734,5 +738,6 @@ describe("Rooms view streaming config actions", function () { // Close dialog cy.get('[data-test="dialog-cancel-button"]').click(); }); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfile.cy.js b/tests/Frontend/e2e/UserProfile.cy.js index a07bfae13..31f192681 100644 --- a/tests/Frontend/e2e/UserProfile.cy.js +++ b/tests/Frontend/e2e/UserProfile.cy.js @@ -8,6 +8,7 @@ describe("User Profile", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/profile"); + cy.checkFinalState(); }); it("open user profile", function () { @@ -55,6 +56,7 @@ describe("User Profile", function () { cy.get('[data-test="email-tab-button"]').should("be.visible"); cy.get('[data-test="security-tab-button"]').should("be.visible"); cy.get('[data-test="others-tab-button"]').should("be.visible"); + cy.checkFinalState(); }); it("open user profile errors", function () { @@ -106,6 +108,7 @@ describe("User Profile", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("should hide edit controls when external_image is true", function () { @@ -120,5 +123,6 @@ describe("User Profile", function () { cy.get('[data-test="profile-image-field"]').should("be.visible"); cy.get('[data-test="upload-file-button"]').should("not.exist"); cy.get('[data-test="delete-image-button"]').should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileBase.cy.js b/tests/Frontend/e2e/UserProfileBase.cy.js index 1c3f7820e..7e4003911 100644 --- a/tests/Frontend/e2e/UserProfileBase.cy.js +++ b/tests/Frontend/e2e/UserProfileBase.cy.js @@ -495,6 +495,7 @@ describe("User Profile Base", function () { cy.get('[data-test="default-profile-image-preview"]') .should("be.visible") .and("include.text", "LR"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -640,6 +641,7 @@ describe("User Profile Base", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("view without users.updateOwnAttributes permission", function () { @@ -682,6 +684,7 @@ describe("User Profile Base", function () { "true", ); }); + cy.checkFinalState(); }); it("view as external user", function () { @@ -740,6 +743,7 @@ describe("User Profile Base", function () { "true", ); }); + cy.checkFinalState(); }); it("load timezones error", function () { @@ -830,5 +834,6 @@ describe("User Profile Base", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileEmail.cy.js b/tests/Frontend/e2e/UserProfileEmail.cy.js index 2c4ffe5d6..5a649177c 100644 --- a/tests/Frontend/e2e/UserProfileEmail.cy.js +++ b/tests/Frontend/e2e/UserProfileEmail.cy.js @@ -104,6 +104,7 @@ describe("User Profile Email", function () { cy.get("#email") .should("have.value", "john.doe@example.com") .and("not.be.disabled"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -188,6 +189,7 @@ describe("User Profile Email", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("view without users.updateOwnAttributes permission", function () { @@ -208,6 +210,7 @@ describe("User Profile Email", function () { .and("have.value", "JohnDoe@domain.tld"); cy.get('[data-test="user-tab-email-save-button"]').should("not.exist"); + cy.checkFinalState(); }); it("view as external user", function () { @@ -236,5 +239,6 @@ describe("User Profile Email", function () { .and("have.value", "JohnDoe@domain.tld"); cy.get('[data-test="user-tab-email-save-button"]').should("not.exist"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileOthers.cy.js b/tests/Frontend/e2e/UserProfileOthers.cy.js index 165d4c66a..e75aa05f5 100644 --- a/tests/Frontend/e2e/UserProfileOthers.cy.js +++ b/tests/Frontend/e2e/UserProfileOthers.cy.js @@ -55,6 +55,7 @@ describe("User Profile Others", function () { // Check that the changes are shown cy.get("#bbb_skip_check_audio").should("be.checked"); + cy.checkFinalState(); }); it("save changes errors", function () { @@ -150,5 +151,6 @@ describe("User Profile Others", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileSecurity.cy.js b/tests/Frontend/e2e/UserProfileSecurity.cy.js index 6a80e0e98..2f233d621 100644 --- a/tests/Frontend/e2e/UserProfileSecurity.cy.js +++ b/tests/Frontend/e2e/UserProfileSecurity.cy.js @@ -193,6 +193,7 @@ describe("User Profile Security", function () { .should("include.text", "auth.sessions.current") .should("include.text", "auth.sessions.browser Chrome") .should("include.text", "auth.sessions.ip 10.9.1.2"); + cy.checkFinalState(); }); it("view without password change allowed", function () { @@ -255,6 +256,7 @@ describe("User Profile Security", function () { cy.get('[data-test="logout-all-sessions-button"]') .should("have.text", "auth.sessions.logout_all") .should("not.be.disabled"); + cy.checkFinalState(); }); it("view as external user", function () { @@ -318,6 +320,7 @@ describe("User Profile Security", function () { cy.get('[data-test="logout-all-sessions-button"]') .should("have.text", "auth.sessions.logout_all") .should("not.be.disabled"); + cy.checkFinalState(); }); it("change settings errors", function () { @@ -479,6 +482,7 @@ describe("User Profile Security", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); it("load sessions error", function () { @@ -552,5 +556,6 @@ describe("User Profile Security", function () { .should("include.text", "01/23/2022, 16:55") .should("include.text", "auth.sessions.browser Mobile Safari") .should("include.text", "auth.sessions.ip 10.9.1.5"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/VerifyEmail.cy.js b/tests/Frontend/e2e/VerifyEmail.cy.js index a809e4da9..464908a10 100644 --- a/tests/Frontend/e2e/VerifyEmail.cy.js +++ b/tests/Frontend/e2e/VerifyEmail.cy.js @@ -27,10 +27,12 @@ describe("Verify email", function () { cy.visit("/verify_email"); cy.url().should("include", "/404").and("not.include", "/verify_email"); + cy.checkFinalState(); }); it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/verify_email"); + cy.checkFinalState(); }); it("verify email", function () { @@ -70,6 +72,7 @@ describe("Verify email", function () { .and("include.text", "app.verify_email.success"); cy.get('[data-test="verify-invalid-message"]').should("not.exist"); cy.get('[data-test="verify-error-message"]').should("not.exist"); + cy.checkFinalState(); }); it("verify email errors", function () { @@ -169,5 +172,6 @@ describe("Verify email", function () { cy.url().should("include", "/login?redirect=/verify_email"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkFinalState(); }); }); diff --git a/tests/Frontend/support/commands/generalCommands.js b/tests/Frontend/support/commands/generalCommands.js index cb0725c04..774b29422 100644 --- a/tests/Frontend/support/commands/generalCommands.js +++ b/tests/Frontend/support/commands/generalCommands.js @@ -1,3 +1,39 @@ +Cypress.Commands.overwrite("visit", (originalFn, url, options) => { + return cy + .wrap(null) + .then(() => { + cy.checkFinalState(); + }) + .then(() => { + return originalFn(url, options); + }); +}); + +Cypress.Commands.overwrite("reload", (originalFn, options) => { + return cy + .wrap(null) + .then(() => { + cy.checkFinalState(); + }) + .then(() => { + return originalFn(options); + }); +}); + +Cypress.Commands.add("checkFinalState", () => { + cy.url().then((currentUrl) => { + const currentOrigin = new URL(currentUrl).origin; + const baseOrigin = new URL(Cypress.config().baseUrl).origin; + + if (currentOrigin === baseOrigin) { + // Check that all toasts that maybe have been created during the test have been removed + // This makes sure that unexpected error toasts that are not handled in the test will cause the test to fail, + // which makes sure that we don't miss any unexpected errors in the tests + cy.get(".p-toast-message").should("not.exist"); + } + }); +}); + /** * Check that a user who visits this page without being logged in is redirected to the login page * @memberof cy From 904e22a70167a5c7c79cf7a269076597cb228be6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Sun, 3 May 2026 20:49:47 +0200 Subject: [PATCH 02/14] Move custom command overrides --- .../support/commands/commandOverrides.js | 29 +++++++++++++++++++ .../support/commands/generalCommands.js | 29 +++++-------------- tests/Frontend/support/e2e.js | 1 + 3 files changed, 37 insertions(+), 22 deletions(-) create mode 100644 tests/Frontend/support/commands/commandOverrides.js diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js new file mode 100644 index 000000000..a1445a03d --- /dev/null +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -0,0 +1,29 @@ +/** + * Override for visit + * Checks final state before performing the visit, to make sure that unexpected errors that may have happened previously are caught. + */ +Cypress.Commands.overwrite("visit", (originalFn, url, options) => { + return cy + .wrap(null) + .then(() => { + cy.checkFinalState(); + }) + .then(() => { + return originalFn(url, options); + }); +}); + +/** + * Override for reload + * Checks final state before performing the reload, to make sure that unexpected errors that may have happened previously are caught. + */ +Cypress.Commands.overwrite("reload", (originalFn, options) => { + return cy + .wrap(null) + .then(() => { + cy.checkFinalState(); + }) + .then(() => { + return originalFn(options); + }); +}); diff --git a/tests/Frontend/support/commands/generalCommands.js b/tests/Frontend/support/commands/generalCommands.js index 774b29422..6d9460c2c 100644 --- a/tests/Frontend/support/commands/generalCommands.js +++ b/tests/Frontend/support/commands/generalCommands.js @@ -1,25 +1,10 @@ -Cypress.Commands.overwrite("visit", (originalFn, url, options) => { - return cy - .wrap(null) - .then(() => { - cy.checkFinalState(); - }) - .then(() => { - return originalFn(url, options); - }); -}); - -Cypress.Commands.overwrite("reload", (originalFn, options) => { - return cy - .wrap(null) - .then(() => { - cy.checkFinalState(); - }) - .then(() => { - return originalFn(options); - }); -}); - +/** + * Check that the final state of the test is correct, e.g. that there are no unexpected error toasts. + * This should be called at the end of every test to make sure that unexpected errors aren't missed in the tests. + * @memberof cy + * @method checkFinalState + * @returns void + */ Cypress.Commands.add("checkFinalState", () => { cy.url().then((currentUrl) => { const currentOrigin = new URL(currentUrl).origin; diff --git a/tests/Frontend/support/e2e.js b/tests/Frontend/support/e2e.js index 3c6adc628..f35f87a91 100644 --- a/tests/Frontend/support/e2e.js +++ b/tests/Frontend/support/e2e.js @@ -13,6 +13,7 @@ // https://on.cypress.io/configuration // *********************************************************** +import "./commands/commandOverrides.js"; import "./commands/generalCommands.js"; import "./commands/roomCommands.js"; import "./commands/interceptCommands.js"; From 7175a3a5df083ad6c1bbc869b39114906cc06133 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Sun, 3 May 2026 20:51:21 +0200 Subject: [PATCH 03/14] Add missing toast checks --- tests/Frontend/e2e/AdminIndex.cy.js | 2 ++ tests/Frontend/e2e/AdminRolesNew.cy.js | 2 ++ tests/Frontend/e2e/AdminRoomTypesNew.cy.js | 2 ++ tests/Frontend/e2e/Login.cy.js | 4 ++++ tests/Frontend/e2e/RoomsViewFiles.cy.js | 1 - 5 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/Frontend/e2e/AdminIndex.cy.js b/tests/Frontend/e2e/AdminIndex.cy.js index bf4faf656..81e7388f8 100644 --- a/tests/Frontend/e2e/AdminIndex.cy.js +++ b/tests/Frontend/e2e/AdminIndex.cy.js @@ -27,6 +27,8 @@ describe("Admin index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkToastMessage("app.flash.unauthorized"); + cy.checkFinalState(); }); diff --git a/tests/Frontend/e2e/AdminRolesNew.cy.js b/tests/Frontend/e2e/AdminRolesNew.cy.js index 1317f22c8..4769aa063 100644 --- a/tests/Frontend/e2e/AdminRolesNew.cy.js +++ b/tests/Frontend/e2e/AdminRolesNew.cy.js @@ -44,6 +44,8 @@ describe("Admin roles new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/room_types"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkToastMessage("app.flash.unauthorized"); + cy.checkFinalState(); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesNew.cy.js b/tests/Frontend/e2e/AdminRoomTypesNew.cy.js index dcef9b3cc..b438a5a00 100644 --- a/tests/Frontend/e2e/AdminRoomTypesNew.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesNew.cy.js @@ -47,6 +47,8 @@ describe("Admin room types new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/room_types"); cy.get("h1").should("be.visible").and("include.text", "home.title"); + cy.checkToastMessage("app.flash.unauthorized"); + cy.checkFinalState(); }); diff --git a/tests/Frontend/e2e/Login.cy.js b/tests/Frontend/e2e/Login.cy.js index c2355adf5..a41b52245 100644 --- a/tests/Frontend/e2e/Login.cy.js +++ b/tests/Frontend/e2e/Login.cy.js @@ -655,6 +655,8 @@ describe("Login", function () { cy.visit("/external_login"); cy.url().should("include", "/rooms").and("not.include", "/login"); + cy.checkToastMessage("auth.flash.login"); + cy.checkFinalState(); }); @@ -845,6 +847,8 @@ describe("Login", function () { cy.visit("/external_login"); cy.url().should("include", "/rooms").and("not.include", "/login"); + cy.checkToastMessage("auth.flash.login"); + cy.checkFinalState(); }); diff --git a/tests/Frontend/e2e/RoomsViewFiles.cy.js b/tests/Frontend/e2e/RoomsViewFiles.cy.js index f4a6b3014..3dec6cfeb 100644 --- a/tests/Frontend/e2e/RoomsViewFiles.cy.js +++ b/tests/Frontend/e2e/RoomsViewFiles.cy.js @@ -433,7 +433,6 @@ describe("Rooms View Files", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); - cy.contains("rooms.flash.access_code_invalid").should("be.visible"); cy.checkFinalState(); }); From a19ed044c35bc4a9648216d87408d4f0f4a2f6f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Sun, 3 May 2026 20:57:52 +0200 Subject: [PATCH 04/14] Add toast checks for require_code error toasts --- tests/Frontend/e2e/RoomsViewGeneral.cy.js | 3 +++ tests/Frontend/e2e/RoomsViewHistory.cy.js | 2 ++ tests/Frontend/e2e/RoomsViewMembers.cy.js | 2 ++ tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js | 1 + tests/Frontend/e2e/RoomsViewSettings.cy.js | 2 ++ tests/Frontend/support/commands/roomCommands.js | 5 +++++ 6 files changed, 15 insertions(+) diff --git a/tests/Frontend/e2e/RoomsViewGeneral.cy.js b/tests/Frontend/e2e/RoomsViewGeneral.cy.js index 80f5a4d73..58ee18032 100644 --- a/tests/Frontend/e2e/RoomsViewGeneral.cy.js +++ b/tests/Frontend/e2e/RoomsViewGeneral.cy.js @@ -2464,6 +2464,7 @@ describe("Room View general", function () { cy.url().should("not.include", "/login"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkToastMessage("rooms.require_access_code"); cy.contains("auth.login").should("be.visible"); @@ -2715,6 +2716,8 @@ describe("Room View general", function () { cy.url().should("not.include", "/login"); cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkToastMessage("rooms.require_access_code"); + cy.contains("auth.login").should("be.visible"); // Check that access code overlay is shown diff --git a/tests/Frontend/e2e/RoomsViewHistory.cy.js b/tests/Frontend/e2e/RoomsViewHistory.cy.js index d0ce9ddd9..27b8f48ab 100644 --- a/tests/Frontend/e2e/RoomsViewHistory.cy.js +++ b/tests/Frontend/e2e/RoomsViewHistory.cy.js @@ -389,6 +389,8 @@ describe("Rooms view history", function () { // Check that error message is shown cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkToastMessage("rooms.require_access_code"); + cy.contains("auth.login").should("be.visible"); // 401 error but guests are forbidden diff --git a/tests/Frontend/e2e/RoomsViewMembers.cy.js b/tests/Frontend/e2e/RoomsViewMembers.cy.js index a83556aaa..b4a7a12fe 100644 --- a/tests/Frontend/e2e/RoomsViewMembers.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembers.cy.js @@ -377,6 +377,8 @@ describe("Rooms view members", function () { // Check that error message is shown cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkToastMessage("rooms.require_access_code"); + cy.contains("auth.login").should("be.visible"); // 401 error but guests are forbidden diff --git a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js index 530cf923d..75f11f0df 100644 --- a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js +++ b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js @@ -389,6 +389,7 @@ describe("Rooms view personalized links", function () { // Check that error message is shown cy.checkToastMessage("app.flash.unauthenticated"); + cy.checkToastMessage("rooms.require_access_code"); cy.contains("auth.login").should("be.visible"); // 401 error but guests are forbidden diff --git a/tests/Frontend/e2e/RoomsViewSettings.cy.js b/tests/Frontend/e2e/RoomsViewSettings.cy.js index 4111c0977..a0a4e7f7d 100644 --- a/tests/Frontend/e2e/RoomsViewSettings.cy.js +++ b/tests/Frontend/e2e/RoomsViewSettings.cy.js @@ -2090,6 +2090,8 @@ describe("Rooms view settings", function () { cy.contains("Laura Walter").should("be.visible"); // Check that access code overlay is shown + cy.checkToastMessage("rooms.require_access_code"); + cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); cy.checkFinalState(); }); diff --git a/tests/Frontend/support/commands/roomCommands.js b/tests/Frontend/support/commands/roomCommands.js index 11abf2e17..a418998c4 100644 --- a/tests/Frontend/support/commands/roomCommands.js +++ b/tests/Frontend/support/commands/roomCommands.js @@ -202,6 +202,8 @@ Cypress.Commands.add( cy.checkToastMessage("app.flash.unauthenticated"); cy.contains("auth.login").should("be.visible"); + cy.checkToastMessage("rooms.require_access_code"); + // Check with 401 error but guests are forbidden // Reload with logged in user cy.intercept("GET", "api/v1/rooms/abc-def-123", { @@ -395,6 +397,9 @@ Cypress.Commands.add( // Check that room gets reloaded cy.wait("@roomRequestCheckRoomAuthErrors"); + // Check that require code error message is shown + cy.checkToastMessage("rooms.require_access_code"); + // Check that access code overlay is shown cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); From 57757ac1b1ce943e01505930e783961a340e4273 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Tue, 5 May 2026 07:37:49 +0200 Subject: [PATCH 05/14] Improve cypress log readability --- tests/Frontend/support/commands/commandOverrides.js | 6 ++++-- tests/Frontend/support/commands/generalCommands.js | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index a1445a03d..01af50c06 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -4,11 +4,12 @@ */ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { return cy - .wrap(null) + .wrap(null, { log: false }) .then(() => { cy.checkFinalState(); }) .then(() => { + cy.log(`Visit ${url}`); return originalFn(url, options); }); }); @@ -19,11 +20,12 @@ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { */ Cypress.Commands.overwrite("reload", (originalFn, options) => { return cy - .wrap(null) + .wrap(null, { log: false }) .then(() => { cy.checkFinalState(); }) .then(() => { + cy.log("Reload page"); return originalFn(options); }); }); diff --git a/tests/Frontend/support/commands/generalCommands.js b/tests/Frontend/support/commands/generalCommands.js index 6d9460c2c..f92ea5281 100644 --- a/tests/Frontend/support/commands/generalCommands.js +++ b/tests/Frontend/support/commands/generalCommands.js @@ -6,7 +6,7 @@ * @returns void */ Cypress.Commands.add("checkFinalState", () => { - cy.url().then((currentUrl) => { + cy.url({ log: false }).then((currentUrl) => { const currentOrigin = new URL(currentUrl).origin; const baseOrigin = new URL(Cypress.config().baseUrl).origin; From 03c98f678ffc322034aecbf9823c1602a48eb4d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Sun, 10 May 2026 08:48:58 +0200 Subject: [PATCH 06/14] Revert "Add toast checks for require_code error toasts" This reverts commit a19ed044c35bc4a9648216d87408d4f0f4a2f6f6. --- tests/Frontend/e2e/RoomsViewGeneral.cy.js | 3 --- tests/Frontend/e2e/RoomsViewHistory.cy.js | 2 -- tests/Frontend/e2e/RoomsViewMembers.cy.js | 2 -- tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js | 1 - tests/Frontend/e2e/RoomsViewSettings.cy.js | 2 -- tests/Frontend/support/commands/roomCommands.js | 5 ----- 6 files changed, 15 deletions(-) diff --git a/tests/Frontend/e2e/RoomsViewGeneral.cy.js b/tests/Frontend/e2e/RoomsViewGeneral.cy.js index ee81d5517..a0f7fbd4b 100644 --- a/tests/Frontend/e2e/RoomsViewGeneral.cy.js +++ b/tests/Frontend/e2e/RoomsViewGeneral.cy.js @@ -2599,7 +2599,6 @@ describe("Room View general", function () { cy.url().should("not.include", "/login"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkToastMessage("rooms.require_access_code"); cy.contains("auth.login").should("be.visible"); @@ -2944,8 +2943,6 @@ describe("Room View general", function () { cy.url().should("not.include", "/login"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkToastMessage("rooms.require_access_code"); - cy.contains("auth.login").should("be.visible"); // Check that access code overlay is shown diff --git a/tests/Frontend/e2e/RoomsViewHistory.cy.js b/tests/Frontend/e2e/RoomsViewHistory.cy.js index 2dac077ba..2f05c7614 100644 --- a/tests/Frontend/e2e/RoomsViewHistory.cy.js +++ b/tests/Frontend/e2e/RoomsViewHistory.cy.js @@ -389,8 +389,6 @@ describe("Rooms view history", function () { // Check that error message is shown cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkToastMessage("rooms.require_access_code"); - cy.contains("auth.login").should("be.visible"); // 401 error but guests are forbidden diff --git a/tests/Frontend/e2e/RoomsViewMembers.cy.js b/tests/Frontend/e2e/RoomsViewMembers.cy.js index 527aab8ea..b3f3bdb00 100644 --- a/tests/Frontend/e2e/RoomsViewMembers.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembers.cy.js @@ -377,8 +377,6 @@ describe("Rooms view members", function () { // Check that error message is shown cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkToastMessage("rooms.require_access_code"); - cy.contains("auth.login").should("be.visible"); // 401 error but guests are forbidden diff --git a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js index 5cccb6824..32bb566d1 100644 --- a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js +++ b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js @@ -389,7 +389,6 @@ describe("Rooms view personalized links", function () { // Check that error message is shown cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkToastMessage("rooms.require_access_code"); cy.contains("auth.login").should("be.visible"); // 401 error but guests are forbidden diff --git a/tests/Frontend/e2e/RoomsViewSettings.cy.js b/tests/Frontend/e2e/RoomsViewSettings.cy.js index e9c32a0ca..24e4f1cc2 100644 --- a/tests/Frontend/e2e/RoomsViewSettings.cy.js +++ b/tests/Frontend/e2e/RoomsViewSettings.cy.js @@ -2177,8 +2177,6 @@ describe("Rooms view settings", function () { cy.contains("Laura Walter").should("be.visible"); // Check that access code overlay is shown - cy.checkToastMessage("rooms.require_access_code"); - cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); cy.checkFinalState(); }); diff --git a/tests/Frontend/support/commands/roomCommands.js b/tests/Frontend/support/commands/roomCommands.js index a418998c4..11abf2e17 100644 --- a/tests/Frontend/support/commands/roomCommands.js +++ b/tests/Frontend/support/commands/roomCommands.js @@ -202,8 +202,6 @@ Cypress.Commands.add( cy.checkToastMessage("app.flash.unauthenticated"); cy.contains("auth.login").should("be.visible"); - cy.checkToastMessage("rooms.require_access_code"); - // Check with 401 error but guests are forbidden // Reload with logged in user cy.intercept("GET", "api/v1/rooms/abc-def-123", { @@ -397,9 +395,6 @@ Cypress.Commands.add( // Check that room gets reloaded cy.wait("@roomRequestCheckRoomAuthErrors"); - // Check that require code error message is shown - cy.checkToastMessage("rooms.require_access_code"); - // Check that access code overlay is shown cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); From c2e998c2aed0e9e1f51b459822781fff9f27b13a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Wed, 13 May 2026 18:00:55 +0200 Subject: [PATCH 07/14] Move check or unexpected toasts to it function --- tests/Frontend/e2e/AdminIndex.cy.js | 11 ---- tests/Frontend/e2e/AdminRolesEdit.cy.js | 12 ---- tests/Frontend/e2e/AdminRolesIndex.cy.js | 12 ---- .../e2e/AdminRolesIndexRoleActions.cy.js | 5 -- tests/Frontend/e2e/AdminRolesNew.cy.js | 9 --- tests/Frontend/e2e/AdminRolesView.cy.js | 12 ---- .../e2e/AdminRolesViewRoleActions.cy.js | 3 - tests/Frontend/e2e/AdminRoomTypesEdit.cy.js | 9 --- tests/Frontend/e2e/AdminRoomTypesIndex.cy.js | 9 --- .../AdminRoomTypesIndexRoomTypeActions.cy.js | 7 --- tests/Frontend/e2e/AdminRoomTypesNew.cy.js | 8 --- tests/Frontend/e2e/AdminRoomTypesView.cy.js | 7 --- .../AdminRoomTypesViewRoomTypeActions.cy.js | 5 -- tests/Frontend/e2e/AdminServerPoolsEdit.cy.js | 7 --- .../Frontend/e2e/AdminServerPoolsIndex.cy.js | 11 ---- ...minServerPoolsIndexServerPoolActions.cy.js | 5 -- tests/Frontend/e2e/AdminServerPoolsNew.cy.js | 6 -- tests/Frontend/e2e/AdminServerPoolsView.cy.js | 6 -- ...dminServerPoolsViewServerPoolActions.cy.js | 3 - tests/Frontend/e2e/AdminServersEdit.cy.js | 6 -- tests/Frontend/e2e/AdminServersIndex.cy.js | 11 ---- .../e2e/AdminServersIndexServerActions.cy.js | 6 -- tests/Frontend/e2e/AdminServersNew.cy.js | 4 -- tests/Frontend/e2e/AdminServersView.cy.js | 8 --- .../e2e/AdminServersViewServerActions.cy.js | 7 --- tests/Frontend/e2e/AdminSettingsEdit.cy.js | 11 ---- tests/Frontend/e2e/AdminSettingsGeneral.cy.js | 6 -- tests/Frontend/e2e/AdminSettingsView.cy.js | 7 --- tests/Frontend/e2e/AdminStreamingEdit.cy.js | 8 --- tests/Frontend/e2e/AdminStreamingView.cy.js | 3 - tests/Frontend/e2e/AdminUsersEdit.cy.js | 6 -- tests/Frontend/e2e/AdminUsersEditBase.cy.js | 4 -- tests/Frontend/e2e/AdminUsersEditEmail.cy.js | 3 - tests/Frontend/e2e/AdminUsersEditOthers.cy.js | 2 - .../Frontend/e2e/AdminUsersEditSecurity.cy.js | 8 --- tests/Frontend/e2e/AdminUsersIndex.cy.js | 14 ----- .../e2e/AdminUsersIndexUserActions.cy.js | 7 --- tests/Frontend/e2e/AdminUsersNew.cy.js | 9 --- tests/Frontend/e2e/AdminUsersView.cy.js | 10 ---- .../e2e/AdminUsersViewUserActions.cy.js | 5 -- tests/Frontend/e2e/Banner.cy.js | 3 - tests/Frontend/e2e/Footer.cy.js | 13 ----- tests/Frontend/e2e/ForgotPassword.cy.js | 5 -- tests/Frontend/e2e/GeneralApplication.cy.js | 14 ----- tests/Frontend/e2e/Login.cy.js | 25 --------- tests/Frontend/e2e/Logout.cy.js | 3 - tests/Frontend/e2e/MeetingsIndex.cy.js | 9 --- tests/Frontend/e2e/PasswordReset.cy.js | 5 -- tests/Frontend/e2e/RoomsIndex.cy.js | 17 ------ .../e2e/RoomsIndexCreateNewRoom.cy.js | 10 ---- .../e2e/RoomsViewBrowserNotification.cy.js | 8 --- tests/Frontend/e2e/RoomsViewDescription.cy.js | 6 -- .../RoomsViewDescriptionTipTapEditor.cy.js | 7 --- tests/Frontend/e2e/RoomsViewFiles.cy.js | 11 ---- .../e2e/RoomsViewFilesFileActions.cy.js | 19 ------- tests/Frontend/e2e/RoomsViewGeneral.cy.js | 34 ----------- tests/Frontend/e2e/RoomsViewHistory.cy.js | 5 -- .../e2e/RoomsViewHistoryMeetingActions.cy.js | 4 -- tests/Frontend/e2e/RoomsViewMeetings.cy.js | 56 ------------------- tests/Frontend/e2e/RoomsViewMembers.cy.js | 8 --- .../e2e/RoomsViewMembersBulkActions.cy.js | 6 -- .../e2e/RoomsViewMembersMemberActions.cy.js | 6 -- .../e2e/RoomsViewPersonalizedLinks.cy.js | 7 --- ...omsViewPersonalizedLinksTokenActions.cy.js | 7 --- tests/Frontend/e2e/RoomsViewRecordings.cy.js | 12 ---- .../RoomsViewRecordingsRecordingActions.cy.js | 11 ---- tests/Frontend/e2e/RoomsViewSettings.cy.js | 10 ---- .../RoomsViewSettingsRoomTypeActions.cy.js | 6 -- tests/Frontend/e2e/RoomsViewStreaming.cy.js | 8 --- .../e2e/RoomsViewStreamingConfigActions.cy.js | 5 -- tests/Frontend/e2e/UserProfile.cy.js | 4 -- tests/Frontend/e2e/UserProfileBase.cy.js | 5 -- tests/Frontend/e2e/UserProfileEmail.cy.js | 4 -- tests/Frontend/e2e/UserProfileOthers.cy.js | 2 - tests/Frontend/e2e/UserProfileSecurity.cy.js | 5 -- tests/Frontend/e2e/VerifyEmail.cy.js | 4 -- .../support/commands/commandOverrides.js | 21 +++++++ 77 files changed, 21 insertions(+), 656 deletions(-) diff --git a/tests/Frontend/e2e/AdminIndex.cy.js b/tests/Frontend/e2e/AdminIndex.cy.js index 81e7388f8..902e33875 100644 --- a/tests/Frontend/e2e/AdminIndex.cy.js +++ b/tests/Frontend/e2e/AdminIndex.cy.js @@ -13,7 +13,6 @@ describe("Admin index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin"); - cy.checkFinalState(); }); it("visit without permission to view admin pages", function () { @@ -28,8 +27,6 @@ describe("Admin index", function () { cy.url().should("not.include", "/admin"); cy.get("h1").should("be.visible").and("include.text", "home.title"); cy.checkToastMessage("app.flash.unauthorized"); - - cy.checkFinalState(); }); it("check admin index with all permissions", function () { @@ -97,7 +94,6 @@ describe("Admin index", function () { .and("have.attr", "href", "/admin") .and("include.text", "app.streaming") .and("include.text", "admin.streaming.tile_description"); - cy.checkFinalState(); }); it("open admin settings", function () { @@ -141,7 +137,6 @@ describe("Admin index", function () { cy.get('[data-test="admin-settings-link"]').click(); cy.url().should("include", "/admin/settings"); - cy.checkFinalState(); }); it("open admin users", function () { @@ -192,7 +187,6 @@ describe("Admin index", function () { cy.get('[data-test="admin-users-link"]').click(); cy.url().should("include", "/admin/users"); - cy.checkFinalState(); }); it("open admin roles", function () { @@ -235,7 +229,6 @@ describe("Admin index", function () { cy.get('[data-test="admin-roles-link"]').click(); cy.url().should("include", "/admin/roles"); - cy.checkFinalState(); }); it("open admin room types", function () { @@ -274,7 +267,6 @@ describe("Admin index", function () { cy.get('[data-test="admin-room-types-link"]').click(); cy.url().should("include", "/admin/room_types"); - cy.checkFinalState(); }); it("open admin servers", function () { @@ -317,7 +309,6 @@ describe("Admin index", function () { cy.get('[data-test="admin-servers-link"]').click(); cy.url().should("include", "/admin/servers"); - cy.checkFinalState(); }); it("open admin server pools", function () { @@ -360,7 +351,6 @@ describe("Admin index", function () { cy.get('[data-test="admin-server-pools-link"]').click(); cy.url().should("include", "/admin/server_pools"); - cy.checkFinalState(); }); it("open admin streaming", function () { @@ -414,6 +404,5 @@ describe("Admin index", function () { cy.get('[data-test="admin-streaming-link"]').click(); cy.url().should("include", "/admin/streaming_settings"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesEdit.cy.js b/tests/Frontend/e2e/AdminRolesEdit.cy.js index 761ca4103..ff32eb556 100644 --- a/tests/Frontend/e2e/AdminRolesEdit.cy.js +++ b/tests/Frontend/e2e/AdminRolesEdit.cy.js @@ -23,7 +23,6 @@ describe("Admin roles edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles/2/edit"); - cy.checkFinalState(); }); it("visit with user without permission to edit roles", function () { @@ -46,7 +45,6 @@ describe("Admin roles edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/roles/2/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("edit role", function () { @@ -524,7 +522,6 @@ describe("Admin roles edit", function () { "include.text", 'admin.breadcrumbs.roles.view_{"name":"Standard role"}', ); - cy.checkFinalState(); }); it("edit role with different room limits", function () { @@ -745,7 +742,6 @@ describe("Admin roles edit", function () { // Check that role page is shown cy.url().should("include", "/admin/roles/2"); cy.url().should("not.include", "/edit"); - cy.checkFinalState(); }); it("check permission list with different permission dependencies", function () { @@ -997,7 +993,6 @@ describe("Admin roles edit", function () { cy.checkPermissionGroup(4, "serverPools.delete", true, true, false); }); }); - cy.checkFinalState(); }); it("check permission list with restricted permissions", function () { @@ -1393,7 +1388,6 @@ describe("Admin roles edit", function () { ); }); }); - cy.checkFinalState(); }); it("edit role errors", function () { @@ -1684,7 +1678,6 @@ describe("Admin roles edit", function () { cy.url().should("include", "/login?redirect=/admin/roles/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load permissions errors", function () { @@ -1765,7 +1758,6 @@ describe("Admin roles edit", function () { cy.url().should("include", "/login?redirect=/admin/roles/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load role errors", function () { @@ -1851,7 +1843,6 @@ describe("Admin roles edit", function () { cy.url().should("include", "/login?redirect=/admin/roles/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -1884,7 +1875,6 @@ describe("Admin roles edit", function () { .should("be.visible") .and("not.be.disabled") .and("include.text", "app.save"); - cy.checkFinalState(); }); it("check view for user that is superuser", function () { @@ -2048,7 +2038,6 @@ describe("Admin roles edit", function () { cy.checkPermissionGroup(30, "serverPools.update", true, true, true); cy.checkPermissionGroup(31, "serverPools.create", true, true, true); cy.checkPermissionGroup(32, "serverPools.delete", true, true, true); - cy.checkFinalState(); }); it("check view for user that is no superuser", function () { @@ -2213,6 +2202,5 @@ describe("Admin roles edit", function () { cy.checkPermissionGroup(30, "serverPools.update", true, true, true); cy.checkPermissionGroup(31, "serverPools.create", true, true, true); cy.checkPermissionGroup(32, "serverPools.delete", true, true, true); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesIndex.cy.js b/tests/Frontend/e2e/AdminRolesIndex.cy.js index 1a89bfd3a..d392055e9 100644 --- a/tests/Frontend/e2e/AdminRolesIndex.cy.js +++ b/tests/Frontend/e2e/AdminRolesIndex.cy.js @@ -16,7 +16,6 @@ describe("Admin roles index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles"); - cy.checkFinalState(); }); it("visit with user without permission to view roles", function () { @@ -36,7 +35,6 @@ describe("Admin roles index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/roles"); cy.get("h1").should("be.visible").and("contain", "home.title"); - cy.checkFinalState(); }); it("load roles", function () { @@ -119,7 +117,6 @@ describe("Admin roles index", function () { .should("include.text", "Students") .and("not.include.text", "admin.roles.superuser"); }); - cy.checkFinalState(); }); it("load roles errors", function () { @@ -269,7 +266,6 @@ describe("Admin roles index", function () { cy.url().should("include", "/login?redirect=/admin/roles"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load roles page out of bounds", function () { @@ -350,7 +346,6 @@ describe("Admin roles index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("role search", function () { @@ -530,7 +525,6 @@ describe("Admin roles index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("sort roles", function () { @@ -693,7 +687,6 @@ describe("Admin roles index", function () { .eq(0) .should("include.text", "Superuser") .and("include.text", "admin.roles.superuser"); - cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -746,7 +739,6 @@ describe("Admin roles index", function () { cy.get('[data-test="roles-edit-button"]').should("not.exist"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -806,7 +798,6 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -869,7 +860,6 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -933,7 +923,6 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("be.visible"); }); - cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -998,7 +987,6 @@ describe("Admin roles index", function () { .and("have.attr", "href", "/admin/roles/3/edit"); cy.get('[data-test="roles-delete-button"]').should("be.visible"); }); - cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js b/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js index f4b392319..c149da653 100644 --- a/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js +++ b/tests/Frontend/e2e/AdminRolesIndexRoleActions.cy.js @@ -105,7 +105,6 @@ describe("Admin roles index role actions", function () { .should("have.text", "app.no") .click(); cy.get('[data-test="roles-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete role errors", function () { @@ -223,7 +222,6 @@ describe("Admin roles index role actions", function () { cy.url().should("include", "/login?redirect=/admin/roles"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("open add new role page", function () { @@ -234,7 +232,6 @@ describe("Admin roles index role actions", function () { cy.get('[data-test="roles-add-button"]').click(); cy.url().should("include", "/admin/roles/new"); - cy.checkFinalState(); }); it("open edit role page", function () { @@ -248,7 +245,6 @@ describe("Admin roles index role actions", function () { .find('[data-test="roles-edit-button"]') .click(); cy.url().should("include", "/admin/roles/2/edit"); - cy.checkFinalState(); }); it("open view role page", function () { @@ -262,6 +258,5 @@ describe("Admin roles index role actions", function () { .find('[data-test="roles-view-button"]') .click(); cy.url().should("include", "/admin/roles/2"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesNew.cy.js b/tests/Frontend/e2e/AdminRolesNew.cy.js index 4769aa063..2aa4141aa 100644 --- a/tests/Frontend/e2e/AdminRolesNew.cy.js +++ b/tests/Frontend/e2e/AdminRolesNew.cy.js @@ -23,7 +23,6 @@ describe("Admin roles new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles/new"); - cy.checkFinalState(); }); it("visit with user without permission to add new roles", function () { @@ -45,8 +44,6 @@ describe("Admin roles new", function () { cy.url().should("not.include", "/admin/room_types"); cy.get("h1").should("be.visible").and("include.text", "home.title"); cy.checkToastMessage("app.flash.unauthorized"); - - cy.checkFinalState(); }); it("add new role", function () { @@ -492,7 +489,6 @@ describe("Admin roles new", function () { "include.text", 'admin.breadcrumbs.roles.view_{"name":"Standard role"}', ); - cy.checkFinalState(); }); it("add new role with different room limits", function () { @@ -694,7 +690,6 @@ describe("Admin roles new", function () { // Check that role page is shown cy.url().should("include", "/admin/roles/40"); - cy.checkFinalState(); }); it("check permission list with different permission dependencies", function () { @@ -937,7 +932,6 @@ describe("Admin roles new", function () { cy.checkPermissionGroup(4, "serverPools.delete", true, true, false); }); }); - cy.checkFinalState(); }); it("check permission list with restricted permissions", function () { @@ -1324,7 +1318,6 @@ describe("Admin roles new", function () { ); }); }); - cy.checkFinalState(); }); it("add roles errors", function () { @@ -1403,7 +1396,6 @@ describe("Admin roles new", function () { cy.url().should("include", "/login?redirect=/admin/roles/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load permissions errors", function () { @@ -1480,6 +1472,5 @@ describe("Admin roles new", function () { cy.url().should("include", "/login?redirect=/admin/roles/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesView.cy.js b/tests/Frontend/e2e/AdminRolesView.cy.js index caebb8f86..7b1a9a048 100644 --- a/tests/Frontend/e2e/AdminRolesView.cy.js +++ b/tests/Frontend/e2e/AdminRolesView.cy.js @@ -20,7 +20,6 @@ describe("Admin roles view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/roles/2"); - cy.checkFinalState(); }); it("visit with user without permission to view roles", function () { @@ -38,7 +37,6 @@ describe("Admin roles view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("check rolesView shown correctly", function () { @@ -280,7 +278,6 @@ describe("Admin roles view", function () { ); }); }); - cy.checkFinalState(); }); it("check rolesView with no permissions available", function () { @@ -338,7 +335,6 @@ describe("Admin roles view", function () { cy.get('[data-test="permission-list"]').should("not.exist"); cy.contains("admin.roles.no_options").should("be.visible"); - cy.checkFinalState(); }); it("check rolesView with different permission dependencies", function () { @@ -511,7 +507,6 @@ describe("Admin roles view", function () { ); }); }); - cy.checkFinalState(); }); it("check rolesView with different room limit settings", function () { @@ -637,7 +632,6 @@ describe("Admin roles view", function () { .and("have.value", "2") .and("be.disabled"); }); - cy.checkFinalState(); }); it("load role errors", function () { @@ -723,7 +717,6 @@ describe("Admin roles view", function () { cy.url().should("include", "/login?redirect=/admin/roles/2"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load permissions errors", function () { @@ -799,7 +792,6 @@ describe("Admin roles view", function () { cy.url().should("include", "/login?redirect=/admin/roles/2"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -827,7 +819,6 @@ describe("Admin roles view", function () { .and("have.attr", "href", "/admin/roles/2/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); cy.get('[data-test="roles-save-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -859,7 +850,6 @@ describe("Admin roles view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="roles-save-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility for user that is superuser", function () { @@ -914,7 +904,6 @@ describe("Admin roles view", function () { .and("include.text", "app.edit") .and("have.attr", "href", "/admin/roles/2/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -971,6 +960,5 @@ describe("Admin roles view", function () { .and("include.text", "app.edit") .and("have.attr", "href", "/admin/roles/2/edit"); cy.get('[data-test="roles-delete-button"]').should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js b/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js index 79e3a5a73..c5e81c696 100644 --- a/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js +++ b/tests/Frontend/e2e/AdminRolesViewRoleActions.cy.js @@ -85,7 +85,6 @@ describe("Admin roles view role actions", function () { // Check that dialog was closed cy.get('[data-test="roles-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete role errors", function () { @@ -182,7 +181,6 @@ describe("Admin roles view role actions", function () { cy.url().should("include", "/login?redirect=/admin/roles/2"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -423,6 +421,5 @@ describe("Admin roles view role actions", function () { cy.get('[data-test="roles-save-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js b/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js index 0e1f2a892..aae574158 100644 --- a/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesEdit.cy.js @@ -24,7 +24,6 @@ describe("Admin room types edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types/3/edit"); - cy.checkFinalState(); }); it("visit with user without permission to edit room types", function () { @@ -43,7 +42,6 @@ describe("Admin room types edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("edit room type", function () { @@ -871,7 +869,6 @@ describe("Admin room types edit", function () { "include.text", 'admin.breadcrumbs.room_types.view_{"name":"Exam 01"}', ); - cy.checkFinalState(); }); it("edit room type with restrictions", function () { @@ -1184,7 +1181,6 @@ describe("Admin room types edit", function () { // Check that room type view page is shown cy.url().should("include", "/admin/room_types/3"); cy.url().should("not.include", "/edit"); - cy.checkFinalState(); }); it("edit room type errors", function () { @@ -2124,7 +2120,6 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load room type errors", function () { @@ -2205,7 +2200,6 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -2239,7 +2233,6 @@ describe("Admin room types edit", function () { .should("be.visible") .and("not.be.disabled") .and("include.text", "app.save"); - cy.checkFinalState(); }); it("load roles errors", function () { @@ -2447,7 +2440,6 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load server pools errors", function () { @@ -2614,6 +2606,5 @@ describe("Admin room types edit", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js b/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js index 07917f27b..85c27bd08 100644 --- a/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesIndex.cy.js @@ -16,7 +16,6 @@ describe("Admin room types index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types"); - cy.checkFinalState(); }); it("load room types", function () { @@ -86,7 +85,6 @@ describe("Admin room types index", function () { .eq(0) .should("have.text", "Lecture"); }); - cy.checkFinalState(); }); it("load room types errors", function () { @@ -153,7 +151,6 @@ describe("Admin room types index", function () { cy.url().should("include", "/login?redirect=/admin/room_types"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load room types with no data", function () { @@ -166,7 +163,6 @@ describe("Admin room types index", function () { }); cy.visit("/admin/room_types"); - cy.checkFinalState(); }); it("room type search and sorting", function () { @@ -290,7 +286,6 @@ describe("Admin room types index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -329,7 +324,6 @@ describe("Admin room types index", function () { cy.get('[data-test="room-types-edit-button"]').should("not.exist"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -378,7 +372,6 @@ describe("Admin room types index", function () { .and("have.attr", "href", "/admin/room_types/1/edit"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -430,7 +423,6 @@ describe("Admin room types index", function () { .and("have.attr", "href", "/admin/room_types/1/edit"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -483,7 +475,6 @@ describe("Admin room types index", function () { .and("have.attr", "href", "/admin/room_types/1/edit"); cy.get('[data-test="room-types-delete-button"]').should("be.visible"); }); - cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js b/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js index 362ba6340..332e4e44a 100644 --- a/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesIndexRoomTypeActions.cy.js @@ -142,7 +142,6 @@ describe("Admin room types index room type actions", function () { "include.text", 'admin.room_types.delete.confirm_{"name":"Meeting"}', ); - cy.checkFinalState(); }); it("delete room type with replacement", function () { @@ -253,7 +252,6 @@ describe("Admin room types index room type actions", function () { // Check that dialog is closed cy.get('[data-test="room-types-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete room type errors", function () { @@ -397,7 +395,6 @@ describe("Admin room types index room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load replacement room types errors", function () { @@ -495,7 +492,6 @@ describe("Admin room types index room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("open add new room type page", function () { @@ -508,7 +504,6 @@ describe("Admin room types index room type actions", function () { cy.get('[data-test="room-types-add-button"]').click(); cy.url().should("include", "/admin/room_types/new"); - cy.checkFinalState(); }); it("open edit room type page", function () { @@ -524,7 +519,6 @@ describe("Admin room types index room type actions", function () { .click(); cy.url().should("include", "/admin/room_types/3/edit"); - cy.checkFinalState(); }); it("open view room type page", function () { @@ -541,6 +535,5 @@ describe("Admin room types index room type actions", function () { cy.url().should("include", "/admin/room_types/3"); cy.url().should("not.include", "/edit"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesNew.cy.js b/tests/Frontend/e2e/AdminRoomTypesNew.cy.js index b438a5a00..bdf352425 100644 --- a/tests/Frontend/e2e/AdminRoomTypesNew.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesNew.cy.js @@ -24,7 +24,6 @@ describe("Admin room types new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types/new"); - cy.checkFinalState(); }); it("visit with user without permission to add new room types", function () { @@ -48,8 +47,6 @@ describe("Admin room types new", function () { cy.url().should("not.include", "/admin/room_types"); cy.get("h1").should("be.visible").and("include.text", "home.title"); cy.checkToastMessage("app.flash.unauthorized"); - - cy.checkFinalState(); }); it("add new room type", function () { @@ -745,7 +742,6 @@ describe("Admin room types new", function () { "include.text", 'admin.breadcrumbs.room_types.view_{"name":"Exam 01"}', ); - cy.checkFinalState(); }); it("add new room type with restrictions", function () { @@ -1079,7 +1075,6 @@ describe("Admin room types new", function () { // Check that room type page is shown cy.url().should("include", "/admin/room_types/30"); - cy.checkFinalState(); }); it("add new room type errors", function () { @@ -1549,7 +1544,6 @@ describe("Admin room types new", function () { cy.url().should("include", "/login?redirect=/admin/room_types/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load roles errors", function () { @@ -1695,7 +1689,6 @@ describe("Admin room types new", function () { cy.url().should("include", "/login?redirect=/admin/room_types/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load server pools errors", function () { @@ -1852,6 +1845,5 @@ describe("Admin room types new", function () { cy.url().should("include", "/login?redirect=/admin/room_types/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesView.cy.js b/tests/Frontend/e2e/AdminRoomTypesView.cy.js index 94a4e7a45..fddec5bab 100644 --- a/tests/Frontend/e2e/AdminRoomTypesView.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesView.cy.js @@ -16,7 +16,6 @@ describe("Admin room types view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/room_types/3"); - cy.checkFinalState(); }); it("visit with user without permission to view room types", function () { @@ -35,7 +34,6 @@ describe("Admin room types view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("check roomTypeView shown correctly", function () { @@ -536,7 +534,6 @@ describe("Admin room types view", function () { ) .and("be.disabled"); }); - cy.checkFinalState(); }); it("check restrictions shown correctly", function () { @@ -588,7 +585,6 @@ describe("Admin room types view", function () { .should("not.exist"); }); }); - cy.checkFinalState(); }); it("open view errors", function () { @@ -670,7 +666,6 @@ describe("Admin room types view", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -699,7 +694,6 @@ describe("Admin room types view", function () { .and("have.attr", "href", "/admin/room_types/3/edit"); cy.get('[data-test="room-types-delete-button"]').should("not.exist"); cy.get('[data-test="room-types-save-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -733,6 +727,5 @@ describe("Admin room types view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="room-types-save-button"]').should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js b/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js index 6235ceca2..1a739b263 100644 --- a/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js +++ b/tests/Frontend/e2e/AdminRoomTypesViewRoomTypeActions.cy.js @@ -113,7 +113,6 @@ describe("Admin room types view room type actions", function () { // Check that redirect worked cy.url().should("not.include", "/admin/room_types/3"); cy.url().should("include", "/admin/room_types"); - cy.checkFinalState(); }); it("delete room type with replacement", function () { @@ -214,7 +213,6 @@ describe("Admin room types view room type actions", function () { // Check that redirect worked cy.url().should("not.include", "/admin/room_types/3"); cy.url().should("include", "/admin/room_types"); - cy.checkFinalState(); }); it("delete room type errors", function () { @@ -334,7 +332,6 @@ describe("Admin room types view room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load replacement room types errors", function () { @@ -424,7 +421,6 @@ describe("Admin room types view room type actions", function () { cy.url().should("include", "/login?redirect=/admin/room_types/3"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -998,6 +994,5 @@ describe("Admin room types view room type actions", function () { cy.get('[data-test="room-types-save-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js b/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js index 2e12e4fbc..4a0dcfa88 100644 --- a/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsEdit.cy.js @@ -24,7 +24,6 @@ describe("Admin server pools edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools/1"); - cy.checkFinalState(); }); it("visit with user without permission to edit server pools", function () { @@ -48,7 +47,6 @@ describe("Admin server pools edit", function () { cy.url().should("not.include", "/admin/server_pools/1/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); }); - cy.checkFinalState(); }); it("edit server pool", function () { @@ -387,7 +385,6 @@ describe("Admin server pools edit", function () { "include.text", 'admin.breadcrumbs.server_pools.view_{"name":"Server Pool 1"}', ); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -660,7 +657,6 @@ describe("Admin server pools edit", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -695,7 +691,6 @@ describe("Admin server pools edit", function () { .should("be.visible") .and("not.be.disabled") .and("include.text", "app.save"); - cy.checkFinalState(); }); it("load server pool errors", function () { @@ -776,7 +771,6 @@ describe("Admin server pools edit", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load servers errors", function () { @@ -926,6 +920,5 @@ describe("Admin server pools edit", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js b/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js index 8ead7e82c..e365e1568 100644 --- a/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsIndex.cy.js @@ -16,7 +16,6 @@ describe("Admin server pools index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools"); - cy.checkFinalState(); }); it("visit with user without permission to view server pools", function () { @@ -34,7 +33,6 @@ describe("Admin server pools index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/servers"); cy.get("h1").should("be.visible").and("contain", "home.title"); - cy.checkFinalState(); }); it("load server pools", function () { @@ -117,7 +115,6 @@ describe("Admin server pools index", function () { .eq(1) .should("have.text", "1"); }); - cy.checkFinalState(); }); it("load server pools errors", function () { @@ -271,7 +268,6 @@ describe("Admin server pools index", function () { cy.url().should("include", "/login?redirect=/admin/server_pools"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load server pools page out of bounds", function () { @@ -335,7 +331,6 @@ describe("Admin server pools index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("server pools search", function () { @@ -511,7 +506,6 @@ describe("Admin server pools index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("sort server pools", function () { @@ -764,7 +758,6 @@ describe("Admin server pools index", function () { .eq(0) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); - cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -806,7 +799,6 @@ describe("Admin server pools index", function () { cy.get('[data-test="server-pools-edit-button"]').should("not.exist"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -854,7 +846,6 @@ describe("Admin server pools index", function () { .and("have.attr", "href", "/admin/server_pools/2/edit"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -905,7 +896,6 @@ describe("Admin server pools index", function () { .and("have.attr", "href", "/admin/server_pools/2/edit"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -957,7 +947,6 @@ describe("Admin server pools index", function () { .and("have.attr", "href", "/admin/server_pools/2/edit"); cy.get('[data-test="server-pools-delete-button"]').should("be.visible"); }); - cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js b/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js index 042d0bb12..64701b0e0 100644 --- a/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsIndexServerPoolActions.cy.js @@ -109,7 +109,6 @@ describe("Admin server pools index server pool actions", function () { // Cancel delete of server pool cy.get('[data-test="dialog-cancel-button"]').click(); cy.get('[data-test="server-pools-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete server pool errors", function () { @@ -264,7 +263,6 @@ describe("Admin server pools index server pool actions", function () { cy.url().should("include", "/login?redirect=/admin/server_pools"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("open add new server pool page", function () { @@ -277,7 +275,6 @@ describe("Admin server pools index server pool actions", function () { cy.get('[data-test="server-pools-add-button"]').click(); cy.url().should("include", "/admin/server_pools/new"); - cy.checkFinalState(); }); it("open edit server pool page", function () { @@ -293,7 +290,6 @@ describe("Admin server pools index server pool actions", function () { .click(); cy.url().should("include", "/admin/server_pools/1/edit"); - cy.checkFinalState(); }); it("open view server pool page", function () { @@ -310,6 +306,5 @@ describe("Admin server pools index server pool actions", function () { cy.url().should("include", "/admin/server_pools/1"); cy.url().should("not.include", "/edit"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsNew.cy.js b/tests/Frontend/e2e/AdminServerPoolsNew.cy.js index dbdc32440..7e50d0d0a 100644 --- a/tests/Frontend/e2e/AdminServerPoolsNew.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsNew.cy.js @@ -24,7 +24,6 @@ describe("Admin server pools new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools/new"); - cy.checkFinalState(); }); it("visit with user without permission to add new server pools", function () { @@ -49,7 +48,6 @@ describe("Admin server pools new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("add new server pool with 1 server", function () { @@ -226,7 +224,6 @@ describe("Admin server pools new", function () { // Check that server pool page is shown cy.url().should("include", "/admin/server_pools/20"); - cy.checkFinalState(); }); it("add new server pool with several servers", function () { @@ -440,7 +437,6 @@ describe("Admin server pools new", function () { // Check that user page is shown cy.url().should("include", "/admin/server_pools/20"); - cy.checkFinalState(); }); it("add new server pool errors", function () { @@ -538,7 +534,6 @@ describe("Admin server pools new", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load servers errors", function () { @@ -685,6 +680,5 @@ describe("Admin server pools new", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsView.cy.js b/tests/Frontend/e2e/AdminServerPoolsView.cy.js index 8ac9c61fe..f76b8e049 100644 --- a/tests/Frontend/e2e/AdminServerPoolsView.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsView.cy.js @@ -20,7 +20,6 @@ describe("Admin server pools view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/server_pools/1"); - cy.checkFinalState(); }); it("visit with user without permission to view server pools", function () { @@ -39,7 +38,6 @@ describe("Admin server pools view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/servers/1"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("check serverPoolView shown correctly", function () { @@ -123,7 +121,6 @@ describe("Admin server pools view", function () { .should("not.exist"); }); }); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -153,7 +150,6 @@ describe("Admin server pools view", function () { .and("have.attr", "href", "/admin/server_pools/1/edit"); cy.get('[data-test="server-pools-delete-button"]').should("not.exist"); cy.get('[data-test="server-pools-save-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -187,7 +183,6 @@ describe("Admin server pools view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="server-pools-save-button"]').should("not.exist"); - cy.checkFinalState(); }); it("open view errors", function () { @@ -268,6 +263,5 @@ describe("Admin server pools view", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js b/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js index 6f5d1523a..e1820beaa 100644 --- a/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js +++ b/tests/Frontend/e2e/AdminServerPoolsViewServerPoolActions.cy.js @@ -82,7 +82,6 @@ describe("Admin server pools view", function () { // Check that redirect worked cy.url().should("not.include", "/admin/server_pools/1"); cy.url().should("include", "/admin/server_pools"); - cy.checkFinalState(); }); it("delete server pool errors", function () { @@ -206,7 +205,6 @@ describe("Admin server pools view", function () { cy.url().should("include", "/login?redirect=/admin/server_pools/1"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -344,6 +342,5 @@ describe("Admin server pools view", function () { cy.get('[data-test="server-pools-save-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersEdit.cy.js b/tests/Frontend/e2e/AdminServersEdit.cy.js index 524936397..c0c40f653 100644 --- a/tests/Frontend/e2e/AdminServersEdit.cy.js +++ b/tests/Frontend/e2e/AdminServersEdit.cy.js @@ -23,7 +23,6 @@ describe("Admin servers edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers/1/edit"); - cy.checkFinalState(); }); it("visit with user without permission to edit servers", function () { @@ -47,7 +46,6 @@ describe("Admin servers edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/users/2/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("edit server", function () { @@ -347,7 +345,6 @@ describe("Admin servers edit", function () { // Check that delete button is now hidden because server is enabled and // therefore cannot be deleted cy.get('[data-test="servers-delete-button"]').should("not.exist"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -681,7 +678,6 @@ describe("Admin servers edit", function () { cy.url().should("include", "/login?redirect=/admin/servers/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check button visibility without delete permission", function () { @@ -786,7 +782,6 @@ describe("Admin servers edit", function () { .and("not.be.disabled"); cy.get('[data-test="servers-panic-button"]').should("not.exist"); - cy.checkFinalState(); }); it("load server errors", function () { @@ -866,6 +861,5 @@ describe("Admin servers edit", function () { cy.url().should("include", "/login?redirect=/admin/servers/1/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersIndex.cy.js b/tests/Frontend/e2e/AdminServersIndex.cy.js index d310836d2..63ab49733 100644 --- a/tests/Frontend/e2e/AdminServersIndex.cy.js +++ b/tests/Frontend/e2e/AdminServersIndex.cy.js @@ -16,7 +16,6 @@ describe("Admin servers index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers"); - cy.checkFinalState(); }); it("visit with user without permission to view servers", function () { @@ -37,7 +36,6 @@ describe("Admin servers index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/servers"); cy.get("h1").should("be.visible").and("contain", "home.title"); - cy.checkFinalState(); }); it("load servers", function () { @@ -274,7 +272,6 @@ describe("Admin servers index", function () { .eq(6) .should("have.text", " --- "); }); - cy.checkFinalState(); }); it("load servers errors", function () { @@ -447,7 +444,6 @@ describe("Admin servers index", function () { cy.url().should("include", "/login?redirect=/admin/servers"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load servers page out of bounds", function () { @@ -526,7 +522,6 @@ describe("Admin servers index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("server search", function () { @@ -715,7 +710,6 @@ describe("Admin servers index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("sort servers", function () { @@ -1054,7 +1048,6 @@ describe("Admin servers index", function () { .eq(6) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); - cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -1116,7 +1109,6 @@ describe("Admin servers index", function () { cy.get('[data-test="servers-edit-button" ]').should("not.exist"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -1196,7 +1188,6 @@ describe("Admin servers index", function () { .and("have.attr", "href", "/admin/servers/4/edit"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -1279,7 +1270,6 @@ describe("Admin servers index", function () { .and("have.attr", "href", "/admin/servers/4/edit"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -1362,6 +1352,5 @@ describe("Admin servers index", function () { .and("have.attr", "href", "/admin/servers/4/edit"); cy.get('[data-test="servers-delete-button"]').should("not.exist"); }); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js b/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js index f738f8c40..fbc91ed41 100644 --- a/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js +++ b/tests/Frontend/e2e/AdminServersIndexServerActions.cy.js @@ -113,7 +113,6 @@ describe("Admin servers index server actions", function () { // Cancel delete of server cy.get('[data-test="dialog-cancel-button"]').click(); cy.get('[data-test="servers-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete server errors", function () { @@ -212,7 +211,6 @@ describe("Admin servers index server actions", function () { cy.url().should("include", "/login?redirect=/admin/servers"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("reload servers", function () { @@ -436,7 +434,6 @@ describe("Admin servers index server actions", function () { cy.get('[data-test="paginator-page"]') .eq(1) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("open add new server page", function () { @@ -447,7 +444,6 @@ describe("Admin servers index server actions", function () { cy.get('[data-test="servers-add-button"]').click(); cy.url().should("include", "/admin/servers/new"); - cy.checkFinalState(); }); it("open edit server page", function () { @@ -463,7 +459,6 @@ describe("Admin servers index server actions", function () { .click(); cy.url().should("include", "/admin/servers/1/edit"); - cy.checkFinalState(); }); it("open view server page", function () { @@ -480,6 +475,5 @@ describe("Admin servers index server actions", function () { cy.url().should("include", "/admin/servers/1"); cy.url().should("not.include", "/edit"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersNew.cy.js b/tests/Frontend/e2e/AdminServersNew.cy.js index 13ee16dbc..3d8bdc4ac 100644 --- a/tests/Frontend/e2e/AdminServersNew.cy.js +++ b/tests/Frontend/e2e/AdminServersNew.cy.js @@ -23,7 +23,6 @@ describe("Admin servers view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers/new"); - cy.checkFinalState(); }); it("visit with user without permission to add new servers", function () { @@ -48,7 +47,6 @@ describe("Admin servers view", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("add new server", function () { @@ -292,7 +290,6 @@ describe("Admin servers view", function () { "include.text", 'admin.breadcrumbs.servers.view_{"name":"Server 01"}', ); - cy.checkFinalState(); }); it("add new server errors", function () { @@ -453,6 +450,5 @@ describe("Admin servers view", function () { cy.url().should("include", "/login?redirect=/admin/servers/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersView.cy.js b/tests/Frontend/e2e/AdminServersView.cy.js index c1ff48d73..0d055c16f 100644 --- a/tests/Frontend/e2e/AdminServersView.cy.js +++ b/tests/Frontend/e2e/AdminServersView.cy.js @@ -20,7 +20,6 @@ describe("Admin servers view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/servers/1"); - cy.checkFinalState(); }); it("visit with user without permission to view servers", function () { @@ -39,7 +38,6 @@ describe("Admin servers view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/servers/1"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("check serverView shown correctly (server enabled)", function () { @@ -209,7 +207,6 @@ describe("Admin servers view", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check serverView shown correctly (server draining)", function () { @@ -268,7 +265,6 @@ describe("Admin servers view", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check serverView shown correctly (server disabled)", function () { @@ -331,7 +327,6 @@ describe("Admin servers view", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -432,7 +427,6 @@ describe("Admin servers view", function () { .and("not.be.disabled"); cy.get('[data-test="servers-panic-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -537,7 +531,6 @@ describe("Admin servers view", function () { .and("not.be.disabled"); cy.get('[data-test="servers-panic-button"]').should("not.exist"); - cy.checkFinalState(); }); it("open view errors", function () { @@ -617,6 +610,5 @@ describe("Admin servers view", function () { cy.url().should("include", "/login?redirect=/admin/servers/1"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminServersViewServerActions.cy.js b/tests/Frontend/e2e/AdminServersViewServerActions.cy.js index 055e0451f..9d3034331 100644 --- a/tests/Frontend/e2e/AdminServersViewServerActions.cy.js +++ b/tests/Frontend/e2e/AdminServersViewServerActions.cy.js @@ -94,7 +94,6 @@ describe("Admin servers view server actions", function () { // Check that dialog is closed cy.get('[data-test="servers-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete server errors", function () { @@ -181,7 +180,6 @@ describe("Admin servers view server actions", function () { cy.url().should("include", "/login?redirect=/admin/servers/1"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check connection", function () { @@ -296,7 +294,6 @@ describe("Admin servers view server actions", function () { "not.include.text", "admin.servers.offline_reason", ); - cy.checkFinalState(); }); it("check connection errors", function () { @@ -343,7 +340,6 @@ describe("Admin servers view server actions", function () { cy.url().should("include", "/login?redirect=/admin/servers/1"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("panic", function () { @@ -419,7 +415,6 @@ describe("Admin servers view server actions", function () { // Check that panic button is hidden (missing permissions) cy.get('[data-test="servers-panic-button"]').should("not.exist"); - cy.checkFinalState(); }); it("panic errors", function () { @@ -486,7 +481,6 @@ describe("Admin servers view server actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.server"}', 'app.flash.model_not_found.details_{"ids":"1"}', ]); - cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -659,6 +653,5 @@ describe("Admin servers view server actions", function () { cy.get('[data-test="servers-save-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminSettingsEdit.cy.js b/tests/Frontend/e2e/AdminSettingsEdit.cy.js index 5a9517a99..1b892e85a 100644 --- a/tests/Frontend/e2e/AdminSettingsEdit.cy.js +++ b/tests/Frontend/e2e/AdminSettingsEdit.cy.js @@ -359,7 +359,6 @@ describe("Admin settings with edit permission", function () { "Europe/Berlin", ); cy.get("#no-welcome-page").should("not.be.checked"); - cy.checkFinalState(); }); it("change theme settings that do not trigger reload", function () { @@ -707,7 +706,6 @@ describe("Admin settings with edit permission", function () { // Check that page was not reloaded (settingsReloadRequest was not called) cy.get("@settingsReloadRequest").should("be.null"); - cy.checkFinalState(); }); it("change theme favicon setting", function () { @@ -832,7 +830,6 @@ describe("Admin settings with edit permission", function () { .find('[data-test="settings-image-preview"]') .should("have.attr", "src") .and("include", "/images/favicon3.ico"); - cy.checkFinalState(); }); it("change theme favicon dark setting", function () { @@ -959,7 +956,6 @@ describe("Admin settings with edit permission", function () { .find('[data-test="settings-image-preview"]') .should("have.attr", "src") .and("include", "/images/favicon-dark3.ico"); - cy.checkFinalState(); }); it("change theme custom css setting", function () { @@ -1084,7 +1080,6 @@ describe("Admin settings with edit permission", function () { cy.get('[data-test="settings-file-view-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("change banner settings", function () { @@ -1767,7 +1762,6 @@ describe("Admin settings with edit permission", function () { .should("not.have.class", "selected"); } }); - cy.checkFinalState(); }); it("change room settings", function () { @@ -2268,7 +2262,6 @@ describe("Admin settings with edit permission", function () { ); cy.get("#room-file-terms-of-use").should("have.value", ""); cy.get("#room-hide-owner").should("not.be.checked"); - cy.checkFinalState(); }); it("change user settings", function () { @@ -2331,7 +2324,6 @@ describe("Admin settings with edit permission", function () { // Check that settings are shown correctly cy.get("#password-change-allowed").should("not.be.checked"); - cy.checkFinalState(); }); it("change recording and statistics settings", function () { @@ -2726,7 +2718,6 @@ describe("Admin settings with edit permission", function () { "have.text", "admin.settings.one_week", ); - cy.checkFinalState(); }); it("change bbb settings", function () { @@ -3110,7 +3101,6 @@ describe("Admin settings with edit permission", function () { // Check that config is loaded cy.wait("@configRequest"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -3629,6 +3619,5 @@ describe("Admin settings with edit permission", function () { cy.url().should("include", "/login?redirect=/admin/settings"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminSettingsGeneral.cy.js b/tests/Frontend/e2e/AdminSettingsGeneral.cy.js index f587fbf70..ad01d2e98 100644 --- a/tests/Frontend/e2e/AdminSettingsGeneral.cy.js +++ b/tests/Frontend/e2e/AdminSettingsGeneral.cy.js @@ -20,7 +20,6 @@ describe("Admin settings general", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/settings"); - cy.checkFinalState(); }); it("visit with user without permission to view settings", function () { @@ -39,7 +38,6 @@ describe("Admin settings general", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/room_types/3/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("check loading only view", function () { @@ -81,7 +79,6 @@ describe("Admin settings general", function () { cy.get('[data-test="admin-breadcrumb"]') .should("be.visible") .should("include.text", "admin.breadcrumbs.settings"); - cy.checkFinalState(); }); it("check loading with edit permission", function () { @@ -115,7 +112,6 @@ describe("Admin settings general", function () { cy.get('[data-test="admin-breadcrumb"]') .should("be.visible") .should("include.text", "admin.breadcrumbs.settings"); - cy.checkFinalState(); }); it("load settings errors", function () { @@ -159,7 +155,6 @@ describe("Admin settings general", function () { cy.url().should("include", "/login?redirect=/admin/settings"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load timezones error", function () { @@ -247,6 +242,5 @@ describe("Admin settings general", function () { cy.url().should("include", "/login?redirect=/admin/settings"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminSettingsView.cy.js b/tests/Frontend/e2e/AdminSettingsView.cy.js index b031eebd3..5949309da 100644 --- a/tests/Frontend/e2e/AdminSettingsView.cy.js +++ b/tests/Frontend/e2e/AdminSettingsView.cy.js @@ -166,7 +166,6 @@ describe("Admin settings with edit permission", function () { .and("be.disabled"); }); }); - cy.checkFinalState(); }); it("check theme settings with only view permission", function () { @@ -237,7 +236,6 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.checkSettingsFileSelectorOnlyView(""); }); - cy.checkFinalState(); }); it("check banner settings with only view permission", function () { @@ -513,7 +511,6 @@ describe("Admin settings with edit permission", function () { .should("have.value", "#ef4444") .and("be.disabled"); }); - cy.checkFinalState(); }); it("check room settings with only view permission", function () { @@ -715,7 +712,6 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.get("#room-hide-owner").should("be.checked").and("be.disabled"); }); - cy.checkFinalState(); }); it("check user settings with only view permission", function () { @@ -731,7 +727,6 @@ describe("Admin settings with edit permission", function () { .should("be.checked") .and("be.disabled"); }); - cy.checkFinalState(); }); it("check recording and statistics settings with only view permission", function () { @@ -837,7 +832,6 @@ describe("Admin settings with edit permission", function () { ); }); }); - cy.checkFinalState(); }); it("check bbb settings with only view permission", function () { @@ -917,6 +911,5 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.checkSettingsFileSelectorOnlyView("/files/testFile.txt"); }); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminStreamingEdit.cy.js b/tests/Frontend/e2e/AdminStreamingEdit.cy.js index db5febf1f..24c202665 100644 --- a/tests/Frontend/e2e/AdminStreamingEdit.cy.js +++ b/tests/Frontend/e2e/AdminStreamingEdit.cy.js @@ -221,7 +221,6 @@ describe("Admin settings with edit permission", function () { .within(() => { cy.checkSettingsFileSelector("", "streaming.css", true); }); - cy.checkFinalState(); }); it("edit settings saving error", function () { @@ -329,7 +328,6 @@ describe("Admin settings with edit permission", function () { "not.include.text", "The userdata-bbb_hide_notifications parameter is missing a value.", ); - cy.checkFinalState(); }); it("edit settings loading error", function () { @@ -391,7 +389,6 @@ describe("Admin settings with edit permission", function () { // Check save button is enabled cy.get('[data-test="save-button"]').should("not.be.disabled"); - cy.checkFinalState(); }); it("check settings with update permission", function () { @@ -476,7 +473,6 @@ describe("Admin settings with edit permission", function () { ) .and("not.be.disabled"); }); - cy.checkFinalState(); }); it("check room type settings table", function () { @@ -648,7 +644,6 @@ describe("Admin settings with edit permission", function () { .find(".fa-solid.fa-check") .should("exist"); }); - cy.checkFinalState(); }); it("edit room type settings", function () { @@ -899,7 +894,6 @@ describe("Admin settings with edit permission", function () { .find(".fa-solid.fa-times") .should("exist"); }); - cy.checkFinalState(); }); it("edit room type settings saving error", function () { @@ -986,7 +980,6 @@ describe("Admin settings with edit permission", function () { "not.include.text", "The Default pause image must have a resolution of 1920x1080 pixels.", ); - cy.checkFinalState(); }); it("edit room type settings loading error", function () { @@ -1055,6 +1048,5 @@ describe("Admin settings with edit permission", function () { // Check save button is enabled cy.get('[data-test="dialog-save-button"]').should("not.be.disabled"); }); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminStreamingView.cy.js b/tests/Frontend/e2e/AdminStreamingView.cy.js index a3844cb25..89bfad1c9 100644 --- a/tests/Frontend/e2e/AdminStreamingView.cy.js +++ b/tests/Frontend/e2e/AdminStreamingView.cy.js @@ -35,7 +35,6 @@ describe("Admin settings with edit permission", function () { // check 404 cy.url().should("include", "/404"); - cy.checkFinalState(); }); it("check settings with only view permission", function () { @@ -112,7 +111,6 @@ describe("Admin settings with edit permission", function () { ) .and("be.disabled"); }); - cy.checkFinalState(); }); it("check room type settings table", function () { @@ -284,6 +282,5 @@ describe("Admin settings with edit permission", function () { .find(".fa-solid.fa-check") .should("exist"); }); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEdit.cy.js b/tests/Frontend/e2e/AdminUsersEdit.cy.js index f9a2295d1..1f6c96cbb 100644 --- a/tests/Frontend/e2e/AdminUsersEdit.cy.js +++ b/tests/Frontend/e2e/AdminUsersEdit.cy.js @@ -32,7 +32,6 @@ describe("Admin users edit", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users/2/edit"); - cy.checkFinalState(); }); it("visit with user without permission to edit users", function () { @@ -57,7 +56,6 @@ describe("Admin users edit", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/users/2/edit"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("check visiting edit user page of a superuser", function () { @@ -128,7 +126,6 @@ describe("Admin users edit", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); - cy.checkFinalState(); }); it("visit edit user page", function () { @@ -193,7 +190,6 @@ describe("Admin users edit", function () { cy.get('[data-test="email-tab-button"]').should("be.visible"); cy.get('[data-test="security-tab-button"]').should("be.visible"); cy.get('[data-test="others-tab-button"]').should("be.visible"); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -232,7 +228,6 @@ describe("Admin users edit", function () { cy.get('[data-test="user-tab-profile-save-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); it("visit edit user page errors", function () { @@ -312,6 +307,5 @@ describe("Admin users edit", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditBase.cy.js b/tests/Frontend/e2e/AdminUsersEditBase.cy.js index 609af4226..81b236b1b 100644 --- a/tests/Frontend/e2e/AdminUsersEditBase.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditBase.cy.js @@ -571,7 +571,6 @@ describe("Admin users edit base", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -758,7 +757,6 @@ describe("Admin users edit base", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("view as external user", function () { @@ -817,7 +815,6 @@ describe("Admin users edit base", function () { "true", ); }); - cy.checkFinalState(); }); it("load timezones error", function () { @@ -907,6 +904,5 @@ describe("Admin users edit base", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditEmail.cy.js b/tests/Frontend/e2e/AdminUsersEditEmail.cy.js index 5eb5b0712..8fb745c8a 100644 --- a/tests/Frontend/e2e/AdminUsersEditEmail.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditEmail.cy.js @@ -117,7 +117,6 @@ describe("Admin users edit email", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -215,7 +214,6 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("view for external user", function () { @@ -244,6 +242,5 @@ describe("Admin users edit email", function () { .and("have.value", "LauraWRivera@domain.tld"); cy.get('[data-test="user-tab-email-save-button"]').should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditOthers.cy.js b/tests/Frontend/e2e/AdminUsersEditOthers.cy.js index 31b361411..1b7dbabcf 100644 --- a/tests/Frontend/e2e/AdminUsersEditOthers.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditOthers.cy.js @@ -107,7 +107,6 @@ describe("Admin users edit others", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -245,6 +244,5 @@ describe("Admin users edit others", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js b/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js index 57f7342b0..87a9a76fa 100644 --- a/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js +++ b/tests/Frontend/e2e/AdminUsersEditSecurity.cy.js @@ -82,7 +82,6 @@ describe("Admin users edit email", function () { // Check that essions are not shown cy.get('[data-test="session-panel"]').should("not.exist"); - cy.checkFinalState(); }); it("check view with external user", function () { @@ -123,7 +122,6 @@ describe("Admin users edit email", function () { // Check that sessions are not shown cy.get('[data-test="session-panel"]').should("not.exist"); - cy.checkFinalState(); }); it("change role", function () { @@ -424,7 +422,6 @@ describe("Admin users edit email", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); - cy.checkFinalState(); }); it("check that superuser role is disabled for users that are not superusers", function () { @@ -488,7 +485,6 @@ describe("Admin users edit email", function () { .eq(4) .should("include.text", "admin.roles.no_data") .and("not.be.visible"); - cy.checkFinalState(); }); it("change role errors", function () { @@ -631,7 +627,6 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("change password", function () { @@ -711,7 +706,6 @@ describe("Admin users edit email", function () { cy.url().should("not.include", "/edit"); cy.wait("@userRequest"); - cy.checkFinalState(); }); it("change password errors", function () { @@ -848,7 +842,6 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load roles errors", function () { @@ -988,6 +981,5 @@ describe("Admin users edit email", function () { cy.url().should("include", "/login?redirect=/admin/users/2/edit"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersIndex.cy.js b/tests/Frontend/e2e/AdminUsersIndex.cy.js index 7b2018ca1..462b679c6 100644 --- a/tests/Frontend/e2e/AdminUsersIndex.cy.js +++ b/tests/Frontend/e2e/AdminUsersIndex.cy.js @@ -29,7 +29,6 @@ describe("Admin users index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users"); - cy.checkFinalState(); }); it("visit with user without permission to view users", function () { @@ -49,7 +48,6 @@ describe("Admin users index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("contain", "home.title"); - cy.checkFinalState(); }); it("load users", function () { @@ -301,7 +299,6 @@ describe("Admin users index", function () { ); }); }); - cy.checkFinalState(); }); it("load users errors", function () { @@ -467,7 +464,6 @@ describe("Admin users index", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load users page out of bounds", function () { @@ -546,7 +542,6 @@ describe("Admin users index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("load roles errors", function () { @@ -730,7 +725,6 @@ describe("Admin users index", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("user search", function () { @@ -907,7 +901,6 @@ describe("Admin users index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("filter users", function () { @@ -1234,7 +1227,6 @@ describe("Admin users index", function () { .should("include.text", "admin.users.role_filter"); cy.get('[data-test="clear-roles-button"]').should("not.exist"); - cy.checkFinalState(); }); it("sort users", function () { @@ -1542,7 +1534,6 @@ describe("Admin users index", function () { .eq(5) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); - cy.checkFinalState(); }); it("check button visibility with view permission", function () { @@ -1609,7 +1600,6 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -1735,7 +1725,6 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with add permission", function () { @@ -1876,7 +1865,6 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -1956,7 +1944,6 @@ describe("Admin users index", function () { "be.visible", ); }); - cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -2033,7 +2020,6 @@ describe("Admin users index", function () { cy.get('[data-test="users-delete-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js b/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js index 17f57b8f8..ba1550364 100644 --- a/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js +++ b/tests/Frontend/e2e/AdminUsersIndexUserActions.cy.js @@ -116,7 +116,6 @@ describe("Admin users index user actions", function () { // Cancel delete cy.get('[data-test="dialog-cancel-button"]').click(); cy.get('[data-test="users-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete user errors", function () { @@ -215,7 +214,6 @@ describe("Admin users index user actions", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("reset password", function () { @@ -270,7 +268,6 @@ describe("Admin users index user actions", function () { // Check that dialog is closed cy.get('[data-test="users-reset-password-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("reset password errors", function () { @@ -319,7 +316,6 @@ describe("Admin users index user actions", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("open add new user page", function () { @@ -332,7 +328,6 @@ describe("Admin users index user actions", function () { cy.get('[data-test="users-add-button"]').click(); cy.url().should("include", "/admin/users/new"); - cy.checkFinalState(); }); it("open edit user page", function () { @@ -376,7 +371,6 @@ describe("Admin users index user actions", function () { .click(); cy.url().should("include", "/admin/users/1/edit"); - cy.checkFinalState(); }); it("open view user page", function () { @@ -426,6 +420,5 @@ describe("Admin users index user actions", function () { cy.url().should("include", "/admin/users/1"); cy.url().should("not.include", "/edit"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersNew.cy.js b/tests/Frontend/e2e/AdminUsersNew.cy.js index e76258e09..0473d7005 100644 --- a/tests/Frontend/e2e/AdminUsersNew.cy.js +++ b/tests/Frontend/e2e/AdminUsersNew.cy.js @@ -33,7 +33,6 @@ describe("Admin users new", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users/new"); - cy.checkFinalState(); }); it("visit with user without permission to add new users", function () { @@ -58,7 +57,6 @@ describe("Admin users new", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/users"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("visit with local auth disabled", function () { @@ -68,7 +66,6 @@ describe("Admin users new", function () { cy.url().should("not.include", "/admin/users/new"); cy.url().should("include", "/404"); - cy.checkFinalState(); }); it("add new user with custom password and 1 role", function () { @@ -383,7 +380,6 @@ describe("Admin users new", function () { "include.text", 'admin.breadcrumbs.users.view_{"firstname":"Max","lastname":"Doe"}', ); - cy.checkFinalState(); }); it("add new user with generated password and several roles", function () { @@ -629,7 +625,6 @@ describe("Admin users new", function () { // Check that user page is shown cy.url().should("include", "/admin/users/20"); - cy.checkFinalState(); }); it("add new user errors", function () { @@ -781,7 +776,6 @@ describe("Admin users new", function () { cy.url().should("include", "/login?redirect=/admin/users/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load timezones errors", function () { @@ -859,7 +853,6 @@ describe("Admin users new", function () { cy.url().should("include", "/login?redirect=/admin/users/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("check that superuser role is disabled for users that are not superusers", function () { @@ -919,7 +912,6 @@ describe("Admin users new", function () { .eq(4) .should("include.text", "admin.roles.no_data") .and("not.be.visible"); - cy.checkFinalState(); }); it("load roles errors", function () { @@ -1051,6 +1043,5 @@ describe("Admin users new", function () { cy.url().should("include", "/login?redirect=/admin/users/new"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersView.cy.js b/tests/Frontend/e2e/AdminUsersView.cy.js index 73466b295..0bb703321 100644 --- a/tests/Frontend/e2e/AdminUsersView.cy.js +++ b/tests/Frontend/e2e/AdminUsersView.cy.js @@ -31,7 +31,6 @@ describe("Admin users view", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/admin/users/"); - cy.checkFinalState(); }); it("visit with user without permission to view users", function () { @@ -55,7 +54,6 @@ describe("Admin users view", function () { // Check if welcome page is shown cy.url().should("not.include", "/admin/users/2"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("check userView shown correctly", function () { @@ -249,7 +247,6 @@ describe("Admin users view", function () { // Check that others save button is hidden cy.get('[data-test="user-tab-others-save-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check userView with ldap user", function () { @@ -315,7 +312,6 @@ describe("Admin users view", function () { cy.get('[data-test="others-tab-button"]').click(); cy.get("#bbb_skip_check_audio").should("not.be.checked").and("be.disabled"); - cy.checkFinalState(); }); it("check button visibility with update permission", function () { @@ -347,7 +343,6 @@ describe("Admin users view", function () { .should("be.visible") .and("not.be.disabled"); cy.get('[data-test="users-delete-button"]').should("not.exist"); - cy.checkFinalState(); }); it("check button visibility with delete permission", function () { @@ -383,7 +378,6 @@ describe("Admin users view", function () { cy.get('[data-test="users-delete-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); it("check button visibility for user that is superuser", function () { @@ -454,7 +448,6 @@ describe("Admin users view", function () { cy.get('[data-test="users-delete-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); it("check button visibility for user that is no superuser", function () { @@ -518,7 +511,6 @@ describe("Admin users view", function () { cy.get('[data-test="users-edit-button"]').should("not.exist"); cy.get('[data-test="users-reset-password-button"]').should("not.exist"); cy.get('[data-test="users-delete-button"]').should("not.exist"); - cy.checkFinalState(); }); it("open view errors", function () { @@ -599,7 +591,6 @@ describe("Admin users view", function () { cy.url().should("include", "/login?redirect=/admin/users/2"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load timezones error", function () { @@ -670,6 +661,5 @@ describe("Admin users view", function () { cy.url().should("include", "/login?redirect=/admin/users/2"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js b/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js index f772532bf..dbec5df87 100644 --- a/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js +++ b/tests/Frontend/e2e/AdminUsersViewUserActions.cy.js @@ -95,7 +95,6 @@ describe("Admin users view user actions", function () { // Check that dialog is closed cy.get('[data-test="users-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete user errors", function () { @@ -173,7 +172,6 @@ describe("Admin users view user actions", function () { cy.url().should("include", "/login?redirect=/admin/users/2"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("reset password", function () { @@ -225,7 +223,6 @@ describe("Admin users view user actions", function () { // Check that dialog is closed cy.get('[data-test="users-reset-password-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("reset password errors", function () { @@ -303,7 +300,6 @@ describe("Admin users view user actions", function () { cy.url().should("include", "/login?redirect=/admin/users"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("switch between edit and view", function () { @@ -695,6 +691,5 @@ describe("Admin users view user actions", function () { cy.get('[data-test="user-tab-others-save-button"]') .should("be.visible") .and("not.be.disabled"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Banner.cy.js b/tests/Frontend/e2e/Banner.cy.js index 2846b3120..4a1c3e282 100644 --- a/tests/Frontend/e2e/Banner.cy.js +++ b/tests/Frontend/e2e/Banner.cy.js @@ -81,7 +81,6 @@ describe("Banner", function () { cy.get('[data-test="banner-link-button"]').should("not.exist"); }); }); - cy.checkFinalState(); }); it("check banner link works correctly", function () { @@ -149,7 +148,6 @@ describe("Banner", function () { .and("have.attr", "data-p-severity", "danger") .and("not.have.class", "p-0 underline"); }); - cy.checkFinalState(); }); it("check banner hidden if disabled", function () { @@ -173,6 +171,5 @@ describe("Banner", function () { // Check that banner is shown correctly cy.get('[data-test="app-banner"]').should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Footer.cy.js b/tests/Frontend/e2e/Footer.cy.js index 6078c8e0c..0fbc8362f 100644 --- a/tests/Frontend/e2e/Footer.cy.js +++ b/tests/Frontend/e2e/Footer.cy.js @@ -57,7 +57,6 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.0.0"); }); - cy.checkFinalState(); }); it("check footer shown correctly with only legal notice link, no version and whitelabel", function () { @@ -95,7 +94,6 @@ describe("Footer", function () { cy.get('[data-test="github-button"]').should("not.exist"); cy.get('[data-test="version"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check footer shown correctly with only privacy policy link, no version and whitelabel", function () { @@ -132,7 +130,6 @@ describe("Footer", function () { cy.get('[data-test="github-button"]').should("not.exist"); cy.get('[data-test="version"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check footer shown correctly with no links, no version and no whitelabel", function () { @@ -165,7 +162,6 @@ describe("Footer", function () { .and("have.attr", "href", "https://github.com/THM-Health/PILOS"); cy.get('[data-test="version"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check footer shown correctly with no links, version and whitelabel", function () { @@ -197,7 +193,6 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.0.0"); }); - cy.checkFinalState(); }); it("check footer shown correctly with 2 links, version and whitelabel", function () { @@ -250,7 +245,6 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.0.0"); }); - cy.checkFinalState(); }); it("check footer shown correctly with 2 links, no version and whitelabel", function () { @@ -300,7 +294,6 @@ describe("Footer", function () { cy.get('[data-test="github-button"]').should("not.exist"); cy.get('[data-test="version"]').should("not.exist"); }); - cy.checkFinalState(); }); it("check footer hidden with no links, no version and whitelabel", function () { @@ -319,7 +312,6 @@ describe("Footer", function () { cy.wait("@configRequest"); cy.get('[data-test="app-footer"]').should("not.exist"); - cy.checkFinalState(); }); it("check footer shown correctly with only legal notice link, version and whitelabel", function () { @@ -359,7 +351,6 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 1.2.0"); }); - cy.checkFinalState(); }); it("check footer shown correctly with only privacy policy link, version and whitelabel", function () { @@ -398,7 +389,6 @@ describe("Footer", function () { .should("be.visible") .and("have.text", "app.version 2.1.0"); }); - cy.checkFinalState(); }); it("open legal notice link", function () { @@ -417,7 +407,6 @@ describe("Footer", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/legal?foo=a&bar=b`, ); - cy.checkFinalState(); }); it("open accessibility link", function () { @@ -436,7 +425,6 @@ describe("Footer", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/accessibility?foo=a&bar=b`, ); - cy.checkFinalState(); }); it("open privacy policy link", function () { @@ -455,6 +443,5 @@ describe("Footer", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/privacy?foo=a&bar=b`, ); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/ForgotPassword.cy.js b/tests/Frontend/e2e/ForgotPassword.cy.js index 3b1df271d..6720f8d97 100644 --- a/tests/Frontend/e2e/ForgotPassword.cy.js +++ b/tests/Frontend/e2e/ForgotPassword.cy.js @@ -27,7 +27,6 @@ describe("Forgot password", function () { cy.visit("/forgot_password"); cy.url().should("include", "/404").and("not.include", "/forgot_password"); - cy.checkFinalState(); }); it("check with password change forbidden", function () { @@ -44,7 +43,6 @@ describe("Forgot password", function () { cy.visit("/forgot_password"); cy.url().should("include", "/404").and("not.include", "/forgot_password"); - cy.checkFinalState(); }); it("visit with logged in user", function () { @@ -61,7 +59,6 @@ describe("Forgot password", function () { // Check that user is redirected to home page cy.url().should("not.include", "/forgot_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("forgot password", function () { @@ -129,7 +126,6 @@ describe("Forgot password", function () { // Check that user is redirected to home page cy.url().should("not.include", "/forgot_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("forgot password errors", function () { @@ -178,6 +174,5 @@ describe("Forgot password", function () { cy.get('[data-test="email-field"]') .should("be.visible") .and("not.include.text", "The email fiel is required."); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/GeneralApplication.cy.js b/tests/Frontend/e2e/GeneralApplication.cy.js index 52a0cfd55..8c4b7dd34 100644 --- a/tests/Frontend/e2e/GeneralApplication.cy.js +++ b/tests/Frontend/e2e/GeneralApplication.cy.js @@ -28,7 +28,6 @@ describe("General", function () { .should("exist") .should("have.text", "Français"); }); - cy.checkFinalState(); }); it("hide locale menu if only one locale is available", function () { @@ -40,7 +39,6 @@ describe("General", function () { // Check locale select is not shown cy.get('[data-test="navbar-locale"]').should("not.exist"); - cy.checkFinalState(); }); it("changing selected locale", function () { @@ -88,7 +86,6 @@ describe("General", function () { // Check that the menu is closed cy.get('[data-test="submenu"]').should("not.be.visible"); - cy.checkFinalState(); }); it("changing selected locale error", function () { @@ -156,7 +153,6 @@ describe("General", function () { 'app.flash.server_error.message_{"message":["Test"]}', 'app.flash.server_error.error_code_{"statusCode":500}', ]); - cy.checkFinalState(); }); it("PrimeVue uses locale with exact match", function () { @@ -198,7 +194,6 @@ describe("General", function () { cy.get('[data-test="paginator-page"]') .first() .should("have.attr", "aria-label", "Seite 1"); - cy.checkFinalState(); }); it("PrimeVue uses parent locale for invalid language-region codes (de-XX -> de)", function () { @@ -253,7 +248,6 @@ describe("General", function () { cy.get('[data-test="paginator-page"]') .first() .should("have.attr", "aria-label", "Seite 1"); - cy.checkFinalState(); }); it("PrimeVue uses local fallback (en) for unsupported PrimeLocale locales", function () { @@ -308,7 +302,6 @@ describe("General", function () { cy.get('[data-test="paginator-page"]') .last() .should("have.attr", "aria-label", "Page 1"); - cy.checkFinalState(); }); it("disabled welcome page redirect unauthenticated users to login", function () { @@ -330,7 +323,6 @@ describe("General", function () { cy.url().should("contain", "/login?redirect=/rooms"); cy.get('[data-test="login-tab-button-local"]').should("be.visible"); - cy.checkFinalState(); }); it("disabled welcome page redirect authenticated users to rooms overview", function () { @@ -348,7 +340,6 @@ describe("General", function () { // Should be redirected to rooms overview cy.url().should("contain", "/rooms"); - cy.checkFinalState(); }); it("welcome page shown", function () { @@ -357,7 +348,6 @@ describe("General", function () { // Check if the welcome page is shown cy.get("h1").should("be.visible").and("contain", "home.title"); - cy.checkFinalState(); }); it("check help button if help url specified", function () { @@ -385,7 +375,6 @@ describe("General", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/help?foo=a&bar=b`, ); - cy.checkFinalState(); }); it("check help button hidden if help url not specified", function () { @@ -397,7 +386,6 @@ describe("General", function () { cy.visit("/"); cy.get('[data-test="navbar-help"]').should("not.exist"); - cy.checkFinalState(); }); it("change to dark mode", function () { @@ -426,7 +414,6 @@ describe("General", function () { cy.get('[data-test="navbar-dark-mode"]') .find("svg") .should("have.attr", "data-test", "navbar-dark-mode-disabled-icon"); - cy.checkFinalState(); }); it("change to light mode", function () { @@ -459,6 +446,5 @@ describe("General", function () { cy.get('[data-test="navbar-dark-mode"]') .find("svg") .should("have.attr", "data-test", "navbar-dark-mode-enabled-icon"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Login.cy.js b/tests/Frontend/e2e/Login.cy.js index 86fdd7a93..a77b699d7 100644 --- a/tests/Frontend/e2e/Login.cy.js +++ b/tests/Frontend/e2e/Login.cy.js @@ -88,7 +88,6 @@ describe("Login", function () { cy.checkToastMessage("auth.flash.login"); // Check if redirect works cy.url().should("include", "/rooms").and("not.include", "/login"); - cy.checkFinalState(); }); it("hide ldap login if disabled", function () { @@ -109,7 +108,6 @@ describe("Login", function () { cy.get('[data-test="login-tab-button-local"]').should("exist"); cy.get('[data-test="login-tab-button-ldap"]').should("not.exist"); - cy.checkFinalState(); }); it("ldap login with redirect query set", function () { @@ -156,7 +154,6 @@ describe("Login", function () { // Check if redirect works cy.url().should("include", "/admin").and("not.include", "/login"); - cy.checkFinalState(); }); it("local login", function () { @@ -250,7 +247,6 @@ describe("Login", function () { cy.checkToastMessage("auth.flash.login"); // Check if redirect works cy.url().should("include", "/rooms").and("not.include", "/login"); - cy.checkFinalState(); }); it("open forgot password page", function () { @@ -282,7 +278,6 @@ describe("Login", function () { .click(); cy.url().should("include", "/forgot_password").and("not.include", "/login"); - cy.checkFinalState(); }); it("hide local login if disabled", function () { @@ -302,7 +297,6 @@ describe("Login", function () { cy.get('[data-test="login-tab-button-ldap"]').should("exist"); cy.get('[data-test="login-tab-button-local"]').should("not.exist"); - cy.checkFinalState(); }); it("local login with redirect query set", function () { @@ -348,7 +342,6 @@ describe("Login", function () { // Check if redirect works cy.url().should("include", "/admin").and("not.include", "/login"); - cy.checkFinalState(); }); it("local login errors", function () { @@ -472,7 +465,6 @@ describe("Login", function () { cy.checkToastMessage("app.flash.guests_only"); cy.url().should("not.include", "/login"); - cy.checkFinalState(); }); it("ldap login errors", function () { @@ -604,7 +596,6 @@ describe("Login", function () { cy.checkToastMessage("app.flash.guests_only"); cy.url().should("not.include", "/login"); - cy.checkFinalState(); }); it("visit login page with already logged in user", function () { @@ -624,7 +615,6 @@ describe("Login", function () { // Check with redirect query parameter cy.visit("/login?redirect=/admin"); cy.url().should("include", "/admin").and("not.include", "/login"); - cy.checkFinalState(); }); it("shibboleth login", function () { @@ -654,8 +644,6 @@ describe("Login", function () { cy.url().should("include", "/rooms").and("not.include", "/login"); cy.checkToastMessage("auth.flash.login"); - - cy.checkFinalState(); }); it("hide shibboleth login if disabled", function () { @@ -675,7 +663,6 @@ describe("Login", function () { cy.wait("@configRequest"); cy.get('[data-test="login-tab-button-local"]').should("exist"); cy.get('[data-test="login-tab-button-shibboleth"]').should("not.exist"); - cy.checkFinalState(); }); it("shibboleth login with redirect query set", function () { @@ -718,8 +705,6 @@ describe("Login", function () { // Check admin page is shown (loading is finished) and toast message is shown cy.contains("admin.title").should("be.visible"); cy.checkToastMessage("auth.flash.login"); - - cy.checkFinalState(); }); it("external login callback missing attributes error", function () { @@ -735,8 +720,6 @@ describe("Login", function () { .should("be.visible") .should("have.text", "auth.login") .should("have.attr", "href", "/login"); - - cy.checkFinalState(); }); it("external login callback duplicate session error", function () { @@ -754,8 +737,6 @@ describe("Login", function () { .should("be.visible") .should("have.text", "auth.login") .should("have.attr", "href", "/login"); - - cy.checkFinalState(); }); it("external login callback invalid request", function () { @@ -771,8 +752,6 @@ describe("Login", function () { .should("be.visible") .should("have.text", "auth.login") .should("have.attr", "href", "/login"); - - cy.checkFinalState(); }); it("external login callback openid connect network exception", function () { @@ -846,8 +825,6 @@ describe("Login", function () { cy.url().should("include", "/rooms").and("not.include", "/login"); cy.checkToastMessage("auth.flash.login"); - - cy.checkFinalState(); }); it("hide oidc login if disabled", function () { @@ -867,7 +844,6 @@ describe("Login", function () { cy.wait("@configRequest"); cy.get('[data-test="login-tab-button-local"]').should("exist"); cy.get('[data-test="login-tab-button-oidc"]').should("not.exist"); - cy.checkFinalState(); }); it("oidc login with redirect query set", function () { @@ -932,6 +908,5 @@ describe("Login", function () { // Check admin page is shown (loading is finished) and no toast message is shown cy.contains("admin.title").should("be.visible"); cy.get(".p-toast-message").should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/Logout.cy.js b/tests/Frontend/e2e/Logout.cy.js index a36dcb902..07dfe0bad 100644 --- a/tests/Frontend/e2e/Logout.cy.js +++ b/tests/Frontend/e2e/Logout.cy.js @@ -33,7 +33,6 @@ describe("Logout", function () { // Check redirect to home page cy.get('[data-test="home-button"]').should("have.text", "app.home").click(); cy.url().should("not.include", "/logout"); - cy.checkFinalState(); }); it("successful logout with redirect", function () { @@ -60,7 +59,6 @@ describe("Logout", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/idp?foo=a&bar=b`, ); - cy.checkFinalState(); }); it("failed logout", function () { @@ -91,6 +89,5 @@ describe("Logout", function () { .should("include", "/rooms") .and("not.include", "/logout") .and("not.include", "/login"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/MeetingsIndex.cy.js b/tests/Frontend/e2e/MeetingsIndex.cy.js index b2d228b2e..a7ff04203 100644 --- a/tests/Frontend/e2e/MeetingsIndex.cy.js +++ b/tests/Frontend/e2e/MeetingsIndex.cy.js @@ -16,7 +16,6 @@ describe("Meetings index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/meetings"); - cy.checkFinalState(); }); it("visit with user without permission to view meetings", function () { @@ -32,7 +31,6 @@ describe("Meetings index", function () { // Check if the welcome page is shown cy.url().should("not.include", "/admin/meetings"); cy.get("h1").should("be.visible").and("contain", "home.title"); - cy.checkFinalState(); }); it("load meetings", function () { @@ -271,7 +269,6 @@ describe("Meetings index", function () { .and("have.attr", "href", "/rooms/def-abc-456"); }); }); - cy.checkFinalState(); }); it("load meetings errors", function () { @@ -434,7 +431,6 @@ describe("Meetings index", function () { cy.url().should("include", "/login?redirect=/meetings"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load meetings page out of bounds", function () { @@ -514,7 +510,6 @@ describe("Meetings index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("meeting search", function () { @@ -699,7 +694,6 @@ describe("Meetings index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("sort meetings", function () { @@ -1011,7 +1005,6 @@ describe("Meetings index", function () { .eq(7) .should("have.attr", "data-p-sorted", "true") .and("have.attr", "aria-sort", "ascending"); - cy.checkFinalState(); }); it("reload meetings", function () { @@ -1101,7 +1094,6 @@ describe("Meetings index", function () { .eq(0) .should("include.text", "02/12/2021, 19:10") .and("include.text", "Meeting Two"); - cy.checkFinalState(); }); it("view room of meeting", function () { @@ -1123,7 +1115,6 @@ describe("Meetings index", function () { // Check that redirect worked cy.url().should("include", "/rooms/abc-def-123"); cy.url().should("not.include", "/meetings"); - cy.checkFinalState(); }); it("check loading state during reload", function () { diff --git a/tests/Frontend/e2e/PasswordReset.cy.js b/tests/Frontend/e2e/PasswordReset.cy.js index 43de7b4cc..8f1d11aec 100644 --- a/tests/Frontend/e2e/PasswordReset.cy.js +++ b/tests/Frontend/e2e/PasswordReset.cy.js @@ -27,7 +27,6 @@ describe("Password reset", function () { cy.visit("/reset_password"); cy.url().should("include", "/404").and("not.include", "/forgot_password"); - cy.checkFinalState(); }); it("visit with logged in user", function () { @@ -44,7 +43,6 @@ describe("Password reset", function () { // Check that user is redirected to home page cy.url().should("not.include", "/forgot_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("reset password of existing user", function () { @@ -130,7 +128,6 @@ describe("Password reset", function () { // Check that user is redirected to home page cy.url().should("not.include", "/reset_password"); cy.get("h1").should("be.visible").and("include.text", "home.title"); - cy.checkFinalState(); }); it("reset password view for new user", function () { @@ -144,7 +141,6 @@ describe("Password reset", function () { "have.text", "auth.set_password", ); - cy.checkFinalState(); }); it("reset password errors", function () { @@ -249,6 +245,5 @@ describe("Password reset", function () { // Check that error message is shown cy.checkToastMessage("app.flash.too_many_requests"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsIndex.cy.js b/tests/Frontend/e2e/RoomsIndex.cy.js index 414d2974f..38f049d7e 100644 --- a/tests/Frontend/e2e/RoomsIndex.cy.js +++ b/tests/Frontend/e2e/RoomsIndex.cy.js @@ -8,7 +8,6 @@ describe("Room Index", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/rooms"); - cy.checkFinalState(); }); it("check list of rooms and opening room view", function () { @@ -172,7 +171,6 @@ describe("Room Index", function () { }); cy.url().should("include", "/rooms/abc-def-123"); - cy.checkFinalState(); }); it("check list of rooms with rooms.filterAll permission", function () { @@ -269,7 +267,6 @@ describe("Room Index", function () { // Check if rooms are shown cy.get('[data-test="room-card"]').should("have.length", 3); - cy.checkFinalState(); }); it("click on room card to open room view", function () { @@ -298,7 +295,6 @@ describe("Room Index", function () { cy.wait("@roomRequest"); cy.get('[data-test="no-room-overlay"]').should("not.exist"); - cy.checkFinalState(); }); it("sorting", function () { @@ -451,7 +447,6 @@ describe("Room Index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("search", function () { @@ -629,7 +624,6 @@ describe("Room Index", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("filter room type", function () { @@ -863,7 +857,6 @@ describe("Room Index", function () { // Check all rooms are shown cy.get('[data-test="room-card"]').should("have.length", 3); - cy.checkFinalState(); }); it("filter without viewAll permission", function () { @@ -1050,7 +1043,6 @@ describe("Room Index", function () { cy.get('[data-test="rooms-filter-button"]') .eq(0) .should("have.attr", "aria-pressed", "false"); - cy.checkFinalState(); }); it("filter with viewAll permission", function () { @@ -1322,7 +1314,6 @@ describe("Room Index", function () { .eq(2) .should("have.text", "rooms.index.show_public") .and("have.attr", "aria-pressed", "true"); - cy.checkFinalState(); }); it("show favorites", function () { @@ -1516,7 +1507,6 @@ describe("Room Index", function () { cy.get('[data-test="room-card"]') .should("have.length", 1) .and("include.text", "Meeting One"); - cy.checkFinalState(); }); it("trigger favorites button", function () { @@ -1942,7 +1932,6 @@ describe("Room Index", function () { page: "1", }); }); - cy.checkFinalState(); }); it("trigger favorites button errors (room card)", function () { @@ -2144,8 +2133,6 @@ describe("Room Index", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("trigger favorites button errors (room info dialog)", function () { @@ -2397,8 +2384,6 @@ describe("Room Index", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("error loading rooms", function () { @@ -2624,7 +2609,6 @@ describe("Room Index", function () { cy.url().should("include", "/login"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("error loading room types", function () { @@ -2703,6 +2687,5 @@ describe("Room Index", function () { cy.url().should("include", "/login?redirect=/rooms"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js b/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js index 0758c4be9..dbd4c3e3c 100644 --- a/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js +++ b/tests/Frontend/e2e/RoomsIndexCreateNewRoom.cy.js @@ -23,7 +23,6 @@ describe("Rooms index create new room", function () { cy.get('[data-test="room-create-button"]').should("not.exist"); // Check that room limit tag does not exist cy.contains("rooms.room_limit").should("not.exist"); - cy.checkFinalState(); }); it("create new room", function () { @@ -369,7 +368,6 @@ describe("Rooms index create new room", function () { // Check if redirected to the created room cy.url().should("include", "/rooms/abc-def-123"); - cy.checkFinalState(); }); it("create new room with features enabled", function () { @@ -470,7 +468,6 @@ describe("Rooms index create new room", function () { ); }); }); - cy.checkFinalState(); }); it("create new room with features disabled", function () { @@ -542,7 +539,6 @@ describe("Rooms index create new room", function () { cy.get('[data-test="room-type-features"]').should("not.exist"); }); }); - cy.checkFinalState(); }); it("create new room with features disabled and show disabled features", function () { @@ -626,7 +622,6 @@ describe("Rooms index create new room", function () { ); }); }); - cy.checkFinalState(); }); it("create new room errors", function () { @@ -860,7 +855,6 @@ describe("Rooms index create new room", function () { cy.url().should("include", "/login?redirect=/rooms"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("create new room limit reached", function () { @@ -986,7 +980,6 @@ describe("Rooms index create new room", function () { // Check if room limit is updated and create button is disabled cy.get('[data-test="room-create-button"]').should("be.disabled"); cy.contains('rooms.room_limit_{"has":1,"max":1}').should("be.visible"); - cy.checkFinalState(); }); it("create new room limit reached when visiting", function () { @@ -1017,7 +1010,6 @@ describe("Rooms index create new room", function () { // Check if room limit is shown and create button is disabled cy.get('[data-test="room-create-button"]').should("be.disabled"); cy.contains('rooms.room_limit_{"has":1,"max":1}').should("be.visible"); - cy.checkFinalState(); }); it("cancel create new room", function () { @@ -1065,7 +1057,6 @@ describe("Rooms index create new room", function () { cy.get("#room-name").should("have.value", ""); cy.get('[data-test="room-type-details"]').should("not.exist"); }); - cy.checkFinalState(); }); it("errors loading room types", function () { @@ -1175,6 +1166,5 @@ describe("Rooms index create new room", function () { cy.url().should("include", "/login?redirect=/rooms"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js b/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js index c47940690..386b0eb8d 100644 --- a/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js +++ b/tests/Frontend/e2e/RoomsViewBrowserNotification.cy.js @@ -31,7 +31,6 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.disable", ); - cy.checkFinalState(); }); it("enable notifications with denied permission", function () { @@ -56,7 +55,6 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.enable", ); - cy.checkFinalState(); }); it("enable notification with default permission, but granted on request", function () { @@ -99,7 +97,6 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.disable", ); - cy.checkFinalState(); }); it("enable notification with default permission, but denied on request", function () { @@ -139,7 +136,6 @@ describe("Rooms view browser notification", function () { "aria-label", "rooms.notification.enable", ); - cy.checkFinalState(); }); it("hide enable button if not supported by browser", function () { @@ -152,7 +148,6 @@ describe("Rooms view browser notification", function () { cy.wait("@roomRequest"); cy.get('[data-test="room-notification-button"]').should("not.exist"); - cy.checkFinalState(); }); it("hide enable button if not fully supported", function () { @@ -175,7 +170,6 @@ describe("Rooms view browser notification", function () { .and("be.calledWith", ""); cy.get('[data-test="room-notification-button"]').should("not.exist"); - cy.checkFinalState(); }); it("change status from not running to running", function () { @@ -353,7 +347,6 @@ describe("Rooms view browser notification", function () { "rooms.notification.enable", ); cy.checkToastMessage("rooms.notification.disabled"); - cy.checkFinalState(); }); it("change status from not running to running errors", function () { @@ -392,6 +385,5 @@ describe("Rooms view browser notification", function () { cy.checkToastMessage("rooms.notification.browser_support"); cy.get('[data-test="room-notification-button"]').should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewDescription.cy.js b/tests/Frontend/e2e/RoomsViewDescription.cy.js index 29e15dcf7..0c096418c 100644 --- a/tests/Frontend/e2e/RoomsViewDescription.cy.js +++ b/tests/Frontend/e2e/RoomsViewDescription.cy.js @@ -130,7 +130,6 @@ describe("Rooms view description", function () { cy.get('[data-test="room-description-edit-button"]') .should("have.text", "app.edit") .and("not.be.disabled"); - cy.checkFinalState(); }); it("edit description", function () { @@ -388,7 +387,6 @@ describe("Rooms view description", function () { }); cy.get('[data-test="tip-tap-editor"]').should("not.exist"); cy.get('[data-test="room-description-edit-button"]').should("be.visible"); - cy.checkFinalState(); }); it("edit description errors", function () { @@ -496,7 +494,6 @@ describe("Rooms view description", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("description changes", function () { @@ -578,7 +575,6 @@ describe("Rooms view description", function () { .and("be.visible"); }); cy.get('[data-test="tip-tap-editor"]').should("not.exist"); - cy.checkFinalState(); }); it("open external link", function () { @@ -653,7 +649,6 @@ describe("Rooms view description", function () { `${Cypress.expose("redirectBaseUrl")}/?foo=a&bar=b`, "_blank", ); - cy.checkFinalState(); }); it("sanitize html", function () { @@ -726,6 +721,5 @@ describe("Rooms view description", function () { `${Cypress.expose("redirectBaseUrl")}/?foo=a&bar=b`, ); }); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js b/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js index d3fd463af..2b96f3ca6 100644 --- a/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js +++ b/tests/Frontend/e2e/RoomsViewDescriptionTipTapEditor.cy.js @@ -98,7 +98,6 @@ describe("Rooms view description TipTap Editor", function () { .and("have.attr", "alt", "Test image") .and("have.css", "width", "250px"); }); - cy.checkFinalState(); }); it("edit image", function () { @@ -183,7 +182,6 @@ describe("Rooms view description TipTap Editor", function () { .and("have.attr", "alt", "Test image 2") .and("have.css", "width", "300px"); }); - cy.checkFinalState(); }); it("delete image", function () { @@ -237,7 +235,6 @@ describe("Rooms view description TipTap Editor", function () { .within(() => { cy.get("img").should("not.exist"); }); - cy.checkFinalState(); }); it("add link", function () { @@ -351,7 +348,6 @@ describe("Rooms view description TipTap Editor", function () { const selectedText = selection.toString(); expect(selectedText).to.eq("Room description"); }); - cy.checkFinalState(); }); it("edit link", function () { @@ -451,7 +447,6 @@ describe("Rooms view description TipTap Editor", function () { .and("have.text", "Test Link") .click(); }); - cy.checkFinalState(); }); it("delete link", function () { @@ -517,7 +512,6 @@ describe("Rooms view description TipTap Editor", function () { cy.get("a").should("not.exist"); cy.get("p").should("have.text", "Test Link"); }); - cy.checkFinalState(); }); it("change source code", function () { @@ -586,6 +580,5 @@ describe("Rooms view description TipTap Editor", function () { cy.get("p").should("have.text", "Room description"); cy.get("h1").should("have.text", "Additional room description"); }); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewFiles.cy.js b/tests/Frontend/e2e/RoomsViewFiles.cy.js index 889b155f7..334458885 100644 --- a/tests/Frontend/e2e/RoomsViewFiles.cy.js +++ b/tests/Frontend/e2e/RoomsViewFiles.cy.js @@ -179,7 +179,6 @@ describe("Rooms View Files", function () { .eq(0) .find('button[data-test="room-files-delete-button"]') .should("not.be.disabled"); - cy.checkFinalState(); }); it("load files with access code", function () { @@ -286,7 +285,6 @@ describe("Rooms View Files", function () { .eq(1) .find('[data-test="room-files-delete-button"]') .should("not.exist"); - cy.checkFinalState(); }); it("load files with access code errors", function () { @@ -433,7 +431,6 @@ describe("Rooms View Files", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); - cy.checkFinalState(); }); it("load files with personalized link", function () { @@ -528,7 +525,6 @@ describe("Rooms View Files", function () { .eq(1) .find('[data-test="room-files-delete-button"]') .should("not.exist"); - cy.checkFinalState(); }); it("load files with personalized link errors", function () { @@ -620,7 +616,6 @@ describe("Rooms View Files", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); - cy.checkFinalState(); }); it("load files errors", function () { @@ -832,7 +827,6 @@ describe("Rooms View Files", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("load files page out of range", function () { @@ -907,7 +901,6 @@ describe("Rooms View Files", function () { page: "1", }); }); - cy.checkFinalState(); }); it("view with different permissions", function () { @@ -1478,7 +1471,6 @@ describe("Rooms View Files", function () { .eq(2) .find('[data-test="room-files-delete-button"]') .should("not.be.disabled"); - cy.checkFinalState(); }); it("search files", function () { @@ -1659,7 +1651,6 @@ describe("Rooms View Files", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("filter files", function () { @@ -1888,7 +1879,6 @@ describe("Rooms View Files", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("sort files", function () { @@ -2103,6 +2093,5 @@ describe("Rooms View Files", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js b/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js index 258ebd664..1b2473bf3 100644 --- a/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewFilesFileActions.cy.js @@ -235,8 +235,6 @@ describe("Rooms view files file actions", function () { cy.get('[data-test="room-file-item"]') .eq(4) .should("include.text", "rooms.files.use_in_next_meeting_disabled"); - - cy.checkFinalState(); }); it("upload file errors", function () { @@ -370,8 +368,6 @@ describe("Rooms view files file actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("delete file", function () { @@ -440,8 +436,6 @@ describe("Rooms view files file actions", function () { // Check that dialog is closed cy.get('[data-test="room-files-delete-dialog"]').should("not.exist"); - - cy.checkFinalState(); }); it("delete file errors", function () { @@ -586,8 +580,6 @@ describe("Rooms view files file actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("change file settings", function () { @@ -680,8 +672,6 @@ describe("Rooms view files file actions", function () { .and("include.text", "rooms.files.use_in_next_meeting") .and("not.include.text", "rooms.files.download_visible") .and("not.include.text", "rooms.files.use_in_next_meeting_disabled"); - - cy.checkFinalState(); }); it("change file settings errors", function () { @@ -850,8 +840,6 @@ describe("Rooms view files file actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("download file with terms of use", function () { @@ -907,8 +895,6 @@ describe("Rooms view files file actions", function () { ) .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); - - cy.checkFinalState(); }); it("download file with access code errors", function () { @@ -1028,8 +1014,6 @@ describe("Rooms view files file actions", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); - - cy.checkFinalState(); }); it("download file with personalized link errors", function () { @@ -1117,8 +1101,6 @@ describe("Rooms view files file actions", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); - - cy.checkFinalState(); }); it("download file errors", function () { @@ -1376,6 +1358,5 @@ describe("Rooms view files file actions", function () { // Check that files were not reloaded cy.get("@reloadRoomFilesRequest").should("be.null"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewGeneral.cy.js b/tests/Frontend/e2e/RoomsViewGeneral.cy.js index a0f7fbd4b..2b6ee8dfd 100644 --- a/tests/Frontend/e2e/RoomsViewGeneral.cy.js +++ b/tests/Frontend/e2e/RoomsViewGeneral.cy.js @@ -101,7 +101,6 @@ describe("Room View general", function () { cy.get("#tab-recordings").should("be.visible"); cy.get("#tab-history").should("not.exist"); cy.get("#tab-settings").should("not.exist"); - cy.checkFinalState(); }); it("room view with access code", function () { @@ -392,7 +391,6 @@ describe("Room View general", function () { }); cy.get('[data-test="room-access-code-overlay"]').should("not.exist"); - cy.checkFinalState(); }); it("room view with legacy access code", function () { @@ -500,7 +498,6 @@ describe("Room View general", function () { // Check that the correct tab is shown cy.contains("rooms.description.title").should("be.visible"); - cy.checkFinalState(); }); it("room auth with access code errors", function () { @@ -755,7 +752,6 @@ describe("Room View general", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("room view with access code errors", function () { @@ -898,7 +894,6 @@ describe("Room View general", function () { cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); cy.get("#access-code").should("not.be.disabled"); cy.get('[data-test="room-login-button"]').should("not.be.disabled"); - cy.checkFinalState(); }); it("room view as member", function () { @@ -952,7 +947,6 @@ describe("Room View general", function () { // Check if share button is hidden cy.get('[data-test="room-share-button"]').should("not.exist"); - cy.checkFinalState(); }); it("room view as moderator", function () { @@ -1004,7 +998,6 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); - cy.checkFinalState(); }); it("share room", function () { @@ -1203,7 +1196,6 @@ describe("Room View general", function () { cy.get('[data-test="room-invitation-copy-code-button"]').should( "not.exist", ); - cy.checkFinalState(); }); it("room view as co-owner", function () { @@ -1257,7 +1249,6 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); - cy.checkFinalState(); }); it("room view as owner", function () { @@ -1303,7 +1294,6 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); - cy.checkFinalState(); }); it("room view with personalized link (participant)", function () { @@ -1415,7 +1405,6 @@ describe("Room View general", function () { // Check that error message is shown cy.checkToastMessage("rooms.flash.personalized_link_invalid"); cy.contains("rooms.invalid_personalized_link").should("be.visible"); - cy.checkFinalState(); }); it("room view with personalized link (moderator)", function () { @@ -1496,7 +1485,6 @@ describe("Room View general", function () { // Check if share button is hidden cy.get('[data-test="room-share-button"]').should("not.exist"); - cy.checkFinalState(); }); it("room auth with personalized link errors", function () { @@ -1691,7 +1679,6 @@ describe("Room View general", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("room view with personalized link errors", function () { @@ -1884,7 +1871,6 @@ describe("Room View general", function () { // Check that room auth request was not sent again cy.get("@differentRoomAuthRequest").should("be.null"); - cy.checkFinalState(); }); it("room view with rooms.viewAll permission", function () { @@ -1942,7 +1928,6 @@ describe("Room View general", function () { // Check if share button is shown correctly cy.get('[data-test="room-share-button"]').should("exist"); - cy.checkFinalState(); }); it("room view streaming enabled", function () { @@ -1988,7 +1973,6 @@ describe("Room View general", function () { cy.get("#tab-streaming") .should("be.visible") .should("have.attr", "data-feature-disabled", "false"); - cy.checkFinalState(); }); it("room view streaming disabled", function () { @@ -2089,7 +2073,6 @@ describe("Room View general", function () { 'rooms.feature_disabled_system_{"name":"rooms.streaming.title"}', ); cy.get('[data-test="dialog-close-button"]').click(); - cy.checkFinalState(); }); it("membership button", function () { @@ -2243,7 +2226,6 @@ describe("Room View general", function () { // Check that no error message is shown even though room request returned authenticated false again cy.get(".p-toast-message").should("not.exist"); - cy.checkFinalState(); }); it("membership button errors", function () { @@ -2652,7 +2634,6 @@ describe("Room View general", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("trigger favorites button", function () { @@ -2758,7 +2739,6 @@ describe("Room View general", function () { "aria-label", "rooms.favorites.add", ); - cy.checkFinalState(); }); it("trigger favorites button errors", function () { @@ -2995,7 +2975,6 @@ describe("Room View general", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("visit with guest forbidden", function () { @@ -3018,7 +2997,6 @@ describe("Room View general", function () { "href", "/login?redirect=/rooms/abc-def-123", ); - cy.checkFinalState(); }); it("visit with personalized link as authenticated user", function () { @@ -3048,7 +3026,6 @@ describe("Room View general", function () { "not.include", "/rooms/abc-def-123/xWDCevVTcMys1ftzt3nFPgU56Wf32fopFWgAEBtklSkFU22z1ntA4fBHsHeMygMiOa9szJbNEfBAgEWSLNWg2gcF65PwPZ2ylPQR", ); - cy.checkFinalState(); }); it("visit with general error", function () { @@ -3082,7 +3059,6 @@ describe("Room View general", function () { // Check that overlay is hidden cy.get('[data-test="no-room-overlay"]').should("not.exist"); - cy.checkFinalState(); }); it("visit with room not found", function () { @@ -3124,7 +3100,6 @@ describe("Room View general", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("auto-reload", function () { @@ -3154,7 +3129,6 @@ describe("Room View general", function () { // Wait more than 60 seconds (due to reload randomness) for a auto-reload cy.tick(100000); cy.get("@roomRequest.all").should("have.length", 2); - cy.checkFinalState(); }); it("auto-reload disabled on error", function () { @@ -3183,7 +3157,6 @@ describe("Room View general", function () { // Wait more than 60 seconds (due to reload randomness) for no auto-reload cy.tick(100000); cy.get("@roomRequest.all").should("have.length", 1); - cy.checkFinalState(); }); it("reload with errors", function () { @@ -3309,7 +3282,6 @@ describe("Room View general", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("reload with access code errors", function () { @@ -3422,7 +3394,6 @@ describe("Room View general", function () { cy.contains("rooms.flash.access_code_invalid").should("be.visible"); cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); - cy.checkFinalState(); }); it("reload with personalized link errors", function () { @@ -3533,7 +3504,6 @@ describe("Room View general", function () { cy.url() .should("not.include", "/rooms") .and("not.include", "rooms/abc-def-123"); - cy.checkFinalState(); }); it("logged in status change", function () { @@ -3611,7 +3581,6 @@ describe("Room View general", function () { cy.get("#tab-recordings").should("be.visible"); cy.get("#tab-history").should("be.visible"); cy.get("#tab-settings").should("be.visible"); - cy.checkFinalState(); }); it("displays meeting ended reason", function () { @@ -3640,7 +3609,6 @@ describe("Room View general", function () { // Check reason message is removed from URL cy.url().should("not.include", "reason"); - cy.checkFinalState(); }); it("displays bbb error messages", function () { @@ -3709,7 +3677,6 @@ describe("Room View general", function () { // Check url is updated (no errors) cy.url().should("not.include", "errors"); - cy.checkFinalState(); }); it("hide room owner if not provided", function () { @@ -3731,6 +3698,5 @@ describe("Room View general", function () { // room should not contain owner name cy.contains("John Doe").should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewHistory.cy.js b/tests/Frontend/e2e/RoomsViewHistory.cy.js index 2f05c7614..1936dd962 100644 --- a/tests/Frontend/e2e/RoomsViewHistory.cy.js +++ b/tests/Frontend/e2e/RoomsViewHistory.cy.js @@ -159,7 +159,6 @@ describe("Rooms view history", function () { cy.get('[data-test="room-history-item"]').should("have.length", 0); cy.contains("meetings.no_historical_data").should("be.visible"); - cy.checkFinalState(); }); it("load history errors", function () { @@ -527,7 +526,6 @@ describe("Rooms view history", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("load history page out of range", function () { @@ -602,7 +600,6 @@ describe("Rooms view history", function () { page: "1", }); }); - cy.checkFinalState(); }); it("load history retention period", function () { @@ -647,7 +644,6 @@ describe("Rooms view history", function () { "include.text", 'meetings.attendance.retention_period_{"days":30}', ); - cy.checkFinalState(); }); it("sort history", function () { @@ -865,6 +861,5 @@ describe("Rooms view history", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js b/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js index 1f6c6ef78..6a9fb3185 100644 --- a/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewHistoryMeetingActions.cy.js @@ -62,7 +62,6 @@ describe("Rooms view history meeting actions", function () { 1163 * window.devicePixelRatio, ); }); - cy.checkFinalState(); }); it("show stats errors", function () { @@ -178,7 +177,6 @@ describe("Rooms view history meeting actions", function () { "api/v1/meetings/3a3e504a-d2c4-431c-8ca1-a62598e66761/stats", "history", ); - cy.checkFinalState(); }); it("show attendance", function () { @@ -373,7 +371,6 @@ describe("Rooms view history meeting actions", function () { 0, ); }); - cy.checkFinalState(); }); it("show attendance errors", function () { @@ -519,6 +516,5 @@ describe("Rooms view history meeting actions", function () { "api/v1/meetings/3a3e504a-d2c4-431c-8ca1-a62598e66761/attendance", "history", ); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMeetings.cy.js b/tests/Frontend/e2e/RoomsViewMeetings.cy.js index b497af70e..b253e292d 100644 --- a/tests/Frontend/e2e/RoomsViewMeetings.cy.js +++ b/tests/Frontend/e2e/RoomsViewMeetings.cy.js @@ -86,8 +86,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting with attendance logging", function () { @@ -174,8 +172,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting with streaming", function () { @@ -262,8 +258,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting with recording", function () { @@ -353,8 +347,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting with recording without video", function () { @@ -424,8 +416,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting guests", function () { @@ -502,8 +492,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting guests errors", function () { @@ -613,8 +601,6 @@ describe("Rooms view meetings", function () { 'app.flash.server_error.message_{"message":"Test"}', 'app.flash.server_error.error_code_{"statusCode":500}', ]); - - cy.checkFinalState(); }); it("join running meeting with access code", function () { @@ -731,8 +717,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting access code errors", function () { @@ -908,8 +892,6 @@ describe("Rooms view meetings", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); - - cy.checkFinalState(); }); it("join running meeting with personalized link", function () { @@ -1007,8 +989,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("join running meeting with personalized link errors", function () { @@ -1081,8 +1061,6 @@ describe("Rooms view meetings", function () { cy.checkToastMessage("rooms.flash.personalized_link_invalid"); cy.contains("rooms.invalid_personalized_link").should("be.visible"); - - cy.checkFinalState(); }); it("join meeting errors", function () { @@ -1416,8 +1394,6 @@ describe("Rooms view meetings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("join meeting load requirements errors", function () { @@ -1667,8 +1643,6 @@ describe("Rooms view meetings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("join running meeting with dark mode", function () { @@ -1732,8 +1706,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting", function () { @@ -1802,8 +1774,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting with attendance logging", function () { @@ -1881,8 +1851,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting with streaming", function () { @@ -1960,8 +1928,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting with recording", function () { @@ -2042,8 +2008,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting with recording without video", function () { @@ -2100,8 +2064,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting guests", function () { @@ -2171,8 +2133,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting guests errors", function () { @@ -2274,8 +2234,6 @@ describe("Rooms view meetings", function () { 'app.flash.server_error.message_{"message":"Test"}', 'app.flash.server_error.error_code_{"statusCode":500}', ]); - - cy.checkFinalState(); }); it("start meeting with access code", function () { @@ -2378,8 +2336,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting access code errors", function () { @@ -2531,8 +2487,6 @@ describe("Rooms view meetings", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); - - cy.checkFinalState(); }); it("start meeting with personalized link", function () { @@ -2619,8 +2573,6 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); it("start meeting with personalized link errors", function () { @@ -2697,8 +2649,6 @@ describe("Rooms view meetings", function () { cy.checkToastMessage("rooms.flash.personalized_link_invalid"); cy.contains("rooms.invalid_personalized_link").should("be.visible"); - - cy.checkFinalState(); }); it("start meeting errors", function () { @@ -3096,8 +3046,6 @@ describe("Rooms view meetings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("start meeting load requirements errors", function () { @@ -3348,8 +3296,6 @@ describe("Rooms view meetings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - - cy.checkFinalState(); }); it("start meeting with dark mode", function () { @@ -3400,7 +3346,5 @@ describe("Rooms view meetings", function () { "eq", `${Cypress.expose("redirectBaseUrl")}/bigbluebutton?foo=a&bar=b`, ); - - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMembers.cy.js b/tests/Frontend/e2e/RoomsViewMembers.cy.js index b3f3bdb00..93873acd8 100644 --- a/tests/Frontend/e2e/RoomsViewMembers.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembers.cy.js @@ -125,7 +125,6 @@ describe("Rooms view members", function () { .eq(2) .find("img") .should("have.attr", "src", "test.jpg"); - cy.checkFinalState(); }); it("load members errors", function () { @@ -514,7 +513,6 @@ describe("Rooms view members", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("load members page out of range", function () { @@ -589,7 +587,6 @@ describe("Rooms view members", function () { page: "1", }); }); - cy.checkFinalState(); }); it("search members", function () { @@ -780,7 +777,6 @@ describe("Rooms view members", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("filter members", function () { @@ -1024,7 +1020,6 @@ describe("Rooms view members", function () { "have.text", "rooms.members.filter.all", ); - cy.checkFinalState(); }); it("sort members", function () { @@ -1244,7 +1239,6 @@ describe("Rooms view members", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("check button visibility co_owner", function () { @@ -1427,7 +1421,6 @@ describe("Rooms view members", function () { cy.get('[data-test="room-members-select-all-checkbox"]').should( "not.exist", ); - cy.checkFinalState(); }); it("check button visibility with rooms.viewAll and rooms.manage permissions", function () { @@ -1606,6 +1599,5 @@ describe("Rooms view members", function () { cy.get('[data-test="room-members-bulk-delete-button"]').should( "be.visible", ); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js b/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js index 4abefbee1..1a9dbb172 100644 --- a/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembersBulkActions.cy.js @@ -246,7 +246,6 @@ describe("Rooms view members bulk actions", function () { // Check that bulk edit dialog is closed and bulk edit button is hidden cy.get('[data-test="room-members-bulk-edit-dialog"]').should("not.exist"); cy.get('[data-test="room-members-bulk-edit-button"]').should("not.exist"); - cy.checkFinalState(); }); it("bulk edit members errors", function () { @@ -450,7 +449,6 @@ describe("Rooms view members bulk actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("bulk delete members", function () { @@ -619,7 +617,6 @@ describe("Rooms view members bulk actions", function () { // Check that users were removed cy.get('[data-test="room-member-item"]').should("have.length", 0); cy.contains("rooms.members.nodata").should("be.visible"); - cy.checkFinalState(); }); it("bulk delete members errors", function () { @@ -770,7 +767,6 @@ describe("Rooms view members bulk actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("bulk import members", function () { @@ -1370,7 +1366,6 @@ describe("Rooms view members bulk actions", function () { cy.get('[data-test="room-members-bulk-import-dialog"]').should("not.exist"); cy.get('[data-test="room-member-item"]').should("have.length", 5); - cy.checkFinalState(); }); it("bulk import members errors", function () { @@ -1519,6 +1514,5 @@ describe("Rooms view members bulk actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js b/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js index 4c44f0381..0947f2ca6 100644 --- a/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewMembersMemberActions.cy.js @@ -239,7 +239,6 @@ describe("Rooms view members member actions", function () { cy.get('[data-test="room-member-item"]') .eq(3) .should("include.text", "rooms.roles.moderator"); - cy.checkFinalState(); }); it("add new member errors", function () { @@ -477,7 +476,6 @@ describe("Rooms view members member actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("edit member", function () { @@ -567,7 +565,6 @@ describe("Rooms view members member actions", function () { cy.get('[data-test="room-member-item"]') .eq(0) .should("include.text", "rooms.roles.moderator"); - cy.checkFinalState(); }); it("edit member errors", function () { @@ -725,7 +722,6 @@ describe("Rooms view members member actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("delete member", function () { @@ -794,7 +790,6 @@ describe("Rooms view members member actions", function () { // Check that delete dialog is closed cy.get('[data-test="room-members-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete member errors", function () { @@ -930,6 +925,5 @@ describe("Rooms view members member actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js index 32bb566d1..23c4c59ff 100644 --- a/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js +++ b/tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js @@ -127,7 +127,6 @@ describe("Rooms view personalized links", function () { 'rooms.personalized_links.expires_at_{"date":"10/20/2021, 11:17"}', ) .should("include.text", "rooms.roles.moderator"); - cy.checkFinalState(); }); it("load personalized links errors", function () { @@ -535,7 +534,6 @@ describe("Rooms view personalized links", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("load personalized links page out of range", function () { @@ -610,7 +608,6 @@ describe("Rooms view personalized links", function () { page: "1", }); }); - cy.checkFinalState(); }); it("view with different permissions", function () { @@ -835,7 +832,6 @@ describe("Rooms view personalized links", function () { "be.visible", ); }); - cy.checkFinalState(); }); it("search personalized links", function () { @@ -1031,7 +1027,6 @@ describe("Rooms view personalized links", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("filter personalized links", function () { @@ -1281,7 +1276,6 @@ describe("Rooms view personalized links", function () { "have.text", "rooms.personalized_links.filter.all", ); - cy.checkFinalState(); }); it("sort personalized links", function () { @@ -1512,6 +1506,5 @@ describe("Rooms view personalized links", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js b/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js index ae337587b..8cdf74b72 100644 --- a/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js @@ -137,7 +137,6 @@ describe("Rooms view personalized links actions", function () { .and("include.text", "rooms.roles.participant") .and("not.include.text", "rooms.personalized_links.last_used_at") .and("not.include.text", "rooms.personalized_links.expires_at"); - cy.checkFinalState(); }); it("add new personalized link errors", function () { @@ -272,7 +271,6 @@ describe("Rooms view personalized links actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("edit personalized link", function () { @@ -413,7 +411,6 @@ describe("Rooms view personalized links actions", function () { "include.text", 'rooms.personalized_links.expires_at_{"date":"10/17/2021, 14:21"}', ); - cy.checkFinalState(); }); it("edit personalized link errors", function () { @@ -605,7 +602,6 @@ describe("Rooms view personalized links actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("delete personalized link", function () { @@ -683,7 +679,6 @@ describe("Rooms view personalized links actions", function () { "have.length", 2, ); - cy.checkFinalState(); }); it("delete personalized link errors", function () { @@ -842,7 +837,6 @@ describe("Rooms view personalized links actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("copy personalized link", function () { @@ -869,6 +863,5 @@ describe("Rooms view personalized links actions", function () { cy.checkToastMessage( 'rooms.personalized_links.room_link_copied_{"firstname":"John","lastname":"Doe"}', ); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewRecordings.cy.js b/tests/Frontend/e2e/RoomsViewRecordings.cy.js index b6becdfc0..743026d31 100644 --- a/tests/Frontend/e2e/RoomsViewRecordings.cy.js +++ b/tests/Frontend/e2e/RoomsViewRecordings.cy.js @@ -307,8 +307,6 @@ describe("Rooms view recordings", function () { .eq(0) .find('button[data-test="room-recordings-delete-button"]') .should("not.be.disabled"); - - cy.checkFinalState(); }); it("load recordings with access code", function () { @@ -393,7 +391,6 @@ describe("Rooms view recordings", function () { .should("be.visible") .and("include.text", "rooms.recordings.retention_period.title") .and("include.text", "rooms.recordings.retention_period.unlimited"); - cy.checkFinalState(); }); it("load recordings with access code errors", function () { @@ -540,7 +537,6 @@ describe("Rooms view recordings", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); - cy.checkFinalState(); }); it("load recordings with personalized link", function () { @@ -613,7 +609,6 @@ describe("Rooms view recordings", function () { .should("be.visible") .and("include.text", "rooms.recordings.retention_period.title") .and("include.text", "rooms.recordings.retention_period.unlimited"); - cy.checkFinalState(); }); it("load recordings with personalized link errors", function () { @@ -706,7 +701,6 @@ describe("Rooms view recordings", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); - cy.checkFinalState(); }); it("load recordings errors", function () { @@ -922,7 +916,6 @@ describe("Rooms view recordings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("load recordings page out of range", function () { @@ -996,7 +989,6 @@ describe("Rooms view recordings", function () { page: "1", }); }); - cy.checkFinalState(); }); it("view with different permissions", function () { @@ -1504,7 +1496,6 @@ describe("Rooms view recordings", function () { "include.text", 'rooms.recordings.retention_period.days_{"days":365}', ); - cy.checkFinalState(); }); it("search recordings", function () { @@ -1685,7 +1676,6 @@ describe("Rooms view recordings", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("filter recordings", function () { @@ -1942,7 +1932,6 @@ describe("Rooms view recordings", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); it("sort recordings", function () { @@ -2157,6 +2146,5 @@ describe("Rooms view recordings", function () { cy.get('[data-test="paginator-page"]') .eq(0) .should("have.attr", "data-p-active", "true"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js b/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js index 13c5c90b8..34487ae80 100644 --- a/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewRecordingsRecordingActions.cy.js @@ -66,7 +66,6 @@ describe("Rooms view recordings recording actions", function () { .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); }); - cy.checkFinalState(); }); it("view recording with access code", function () { @@ -170,7 +169,6 @@ describe("Rooms view recordings recording actions", function () { ) .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); - cy.checkFinalState(); }); it("view recording with access code errors", function () { @@ -300,8 +298,6 @@ describe("Rooms view recordings recording actions", function () { cy.contains("rooms.flash.access_code_invalid").should("not.exist"); cy.get("#access-code").should("have.value", ""); - - cy.checkFinalState(); }); it("view recording with personalized link", function () { @@ -394,7 +390,6 @@ describe("Rooms view recordings recording actions", function () { ) .and("have.attr", "rel", "opener") .and("have.attr", "target", "_blank"); - cy.checkFinalState(); }); it("view recording with personalized link errors", function () { @@ -493,7 +488,6 @@ describe("Rooms view recordings recording actions", function () { cy.url() .should("not.include", "/rooms/abc-def-123") .and("not.include", "/rooms"); - cy.checkFinalState(); }); it("view recording with errors", function () { @@ -746,7 +740,6 @@ describe("Rooms view recordings recording actions", function () { cy.get(".p-toast-message").should("not.exist"); cy.get("@reloadRoomRecordingsRequest").should("be.null"); - cy.checkFinalState(); }); it("delete recording", function () { @@ -813,7 +806,6 @@ describe("Rooms view recordings recording actions", function () { // Check that dialog is closed cy.get('[data-test="room-recordings-delete-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("delete recording errors", function () { @@ -966,7 +958,6 @@ describe("Rooms view recordings recording actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("edit recording", function () { @@ -1157,7 +1148,6 @@ describe("Rooms view recordings recording actions", function () { .eq(0) .should("include.text", "rooms.recordings.format_types.screenshare"); }); - cy.checkFinalState(); }); it("edit recording errors", function () { @@ -1370,6 +1360,5 @@ describe("Rooms view recordings recording actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewSettings.cy.js b/tests/Frontend/e2e/RoomsViewSettings.cy.js index 24e4f1cc2..2bb2bd1ef 100644 --- a/tests/Frontend/e2e/RoomsViewSettings.cy.js +++ b/tests/Frontend/e2e/RoomsViewSettings.cy.js @@ -364,7 +364,6 @@ describe("Rooms view settings", function () { .should("have.text", "rooms.settings.advanced.visibility.public") .and("have.attr", "aria-pressed", "true"); }); - cy.checkFinalState(); }); it("load settings errors", function () { @@ -447,7 +446,6 @@ describe("Rooms view settings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("load settings with different permissions", function () { @@ -868,7 +866,6 @@ describe("Rooms view settings", function () { .should("have.text", "rooms.settings.advanced.visibility.public") .and("have.attr", "aria-pressed", "true") .and("not.be.disabled"); - cy.checkFinalState(); }); it("change settings", function () { @@ -1269,7 +1266,6 @@ describe("Rooms view settings", function () { "have.text", "rooms.settings.expert_mode.activate", ); - cy.checkFinalState(); }); it("change settings with GL3 access code", function () { @@ -1337,7 +1333,6 @@ describe("Rooms view settings", function () { // Check that settings are shown correctly cy.get("#room-setting-name").should("have.value", "Meeting Two"); - cy.checkFinalState(); }); it("change settings errors", function () { @@ -1717,7 +1712,6 @@ describe("Rooms view settings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("delete room", function () { @@ -1774,7 +1768,6 @@ describe("Rooms view settings", function () { cy.wait("@roomDeleteRequest"); cy.url().should("include", "/rooms").and("not.include", "/abc-def-123"); - cy.checkFinalState(); }); it("delete room errors", function () { @@ -1863,7 +1856,6 @@ describe("Rooms view settings", function () { "api/v1/rooms/abc-def-123", "settings", ); - cy.checkFinalState(); }); it("transfer ownership", function () { @@ -2178,7 +2170,6 @@ describe("Rooms view settings", function () { // Check that access code overlay is shown cy.get('[data-test="room-access-code-overlay"]').should("be.visible"); - cy.checkFinalState(); }); it("transfer ownership errors", function () { @@ -2389,6 +2380,5 @@ describe("Rooms view settings", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js b/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js index 9ba5f4d1f..46cdb882f 100644 --- a/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewSettingsRoomTypeActions.cy.js @@ -1448,7 +1448,6 @@ describe("Rooms view settings room type actions", function () { .eq(1) .should("have.attr", "aria-pressed", "false") .and("be.disabled"); - cy.checkFinalState(); }); it("change room type with features enabled", function () { @@ -1595,7 +1594,6 @@ describe("Rooms view settings room type actions", function () { ); }); }); - cy.checkFinalState(); }); it("change room type with features disabled", function () { @@ -1645,7 +1643,6 @@ describe("Rooms view settings room type actions", function () { cy.get('[data-test="room-type-features"]').should("not.exist"); }); }); - cy.checkFinalState(); }); it("change room type with features disabled and show disabled features", function () { @@ -1722,7 +1719,6 @@ describe("Rooms view settings room type actions", function () { ); }); }); - cy.checkFinalState(); }); it("change room type no expert", function () { @@ -2514,7 +2510,6 @@ describe("Rooms view settings room type actions", function () { ); cy.get('[data-test="room-type-change-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("errors loading room types", function () { @@ -2620,6 +2615,5 @@ describe("Rooms view settings room type actions", function () { "api/v1/roomTypes*", "settings", ); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewStreaming.cy.js b/tests/Frontend/e2e/RoomsViewStreaming.cy.js index 955fa554a..5a7a80169 100644 --- a/tests/Frontend/e2e/RoomsViewStreaming.cy.js +++ b/tests/Frontend/e2e/RoomsViewStreaming.cy.js @@ -39,7 +39,6 @@ describe("Rooms view streaming", function () { cy.get('[data-test="streaming-stop-button"]').should("be.disabled"); cy.get('[data-test="streaming-pause-button"]').should("be.disabled"); cy.get('[data-test="streaming-resume-button"]').should("be.disabled"); - cy.checkFinalState(); }); it("no running meeting, meeting ended", function () { @@ -70,7 +69,6 @@ describe("Rooms view streaming", function () { cy.get('[data-test="streaming-stop-button"]').should("be.disabled"); cy.get('[data-test="streaming-pause-button"]').should("be.disabled"); cy.get('[data-test="streaming-resume-button"]').should("be.disabled"); - cy.checkFinalState(); }); it("running meeting, streaming disabled", function () { @@ -109,7 +107,6 @@ describe("Rooms view streaming", function () { cy.get('[data-test="streaming-stop-button"]').should("be.disabled"); cy.get('[data-test="streaming-pause-button"]').should("be.disabled"); cy.get('[data-test="streaming-resume-button"]').should("be.disabled"); - cy.checkFinalState(); }); it("fps counter is shown", function () { @@ -175,7 +172,6 @@ describe("Rooms view streaming", function () { // Check if fps counter is not shown cy.get('[data-test="streaming-fps-counter"]').should("not.exist"); - cy.checkFinalState(); }); it("start, pause, resume and stop streaming", function () { @@ -462,7 +458,6 @@ describe("Rooms view streaming", function () { "contain", "rooms.streaming.failed", ); - cy.checkFinalState(); }); it("load settings with different permissions", function () { @@ -583,7 +578,6 @@ describe("Rooms view streaming", function () { "contain", "rooms.streaming.running", ); - cy.checkFinalState(); }); it("auto reloading", function () { @@ -648,7 +642,6 @@ describe("Rooms view streaming", function () { "rooms.streaming.running", ); }); - cy.checkFinalState(); }); it("error handling", function () { @@ -818,6 +811,5 @@ describe("Rooms view streaming", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js b/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js index de96f0ca1..a92235a73 100644 --- a/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js +++ b/tests/Frontend/e2e/RoomsViewStreamingConfigActions.cy.js @@ -212,7 +212,6 @@ describe("Rooms view streaming config actions", function () { // Close dialog cy.get('[data-test="dialog-cancel-button"]').click(); }); - cy.checkFinalState(); }); it("load with error", function () { @@ -305,7 +304,6 @@ describe("Rooms view streaming config actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("edit settings", function () { @@ -519,7 +517,6 @@ describe("Rooms view streaming config actions", function () { // Check dialog closed cy.get('[data-test="room-streaming-config-dialog"]').should("not.exist"); - cy.checkFinalState(); }); it("edit settings errors", function () { @@ -661,7 +658,6 @@ describe("Rooms view streaming config actions", function () { 'app.flash.model_not_found.title_{"model":"app.model.room"}', 'app.flash.model_not_found.details_{"ids":"abc-def-123"}', ]); - cy.checkFinalState(); }); it("view/edit settings with different permissions", function () { @@ -798,6 +794,5 @@ describe("Rooms view streaming config actions", function () { // Close dialog cy.get('[data-test="dialog-cancel-button"]').click(); }); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfile.cy.js b/tests/Frontend/e2e/UserProfile.cy.js index 31f192681..a07bfae13 100644 --- a/tests/Frontend/e2e/UserProfile.cy.js +++ b/tests/Frontend/e2e/UserProfile.cy.js @@ -8,7 +8,6 @@ describe("User Profile", function () { it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/profile"); - cy.checkFinalState(); }); it("open user profile", function () { @@ -56,7 +55,6 @@ describe("User Profile", function () { cy.get('[data-test="email-tab-button"]').should("be.visible"); cy.get('[data-test="security-tab-button"]').should("be.visible"); cy.get('[data-test="others-tab-button"]').should("be.visible"); - cy.checkFinalState(); }); it("open user profile errors", function () { @@ -108,7 +106,6 @@ describe("User Profile", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("should hide edit controls when external_image is true", function () { @@ -123,6 +120,5 @@ describe("User Profile", function () { cy.get('[data-test="profile-image-field"]').should("be.visible"); cy.get('[data-test="upload-file-button"]').should("not.exist"); cy.get('[data-test="delete-image-button"]').should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileBase.cy.js b/tests/Frontend/e2e/UserProfileBase.cy.js index 7e4003911..1c3f7820e 100644 --- a/tests/Frontend/e2e/UserProfileBase.cy.js +++ b/tests/Frontend/e2e/UserProfileBase.cy.js @@ -495,7 +495,6 @@ describe("User Profile Base", function () { cy.get('[data-test="default-profile-image-preview"]') .should("be.visible") .and("include.text", "LR"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -641,7 +640,6 @@ describe("User Profile Base", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("view without users.updateOwnAttributes permission", function () { @@ -684,7 +682,6 @@ describe("User Profile Base", function () { "true", ); }); - cy.checkFinalState(); }); it("view as external user", function () { @@ -743,7 +740,6 @@ describe("User Profile Base", function () { "true", ); }); - cy.checkFinalState(); }); it("load timezones error", function () { @@ -834,6 +830,5 @@ describe("User Profile Base", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileEmail.cy.js b/tests/Frontend/e2e/UserProfileEmail.cy.js index 5a649177c..2c4ffe5d6 100644 --- a/tests/Frontend/e2e/UserProfileEmail.cy.js +++ b/tests/Frontend/e2e/UserProfileEmail.cy.js @@ -104,7 +104,6 @@ describe("User Profile Email", function () { cy.get("#email") .should("have.value", "john.doe@example.com") .and("not.be.disabled"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -189,7 +188,6 @@ describe("User Profile Email", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("view without users.updateOwnAttributes permission", function () { @@ -210,7 +208,6 @@ describe("User Profile Email", function () { .and("have.value", "JohnDoe@domain.tld"); cy.get('[data-test="user-tab-email-save-button"]').should("not.exist"); - cy.checkFinalState(); }); it("view as external user", function () { @@ -239,6 +236,5 @@ describe("User Profile Email", function () { .and("have.value", "JohnDoe@domain.tld"); cy.get('[data-test="user-tab-email-save-button"]').should("not.exist"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileOthers.cy.js b/tests/Frontend/e2e/UserProfileOthers.cy.js index e75aa05f5..165d4c66a 100644 --- a/tests/Frontend/e2e/UserProfileOthers.cy.js +++ b/tests/Frontend/e2e/UserProfileOthers.cy.js @@ -55,7 +55,6 @@ describe("User Profile Others", function () { // Check that the changes are shown cy.get("#bbb_skip_check_audio").should("be.checked"); - cy.checkFinalState(); }); it("save changes errors", function () { @@ -151,6 +150,5 @@ describe("User Profile Others", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/UserProfileSecurity.cy.js b/tests/Frontend/e2e/UserProfileSecurity.cy.js index 2f233d621..6a80e0e98 100644 --- a/tests/Frontend/e2e/UserProfileSecurity.cy.js +++ b/tests/Frontend/e2e/UserProfileSecurity.cy.js @@ -193,7 +193,6 @@ describe("User Profile Security", function () { .should("include.text", "auth.sessions.current") .should("include.text", "auth.sessions.browser Chrome") .should("include.text", "auth.sessions.ip 10.9.1.2"); - cy.checkFinalState(); }); it("view without password change allowed", function () { @@ -256,7 +255,6 @@ describe("User Profile Security", function () { cy.get('[data-test="logout-all-sessions-button"]') .should("have.text", "auth.sessions.logout_all") .should("not.be.disabled"); - cy.checkFinalState(); }); it("view as external user", function () { @@ -320,7 +318,6 @@ describe("User Profile Security", function () { cy.get('[data-test="logout-all-sessions-button"]') .should("have.text", "auth.sessions.logout_all") .should("not.be.disabled"); - cy.checkFinalState(); }); it("change settings errors", function () { @@ -482,7 +479,6 @@ describe("User Profile Security", function () { cy.url().should("include", "/login?redirect=/profile"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); it("load sessions error", function () { @@ -556,6 +552,5 @@ describe("User Profile Security", function () { .should("include.text", "01/23/2022, 16:55") .should("include.text", "auth.sessions.browser Mobile Safari") .should("include.text", "auth.sessions.ip 10.9.1.5"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/e2e/VerifyEmail.cy.js b/tests/Frontend/e2e/VerifyEmail.cy.js index 464908a10..a809e4da9 100644 --- a/tests/Frontend/e2e/VerifyEmail.cy.js +++ b/tests/Frontend/e2e/VerifyEmail.cy.js @@ -27,12 +27,10 @@ describe("Verify email", function () { cy.visit("/verify_email"); cy.url().should("include", "/404").and("not.include", "/verify_email"); - cy.checkFinalState(); }); it("visit with user that is not logged in", function () { cy.testVisitWithoutCurrentUser("/verify_email"); - cy.checkFinalState(); }); it("verify email", function () { @@ -72,7 +70,6 @@ describe("Verify email", function () { .and("include.text", "app.verify_email.success"); cy.get('[data-test="verify-invalid-message"]').should("not.exist"); cy.get('[data-test="verify-error-message"]').should("not.exist"); - cy.checkFinalState(); }); it("verify email errors", function () { @@ -172,6 +169,5 @@ describe("Verify email", function () { cy.url().should("include", "/login?redirect=/verify_email"); cy.checkToastMessage("app.flash.unauthenticated"); - cy.checkFinalState(); }); }); diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index 01af50c06..3a34cae48 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -1,3 +1,24 @@ +const originalIt = window.it; + +window.it = function (title, fn) { + if (typeof fn !== "function") { + return originalIt(title, fn); + } + + return originalIt(title, function () { + fn(); + cy.checkFinalState(); + }); +}; + +window.it.only = function (title, fn) { + return originalIt.only(title, function () { + fn(); + }); +}; + +window.it.skip = originalIt.skip; + /** * Override for visit * Checks final state before performing the visit, to make sure that unexpected errors that may have happened previously are caught. From df14c91696bcd31d92dd63fcd82a0a5db0a3a147 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Sat, 16 May 2026 11:07:32 +0200 Subject: [PATCH 08/14] Improve it function override and cypress logging --- .../support/commands/commandOverrides.js | 41 ++++++++++++------- .../support/commands/generalCommands.js | 1 + 2 files changed, 27 insertions(+), 15 deletions(-) diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index 3a34cae48..e2d6d8152 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -1,22 +1,31 @@ +// Override for window.it used for all tests, to check the final state after each test, to make sure that unexpected errors +// or states that may have happened during the test are caught. + const originalIt = window.it; -window.it = function (title, fn) { - if (typeof fn !== "function") { - return originalIt(title, fn); +window.it = function (title, optionsOrFunction, fn) { + // Determine test function and options based on the arguments passed to it + const testFn = + typeof optionsOrFunction === "function" ? optionsOrFunction : fn; + const testOptions = + typeof optionsOrFunction === "object" ? { ...optionsOrFunction } : {}; + + if (typeof testFn !== "function") { + // Call the original it function with the provided arguments + // This is necessary to make it.skip work correctly + return originalIt(title, optionsOrFunction, fn); } - return originalIt(title, function () { - fn(); + // Call the original it function with the modified test function and options + return originalIt(title, testOptions, function () { + testFn(); cy.checkFinalState(); }); }; -window.it.only = function (title, fn) { - return originalIt.only(title, function () { - fn(); - }); -}; - +// Add the original it.only and it.skip methods to the window object +// originalIt.only and originalIt.skip will use the overridden window.it function +window.it.only = originalIt.only; window.it.skip = originalIt.skip; /** @@ -30,8 +39,9 @@ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { cy.checkFinalState(); }) .then(() => { - cy.log(`Visit ${url}`); - return originalFn(url, options); + cy.log(`Visit ${url}`).then(() => { + return originalFn(url, options); + }); }); }); @@ -46,7 +56,8 @@ Cypress.Commands.overwrite("reload", (originalFn, options) => { cy.checkFinalState(); }) .then(() => { - cy.log("Reload page"); - return originalFn(options); + cy.log("Reload").then(() => { + return originalFn(options); + }); }); }); diff --git a/tests/Frontend/support/commands/generalCommands.js b/tests/Frontend/support/commands/generalCommands.js index f92ea5281..8c98add4a 100644 --- a/tests/Frontend/support/commands/generalCommands.js +++ b/tests/Frontend/support/commands/generalCommands.js @@ -11,6 +11,7 @@ Cypress.Commands.add("checkFinalState", () => { const baseOrigin = new URL(Cypress.config().baseUrl).origin; if (currentOrigin === baseOrigin) { + cy.log("Check final state"); // Check that all toasts that maybe have been created during the test have been removed // This makes sure that unexpected error toasts that are not handled in the test will cause the test to fail, // which makes sure that we don't miss any unexpected errors in the tests From 27cc599f9609b1a33ed1ca693206add91f7340c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Mon, 18 May 2026 16:49:10 +0200 Subject: [PATCH 09/14] Simplify overrides --- .../support/commands/commandOverrides.js | 30 +++++++------------ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index e2d6d8152..4994131de 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -33,16 +33,11 @@ window.it.skip = originalIt.skip; * Checks final state before performing the visit, to make sure that unexpected errors that may have happened previously are caught. */ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { - return cy - .wrap(null, { log: false }) - .then(() => { - cy.checkFinalState(); - }) - .then(() => { - cy.log(`Visit ${url}`).then(() => { - return originalFn(url, options); - }); - }); + cy.checkFinalState(); + + cy.log(`Visit ${url}`).then(() => { + return originalFn(url, options); + }); }); /** @@ -50,14 +45,9 @@ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { * Checks final state before performing the reload, to make sure that unexpected errors that may have happened previously are caught. */ Cypress.Commands.overwrite("reload", (originalFn, options) => { - return cy - .wrap(null, { log: false }) - .then(() => { - cy.checkFinalState(); - }) - .then(() => { - cy.log("Reload").then(() => { - return originalFn(options); - }); - }); + cy.checkFinalState(); + + cy.log("Reload").then(() => { + return originalFn(options); + }); }); From 069bf479dad279778fd64bec99308fe210fb0000 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Mon, 18 May 2026 17:41:06 +0200 Subject: [PATCH 10/14] Improve overrides --- .../support/commands/commandOverrides.js | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index 4994131de..c5072e8a3 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -33,11 +33,11 @@ window.it.skip = originalIt.skip; * Checks final state before performing the visit, to make sure that unexpected errors that may have happened previously are caught. */ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { - cy.checkFinalState(); - - cy.log(`Visit ${url}`).then(() => { - return originalFn(url, options); - }); + return cy + .wrap(null, { log: false }) + .then(() => cy.checkFinalState()) + .then(() => cy.log(`Visit ${url}`)) + .then(() => originalFn(url, options)); }); /** @@ -45,9 +45,9 @@ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { * Checks final state before performing the reload, to make sure that unexpected errors that may have happened previously are caught. */ Cypress.Commands.overwrite("reload", (originalFn, options) => { - cy.checkFinalState(); - - cy.log("Reload").then(() => { - return originalFn(options); - }); + return cy + .wrap(null, { log: false }) + .then(() => cy.checkFinalState()) + .then(() => cy.log("Reload")) + .then(() => originalFn(options)); }); From e92241712c462c4b928c2b0c85165b3b16b70b5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Mon, 18 May 2026 18:34:53 +0200 Subject: [PATCH 11/14] Fix reload override arguments --- tests/Frontend/support/commands/commandOverrides.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index c5072e8a3..a60276824 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -44,10 +44,10 @@ Cypress.Commands.overwrite("visit", (originalFn, url, options) => { * Override for reload * Checks final state before performing the reload, to make sure that unexpected errors that may have happened previously are caught. */ -Cypress.Commands.overwrite("reload", (originalFn, options) => { +Cypress.Commands.overwrite("reload", (originalFn, ...args) => { return cy .wrap(null, { log: false }) .then(() => cy.checkFinalState()) .then(() => cy.log("Reload")) - .then(() => originalFn(options)); + .then(() => originalFn(...args)); }); From 01c002a01ca4d27dc738365a22c92c8f248dc84d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Wed, 20 May 2026 16:11:06 +0200 Subject: [PATCH 12/14] Impove and fix overrides --- .../support/commands/commandOverrides.js | 78 +++++++++++++++---- .../support/commands/generalCommands.js | 2 +- 2 files changed, 66 insertions(+), 14 deletions(-) diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index a60276824..d6773b61d 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -32,22 +32,74 @@ window.it.skip = originalIt.skip; * Override for visit * Checks final state before performing the visit, to make sure that unexpected errors that may have happened previously are caught. */ -Cypress.Commands.overwrite("visit", (originalFn, url, options) => { - return cy - .wrap(null, { log: false }) - .then(() => cy.checkFinalState()) - .then(() => cy.log(`Visit ${url}`)) - .then(() => originalFn(url, options)); +Cypress.Commands.overwrite("visit", (originalFn, urlOrOptions, options) => { + return cy.checkFinalState().then(() => { + // Determine url and options based on the arguments passed to visit + // Add log: false to options to prevent logging the original visit command + const url = typeof urlOrOptions === "string" ? urlOrOptions : undefined; + const optionsWithoutLogs = + typeof urlOrOptions === "object" + ? { log: false, ...urlOrOptions } + : { log: false, ...options }; + + // Log the visit command with the modified url and options + Cypress.log({ + name: "visit", + message: url ? url : optionsWithoutLogs.url, + consoleProps: () => { + return { + Options: optionsWithoutLogs, + }; + }, + }); + + // Call the original visit function with the modified url and options + if (url !== undefined) { + return originalFn(url, optionsWithoutLogs); + } else { + return originalFn(optionsWithoutLogs); + } + }); }); /** * Override for reload * Checks final state before performing the reload, to make sure that unexpected errors that may have happened previously are caught. */ -Cypress.Commands.overwrite("reload", (originalFn, ...args) => { - return cy - .wrap(null, { log: false }) - .then(() => cy.checkFinalState()) - .then(() => cy.log("Reload")) - .then(() => originalFn(...args)); -}); +Cypress.Commands.overwrite( + "reload", + (originalFn, forceReloadOrOptions, options) => { + return cy.checkFinalState().then(() => { + // Determine forceReload and options based on the arguments passed to reload + // Add log: false to options to prevent logging the original reload command + const forceReload = + typeof forceReloadOrOptions === "boolean" + ? forceReloadOrOptions + : undefined; + + const optionsWithoutLogs = + typeof forceReloadOrOptions === "object" + ? { log: false, ...forceReloadOrOptions } + : { log: false, ...options }; + + // Log the reload command with the modified forceReload and options + Cypress.log({ + name: "reload", + message: "", + consoleProps: () => { + return { + "Force reload": forceReload !== undefined ? forceReload : undefined, + Options: optionsWithoutLogs, + }; + }, + }); + + // Call the original reload function with the modified forceReload and options + if (forceReload !== undefined) { + return originalFn(forceReload, optionsWithoutLogs); + } else { + return originalFn(optionsWithoutLogs); + } + }); + }, +); diff --git a/tests/Frontend/support/commands/generalCommands.js b/tests/Frontend/support/commands/generalCommands.js index 8c98add4a..83c76a20f 100644 --- a/tests/Frontend/support/commands/generalCommands.js +++ b/tests/Frontend/support/commands/generalCommands.js @@ -6,7 +6,7 @@ * @returns void */ Cypress.Commands.add("checkFinalState", () => { - cy.url({ log: false }).then((currentUrl) => { + return cy.url({ log: false }).then((currentUrl) => { const currentOrigin = new URL(currentUrl).origin; const baseOrigin = new URL(Cypress.config().baseUrl).origin; From efb1863c047ebf7f6357f4297da24be0c35bed21 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Wed, 20 May 2026 16:21:41 +0200 Subject: [PATCH 13/14] Fix docblock --- tests/Frontend/support/commands/generalCommands.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Frontend/support/commands/generalCommands.js b/tests/Frontend/support/commands/generalCommands.js index 83c76a20f..ba8d4d3d8 100644 --- a/tests/Frontend/support/commands/generalCommands.js +++ b/tests/Frontend/support/commands/generalCommands.js @@ -3,7 +3,7 @@ * This should be called at the end of every test to make sure that unexpected errors aren't missed in the tests. * @memberof cy * @method checkFinalState - * @returns void + * @returns {Cypress.Chainable} */ Cypress.Commands.add("checkFinalState", () => { return cy.url({ log: false }).then((currentUrl) => { From a7ca2817e8a1420b2866ce8cba074a200b32f091 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sabrina=20W=C3=BCst?= <119059706+Sabr1n4W@users.noreply.github.com> Date: Wed, 20 May 2026 16:41:40 +0200 Subject: [PATCH 14/14] Improve option logging --- .../support/commands/commandOverrides.js | 40 ++++++++++++------- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/tests/Frontend/support/commands/commandOverrides.js b/tests/Frontend/support/commands/commandOverrides.js index d6773b61d..ee3f76fcc 100644 --- a/tests/Frontend/support/commands/commandOverrides.js +++ b/tests/Frontend/support/commands/commandOverrides.js @@ -37,27 +37,31 @@ Cypress.Commands.overwrite("visit", (originalFn, urlOrOptions, options) => { // Determine url and options based on the arguments passed to visit // Add log: false to options to prevent logging the original visit command const url = typeof urlOrOptions === "string" ? urlOrOptions : undefined; - const optionsWithoutLogs = - typeof urlOrOptions === "object" - ? { log: false, ...urlOrOptions } - : { log: false, ...options }; + const visitOptions = + typeof urlOrOptions === "object" ? urlOrOptions : options; - // Log the visit command with the modified url and options + // Log the visit command with url and options Cypress.log({ name: "visit", - message: url ? url : optionsWithoutLogs.url, + message: url ? url : visitOptions.url, consoleProps: () => { return { - Options: optionsWithoutLogs, + Options: visitOptions, }; }, }); // Call the original visit function with the modified url and options if (url !== undefined) { - return originalFn(url, optionsWithoutLogs); + return originalFn(url, { + log: false, + ...visitOptions, + }); } else { - return originalFn(optionsWithoutLogs); + return originalFn({ + log: false, + ...visitOptions, + }); } }); }); @@ -77,10 +81,10 @@ Cypress.Commands.overwrite( ? forceReloadOrOptions : undefined; - const optionsWithoutLogs = + const reloadOptions = typeof forceReloadOrOptions === "object" - ? { log: false, ...forceReloadOrOptions } - : { log: false, ...options }; + ? forceReloadOrOptions + : options; // Log the reload command with the modified forceReload and options Cypress.log({ @@ -89,16 +93,22 @@ Cypress.Commands.overwrite( consoleProps: () => { return { "Force reload": forceReload !== undefined ? forceReload : undefined, - Options: optionsWithoutLogs, + Options: reloadOptions, }; }, }); // Call the original reload function with the modified forceReload and options if (forceReload !== undefined) { - return originalFn(forceReload, optionsWithoutLogs); + return originalFn(forceReload, { + log: false, + ...reloadOptions, + }); } else { - return originalFn(optionsWithoutLogs); + return originalFn({ + log: false, + ...reloadOptions, + }); } }); },